closes AE-909
flag=none
Change-Id: Iee8eb9c877addd283bee253f8e277452529a8b76
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/345427
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
QA-Review: Isaac Moore <isaac.moore@instructure.com>
Product-Review: Isaac Moore <isaac.moore@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
closes EVAL-3635
flag=enhanced_rubrics
Test Plan:
- Create a new rubric
- Add a criteria with some ratings
- ensure you can add and drag around the ratings to different indexes,
but the point values stay fixed on the left.
- ensure you can save
the criteria and edit it again and the order and ratings are
preserved.
- Also ensure that when the long description is two long the box expands,
but everything in the rating row is aligned vertically(center).
- ensure when dragging around ratings that the add rating button is
hidden when dragging and reappears when you stop dragging.
-ensure the saved rating order is also correctly displayed on the
criteria index page.
- ensure you can also drag around the criteria themselves and the points
and ratings move with them.
Change-Id: I08fe4d9a09933509deefed0fb62523068a38ad5a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/341590
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Derek Williams <derek.williams@instructure.com>
QA-Review: Christopher Soto <christopher.soto@instructure.com>
Product-Review: Ravi Koll <ravi.koll@instructure.com>
with jquery-migrate 3.4.1 (added to instructure_jquery_patches.js
this time, as it wasn't being loaded soon enough for header usage
in runOnEveryPageButDontBlockAnythingElse.jsx)
this change also disables the assignment column resizing and
reordering feature in the grid gradebook. The drag library used
for this feature does not support jquery 3.x and it is a blocker
refs FOO-4260
flag=none
Test Plan:
- Jenkins Passes
[skip-crystalball]
[fsc-max-nodes=18]
[fsc-timeout=40]
Change-Id: I56ff289813c532c98279766dbca19b9ec28c5d0c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/341600
Product-Review: Ryan Norton <rnorton@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Michael Hulse <michael.hulse@instructure.com>
speed grader no longer uses an unmaintained jquery
plugin to determine the width of the scroll bar in
the student selector. this plugin is not
compatible with jquery 3.5 and is blocking the
upgrade, and removing it does not appear to have
any negative effect (the selector is usable)
closes FOO-4352
refs FOO-4260
flag = none
Test Plan:
- create a course with 2 sections and 50 students
- view an assignment in speed grader
- confirm you can change students on the selector
Change-Id: Ia370fd31a58b1735fede52f7555876a91beea194
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/343131
QA-Review: Jen Smith <jen.smith@instructure.com>
Product-Review: Jen Smith <jen.smith@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Michael Hulse <michael.hulse@instructure.com>
This reverts commit 0e45d78165.
Reason for revert: Jenkins has been failing JS tests since the merge of this patchset. Revert is a test to see if failures might be related
Change-Id: I09ef5ecb3a9f4d8299659c5e9ba39bd7a3f8853d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/342733
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Derek Williams <derek.williams@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
flag=speedgrader_studio_media_capture
test plan:
- test pass
Change-Id: I067343e0c9c6605b4013a956814104011d73d241
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/342121
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Christopher Soto <christopher.soto@instructure.com>
Reviewed-by: Cameron Ray <cameron.ray@instructure.com>
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
Reviewed-by: Jackson Huang <jackson.huang@instructure.com>
Reviewed-by: Jacob DeWar <jacob.dewar@instructure.com>
QA-Review: Kai Bjorkman <kbjorkman@instructure.com>
Product-Review: Ravi Koll <ravi.koll@instructure.com>
Removes user-event from canvas-media since its not actually used there,
and bumps the version in canvas-rce as well. The only non-spec files
that this commit touches are: package.json, canvas-media/package.json,
canvas-rce/package.json, and yarn.lock. The remainder of the changes
are changes to jest spec files to resolve breaking changes in the
user-event API. The vast majority of the changes make usages of
user-event adhere to the new API which returns a promise, so calls
now need to be explicitely `await`ed. This change also exposed a
couple of synchronicity issues in test code which were rectified.
6 total specs were skipped across 3 files: action_button.test.tsx,
FilterNav.test.tsx, and CreateCourseModal.test.jsx. These will be
addressed in follow-up commits by owning teams who have more context
about how the underlying component should behave.
closes LF-1289
flag = none
Test plan: specs pass
Change-Id: If8f9db685593e906da9b2af5ae8d39fc63fe8c7c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/340719
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Jackson Howe <jackson.howe@instructure.com>
Product-Review: Jackson Howe <jackson.howe@instructure.com>
flag=speedgrader_studio_media_capture
test plan:
- enable speedgrader_studio_media_capture feature flag
- go to the speed grader
- click on the media recorder button
- verify that the screen capture option is available
Change-Id: I37349bbe5fa29f431ecb028c2c96f05290974488
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/341093
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Christopher Soto <christopher.soto@instructure.com>
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
QA-Review: Rohan Chugh <rohan.chugh@instructure.com>
Product-Review: Ravi Koll <ravi.koll@instructure.com>
We no longer use fullstory, remove anything related to full story and
the empty privacy tab in settings. And now you know the rest of the
story... good day!
flag=none
test plan:
- specs pass
- confirm canvas loads in a browser
- comfirm account settings page loads in a browser
Change-Id: I0529bc7b0075e93c9766ac8a4a0c79197c988cf1
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/341147
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Keith Garner <kgarner@instructure.com>
Product-Review: Jody Sailor
with jquery-migrate 1.4.1 on QUnit specs and on
runOnEveryPageButDontBlockAnythingElse.jsx
flag=none
refs FOO-4258
[skip-crystalball]
Change-Id: I46606a064237b79a7f9b608ce0e3a93ff8c386d4
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/340741
QA-Review: Jen Smith <jen.smith@instructure.com>
Product-Review: Jen Smith <jen.smith@instructure.com>
Reviewed-by: Angela Gomba <angela.gomba@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
test plan:
- run rspack locally (as "webpack" for now)
- ensure coverage data for crystalball
- ensure build passes with skip-crystalball
- ensure source maps for local dev
- ensure bundle analysis is available and documented
- ensure compile times are at least comparable
refs CFA-32
[skip-crystalball]
flag=none
Change-Id: I8ad916ac7fbe9e3ecee5c690abcd78cdde748ab6
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/339401
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Build-Review: Isaac Moore <isaac.moore@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Removing Babel in Jest ensures we won't add more of the
CommonJS-presuming mutative funny-business that Babel enabled
flag=none
Change-Id: I02a8b7387ff79c6f44b4304bfeb8e15ec26f787c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/337966
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
one exception: I added jsdom condition on line 6954
this enables us to move forward more easily with jquery upgrades
test plan:
- build passes
refs FOO-3741
Change-Id: I40bce735119d81ab9bd53ef40134f6fee493cfc7
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/337415
Reviewed-by: Jackson Huang <jackson.huang@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Build-Review: James Butters <jbutters@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
This avoids unnecessary tsx/jsx parsing on .ts/.js files,
a pattern recommended by rspack docs
This also enables externalHelpers
https://swc.rs/docs/configuration/compilation#jscexternalhelpers
flag=none
[skip-crystalball]
Change-Id: Ie0c2db9e67df115b24407fca5ba9d38002af5987
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/337127
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Build-Review: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
test plan:
- build passes
- ensure bundles are not much larger
- canvas still works in dev environment
- smoke test in Safari
- smoke test in Firefox
closes CFA-38
flag=none
[skip-crystalball]
Change-Id: I7879b1e7274b9ce47c3aa1985a6a22e5e3659f25
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/337103
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Build-Review: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
temporarily includes real underscore for those that
use require('underscore') in custom JS
flag=none
closes CFA-33
Change-Id: I62e10b7c4ab3bed67484ae98a729b6e7d381ed08
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/337045
Reviewed-by: Paul Gray <paul.gray@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
The pathways dashboard and view pages.
refs VICE-3932
flag=learner_passport,learner_passport_r2
test plan:
- click on the Pathways tab
> expect the pathways dashboard
- click on the pathway name, or from the kabob menu select View
> expect the view page
> expect the graph of milestones
> expect zoom in/out to work
Change-Id: I86a3d172b5141a9505dc656d58300177b3076f65
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/335774
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Suggs <aaron.suggs@instructure.com>
QA-Review: Aaron Suggs <aaron.suggs@instructure.com>
Product-Review: Aaron Suggs <aaron.suggs@instructure.com>
AJ Esa