Commit Graph

5 Commits

Author SHA1 Message Date
Ethan Vizitei ad9222ce79 standard LTI error handling for invalid content placement
closes FOO-1387
flag=none

TEST PLAN:
  1) try to launch LTI content in a place it doesn't go
  2) get a standard LTI error response, rather
     than a 500

Change-Id: Id600715e1e4ebd05e1b5d3364f05da2a068ed711
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/255711
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
2020-12-22 03:47:05 +00:00
Cody Cutrer 06763dd519 add # frozen_string_literal: true for lib
Change-Id: I59b751cac52367a89e03f572477f0cf1d607b405
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/251155
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2020-10-27 20:49:50 +00:00
wdransfield 3b00907443 Unify create and update OriginalityReport endpoints
Closes PLAT-2818

Test Plan:
- Using the Create endpoint API found at
  https://canvas.instructure.com/doc/api/originality_reports.html
  and specify an originality score.
- Verify the originality report is created with the specified
  originality score and other data.
- Repeat the exact same post request, but change the originality
  score value.
- Verify the originality report is updated and a new one is not
  created.
- Verify you can still update the originality report via the
  PUT endpoint found in the same docs.

Change-Id: I4a2b8ad6f5b68e49a6195862cf7826fe31152bca
Reviewed-on: https://gerrit.instructure.com/125944
Tested-by: Jenkins
Reviewed-by: Andrew Butterfield <abutterfield@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Weston Dransfield <wdransfield@instructure.com>
2017-09-20 14:18:25 +00:00
Landon Wilkins d198a52517 da licença part 31
add consistent license headers to all source files
(ruby, coffeescript, javascript)

except for vendor files

Change-Id: I7b353d1ec31c36c0b12df7feb09fff743dc8a985
Reviewed-on: https://gerrit.instructure.com/110056
Tested-by: Jenkins
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
2017-04-27 21:59:58 +00:00
Nathan Mills b95267bc95 make lti error constants loadable
fixes PLAT-1871

test plan:
this requires an indirect test,
before loading this code
hit the external_tool#retrieve endpoint passing in a secure_param
jwt that is invalid
/courses/:course_id/external_tools/retrieve
look at your error reports you should have and error for:
uninitialized constant Lti::UnauthorizedError
load this code and repeat the above step, you should now
have an error for a bad JWT token

Change-Id: I405befe60fdcc0d1178c1977442f6e372b73b852
Reviewed-on: https://gerrit.instructure.com/95384
Reviewed-by: Matthew Wheeler <mwheeler@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Tested-by: Jenkins
Product-Review: Nathan Mills <nathanm@instructure.com>
2016-11-28 21:20:06 +00:00