test plan
- specs should pass
- parallel reports should run without extra messages
fixes FOO-984
Change-Id: Idde458386b32d269bc4c134495ec7a0dccfa6f62
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/252048
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
closes LS-1595
flag=new_math_equation_handling
Most RCE content is processed by UserContent.escape in the
canvas backend on its way to the browser, and that is where
most equation images are replaced with their LaTex for MathJax
processing. The flow is different for Discussions whose replies
follow a different path. This change replaces the image with LaTex
in the same place in the browser as where the hidden mathml was
previously injected into the DOM.
test plan:
- in a discusion, add a reply
- use the Equation toolbar button to insert some math
> expect the equation image
- save by clicking Done
> expect the image to be replaced with MaxJax typeset content
(right click and you'll get the mathjax menu)
- edit the reply
> expect the equation image in the RCE
- edit and add some inline math (e.g. $$y = x^2$$)
- save
> expect both the original image and the inline equation to
be typeset by MathJax
Change-Id: Icedcbbf3b2f084b1a9c254ec2a070b31c35ffed9
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/251979
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
refs FOO-1178
flag=none
TEST PLAN:
1) Originality Reports still get copied out to group
submissions
2) error reports/sentry errors don't get filed
when a job runs to copy an originality report
for a test student that got reset before it could run
Change-Id: Iea21ef828e54ac0d42921f9b6f33072e6b2676c0
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/252155
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Ethan Vizitei <evizitei@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
When inserting a table into RCE, you can click a grid to determine
size of new table. Using KO-navigation, clicking on the insert
table button highlighted the background of the grid picker causing
bad contrast. This commit removes the background color of the table
insert grid, keeping the contrast ratio good.
fixes LS-1582
flag=rce_enhancements
Test plan:
- In RCE, use KO-navigation
- Navigate to the toolbar, click Table icon, click the top 'Table'
option, then use arrows to select table size
- Expect the inclued cells to be a light blue and the not included
cells to be white
- Repeat, but access the insert grid from the 'Insert' menubar
option
Change-Id: Ie3a500fcf101615f0b7fd55ed63364ff342606b1
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/251917
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Jackson Howe <jackson.howe@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
closes LS-1599
flag=none
A recent update does a preemptive fetch of the equation image to ensure
it can be returned. We did not have the necessary incantation to
properly make the CORS request. While chrome and ff were OK with
the request headers, safari was not and rejected the request with
the message "Cannot use wildcard in Access-Control-Allow-Origin
when credentials flag is true."
test plan:
- in safari, clear your cache (or create a brand new equation)
- in the RCE, use the equation editor to create an equation
- click "Insert Equation"
> expect to see the equation image in the RCE
Change-Id: If8d1f6b72741b2943faf251be5f04320157b337f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/252115
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
test plan
- have sis_pseudonym on enrollment
- delete it
- it should work as expected...
- just specs should pass
refs FOO-694
flag = none
Change-Id: I85120b065a2a29b7128c63aef9aa621c6fa77acc
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/252146
Reviewed-by: Cody Cutrer <cody@instructure.com>
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Ethan Vizitei <evizitei@instructure.com>
had to allow Auditors table to read from active record
due to Jenkins still reading from cassandra
closes EVAL-1237
flags=final_grade_override_in_gradebook_history
Test Plan:
-specs pass
Change-Id: Ia8da7f67d43f48a2a59fcbc58bb75e58c53afd36
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/251682
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Adrian Packel <apackel@instructure.com>
QA-Review: Kai Bjorkman <kbjorkman@instructure.com>
Product-Review: Syed Hussain <shussain@instructure.com>
closes FOO-694
flag = none
TEST PLAN:
1) create a user with 2 pseudonyms, a and b.
(a having a sis_user_id, b having none)
2) make an enrollment record for that user in a course,
and point it's sis_pseudonym_id at pseudonym a
3) check the SisPseudonym for that user/course
and it should be "a"
4) nil out the sis_user_id on a, and put it into
the sis_user_id on b (save both records)
5) check the SisPseudonym for that user/coures
and it should now be "b"
Change-Id: I2d72f2e93d212339b2ef9093bd18434ccdbed143
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/251998
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Ethan Vizitei <evizitei@instructure.com>
(or other separators)
test plan:
*before pulling down this patch set*, reproduce the bug.
- this requires setting up I18n locally:
1. rake 18n:generate_js
2. RAILS_LOAD_ALL_LOCALES=true USE_OPTIMIZED_JS=true yarn run webpack
3. RAILS_LOAD_ALL_LOCALES=true bundle exec rails server
- create a course and set its language to Portuguese
- enable Mastery Paths feature in the course or its account
- create at least two assignments, set one of them as a trigger
assignment and add the other to a mastery path
- save the trigger assignment
- edit the assignment and change a cutoff value to a fractional
number, using a decimal comma (e.g., "7,5"), which should
be displayed as "7,5 pts"
- try to save the assignment. this will fail with a 400 error.
*pull down the patchset and re-run webpack*
- reload the assignment page
- attempt the edit again
- this time it should save
flag = conditional_release
fixes LS-1547
Change-Id: Ie7b1a0b1dcef6cfddde2a64e5be83b85ab1ac854
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/250906
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
fixes FOO-1163
test plan:
* have a user with pseudonyms on two accounts with the same local id, on
different shards
* go to the user's page (/users/:id)
* it should correctly name both accounts
Change-Id: Ib5dfb77163a013deb0029dc311b26b1b9424f76c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/252039
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
closes FOO-890
TEST PLAN:
1) provide a csv file to sis imports with trailing
csvs and diffing enabled
2) it doesn't break
Change-Id: If5ac926cf7933116eac18b72100a2a86fb629ace
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/252016
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: August Thornton <august@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: August Thornton <august@instructure.com>
Closes FOO-1107
flag=none
Another update to a component using features in the version 6
<Select> component. CanvasAsyncSelect seemed to work pretty
nicely, although it needed a couple of features added as well
to round out the functionality.
Test plan:
* Go to courses/:id/gradebook/history
* The filter boxes should work like they always have
Change-Id: I3cd015a4edac4fa608d01158f9f320642f78a144
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/250903
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Charley Kline <ckline@instructure.com>
QA-Review: August Thornton <august@instructure.com>
... or at least 6 years
still maintaining the shape since it is passed as an empty array from
the controller
Change-Id: I773694a06f3ddbd65ab22c8db52e1cd0445ee1b8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/250502
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Caleb Guanzon <cguanzon@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
Rob Orton