canvas-lms

Commit Graph

Author	SHA1	Message	Date
Jeffrey Johnson	6510219aea	Fix jQuery Kyle Menu to support JAWS fixes VICE-2101 fixes VICE-2102 fixes VICE-2103 fixes EVAL-1979 fixes EVAL-1980 fixes LS-2674 fixes QUIZ-8883 fixes MAT-462 fixes LS-2676 fixes MAT-463 fixes OUT-4789 fixes VICE-2104 fixes LS-2675 Test plan 1. Download patchset 2. Navigate to a Course -> Click People in sidebar 3. Open JAWS 4. Navigate using JAWS to the elipsis in the Table 5. Open menu using appripriate JAWS keys 6. Expect: Menu Items should read out loud in JAWS Note: Only change is removing ARIA-owns from button, the rest is lint rules that were auto run. Note: This issue only reproduces in JAWS + Chrome Note: This should be tested in other places that single test plan listed Change-Id: I2d0b5c50c1ee1c72a9ce1038928d244c3073efb7 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/275149 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Matthew Lemon <mlemon@instructure.com> Product-Review: Matthew Lemon <mlemon@instructure.com> QA-Review: Daniel Sasaki <dsasaki@instructure.com>	2021-10-06 21:47:54 +00:00
Ahmad Amireh	4243097b21	rename some things fixes FOO-1265 [skip-eslint=true] [pin-commit-analytics=7e49eefd7f59cbf43fd03bf8957bbbfa76f8d9d5] [pin-commit-demo_site=adade2e38e46a358a4643cd3db2fe5ccffe39ec5] [pin-commit-instructure_misc_plugin=47a3161102b0611af56d134fbd0c828ddc1b8abf] [pin-commit-migration_tool=0dbac2f5b421d894395605ce4b583ef0f7d60b22] [pin-commit-multiple_root_accounts=cc96d28c0d59bbe47acc64de4fdd8e1d2b029805] Change-Id: I14c07f20bd260cf0de1f48ceb70b3c2313edf2d2 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/258807 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Michael Ziwisky <mziwisky@instructure.com> QA-Review: Michael Ziwisky <mziwisky@instructure.com> Product-Review: Michael Ziwisky <mziwisky@instructure.com>	2021-04-06 01:12:49 +00:00

Author

SHA1

Message

Date

Jeffrey Johnson

6510219aea

Fix jQuery Kyle Menu to support JAWS

fixes VICE-2101
fixes VICE-2102
fixes VICE-2103
fixes EVAL-1979
fixes EVAL-1980
fixes LS-2674
fixes QUIZ-8883
fixes MAT-462
fixes LS-2676
fixes MAT-463
fixes OUT-4789
fixes VICE-2104
fixes LS-2675

Test plan
1. Download patchset
2. Navigate to a Course -> Click People in sidebar
3. Open JAWS
4. Navigate using JAWS to the elipsis in the Table
5. Open menu using appripriate JAWS keys
6. Expect: Menu Items should read out loud in JAWS

Note: Only change is removing ARIA-owns from button, the rest is lint
rules that were auto run.
Note: This issue only reproduces in JAWS + Chrome
Note: This should be tested in other places that single test plan listed

Change-Id: I2d0b5c50c1ee1c72a9ce1038928d244c3073efb7
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/275149
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Matthew Lemon <mlemon@instructure.com>
Product-Review: Matthew Lemon <mlemon@instructure.com>
QA-Review: Daniel Sasaki <dsasaki@instructure.com>

2021-10-06 21:47:54 +00:00

Ahmad Amireh

4243097b21

rename some things

fixes FOO-1265

[skip-eslint=true]
[pin-commit-analytics=7e49eefd7f59cbf43fd03bf8957bbbfa76f8d9d5]
[pin-commit-demo_site=adade2e38e46a358a4643cd3db2fe5ccffe39ec5]
[pin-commit-instructure_misc_plugin=47a3161102b0611af56d134fbd0c828ddc1b8abf]
[pin-commit-migration_tool=0dbac2f5b421d894395605ce4b583ef0f7d60b22]
[pin-commit-multiple_root_accounts=cc96d28c0d59bbe47acc64de4fdd8e1d2b029805]

Change-Id: I14c07f20bd260cf0de1f48ceb70b3c2313edf2d2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/258807
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Michael Ziwisky <mziwisky@instructure.com>
QA-Review: Michael Ziwisky <mziwisky@instructure.com>
Product-Review: Michael Ziwisky <mziwisky@instructure.com>

2021-04-06 01:12:49 +00:00

2 Commits