Commit Graph

7 Commits

Author SHA1 Message Date
Clay Diffrient 946ef4b275 Run prettier on packages/
Test Plan:
  - Automated tests pass

refs COREFE-347

flag = none

Change-Id: I573a1dff4f90b0d68fee8d0f261b50a60c7a3fbb
Reviewed-on: https://gerrit.instructure.com/212768
Tested-by: Jenkins
Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com>
QA-Review: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
2019-10-11 19:29:16 +00:00
Ryan Shaw 78a25bf4e8 [codemod] convert functions to fat arrows
This is the result of running:

jscodeshift -t ../js-codemod/transforms/arrow-function.js .

see: https://github.com/cpojer/js-codemod#arrow-function

Transforms callbacks only when it can guarantee it won't break this 
context in the function. 
Also transforms function() { }.bind(this) calls to () => {}.

jscodeshift -t js-codemod/transforms/arrow-function.js <file>


Change-Id: I04d20c818002b3dce5a43d8e91f01d904f966706
Reviewed-on: https://gerrit.instructure.com/205785
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
Tested-by: Jenkins
QA-Review: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
2019-08-26 22:20:33 +00:00
Jeremy Neander 95247e5f80 allow packages to commit lib files
test plan:
 * Verify Jenkins passes

Change-Id: Ic809a1e456a3d326a3cb115a7743e40109b1022f
Reviewed-on: https://gerrit.instructure.com/200808
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Jeremy Neander <jneander@instructure.com>
Product-Review: Jeremy Neander <jneander@instructure.com>
2019-07-17 15:27:09 +00:00
Steven Burnett bc5b683cd6 allow uploading recorded video to rce
fixes CORE-2659 CORE-2661

Test Plan:
- in the demo site add a jwt and ensure the rcs is running
- spin up and configure notorious to talk to canvas
- click on the upload media button
- notice the modal shows up
- record a video and click save
- notice it saves and embeds a video into the rce

Change-Id: I4845011cb387b1061a97ac755d90537f9b21f44a
Reviewed-on: https://gerrit.instructure.com/194293
Tested-by: Jenkins
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Steven Burnett <sburnett@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
2019-05-30 13:14:30 +00:00
Ryan Shaw 86fdc49c1c make k5uploader work without jQuery
Change-Id: I28a525a9383cb47df10938dd007d6fbe3de221c7
Reviewed-on: https://gerrit.instructure.com/195077
Tested-by: Jenkins
Reviewed-by: Steven Burnett <sburnett@instructure.com>
QA-Review: Steven Burnett <sburnett@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
2019-05-23 23:54:02 +00:00
Steven Burnett 4b63160d93 remove arc media recorder Feature Flag
fixes a ticket

Test Plan
- go record a video through the rce, (new, edit pages)
  without turning on any feature flags and notice the
  arc (modern) video recorder shows on chrome, ff
- record a video and notice it works
- try on all browsers and notice recording works
  no matter if arc or the default recorder

Change-Id: Ic3d0e01554e016962259a60ab50a20d8e215840d
Reviewed-on: https://gerrit.instructure.com/194292
Tested-by: Jenkins
Reviewed-by: Landon Gilbert-Bland <lbland@instructure.com>
Reviewed-by: Ryan Norton <rnorton@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
2019-05-21 21:38:32 +00:00
Ryan Shaw dca7832aeb Move k5uplodaer to /packages
Change-Id: Iee63af909559285316b4cba4bdc1a62ba8fd34a3
Reviewed-on: https://gerrit.instructure.com/192280
Tested-by: Jenkins
Reviewed-by: Steven Burnett <sburnett@instructure.com>
QA-Review: Steven Burnett <sburnett@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
2019-05-10 18:30:51 +00:00