fixes CNVS-17802
test plan:
- go to the outcomes page
- make sure everything looks okay
- play around with it and try to make it look bad
- plug in a non-mighty mouse to see if the scroll
look bad with one of those
- outcomes modal windows are still usable
Change-Id: I7f0ff0a80955032e0f1121adc7ec5c0f3c58ddff
Reviewed-on: https://gerrit.instructure.com/46666
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Adam Stone <astone@instructure.com>
Reviewed-by: Matt Berns <mberns@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
Submission of a quiz sometimes didn't produce associated events. This
prevents the intermittent failure to record those events.
Closes CNVS-17588
Test Plan:
- Take quizzes many times with as quick of submission as you can,
while modifying the answers, as only answer events were problematic.
- Confirm that all events are recorded in the submission log.
Change-Id: I46bcf21287d38886a21fe281d08d49ea83f047b1
Reviewed-on: https://gerrit.instructure.com/47009
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Brian Finney <bfinney@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Ryan Taylor <rtaylor@instructure.com>
This makes it so the indicator button is disabled for anyone without rights
to manage files in the context. This prevents students from being able to
open up the Manage Usage Rights modal. It also puts an additional check
for rights around the display of the warning symbol.
fixes CNVS-18007
Test Plan:
- Enable New Files and Usage Rights Required
- As a teacher, you should see the warning icon for files without usage
rights after uploading them.
- Clicking any of the usage rights indicators should open the Manage
Usage Rights modal
- As a student, clicking the indicator should not open the modal
- Also, you should never see the warning icon as a student.
Change-Id: I6ae6be987b522995d84cb9f5ef7438e63d261324
Reviewed-on: https://gerrit.instructure.com/47263
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
to ensure the permissions on it are updated in a timely fashion.
test plan:
0. enable "better file browsing"
1. have a student enrolled in a course
2. view the student's files page, and note the course's files
appearing in the list
3. in a separate browser, as a teacher or admin, hide the
files tab in the course
4. refresh the student's browser and confirm that the course's
files no longer appear
5. in the teacher's browser, re-enable the files tab
6. refresh the student's browser and confirm that the course's
files appear again
fixes CNVS-17891
Change-Id: I43bb2d5606341e2ef7a337065d2e50e85bb1a40d
Reviewed-on: https://gerrit.instructure.com/47085
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: James Williams <jamesw@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
test plan:
* create two modules, both with an item and completion
requirement
* leave the first one unpublished, but publish the second
* add the first module as a prerequisite for the second
* view the modules page as a student
* the second module should be available (since the first
one is unpublished)
* now publish the first module
* visit the modules page again as the same student
* it should have reset the progress for the second module,
locking it
closes #CNVS-17819
Change-Id: I53bbb15d183866bb0bb25c8a7cf562b018bfe7f4
Reviewed-on: https://gerrit.instructure.com/46919
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
fixes CNVS-14063
Test Plan:
- Using NVDA go to a course's people page
- The tabs should be read out as tabs rather than as links
Change-Id: I8469bdbd4a1d470560dd644d527623a81fed5874
Reviewed-on: https://gerrit.instructure.com/47097
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Dan Minkevitch <dan@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
Array type arguments were not being sent as Rails-style arrays in
the request params.
See https://github.com/instructure/canvas-lms/issues/564
Test Plan:
- in the /doc/api/live page
- send a request that includes an array-type param
(e.g. Submissions -> List submissions for multiple assignments)
- comma-separated values should be interpreted as multiple items
- items should be passed back to Canvas as Rails-style query params
Fixes SIS-752
Fixes GH-564
Change-Id: I310755f2d4cb648a6f4dd33a531d975205a86613
Reviewed-on: https://gerrit.instructure.com/46745
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Tyler Pickett <tpickett+gerrit@instructure.com>
QA-Review: Kausty Saxena <ksaxena@instructure.com>
Product-Review: Nick Houle <nhoule@instructure.com>
fixes CNVS-17898
test plan
- have a discussion topic without threaded replies with a root
entry that has a higher db id than one of its child entries (this
requires fiddling around in the console)
- view the discussion topic show page
- ensure that the entries display correctly and no js error report
is generated
Change-Id: I9a9238366ed15803b43b6d70e7bb8cd5adc93cbc
Reviewed-on: https://gerrit.instructure.com/46903
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Mark Severson <markse@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Joel Hough <joel@instructure.com>
test plan: (basically same as g/44678)
* create an account with a sub account
* change quotas on the parent account
* should still update the defaults on the sub account
refs #CNVS-14971
Change-Id: I1d064271fcf0eda3cedc223664cec861af98817b
Reviewed-on: https://gerrit.instructure.com/47164
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
test plan:
* enable file previews + canvadocs
* create a course with a public syllabus
* add a inline preview link to a canvadocable document
to the syllabus
* view the syllabus as a public user (not logged in)
* should still be able to open the preview without
triggering an authentication error
closes #CNVS-17959
Change-Id: Ia5edede4534aba0768744a6feb663cb6fb8e0ea4
Reviewed-on: https://gerrit.instructure.com/47122
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
refs CNVS-17778
if there a bunch of slow jobs in a row, the singleton won't have created
a job for each one, and we might run out of jobs
Change-Id: I99b89d1266e88b8a004fe9dff2d9be0760b97bc3
Reviewed-on: https://gerrit.instructure.com/47219
Reviewed-by: Rob Orton <rob@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
refs CNVS-17778
also put stuff into the cache even if it hasn't changed
Change-Id: Ifb9a857b2d38303208a20e5a6993349525c56d1b
Reviewed-on: https://gerrit.instructure.com/47215
Reviewed-by: Rob Orton <rob@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
This fixes the react modal in the styleguide. There was a regression
where the content for the component no longer existed and was
causing js errors and styles not to be loaded into the styleguide
fixes CNVS-17958
Test Plan:
- Compile assets and styleguide
- Go to and test the React modal component by clicking on the
trigger buttons
Screenshot of what it should look like:
http://cl.ly/image/3a1v1r171i2H
- Go to Tabs component and make sure styles are being applied
Screenshot of what it should look like:
http://cl.ly/image/2b2P0y3z341C
Change-Id: I162949e313283e60c20af6dfd52c41df9536bee0
Reviewed-on: https://gerrit.instructure.com/47052
Reviewed-by: Chris Hart <chart@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
fixes CNVS-17979
test plan
- create an enrollment csv with an invalid
associated_user_id for an observer
- the import should not fail
- the import should give warning about the bad data
Change-Id: Iaecd177b8be24efdece1db21890beae5d206cdc2
Reviewed-on: https://gerrit.instructure.com/47134
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: August Thornton <august@instructure.com>
fixes CNVS-16542
when a section is cross listed to a course and the
course is deleted the section is treated as
deleted and the section will be uncrosslisted on
an sis import when state of the section is set to
active
test plan
- create a section in course a through sis
- crosslist the section into course b
- delete course b
- import the section again into course a or
course c, and it should move and be active
Change-Id: I84d8f3a6d1c7cfa8d2ae3f2d2a0f890d2cccab49
Reviewed-on: https://gerrit.instructure.com/46997
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
refs CNVS-17778
test plan:
* import a batch with duplicate lines
* it should not fail
Change-Id: I568c3ef8f7173a9d4c287d362e0415af29679647
Reviewed-on: https://gerrit.instructure.com/47150
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
When you start a new course and there is the box that says,
"Your Course is Unpublished" we have now added a button that will
kick off the course setup checklist when activiated.
Test Plan:
- Start a new course
- The Wizard should not automatically pop up
- Click on the blue Setup Checklist button
- The Wizard should now pop up
Change-Id: I8a9a46f6eb3ce62a0f29e72ba397eb0169deda91
Reviewed-on: https://gerrit.instructure.com/46980
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Dan Minkevitch <dan@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
refs CNVS-17778
the point of the loop is to not spawn a ton of jobs for tiny live
events. for large batches, we want it to take a breath in between
so that if a hotfix happens, the next batch will run with new code
Change-Id: I50bef7fa6c3abcf514b8dbb301fe4ff99b965515
Reviewed-on: https://gerrit.instructure.com/47148
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
fixes CNVS-9047
test plan:
(test outcomes and outcome groups to ensure both work as expected)
- enable voiceover and navigate to the move button for a outcome/outcome group
- focus should automatically go to the outcome tree in modal window
- navigate tree using keyboard based on voiceover modal instructions
- select an item, its name should be announced on voiceover
- click 'move'
- outcome/outcome group should be moved into new group
- after short delay, message should display confirming move and be read on voiceover
- page directory should return to moved outcome/outcome group's parent with focus
on outcome group the item belonged to
- directories page should properly reflect change in original and target
directories
- re-opening modal window without refreshing page should still automatically go
to tree when re-opening modal window
- directories on modal should reflect prior change when browsing
- attempting to move an item into the group it already belongs to should generate
an error
- clicking the move button with no group selected should generate an error
- both errors, as well as confirmation message from earlier, should be read aloud
to retest file trees:
- enable better file browsing feature flag
- go to files page and navigate folders, all expected behaviors should occur
- click 'move folder' and navigate the folder tree, all expected behaviors
from master branch should occur, including files moving properly
- go to edit addignment, edit outcome, or edit discusson and click 'embed image'
on toolbar
- go to 'Canvas' tab on modal window and navigate tree, all expected behaviors
from master branch should occur, including images properly attaching
note: assuming successful test, we should take extra care to ensure there are no
styling regressions anywhere else folders appear in the app
Change-Id: I9de723736d96d976630940db432c6849fc414aba
Reviewed-on: https://gerrit.instructure.com/43884
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
QA-Review: Derek Hansen <dhansen@instructure.com>
since it's no longer created on-demand for production environment
test plan:
* set up a new database with `rake db:initial_setup` in a
production environment
Change-Id: Ia048c77e74091c2e10ed81ded0a4c652788bb02a
Reviewed-on: https://gerrit.instructure.com/46311
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
fixes CNVS-17951
test plan:
- go to course settings and enter student view
- open a browser console and type ENV.current_user_roles
- it should include 'student'
Change-Id: I8b4e05089519a9ed2946262c42853cb5c1da03dc
Reviewed-on: https://gerrit.instructure.com/47034
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: Sean Lewis <slewis@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
Test Plan:
- Create a course
- Go to said course, no wizard should appear
- Click the course checklist button, a wizard should appear
Change-Id: Ie4672daa7068b518f1eb8dc0f1da29e3b1c1d8e4
Reviewed-on: https://gerrit.instructure.com/46979
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
Group.all_real_students will return all account users when a group's
context is an Account
Fixes CNVS-17623
Test plan
Regression Test
- Account Level Discussions
- Group Level Discussions
Change-Id: I0db79ab8285f264d46bce82ddd2a020d894befcd
Reviewed-on: https://gerrit.instructure.com/46974
Reviewed-by: Joel Hough <joel@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Brad Horrocks <bhorrocks@instructure.com>
There previously wasn't a button that allowed users
to clear the text field for renaming a file before
uploading (in case of duplicate). This adds the
button so that the user can clear and focus the
text field as requested.
fixes CNVS-17817
Test Plan:
* Enable "Better File Browsing" feature flag
* Go to any course's Files page as a teacher
or admin
* Upload a file to the course
* Attempt to re-upload the same file
* On the modal that appears, click
"Change Name"
* It should display a text field to rename
the file, as well as an X icon/button
in the text field, which upon clicking,
clears and focuses the text field
Change-Id: I15e76b2e9d22e9c69ea701a3c00ef3631300d5e5
Reviewed-on: https://gerrit.instructure.com/47030
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
- Increased the ceiling of the bundler reqs to include
the most recent patch.
- Revised code to use an 80-char per line style.
Change-Id: Iad6e0c278e583ed7fc07e5e63094021a4eaa254a
Reviewed-on: https://gerrit.instructure.com/47089
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
test plan
- Install an LTI tool with grade passback
- Setup an assignment in a course for LTI grading
- Delete the user enrollment and execute outcomes API call
* It should say 'User is no longer in course'
- Delete the assignment and execute outcomes API call
* It should say 'Assignment is invalid'
- Delete the tool and execute outcomes API call
* It should say 'Assignment is no longer associated with this tool'
- Delete the course and execute outcomes API call
* It should say 'Course is invalid'
fixes PLAT-821
Change-Id: Ia058a14854bd107eeea6a28b77258ab197980e25
Reviewed-on: https://gerrit.instructure.com/46891
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
QA-Review: August Thornton <august@instructure.com>
test plan:
- Add an editor button tool
- Create a quiz
- Add something from the LTI tool to the main RCE
- Without refreshing create a quiz question, and add LTI content to it
- Both RCEs should have LTI content
fixes PLAT-698
Change-Id: Ie12f6d405fd321c059ea86fd5c9d4ea3483121f2
Reviewed-on: https://gerrit.instructure.com/46636
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Nathan Mills <nathanm@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Brad Humphrey <brad@instructure.com>
Test plan:
Download the gradebook csv for a course that has a grading standard.
It should show both final and current letter grades.
Change-Id: I352354b5e6254325738b031d5e382d0a0c690102
Reviewed-on: https://gerrit.instructure.com/46861
Reviewed-by: Josh Simpson <jsimpson@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Cameron Matheson <cameron@instructure.com>
fixes CNVS-8728
test plan:
- DA off
- set up an observer following a student
- set up an observer in course without a student
- create an assignment in this course
- both observers and the student should be
notified of the assignments creation
- remove an enrollment from an observer user
- create another assignment and this user
should not be notified
- DA on
- set up an observer following a student
(we'll call him observer A)
- set up an observer following a student
in a different section (observer B)
- set up an observer in course without a student
(observer C)
- create an assignment in this course for only
the section that observer A's student is in
- observer A and observer C should be notified of
the assignment, observer B should not be
Change-Id: I5ff01cc9a6f19e8c7dca4f806fe48b9d6d8dbe36
Reviewed-on: https://gerrit.instructure.com/45853
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Sean Lewis <slewis@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
When using Speedgrader if multiple students have submitted an assignment
multiple times, selecting a later submission for one student
should not subsequently change the submission being shown for the other
students with multiple submissions.
closes CNVS-16419
test plan:
1.With a few different students submit to an assignment multiple times
2.Once finished submitting work go into the speedgrader and notice that
initially everything shows the most recent submission.
3.Select a later submission for one of the students, then go to a different
student. Notice that the submission being shown for the new student is
the most recent submission (before this fix, the submission being shown
for the new student was not the most recent submission. It was being
affected by the submission being selected for the first student).
4.Go back to the first student (the one that you selected a later assignment
for), and make sure the most recent submission is being shown.
5.Also, go to an older submission for a student and change the grade.
Click outside of the grade input box so the page reloads. Verify
after the page is done reloading that the submission you updated
is still selected (so, if i update the grade for Submission2, when
the page reloads Submission2 is still selected).
Change-Id: If7e600e4fabf88cd4b5a040240d949e1aa4339cd
Reviewed-on: https://gerrit.instructure.com/46128
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Josh Simpson <jsimpson@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Spencer Olson <solson@instructure.com>
there was a bug occuring when the 'next' or 'prev' button
was clicked shortly after updating a student's grade -- the
student data being shown was for the inccorrect student. this
commit fixes that bug by checking in the AJAX callback to
make sure that the data received belongs to the
currently-selected student.
closes CNVS-16958
test plan:
1. Have a quiz with at least two students and one quiz submission
2. Update score on quiz
3. Click the next student button immediately after the tab loading icon stops
spinning and prior to the page finishing loading (this is how the bug was
reproduced. see http://screencast.com/t/hGZmNjP8KrJ6 )
4. Notice that the submission data being shown on the page is for the
currently-selected student. Before this fix, the data would show up
for the previously-selected student.
5. Also, update the score on a quiz, and don't hit the 'next' student
button (let the page reload). Make sure the data on the page updates
correctly and shows the information for the currently-selected
student.
Change-Id: Ibd4729416a6cb726288093fb144c1c2eda6aeacf
Reviewed-on: https://gerrit.instructure.com/46369
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Josh Simpson <jsimpson@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Spencer Olson <solson@instructure.com>
Makes sure all the necessary data is in the label and
lines the label up properly.
fixes CNVS-16977
Test Plan:
- Go to courses/x/settings
- All the text for "Make this Course publicly visible" should be part of the label
- All the text should be lined up rather than awkwardly offset
Change-Id: I1fc9e9dd921d9c009c6d5a28143e64182372c290
Reviewed-on: https://gerrit.instructure.com/46930
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Dan Minkevitch <dan@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
Quiz Stats were silently failing. This catches the failed server request
and renders a clean error page which directs the user to download the
reports instead of using the statistics UI.
Closes CNVS-17285
Test Plan:
- Access a quiz with more than 1000 submissions or more than 50
questions. See that the stats page is no longer rendered empty, but
that an error page is shown.
- Confirm that report buttons are operational
- Confirm that report popup info boxes are looking good
Change-Id: I850406ed164a61e59d137dda3221746ee25a77cc
Reviewed-on: https://gerrit.instructure.com/46377
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Josh Simpson <jsimpson@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Ryan Taylor <rtaylor@instructure.com>
Michael Nomitch