Commit Graph

2 Commits

Author SHA1 Message Date
Mysti Lilla f6317a51c2 Improve broken link error message for inaccessible items
fixes ADMIN-2718

Test plan
- Set up a link in a course to a group
  (/groups/:id) and an item in a group
  (/groups/:id/pages/:page)
- Have a student who has access to the
  course, but not the group
- Click on the links as the student and
  verify the teacher gets the inaccessible
  notification instead of the "doesn't exist"
  message

Change-Id: I9675ff948a3d492197e774b6071b920fcecd8fee
Reviewed-on: https://gerrit.instructure.com/198871
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Lauren Williams <lcwilliams@instructure.com>
2019-07-01 17:02:28 +00:00
Mysti Sadler 1abdad37d6 Notification for failed link
closes ADMIN-2334

Test plan
- In a course with a student enrolled
- Set up an assignment, a quiz, a wiki page
  and a discussion topic
- In the body of the above, make sure to set
  up at least one notifiable bad link (a link
  to a course the student doesn't have access
  to, something that 404s like offline_web_exports
  if it's not turned on, something unpublished.
  deleted doesn't work, because it redirects
  right now)
- Set up an instructor with immediate, daily,
  weekly and no notifications for Content
  Link Errors
- As the student, visit the links
- Check /messages for the instructor(s) to ensure
  the notifications were received (or not) as
  expected and the notifications look right
  according to ADMIN-2334
- (If you need to send daily/weekly notifications
  you can do `DelayedMessage.where(workflow_state:
  'pending').update_all(send_at: 1.day.ago)` and
  then `SummaryMessageConsolidator.process` when
  jobs are running to kick them off

Change-Id: Ia324b1f5360dda91641f22ff1a6a2ba528aa4669
Reviewed-on: https://gerrit.instructure.com/179823
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Mysti Sadler <mysti@instructure.com>
Product-Review: Christi Wruck
2019-02-28 16:50:20 +00:00