closes: CNVS-12642
closes: CNVS-11221
test plan:
nothing should have changed for courses/accounts that
have the feature flag 'better_file_browsing' turned off
but I guess make sure.
with it turned on, you should be able to browse the
files in your course, search for things, and re-sort.
it should paginate, download files you click on,
show thumbnails of files (where it has one) and you
and see the files usage in the bottom left.
things that I know dont work:
* the folder tree thing on the left is still
just static html, not the actual files in your course.
* it does full page reloads when you go from
looking at one folder to another or when you
search for something. I am going to fix that.
I know there is still work to be done here to consider
the entire files section complete, but this is a solid
foundation so that sterling and I can collaborate and
work forward.
Change-Id: Ia79ddba4318b7d6e52b38a87e91f615552da250b
Reviewed-on: https://gerrit.instructure.com/37491
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Sterling Cobb <sterling@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
we aren’t using jsx (yet, anyway) bring it into a
module like anything else:
define ['react'], (React) ->
There’s also a helper module to make building
your UI simpler at `compiled/withReactDOM`. It
safely moves everything from `React.DOM` to window
during a function call for convenience.
Change-Id: Ibf64f0b207411c31b92f30dddc6ce188d9462e11
Reviewed-on: https://gerrit.instructure.com/37376
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Ryan Florence <ryanf@instructure.com>
QA-Review: Ryan Florence <ryanf@instructure.com>
to get case insensitive file extension fix
fixes NTRS-608
Change-Id: I7a4f3fa4fb80c24b32e211c197dde844a7117c7d
Reviewed-on: https://gerrit.instructure.com/37047
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jason Madsen <jmadsen@instructure.com>
QA-Review: David Josse <david@instructure.com>
Product-Review: Paul Hinze <paulh@instructure.com>
this commit is meant to be a way to commit some of
the progress I have been making on this. everything
new is behind a hidden feature flag so it should
not do anything any different for any existing users
if you want to test it out, open a console
and do:
Course.find(<your course id>).enable_feature! :better_file_browsing
then browse to the 'files' part of your course.
the main thing to QA right now is that we did not
break anything for people that don't have that
feature flag turned on. I know there are a ton of
things that are either broken or still need to be
implemented on the new app.
this is a few commits squashed into one and
closes multiple tickets:
create rails routes for new files UI
closes: CNVS-12140
for the new files UI we are going to use pushState
urls so we had to find a url namespace that we
could completely take over. the thing we chose was
/(courses|groups)/<course_id>/files/folder/foo/bar/baz
(assuming you were looking at the foo/bar/baz folder)
example urls:
/course/1/files/folder/foo/bar/baz
/groups/2/files/folder/lectures/1 Cell Mitosis/handouts/takehome work/
/files
/course/1/files
acceptance criteria:
the following NEW urls SHOULD be routed to new
ember files page:
/(courses|groups|accounts|users)/:id/files/folder*full_path
/dashboard/files/folder*full_path
/files/folder*full_path
the following urls already exist and if the
:new_files feature is enabled SHOULD be routed
also to the new ember files page instead of where
they go now (but if the :new_files feature is not
enabled, they should still go where they go now):
/files
/(courses|groups|accounts|users)/:id/files
/dashboard/files
style mockups for the new files page
fixes CNVS-11216
Enable feature flag for new files page, closes #CNVS-11215
closes: CNVS-12730
closes: CNVS-12659
closes: CNVS-12663
Change-Id: I3868fcf8efd6b517f38f56e88c7bb1e56cf564e8
Reviewed-on: https://gerrit.instructure.com/36005
QA-Review: Clare Strong <clare@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
this release of ic-menu has fix for conditional items being ordered
correctly and adds ability to have a disabled menu item
closes CNVS-13355
test plan:
- enable ember quizzes
- navigate to an existing quiz overview / show
- click the admin cog in the top right
- lock, or unlock the quiz
- click the cog again
- using up and down keyboard arrows navigate through menu
- verify that the key navigation order syncs with the visual order
in the list
Change-Id: Ica4809c1454fcc0204155d60a429852f1af1bbc3
Reviewed-on: https://gerrit.instructure.com/35803
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Derek DeVries <ddevries@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Jason Madsen <jmadsen@instructure.com>
closes CNVS-11294
test plan:
- enable ember quizzes
- ensure that existing ember quizzes continue to work
- all existing ember tests should continue to pass
Change-Id: I4f56b1267504533be8332520ea5f77d2fa566263
Reviewed-on: https://gerrit.instructure.com/33105
Reviewed-by: Derek DeVries <ddevries@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Jason Madsen <jmadsen@instructure.com>
fixes CNVS-12227
test plan:
* create at least 20 courses
* enable and open calendar 2
* verify that all neighboring courses have visually
distinctive colors
Change-Id: I2d3f9fb0e669cbc4fcda55a432cba07c18dbdfb5
Reviewed-on: https://gerrit.instructure.com/32931
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Joel Hough <joel@instructure.com>
QA-Review: Trevor deHaan <tdehaan@instructure.com>
Product-Review: Braden Anderson <banderson@instructure.com>
Change-Id: Ib1a4175ab7284a7598acb9d8b973876364cad7b6
Reviewed-on: https://gerrit.instructure.com/30364
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Stanley Stuart <stanley@instructure.com>
Product-Review: Stanley Stuart <stanley@instructure.com>
QA-Review: Stanley Stuart <stanley@instructure.com>
closes CNVS-6506
test plan:
- enable kaltura plugin as site admin
- enable js_kaltura_uploader on Account.default.settings
- go to assignment that has kaltura record / upload enabled as student
- upload a file via the RCE
- experience should mimic existing flash uploader
- verify that audio and video recording continue working as before
- disable js_kaltura_uploader on Account.default.settings
- as student attempt to upload to assignment
- verify that it continues to work as before
Change-Id: I1f4ba5ac5df5e023f74046f33d7c623cac924ee3
Reviewed-on: https://gerrit.instructure.com/30340
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Derek DeVries <ddevries@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
Product-Review: Jason Madsen <jmadsen@instructure.com>
Change-Id: I5660379f9fe967403824ed1065b0bdd727b03fb3
Reviewed-on: https://gerrit.instructure.com/30366
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Stanley Stuart <stanley@instructure.com>
Product-Review: Stanley Stuart <stanley@instructure.com>
QA-Review: Stanley Stuart <stanley@instructure.com>
Test Plan:
- Make sure the quizzes index page still looks consistent.
- Show page should follow mockups, but will be missing components that
we'll add in later.
Change-Id: Ifc99f8c33288bd2cb2b7aef5c700568b2735ff9b
Reviewed-on: https://gerrit.instructure.com/29037
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jason Madsen <jmadsen@instructure.com>
Product-Review: Stanley Stuart <stanley@instructure.com>
QA-Review: Stanley Stuart <stanley@instructure.com>
Change-Id: I6ee77408505bd46e8adfecbd4ab23fc00048247b
Reviewed-on: https://gerrit.instructure.com/29857
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
Reviewed-by: Ryan Florence <ryanf@instructure.com>
Product-Review: Ryan Florence <ryanf@instructure.com>
QA-Review: Ryan Florence <ryanf@instructure.com>
Tested-by: Ryan Florence <ryanf@instructure.com>
Product-Review: Stanley Stuart <stanley@instructure.com>
QA-Review: Stanley Stuart <stanley@instructure.com>
Change-Id: Icb34922fe304b3f86571d6fd3528b0233883dbfe
Reviewed-on: https://gerrit.instructure.com/29853
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Stanley Stuart <stanley@instructure.com>
Product-Review: Stanley Stuart <stanley@instructure.com>
QA-Review: Stanley Stuart <stanley@instructure.com>
Change-Id: Ia8ef4f9351bab01edb3fe989e628cfcb9412e227
Reviewed-on: https://gerrit.instructure.com/28542
Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Stanley Stuart <stanley@instructure.com>
Product-Review: Stanley Stuart <stanley@instructure.com>
fixes CNVS-10351
test plan:
* open calendar2
* verify that calendar colors look more distinct than in
http://screencast.com/t/PpKgnpPZ
Change-Id: I488acb1e16af4e51728aa11c3dd667025b11fbc4
Reviewed-on: https://gerrit.instructure.com/28261
Reviewed-by: Braden Anderson <banderson@instructure.com>
QA-Review: Braden Anderson <banderson@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Braden Anderson <banderson@instructure.com>
Change-Id: I65b5520db5bd16bf7149e914b2119c11e283dfc1
Reviewed-on: https://gerrit.instructure.com/28159
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Stanley Stuart <stanley@instructure.com>
QA-Review: Stanley Stuart <stanley@instructure.com>
fixes CNVS-10151
test plan:
* open calendar 2
* verify that calendar colors work as before
Change-Id: I71b7bddec9f66f3c4a0e2c736b232dec0af3200f
Reviewed-on: https://gerrit.instructure.com/27907
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Matt Fairbourn <mfairbourn@instructure.com>
Reviewed-by: Zach Pendleton <zachp@instructure.com>
Product-Review: Braden Anderson <banderson@instructure.com>
- not using ember model or ember data
- all that other stuff is installed with bower
Change-Id: Id8190bf413f07a11aa0b5a1bf1fa194c65969eef
Reviewed-on: https://gerrit.instructure.com/27763
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Ryan Florence <ryanf@instructure.com>
Product-Review: Ryan Florence <ryanf@instructure.com>
closes CNVS-9982, CNVS-9980
also updated ember/shared infrastructure to
support it
Change-Id: I1cbf4529124af16bb09aab47682c6254d5cff0ed
Reviewed-on: https://gerrit.instructure.com/27448
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jason Madsen <jmadsen@instructure.com>
Product-Review: Ryan Florence <ryanf@instructure.com>
QA-Review: Ryan Florence <ryanf@instructure.com>
Ryan Shaw