closes: CNVS-18168
also fixes semantics so:
1. if you press "esc" to close the dialog (instead
of pressing the "cancel" button) it does not
throw a js "can't call method preventDefaut on null"
2. uses a <button type="submit"> so that when you are
on any input element in the form and you hit
"enter" it will submit the form, as is standard.
test plan:
open styleguide
open the react-modal example
make sure it works
Change-Id: I6b1a8b6c757ef8205a59af17bde8743ce24e0dc5
Reviewed-on: https://gerrit.instructure.com/47745
Tested-by: Jenkins
Reviewed-by: Matt Zabriskie <mzabriskie@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
closes: CNVS-18177
this commit just changes our bower version of react
and react-router to the latest and copies the
current versions we are using to
old_unsupported_dot_use_react.js ant
old_unsupported_dot_use_react-router.js
...and then points everyone's existing code to those
old versions, so that nothing actually changes.
but if you require 'react' or 'react-router' you will
now get the new version.
each team can now take the time to update their own code
to the new versions and when no one is using either
of these 2 old libraries we can delete them.
test plan:
poke around in newfiles, the course wizard,
the external_apps app, quiz-statistics and make
sure they still work. nothing should actually change
Change-Id: I99a3526a740ac82f350bb6dd1fd4f25e4fd92483
Reviewed-on: https://gerrit.instructure.com/47625
Tested-by: Jenkins
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Fixes: CNVS-15547
This changeset updates the old jQueryUI-powered modal
boxes to match the look and feel of the new React-
powered modals. This is just a style/visual change.
Nothing has been improved in the current modals in
terms of functionality or accessibility.
Test plan:
- Here is what the jQueryUI modal boxes look like
currently in master/production:
http://cl.ly/image/0z3O133q3b44/modal-current.png
- Here is what they look like after this changeset:
http://cl.ly/image/3O0N051S2w22/modal-new.png
- Click on a few modals around Canvas to make sure
the new styles are being applied across the board
- NOTE TO QA: Many modals don't have the gray box
footer, like this one:
http://cl.ly/image/3S2J2x2y450D/mini-modal.png
This is not a result of this commit.
Change-Id: I6e12a649e155ef0462661e8101bcc8b2d5772a54
Reviewed-on: https://gerrit.instructure.com/45635
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Colleen Palmer <colleen@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
QA-Review: Matt Fairbourn <mfairbourn@instructure.com>
Ryan Shaw
