ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
57,498 Commits 324 Branches 20,019 Tags 1.7 GiB
Commit Graph

8 Commits

Author SHA1 Message Date
Aaron Shafovaloff 11b284327c move .js files with JSX to .jsx extension 
- .js files without JSX reduces unnecessary AST transformation
 - also paves way for vitest

test plan:
  - existing tests pass

flag=none

Change-Id: I392daefdfefab89e7cf511477e16c860b05519ff
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/323393
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Build-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
 2023-07-24 14:59:37 +00:00
Aaron Shafovaloff 07d238b148 Resolve or disable misc eslint errors 
Test plan:
    - All existing tests pass

flag=none

Refs DE-1426

Change-Id: Ic0ac4708089120ad83a6e7bd24eec1eaf4b310a2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/303859
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Derek Williams <derek.williams@instructure.com>
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Deborah Kwak <deborah.kwak@instructure.com>
 2022-10-25 14:10:39 +00:00
Jeffrey D. Johnson 776ed2d7f5 Add missing translation wrappers 
fixes VICE-3191

Test Plan
1. Navigate to people page
2. Click groups tab
3. Click + Group
4. Notice in the modal that all strings are localized
5. Type 0 into the group size and verify error message is localized

Change-Id: Id02ef9d1a1ed6b3c4c0057acc21f620a1921358f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/303753
Reviewed-by: Jason Gillett <jason.gillett@instructure.com>
Product-Review: Jason Gillett <jason.gillett@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
 2022-10-21 16:40:35 +00:00
Caleb Guanzon f34a64c3db add >1 validation to validateBeforeSend 
flag=none
fixes VICE-3161

it was done this way to provide the least
amount of disruption to this shared component
this improves upon existing behavior by
preventing a server create request for
limits of 1

test plan:
- visit course people page
- create or visit a group set
- create a group
- set group limit to 1
- press save
- verify you see Group membership limit must be greater than 1.
error

Change-Id: I9fde53709be0fee143e51b6ec8ca6b7b2e7085a4
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/302720
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Jeffrey Johnson <jeffrey.johnson@instructure.com>
 2022-10-06 18:20:37 +00:00
Aaron Shafovaloff 86d0e7ced2 Update JavaScript in ui/ to latest prettier config 
Test plan:
  - All existing tests pass

flag=none

[skip-eslint]

Change-Id: I36c1a2f47004185f8f02f4155b838c877ee495e3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/302256
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Charley Kline <ckline@instructure.com>
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
Product-Review: Charley Kline <ckline@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
 2022-09-29 22:04:26 +00:00
Aaron Shafovaloff f8458c8699 fix formatting from useScope commits 
test plan:
 - all tests pass

flag=none

Change-Id: I50e858039081b8bd0c5a497cdf9e697710a54dc5
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287364
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ahmad Amireh <ahmad@instructure.com>
QA-Review: Ahmad Amireh <ahmad@instructure.com>
Product-Review: Ahmad Amireh <ahmad@instructure.com>
 2022-03-17 21:07:06 +00:00
Ahmad Amireh bf46b5cc33 rewrite i18n! to useScope in javascripts 
refs FOO-2696
flag = none

applied by the codemod found here: https://github.com/instructure/canvas-i18n-loader-rewrite

this won't pass in isolation, see the mega patch that cherry-picks them
all for the status

~ test plan ~

do a cursory glance over the changes and verify we didn't miss anything

Change-Id: I9bc7dad55c7aba9053ab69c9bb477cb4ee3e78bb
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/286661
Tested-by: James Butters <jbutters@instructure.com>
Reviewed-by: Charley Kline <ckline@instructure.com>
QA-Review: Charley Kline <ckline@instructure.com>
Product-Review: Charley Kline <ckline@instructure.com>
 2022-03-10 21:38:25 +00:00
Ahmad Amireh 4243097b21 rename some things 
fixes FOO-1265

[skip-eslint=true]
[pin-commit-analytics=7e49eefd7f59cbf43fd03bf8957bbbfa76f8d9d5]
[pin-commit-demo_site=adade2e38e46a358a4643cd3db2fe5ccffe39ec5]
[pin-commit-instructure_misc_plugin=47a3161102b0611af56d134fbd0c828ddc1b8abf]
[pin-commit-migration_tool=0dbac2f5b421d894395605ce4b583ef0f7d60b22]
[pin-commit-multiple_root_accounts=cc96d28c0d59bbe47acc64de4fdd8e1d2b029805]

Change-Id: I14c07f20bd260cf0de1f48ceb70b3c2313edf2d2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/258807
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Michael Ziwisky <mziwisky@instructure.com>
QA-Review: Michael Ziwisky <mziwisky@instructure.com>
Product-Review: Michael Ziwisky <mziwisky@instructure.com>
 2021-04-06 01:12:49 +00:00