ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
57,498 Commits 324 Branches 20,019 Tags 1.7 GiB
Commit Graph

9 Commits

Author SHA1 Message Date
Aaron Shafovaloff ce864bb5ff turn on noImplicitAny for typescript 
also: remove tsconfig-strict.json

also: remove tsc precommit hook

test plan:
  - existing tests pass

flag=none

Change-Id: Ia2b30d9d77fdb55159de4fe16f3ee1826f43aad5
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/317197
Reviewed-by: Yona Appletree <yona.appletree@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
 2023-04-27 21:34:07 +00:00
Aaron Shafovaloff b8ab0d98fe remove $.underscore from instructure_misc_helpers 
also removes redundant str-underscore.js

test plan:
  - new specs pass

flag=none

refs EVAL-3087

Change-Id: I2c1beb4183be2ed733899d23bee87efae62b90cd
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/317112
Reviewed-by: Derek Williams <derek.williams@instructure.com>
Reviewed-by: Christopher Soto <christopher.soto@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
 2023-04-27 14:55:38 +00:00
Aaron Shafovaloff ddf696d1f5 move convert-case to ui/shared 
Change-Id: I465adfb221f922da133dbaa73cc9241198b9812f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/316316
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
Reviewed-by: Derek Williams <derek.williams@instructure.com>
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
QA-Review: Cameron Ray <cameron.ray@instructure.com>
Product-Review: Cameron Ray <cameron.ray@instructure.com>
 2023-04-20 17:20:46 +00:00
Aaron Shafovaloff 9e445782a6 Harden speed_grader.tsx 
Test plan:
  - All existing tests pass

flag=none

Change-Id: I5ecfd950a4971199b39b0994f0b0d41d5882f565
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/312210
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
Reviewed-by: Christopher Soto <christopher.soto@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Cameron Ray <cameron.ray@instructure.com>
 2023-03-03 17:59:48 +00:00
Aaron Shafovaloff 419a4906e2 Specify types for convert-case and html-escape 
Test plan:
  - Existing tests pass

flag=none

Change-Id: Ib4ff7609f4ca71242cef7ed91de53a5ef177112c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/310891
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
Reviewed-by: Derek Williams <derek.williams@instructure.com>
QA-Review: Cameron Ray <cameron.ray@instructure.com>
Product-Review: Cameron Ray <cameron.ray@instructure.com>
Build-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
 2023-02-14 17:48:45 +00:00
Aaron Shafovaloff 54743c18ee Reduce gradebook lint warnings and errors 
Test plan:
  - All existing tests pass

flag=none

Refs EVAL-2627

Refs EVAL-2645

Change-Id: I3f13db7e3f75a216e3c9c835df55c7f1b3944baa
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/302482
Product-Review: Cameron Ray <cameron.ray@instructure.com>
Reviewed-by: Derek Williams <derek.williams@instructure.com>
Reviewed-by: Christopher Soto <christopher.soto@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
 2022-10-04 19:00:14 +00:00
Aaron Shafovaloff 86d0e7ced2 Update JavaScript in ui/ to latest prettier config 
Test plan:
  - All existing tests pass

flag=none

[skip-eslint]

Change-Id: I36c1a2f47004185f8f02f4155b838c877ee495e3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/302256
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Charley Kline <ckline@instructure.com>
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
Product-Review: Charley Kline <ckline@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
 2022-09-29 22:04:26 +00:00
Aaron Shafovaloff e814838a64 Add more TypeScript in Gradebook 
Test plan:
  - Existing tests pass

Refs EVAL-2623

flag=none

Change-Id: Idb3cdadc894b032a90655f62f55ed9ae4495aea0
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/301316
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Christopher Soto <christopher.soto@instructure.com>
Reviewed-by: Paulo Chaves <paulo.chaves@instructure.com>
Product-Review: Cameron Ray <cameron.ray@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
 2022-09-19 17:26:50 +00:00
Aaron Shafovaloff d561d99581 TypeScriptify more Gradebook code 
Test plan:
  - Existing tests pass

flag=none

Refs EVAL-2619

Change-Id: I8bcc43fb6aed8ce4fefc7a8354b5efca067e7e74
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/301164
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
Reviewed-by: Christopher Soto <christopher.soto@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Cameron Ray <cameron.ray@instructure.com>
 2022-09-16 18:59:41 +00:00