...and where explicitly told
closes LF-209
flag=explicit_latex_typesetting
test plan:
-with the flag off:
1. test that you can still put math in a module
title
2. confirm that you can still render math in a
wiki page title
3. navigate to a classic quiz edit page and check
that math on the 'Questions' tab IS NOT typeset
4. confirm that you can still put math basically
anywhere in canvas like in a user's name
-with the flag on
1. confirm that module title math does not render
2. confirm that wiki page title math does not
render
3. confirm the same as point 3 above
4. confirm that math doesn't render anywhere
except for user content and places you
explicitly say to (like in the equation editor
advanced mode preview)
Change-Id: I2bc55c88428e5520bf3dc078ef8fee309fb63627
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/320740
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jonathan Guardado <jonathan.guardado@instructure.com>
QA-Review: Jonathan Guardado <jonathan.guardado@instructure.com>
Product-Review: Jake Oeding <jake.oeding@instructure.com>
fixes LF-411
flag=none
qa risk: low
test plan:
-for each home page type, test that with VO on,
the page heading structure is correct
*i.e., starts with an h1 and proceeds to h2(s)
-for wiki page and syllabus, the SR only message
should not be read. the h1 should be the visible
page title
-for everything else, the SR message should be
still be read first
-repeat the checks above but with the recent
announcements on home page setting enabled
-the heading hierarchy should still be maintained
on each page
-on wiki and syllabus pages, expect to see that
recent announcements is an h1 and is an h2 on
all others
Change-Id: I262c66ff083e1525363022efd0e165b0256ac568
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/321716
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jonathan Guardado <jonathan.guardado@instructure.com>
QA-Review: Jake Oeding <jake.oeding@instructure.com>
Product-Review: Daniel Sasaki <dsasaki@instructure.com>
this removes annoyances when decaffeinating files
test plan:
- all tests pass
flag=none
Change-Id: Ie3af0faf13d64a4701bb917fbcae29cb10474df1
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/315484
Reviewed-by: Derek Williams <derek.williams@instructure.com>
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
QA-Review: Kai Bjorkman <kbjorkman@instructure.com>
Product-Review: Cameron Ray <cameron.ray@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Chips away at our dependence on old jQuery
Also: Remove IE and old-Safari detection
Test plan:
- Load Canvas in Safari
- document.body should have 'safari' className
- Load Canvas in Chrome
- document.body should have 'chrome' className
- Load Canvas in Firefox
- document.body should have 'ff' className
flag=none
Refs FOO-87
Change-Id: I27547cce9d6feaaa44c442590962476345229173
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/315224
Reviewed-by: Spencer Olson <solson@instructure.com>
Reviewed-by: Derek Williams <derek.williams@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Spencer Olson <solson@instructure.com>
Product-Review: Spencer Olson <solson@instructure.com>
The migration is straightforward
This chips away at our dependency on old jQuery
Test plan:
- Existing tests pass
flag=none
Refs FOO-87
Change-Id: I197ba09804a22e051c1bb5537121fb0ca1f146e9
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/315240
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Cameron Ray <cameron.ray@instructure.com>
Reviewed-by: Derek Williams <derek.williams@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Cameron Ray <cameron.ray@instructure.com>
This patchset fix the issue when the
Front page tag doesn't display if last
(or only) page is tagged front page
fixes MAT-1216
flag=none
Test plan:
-Create at least two pages in your course (or one).
-Set the last page as the front page (or the
only page to the front page).
-Note that the front page tag does display for the page
Change-Id: I19ce4654fd83a1dd2a961c975237539e67d1f408
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/311218
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Juan Chavez <juan.chavez@instructure.com>
QA-Review: Juan Chavez <juan.chavez@instructure.com>
Product-Review: Allison Howell <allison.howell@instructure.com>
also make sure it's correctly translated
fixes MAT-1159
flag=none
test plan:
-in one of your courses, set a page to be the front page
>confirm that in the pages index view, you see a pill
with text 'Front Page' instead of the old inidcator
-navigate to that page
>confirm you see the pill again where the old indicator
used to be
>check the various menus and used to set and unset
front pages and confirm 'Front Page' still appears
correctly
Change-Id: I211657edf9be89564ef314d48c5e54616a62ea54
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/307895
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Yona Appletree <yona.appletree@instructure.com>
QA-Review: Yona Appletree <yona.appletree@instructure.com>
Product-Review: Allison Howell <allison.howell@instructure.com>
fixes MAT-1105
flag=none
test plan:
-go to pages
-make one of your pages the front page (if you
don't have one set already)
-view the front page
>ensure the 'View All Pages' button does not show
as the primary color and instead matches the
color of the 'Edit' button
Change-Id: I22db19d723aaa20a5e92549b3bfb04122df66e4a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/305606
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Mysti Lilla <mysti@instructure.com>
QA-Review: Mysti Lilla <mysti@instructure.com>
Product-Review: David Lyons <lyons@instructure.com>
test plan:
- all tests pass
flag=none
Change-Id: I50e858039081b8bd0c5a497cdf9e697710a54dc5
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287364
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ahmad Amireh <ahmad@instructure.com>
QA-Review: Ahmad Amireh <ahmad@instructure.com>
Product-Review: Ahmad Amireh <ahmad@instructure.com>
refs FOO-2696
flag = none
applied by the codemod found here: https://github.com/instructure/canvas-i18n-loader-rewrite
this won't pass in isolation, see the mega patch that cherry-picks them
all for the status
~ test plan ~
do a cursory glance over the changes and verify we didn't miss anything
Change-Id: I9bc7dad55c7aba9053ab69c9bb477cb4ee3e78bb
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/286661
Tested-by: James Butters <jbutters@instructure.com>
Reviewed-by: Charley Kline <ckline@instructure.com>
QA-Review: Charley Kline <ckline@instructure.com>
Product-Review: Charley Kline <ckline@instructure.com>
fixes MAT-245
flag=none
test plan
- Create a wiki page with a long content.
It's suggested more than 3-screens size text.
- Using HTML editor, add an id to an element in
the middle of the content.
Ex. <div id="test"></div>
- Save it.
- Create another wiki page.
- Create a link inside the page linking to the
previous page and using id.
Ex. href="/courses/1/pages/page#test"
- Save it.
- On wiki page preview click the link.
> Verify that the page navigate to the 1st page
and positions the viewport starting from
the element with the given id.
> Verify this with the supported browsers.
Specifically Chrome and Safari.
Change-Id: I2f4fb02b0e98b534f3851c019f0ea71a65835484
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/282953
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
Product-Review: Juan Chavez <juan.chavez@instructure.com>
closes MAT-497
flag=none
test plan:
- Edit a wiki page
- Embed a Studio video in RCE
> Verify in HTML view that the iframe
contains lti-embed class
- Save wiki page
- Open wiki page preview
- With browser dev tools, adjust the screen
width to < 320px
> Verify that the page padding is removed for
LTI iframe
> Verify that the iframe width fills the page
> Verify that you can horizontally scroll
inside iframe. With this we need to make sure
that no content is cut, for example: audio
scroll controls
Change-Id: Id420208deb9161741748fccec6fafe336e435859
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/282817
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob DeWar <jacob.dewar@instructure.com>
QA-Review: Jacob DeWar <jacob.dewar@instructure.com>
Product-Review: David Lyons <lyons@instructure.com>
because LockManager.init requires the DOM node to be there
test plan: the following pages should render correctly
in a blueprint course and in a blueprint associated course.
the locked banner should appear near the top of the page
in each instance when the content is locked.
- assignments show
- assignments edit
- discussion topics show
- discussion topics edit
- quizzes show
- quizes edit
- pages show
- pages edit
refs FOO-2597
Change-Id: I066b4590635efe48fcb690ca14f4ba582bf8f7bc
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/280952
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
QA-Review: Jackson Howe <jackson.howe@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Immersive reader used to receive content at
the time the button was initialzed and rendered.
This change updates that model to instead get
the content at the time the button is clicked
refs MAT-478
flag=more_immersive_reader
Test Plan
For each of the following, create content with
an equation and launch the RCE. Verify the
mathml is sent to the immersive reader rather
than the latex from the equation image:
- The assignment show page
- The submission page for students for a text
entry submission
- The syllabus
- A wiki page
Change-Id: I298d88e4d46902155ca792e1e3c43c980556e2be
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/280273
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Weston Dransfield <wdransfield@instructure.com>
Reviewed-by: Jacob DeWar <jacob.dewar@instructure.com>
QA-Review: Jacob DeWar <jacob.dewar@instructure.com>
refs LS-2763
flag = none
Test plan:
- Specs pass and Canvas still works; check these areas in particular:
- Files page direct share
- Syllabus immersive reader
- Wiki page immersive reader
- K5 schedule pages and Important Info pages
- Modules page
Change-Id: I2585e2479938a44237ef0cc859baa6cc8e6e8651
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276179
Reviewed-by: Nate Armstrong <narmstrong@instructure.com>
QA-Review: Nate Armstrong <narmstrong@instructure.com>
Product-Review: Jackson Howe <jackson.howe@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
fixes LS-2605
flag=none
We recently switched to checking VIEW_ALL_PAGES for
VIEW_TOOLBAR as part of
[this change](https://gerrit.instructure.com/c/canvas-lms/+/270314)
which breaks for home pages because, unlike regular wiki show
pages, display_show_all_pages is false (we don't want to show
the All Pages button on the home page).
VIEW_TOOLBAR hides or shows the course title on the home page
so it needs to be true when course_home is true. There are
additional permission checks within VIEW_TOOLBAR so this does
not expose any other undesirable controls.
Test plan:
- Set a page as a front page
- Set a course home page to that front page
- View the course home as a student
- The course title should be displayed
Change-Id: I87b35a1c6bae16c7d092891015965b1817303d99
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/273182
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Nate Armstrong <narmstrong@instructure.com>
closes MAT-247
flag=more_immersive_reader
Test Plan
- Enable Immersive Reader, either the account flag or the user flag.
- Enable More Immersive Reader.
- Navigate to the Course Syllabus page.
- Verify the Immersive Reader button appears.
Change-Id: Ie2e7e9260c7026a27254e1314a4f98d0b5784cd0
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/272328
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jon Scheiding <jon.scheiding@instructure.com>
QA-Review: Jon Scheiding <jon.scheiding@instructure.com>
Product-Review: Gary Mei <gmei@instructure.com>
closes MAT-246, fixes MAT-395
flag=immersive_reader_wiki_pages
Test Plan
- Create a Page.
- Enable Immersive Reader, either in the user's settings or the root
account's settings.
- View the Page.
- Verify that the Immersive Reader button is now higher up than
before, in line with the crumbs that describe where in the course
the user is.
- As a student, copy a link to the Page.
- Disable Pages from the course navigation in course settings.
- As the student, load the Page again.
- Verify that the Immersive Reader button is still present.
- Verify that at small window sizes, the button text disappears but
the button remains in the header.
Change-Id: I3c46da8b318f548f1522ec01f714365778539496
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/272265
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
Product-Review: Gary Mei <gmei@instructure.com>
Extra validations were added to the DISPLAY_SHOW_ALL_LINK
flag in the JS_ENV object. Now, in addition to the navigation
configuration, it is checked if the current user is a student in a k5
subject
closes LS-2404
flag = none
Test Plan:
1. Create a page in a k5 subject, publish it and add it to a module
2. As student go to the k5 course home and click the Modules tab
3. Click on the page you just created
4. Expect to be redirected to the page and the "View All Pages" link
not be there
5.Open any page in a non-k5 course and expect to see the "View All
Pages" link as usual
Change-Id: Id56ecff11205f9e903eaf0bb76959f6f887976b4
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/270314
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Peyton Craighill <pcraighill@instructure.com>
Reviewed-by: Nate Armstrong <narmstrong@instructure.com>
QA-Review: Nate Armstrong <narmstrong@instructure.com>
A component called EmptyHome was added, it will be shown when the
course does not have a front page set, if the user has teacher role,
a manage home button will also be rendered to allow the user add
or select a front page. This change also renames the “Front Page”
indicator in the pages list to “Subject home”, as well as the options
in the three-dot menu, which now make reference to "Subject Home"
instead of "Front Page"
fixes LS-2296
flag=none
Test plan:
- As student go to a course that does not have front page set,
and expect to the panda be presented with the following text
bellow:
- “‘This is where you’ll land when your home is complete.”
- As teacher go to the same course or any other without a front page
set, and expect:
- The same panda and text be presented as in the student
scenario
- A button “Manage Home” to be presented, click that button and
expect:
- A redirection to the course pages list to select a front page if
the course has pages already.
- A redirection to a new page creation if the course does not
have any page
Change-Id: If70510e849ad5c3bb1c338fe93c005ef79816bb7
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/267056
Reviewed-by: Jeff Largent <jeff.largent@instructure.com>
QA-Review: Jeff Largent <jeff.largent@instructure.com>
Product-Review: Peyton Craighill <pcraighill@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
This moves the Mark as Done button from the top right of the page to
the bottom right, below the content of the Page.
closes MAT-261
Test Plan
- Create a Page.
- Add the Page to a Module, with a requirement to Mark as Done.
- Verify that the button appears on the bottom right for a student.
- Verify that clicking the button still works.
Change-Id: I6c834fe1d1ae1d49d4046fc274d392fd327d84eb
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/266856
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
Product-Review: David Lyons <lyons@instructure.com>
Aaron Shafovaloff