ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
53,508 Commits 324 Branches 20,019 Tags 1.7 GiB
Commit Graph

7 Commits

Author SHA1 Message Date
Jacob Burroughs 7d0d80bdc8 Stop leaking siteadmin ids from spec setup 
Change-Id: I9370a96eb9eb0fde8c11f0243dc0785489002a55
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/285831
Reviewed-by: August Thornton <august@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Jacob Burroughs <jburroughs@instructure.com>
Product-Review: Jacob Burroughs <jburroughs@instructure.com>
Migration-Review: Jacob Burroughs <jburroughs@instructure.com>
 2022-02-25 23:11:11 +00:00
Cody Cutrer c2cba46851 RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation 
[skip-stages=Flakey]

auto-corrected

Change-Id: I4a0145abfd50f126669b20f3deaeae8377bac24d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279535
Tested-by: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Migration-Review: Cody Cutrer <cody@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
 2021-11-25 14:03:06 +00:00
Cody Cutrer fd6b50710c RuboCop: Style/CaseLikeIf 
[skip-stages=Flakey]

auto-corrected

Change-Id: I1f6b8a5f58a97a3ef17004ba9bf7a0940632dd55
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/278161
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
 2021-11-12 20:24:23 +00:00
Cody Cutrer c65d57737a RuboCop: Layout lib 
Change-Id: I0655d9a9d750f2debd6378b03d8ddc1403ebc31b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274158
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
 2021-09-22 20:01:52 +00:00
August Thornton f0c41b02f0 make manage courses granular permissions datafix idempotent 
refs FOO-1761
flag = granular_permissions_manage_courses

test plan:
 - builds pass
 - migration runs successfully

Change-Id: I421d3794d0b0de62c60043237ba54f7aa24f7127
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/267318
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
 2021-06-18 19:24:35 +00:00
Cody Cutrer b459579c9d prep for root_account_id being NOT NULL 
refs FOO-1693

Change-Id: I11cc02894ef709cb6183041057a8fa0ac994a882
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/265620
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
 2021-05-25 19:16:48 +00:00
August Thornton 475d7411eb add datafix migration for manage courses granular permissions 
closes FOO-1761
flag = granular_permissions_manage_courses

test plan:
 • ensure migration covers the proper role overrides to populate
   any derived custome role types from the parent base role type

Change-Id: Ife2e1a7a4a3a1f4dcdddd6de69f72580620749ae
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/261089
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
 2021-05-12 13:39:28 +00:00