refs BUDA-7
flag=none
test plan:
- all tests should work
Change-Id: Ia6ecda055361c165fc0a6b12c0c14805dd402794
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/352819
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Imre Foldes <imre.foldes@instructure.com>
Product-Review: Imre Foldes <imre.foldes@instructure.com>
Reviewed-by: August Thornton <august@instructure.com>
Note: this doesn't yet drop the tables/columns associated with this
feature, but every reference in application code is removed.
refs LX-157
flag = none
[skip-crystalball]
Test plan:
- Navigate to the following places in Canvas and verify that there's
no references to Faculty Journal anywhere:
- account settings (link removed from sidebar)
- account permissions (removed permission)
- student detail page (/accounts/:id/users/:id - no FJ button)
- activity report (/users/:id/teacher_activity/courses/:id - no
column for FJ)
- user show page (/users/:id - no FJ button)
- inbox (FJ checkbox removed from create message modal)
Change-Id: I698b4c572b577501b7a9fe8b00f9c44608487558
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/355523
Product-Review: Jackson Howe <jackson.howe@instructure.com>
Reviewed-by: Sarah Gerard <sarah.gerard@instructure.com>
QA-Review: Sarah Gerard <sarah.gerard@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
skip them if we know the server has been pre-configured with our
preset values
Change-Id: Iad078f9812033056a6862720fbae55b954d1d195
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/355350
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
closes FOO-4659
flag = none
test plan |
- permissions should behave as before
- we now have a single source of truth for permissions
that is much more obvious and understandable
- don't clutter role overrides with permissions
- registration has be refactored to be more DRY
- /permissions should work as before and plugins should
be able to register permissions in the same way,
however we settled on one uniform way to do it
Change-Id: I9e2f541643713065dfada692b4eb30230a9896e7
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/355239
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Reviewed-by: Michael Hulse <michael.hulse@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: August Thornton <august@instructure.com>
closes BUDA-17
[skip-crystalball]
flag=none
test plan:
- there are no regressions in this CR, all tests should pass as before
Change-Id: Ic3a9eaf6c8ccdbf8c2d8b5af51de402ca0dc18c6
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/353980
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Mario Hegyi <mario.hegyi@instructure.com>
refs BUDA-1
[skip-crystalball]
flag=none
test plan:
- all test should work
Change-Id: I27a33cad894e2d16286d55534f34c10a2d539fca
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/352469
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Endre Berki <endre.berki@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: Endre Berki <endre.berki@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
closes AE-985
flag=none
test plan:
- when traces and profiles are both enabled,
profiles are collected and sent to Sentry
Change-Id: I4f401056128a47556f5b56bfb731dfc6c06fbd46
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/348756
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Isaac Moore <isaac.moore@instructure.com>
Product-Review: Isaac Moore <isaac.moore@instructure.com>
Build-Review: Isaac Moore <isaac.moore@instructure.com>
new connections run queries to populate the PG type map. if we've
recently cleared the columns cache (like when creating a new shard),
then calling an attribute method in order to add a marginalia comment
will consult the columns hash, and cause a new query... within the
configure_connection method, before it has actually been fully
configured, and thus will fail trying to access the pg_type_map field
for that inner query. avoid the re-entrancy by using direct attribute
access, which doesn't need to check the columns_hash
Change-Id: Ia98cca14d33d69a552f9c7e40704bc5ef6e4250e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/350762
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
fixes RCX-1833
flag=none
Test plan:
- Create a new course
- In course settings, check the file storage
- If it is an old account, it will show 524MB
- If it is a new account, it will show 500MB
Change-Id: Idea02d4b12f1fcb3e1754d990f44dfb7ee575a39
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/349916
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob DeWar <jacob.dewar@instructure.com>
QA-Review: Jacob DeWar <jacob.dewar@instructure.com>
Product-Review: Murilo Paiva <murilo.paiva@instructure.com>
closes AE-280
[skip-stages=Flakey]
also vastly simplified the EventStream gem that no longer has to deal
with Cassandra
a pre-deploy migration is added that will migrate data from Cassandra
back to Postgres if you're currently using Cassandra. this means the
actual Cassandra gem dependencies can't be removed until that migration
is squashed
Change-Id: I0246ad9c058416e373ed4118a378bd640ace9c98
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/349182
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
Build-Review: Jacob Burroughs <jburroughs@instructure.com>
Migration-Review: Jacob Burroughs <jburroughs@instructure.com>
and apply new cop 99% Style/SuperArguments
and a couple Layout/EmptyComment and Style/ArgumentsForwarding that
are found by fixes in those cops
Change-Id: Icc0af9c8065f035bca43868b564f73e8776052f2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/348626
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jake Oeding <jake.oeding@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
Astana and Almaty map to the same timezone as of march 1, 2024
closes FOO-4337
flag=none
test plan:
- check that user, course and account settings time zone picker shows
+5:00 for Astana
Change-Id: I2c3159ae2c0d49a43785a1703299cf600df24003
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/347583
Reviewed-by: Cameron Ray <cameron.ray@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Ajmal Esa <ajmal.esa@instructure.com>
Product-Review: Ajmal Esa <ajmal.esa@instructure.com>
to undo the last actually dated migration, ignoring any migrations
that are "dated" far in the future that are integrity checks
Change-Id: I297dd27f5f6c39af5057d809bf6b89c558f7def0
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/342870
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
soon SmartSearch will make use of our forthcoming LLM gem
test plan:
- smoke test search feature
flag=smart_search
closes ADV-55
Change-Id: I9d837528c28c5acfdb0ded817cf0cc2259dd44b8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/342407
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jonathan Featherstone <jfeatherstone@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
(and `remove_replica_identity`) in favor of `replica_identity_index`
and `set_replica_identity`. `add_replica_identity` required a model, not
just tables, and was written for migrating old tables to adding a replica
identity, instead of for new tables, where you can assume the column is
already null
Change-Id: Ie2db8b1e6859fc30a58c1e474c27f4d11e866f18
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/342497
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
Migration-Review: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
since we could have added new locales. it's a single query that we
often run anyway to find the available collations, and then ones
that already exist are skipped. so fast and safe enough to run on
every migration run
Change-Id: I1cd93982a255646ccba911ae3cf4ab78c71ce27f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/342469
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
Migration-Review: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
closes AE-795
flag=none
test plan:
- verify that if RAILS_DATABASE_SERVICE is specified, it takes
priority over RAILS_DATABASE_USER
- verify that if RAILS_DATABASE_SERVICE is unspecified,
RAILS_DATABASE_USER is used instead
- verify that if the service specified by RAILS_DATABASE_SERVICE
is invalid, RAILS_DATABASE_USER is used instead
Change-Id: Ic8fa1fde3412db048a884c4c651f46d014d6208f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/341762
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Isaac Moore <isaac.moore@instructure.com>
Product-Review: Isaac Moore <isaac.moore@instructure.com>
- Actually enumerate columns when any are ignored to avoid loading unknown attributes
- Remove old ignored_columns so we don't unnecessary bloat queries when not ignoring
- Various minor fixes for places we do unusual AR things to ensure they work with explicit columns
- Tweak some migrations to clear column information so future migrations are happy
refs AE-747
Change-Id: I60b1c3eae73f4fa9f0b6b6ab4d2b00abd8f8395f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/339971
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Migration-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Jacob Burroughs <jburroughs@instructure.com>
Product-Review: Jacob Burroughs <jburroughs@instructure.com>
fixes VICE-4115
flag=react_discussions_post
test plan:
- Specs pass
- Follow steps on the ticket
- Make sure reply buttons appear or disappear
for students as expected.
Change-Id: Ie1c0b6c465f9835d68e52cd9abee4ca3bd923553
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/341183
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
QA-Review: Jason Gillett <jason.gillett@instructure.com>
it can lead to strange results where more rows were updated than were expected
also make sure to lock rows from the appropriate table when doing a subquery
update with a join in it
Change-Id: I16d0fee65a1d2b31ef72fd1933737b3715c441db
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/340620
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
otherwise if you happen to see it in console or specs, it's way too
massive filled with nested objects and you can't see _anything_
Change-Id: I8fca49650b5175a8a29e6ab9de48d9a7c4409578
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/339939
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Jake Oeding