closes LS-730
flag = submission_type_tool_placement
Test Plan:
- requires changes and test plan from LA-728
- icon_url should be passed as part of MC metadata
- once assignment is created, view the assignment index page
- verify icon is displayed and the assessment objectives is displayed
as per given design
Change-Id: I9d8d98011e6d2db76bd279153545ace5a4545296
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/240477
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Peyton Craighill <pcraighill@instructure.com>
also make sure it reads correctly with their silly branding
refs USERS-604
test plan:
* add _just_ apple auth provider
* go to /login/canvas
* it should read "Sign in with Apple"
* add another well known auth provider, like GitHub
* go to /login/canvas again
* it should only have the icons
* remove the apple auth provider
* go to /login/canvas again
* it should read "Login with GitHub"
Change-Id: I100dc2e4b2609bd097c2ce0337212b83af3bddbd
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/239413
Reviewed-by: Charley Kline <ckline@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Pages include rubrics, outcomes, and the
Zoom and New Analytics LTI apps. This calls
the `set_tutorial_js_env` function on those pages
so the proper JS Env vars are set.
Adds the necessary trays as well as the logic for
whether those trays should be opened or not.
Also adds two more adorable panda illustrations.
Test Plan:
Visit the outcomes page of a course
The Tutorial tray should appear; copy and links
should match the requirements in the linked Jira.
Same when visiting the rubrics page (either through
the outcomes page or via the dedicated nav link)
Same when visiting the Zoom LTI app from the course
navbar.
Same when visiting New Analytics, either from the course
navbar or the toolbar link on the right side of the course.
Refs UXS-53
flag = new_user_tutorial
Change-Id: I94d358cfdb23c575eac7cbc2589b336eb3882a59
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/233279
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: David Tan <dtan@instructure.com>
Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
Reviewed-by: Augusto Callejas <acallejas@instructure.com>
Product-Review: Jody Sailor
closes UXS-39
flag = featured_help_links
test plan:
- with the FF disabled
- the help menu should appear as before
- should show all help links in a list
- should not show anything as featured or tagged as "NEW"
- with the FF enabled:
- if nothing is featured or tagged as "NEW", the help
menu should appear as before (normal list)
- if a link is featured, it should appear prominently
at the top of the tray (with panda image), as per the designs
- if a link is tagged as "NEW" it should appear with
a "NEW" pill next to it
- the OTHER RESOURCES separator should ONLY show when
there is a featured link AND there are additional links
besides the featured one
Change-Id: Ic81da274a4570d10c363cda1b14a1c27e2faa287
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/230629
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Jonathan Fenton <jfenton@instructure.com>
Reviewed-by: Michael Brewer-Davis <mbd@instructure.com>
Reviewed-by: Augusto Callejas <acallejas@instructure.com>
flag=none
closes UXS-8
Adds new content (copy and links to Canvas Guides), as well as
updated images for each of the existing new user tutorial trays.
Test Plan:
Verify that the trays work as follows:
- All links should correctly resolve to the Canvas Guides page
they name
- All trays should feature a Panda image
- All tray should open and close, and should be able to be
dismissed permanently (no regressions from existing functionality)
Check the following index pages for trays: Announcements, Assignments,
Collaborations, Conferences, Discussions, Grades, Course Home Page,
Course Import page (under Settings), Modules, Pages, People, Quizzes,
Settings, Syllabus. There is a tray for Files, but it seems to be removed
from the Files index page on page load (not a result of this commit).
Change-Id: I873fdf9ceb6097d987f3e7da38e5fd615c1d98ea
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/230372
QA-Review: David Tan <dtan@instructure.com>
Reviewed-by: Pam Hiett <phiett@instructure.com>
Product-Review: Pam Hiett <phiett@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
refs HackWeek
Test Plan
* try to navigate to a page on canvas that doesn't
exist
* this could be a not found object too
* notice the cool new items on the page
* press space and try to beat the game
Change-Id: I22922fa7fb626ca3177c3d24b95122e2b5b24221
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/158969
Tested-by: Jenkins
Reviewed-by: Matthew Lemon <mlemon@instructure.com>
QA-Review: Steven Burnett <sburnett@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
test plan:
make sure that the images on discussino index page
are not read when running VoiceOver
Change-Id: I15a19262bfdd1a58f6196675f5dddf6aa42515e3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/214250
Tested-by: Jenkins
Reviewed-by: Steven Burnett <sburnett@instructure.com>
QA-Review: Steven Burnett <sburnett@instructure.com>
Product-Review: Daniel Sasaki <dsasaki@instructure.com>
Initial page to enable more parallel development of page features.
Will get visual and a11y improvements in followup tickets.
closes ADMIN-2875
flag=direct_share
test plan:
- Displays user's received shares in reverse chronological order.
- Clicking Action menu for any item prints specific console message
and correct content_share ID.
- Spinner appears briefly on page load as data is retrieved. No VO
message of # of returned results, yet (tbd in future).
Change-Id: Ie63d76c6e533f64c6ca0c36854eee25e10a42e22
Reviewed-on: https://gerrit.instructure.com/209749
Tested-by: Jenkins
Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com>
QA-Review: Jon Willesen <jonw+gerrit@instructure.com>
Product-Review: Carl Kibler <ckibler@instructure.com>
Populate ungraded Assignments 2 rubrics with the appropriate data,
rather than the hard-coded data currently on master. Ungraded
rubrics still display an image of a rubric.
Test plan:
* Create an assignment and a rubric for the assignment.
* As a student, open the assignment; view the rubric under the
Rubric Tab. The fields of the rubric should reflect the data you
entered. The rubric should look identical to its counterpart in
Old Assignments.
* As the teacher, grade the assignment.
* As the student, view the assignment and return to the Old
Assignments view. Click 'Submission Details.' Click 'Show
Rubric.' This rubric should be identical to its counterpart on
master.
flag Assignments 2
fixes COMMS-2181
Change-Id: I3a4bab4fb09ff1f101d554fd582df3bd508937d7
Reviewed-on: https://gerrit.instructure.com/203517
Reviewed-by: Steven Burnett <sburnett@instructure.com>
QA-Review: Steven Burnett <sburnett@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
Tested-by: Jenkins
This will be used by the mobile responsive nav stuff but I made it’s
Own commit so the brand_config migrations can be dealt with in a small
Change.
Test plan:
* go to the theme editor,
* there should be a new spot to upload a logo for
“mobile-global-nav-logo”
* upload something to it
* when the page reloads the new image you uploaded should show up
In that square where the “Canvas” logo default was.
Change-Id: I28a98e16b14ef9d0711543de7326650e5a47251e
Reviewed-on: https://gerrit.instructure.com/201427
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
closes: UIDEV-293
TEST PLAN:
- navigate to a course, select "Discussions" from the SubNav
- to see all of the varying empty states select a course that does
not have any Discussions OR delete the discussions that are
showing
old view: https://www.screencast.com/t/f3kJ8pXTzngp
new view: https://www.screencast.com/t/dibB5n0Fci
Change-Id: I9af53a50d1a73d16ad69a032b2d2fb784ee52eaa
Reviewed-on: https://gerrit.instructure.com/200856
Tested-by: Jenkins
Reviewed-by: Landon Gilbert-Bland <lbland@instructure.com>
QA-Review: Landon Gilbert-Bland <lbland@instructure.com>
Product-Review: Landon Gilbert-Bland <lbland@instructure.com>
closes ADMIN-2242
test plan:
- enable 'Unsplash Image Searches' and Course Card Images flags
- go to a Course and open modal to change photo
- Should see:
- Unsplash logo
- the Flickr SafeSearch text is gone
- Can search images (note... uses Flickr for search...)
- Selecting image puts it in card spot for course
- Diable Unsplash Image Searches and redo steps. Verify
it goes back to normal Flickr text and logo.
Change-Id: I9a02608deee6fb2a3f13024aede1e90d197d915b
Reviewed-on: https://gerrit.instructure.com/191545
Reviewed-by: Mysti Lilla <mysti@instructure.com>
Tested-by: Jenkins
QA-Review: Mysti Lilla <mysti@instructure.com>
Product-Review: Mysti Lilla <mysti@instructure.com>
closes ADMIN-2573
test plan:
- verify static images load for rubric and grading tabs in A2
- image should look pretty ok at normal screen resolutions
Change-Id: If8ec69f9eb6f9c06e4058c1a256076bffe786c77
Reviewed-on: https://gerrit.instructure.com/191632
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins
Product-Review: Carl Kibler <ckibler@instructure.com>
Fixes: CORE-2822
The primary purpose of this commit was to make it so that beta and
Prod are forced into running `BrandConfig.find_each(&:save_all_files!)`
again. This is necessary because we need to create the brotli encoded
versions of each of those files on the CDN.
For backstory on why that’s the case:
Recently, there was a change (g/188866) that will serve everything
from the cdn from a root /br/ folder for browsers that support brotli.
All the rest of the CDN files got a brotli version uploaded to /br when
rake canvas:cdn:upload_to_s3 was ran as part of the deploy but because
these brand_config files are not there on the deploy box, we need
to upload them too). Otherwise people will get 404s for these files.
The way I actually accomplished this was that I ran some images through
a lossless png compressor so that their binary contents would change
and thus we’d get a new md5. So a nice side effect of this commit is
that these images will be smaller.
Test plan:
* check out master
* if you try to run rails server it should give you an error that you
Need to run db migrations if you have not yet
* run db migrations
* now everything should work like normal
Change-Id: I806805c2ccbe75a0cf3a6cf6c664721380b802fc
Reviewed-on: https://gerrit.instructure.com/190330
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Tested-by: Jenkins
refs COMMS-1899
Test Plan:
- In A2 as a student
- validate all svg's for place holders (empty comments, locked
assignments, ect) still exist
Change-Id: I896bb39eed9469b662be6b587ed1d9fa8887af15
Reviewed-on: https://gerrit.instructure.com/183285
Reviewed-by: Landon Gilbert-Bland <lbland@instructure.com>
Reviewed-by: Aaron Hsu <ahsu@instructure.com>
Tested-by: Jenkins
QA-Review: Steven Burnett <sburnett@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
refs COMMS-1844
Test Plan:
- A2 student view with no submissions
- notice the place holder text, input box, and nice svg
Change-Id: I771ee060ceb810eef2a88266e1a6e26ed5228033
Reviewed-on: https://gerrit.instructure.com/180021
Reviewed-by: Aaron Hsu <ahsu@instructure.com>
Tested-by: Jenkins
QA-Review: Steven Burnett <sburnett@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
fixes ADMIN-2336
test plan:
- create a page in a course that links to the following:
* a file that has been deleted
* a file with an invalid id
* a resource (file, assignment, etc.) that is unpublished
* a resource that is in a different course (most easily done
by changing the course id in the link in the html)
- as a student, click these links and ensure the pages you
see look like the mockups in ADMIN-2331.
- in all of these cases,
* there is a centered image
- this image is not read by screen readers,
since it is purely decorative
* there is not a red box
* there is not a link to contact support
- for the deleted file, you should see "Page Not Found" and
a note that the file has been deleted
- for other links to nonexistent items, you should just see
"Page Not Found"
- for unpublished items, you should see "Not Yet Available"
and a locked document picture
- for items in a different course (that the student is not
enrolled in), you should see "Access Denied" and a lock picture
- also test the new 400 and 500 error pages. the easiest way to
do this is with the /test_error endpoint:
- /test_error?status=400
- /test_error?status=500
- these show the broken rocket picture and still include
a support link
Change-Id: I9f20e742e690482887cf375c79e4060aff6d7146
Reviewed-on: https://gerrit.instructure.com/178581
Tested-by: Jenkins
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
Reviewed-by: Carl Kibler <ckibler@instructure.com>
QA-Review: Carl Kibler <ckibler@instructure.com>
Product-Review: Kyle Follett <kfollett@instructure.com>
fixes COMMS-1752
Test Plan
* Create two modules
* Lock a module as a prereq saying must done in order
* Create a bunch of assignments for module
* Mask as a student and notice that assignments with
prereqs cannot be accessed and wil lead the user back to the
prereq assignment
Change-Id: I44ba88e93d775880a3b730a94fcbb2e5f0f48c6e
Reviewed-on: https://gerrit.instructure.com/173725
Tested-by: Jenkins
Reviewed-by: Landon Gilbert-Bland <lbland@instructure.com>
Reviewed-by: Steven Burnett <sburnett@instructure.com>
QA-Review: Aaron Hsu <ahsu@instructure.com>
Product-Review: Aaron Hsu <ahsu@instructure.com>
Fixes COMMS-1751
Test Plan:
* Make sure to compile css before testing this.
* Create three assignments
1) with a lockAt and unlockAt date in the future
2) with only an unlockAt date in the future
3) with only a lockAt date in the past
* Make sure the student view for the page loads in all cases and
matches the designs
Change-Id: Ib8bffd440db799d2c8423461e10a7f173fa72b65
Reviewed-on: https://gerrit.instructure.com/173289
Reviewed-by: Steven Burnett <sburnett@instructure.com>
Tested-by: Jenkins
QA-Review: Landon Gilbert-Bland <lbland@instructure.com>
Product-Review: Landon Gilbert-Bland <lbland@instructure.com>
closes OUT-2220
test plan:
- enable non-scoring rubrics feature flag if not already
- open the account rubrics page
- select the "Learning Mastery" tab
- confirm a billboard is displayed matching the mockup
- if previous custom ratings were defined, you can clear them out
in the rails console:
> OutcomeProficiency.destroy_all
- after saving some custom ratings, confirm the billboard
does not show up after loading the page
- confirm that when using VO/SR, that focus is set on
the first mastery checkbox after dismissing the billboard
Change-Id: Ia00ef7ec6bac771d502c92cbc0ffc088a0161816
Reviewed-on: https://gerrit.instructure.com/153541
Tested-by: Jenkins
Reviewed-by: Michael Brewer-Davis <mbd@instructure.com>
QA-Review: Michael Brewer-Davis <mbd@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
fixes: CORE-1373
Test plan
* turn on RTL
* go take a quiz
* all the arrows to flag a question (eg https://cl.ly/2p163k092Q0v), the
arrows to mark a question as wrong/right/partially correct, etc
(Eg: https://cl.ly/3n0Q360f213L) should be flipped and look
right (opposite of LTR)
* do a general hunt on the old quizzes pages for anything else you can
find that isn’t flipped for RTL
Change-Id: I7bb032efb751e6b3d4d81e71d29fe61609cb71f6
Reviewed-on: https://gerrit.instructure.com/149028
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
closes OUT-2056
1. clear svg title
2. wrap in PresentationContent
test plan:
- using a screenreader like nvda on firefox, confirm that hovering
over the rocketship image on the import outcomes screen does not
read "asset 1"
Change-Id: Id86182659d90a60d858071cae50c5d41cdcc7db1
Reviewed-on: https://gerrit.instructure.com/143858
Tested-by: Jenkins
Reviewed-by: Michael Brewer-Davis <mbd@instructure.com>
Product-Review: Nathan Rogowski <nathan@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
refs: CORE-24
test plan:
* this net result of this change should mean that we are using the exact
same code as we were using before, just pulled from github directly
in our package.json instead of vendored into our repo.
* testing the follow-on commits should show this worked correctly
Change-Id: Ie6d022d5fe8ed1a607f66f9d426c47ec7e8f5b14
Reviewed-on: https://gerrit.instructure.com/142381
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
This reverts commit 2b9853c82d
but replaces the googlusercontent url that doesn't exist on the
internet with one that will continue to exist:
aka: https://du11hjcvx0uqb.cloudfront.net/dist/images/email_signature-ea0b2cda73.png
Change-Id: I82ba0bb3cc5ae3ef4749f1fcaabe783775dcfc78
Reviewed-on: https://gerrit.instructure.com/143074
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins
fixes COMMS-939
Test Plan:
- send any email in canvas
- notice the footer image is there
- inspect the html source, and notice that the host is
your local Canvas install
- enable CDN config, run `node_modules/.bin/gulp rev`,
and `rake canvas:cdn:upload_to_s3`
- send another enable
- notice the footer image is still there
- inspect the html source, and notice that the host
is the CDN
Change-Id: Ieaed838dee02168a2aa67f3448d8d68fb6f5b701
Reviewed-on: https://gerrit.instructure.com/142889
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Reviewed-by: Landon Gilbert-Bland <lbland@instructure.com>
QA-Review: Gentry Beckmann <gbeckmann@instructure.com>
Product-Review: Gentry Beckmann <gbeckmann@instructure.com>
This reverts commit 789e37c932.
Change-Id: Iddf79c419ffee694719f11b7d7c229efeadea594
Reviewed-on: https://gerrit.instructure.com/142886
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins
Product-Review: Steven Burnett <sburnett@instructure.com>
QA-Review: Steven Burnett <sburnett@instructure.com>
fixes COMMS-939
Test Plan:
- We won't be able to test this
until the image makes it to prod
Change-Id: Ied32168463e5a98344c46e6920bdd2290ebfe0ec
Reviewed-on: https://gerrit.instructure.com/142793
Reviewed-by: Venk Natarajan <vnatarajan@instructure.com>
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
QA-Review: Steven Burnett <sburnett@instructure.com>
fixes COMMS-859
Test Plan
* Make sure SSD is turned on (The new discussions feature)
* Find an empty course and see if all the placeholders show up
* Now play around with moving the discussions around
* See if you can go to the create new discussions page from
placeholder
Change-Id: I61b268b5c620a8802c81da60d0d7762b440c684e
Reviewed-on: https://gerrit.instructure.com/141964
Tested-by: Jenkins
Reviewed-by: Venk Natarajan <vnatarajan@instructure.com>
Reviewed-by: Landon Gilbert-Bland <lbland@instructure.com>
QA-Review: Steven Burnett <sburnett@instructure.com>
Product-Review: Matt Goodwin <mattg@instructure.com>
closes OUT-1984
note: import button temporarily hidden prior to merge
until other components are wired in.
test plan:
- go to the outcomes page, there should be an import button
- click the import button
- the outcome view sidebar on the left should become hidden,
and the content should be replaced with a spinner once
upload is triggered
- the spinner should appear for 3 seconds, then revert to
the standard outcome view with sidebar
- the content pane and sidebar should always reset to
the 'Setting up Outcomes' and root level directory,
regardless of how deep you've navigated on the sidebar
Change-Id: Iccb1bac2270488ac4bea3f69cdb66b2cb6a3b702
Reviewed-on: https://gerrit.instructure.com/142225
Tested-by: Jenkins
Reviewed-by: Matt Berns <mberns@instructure.com>
QA-Review: Matt Berns <mberns@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
Reviewed-by: Neil Gupta <ngupta@instructure.com>
fixes COMMS-647
Test Plan
* Make sure section specific announcements is turned on
* Find a course with no announcements
* Find a course with announcements
* Make sure empty page shows up correctly for both
* Test announcements page for student
* Test announcements page for teacher
* Make sure correct page according to the ticket is shown
Change-Id: I329f6a75d8a4e56d48f3c2d8b741e43e98a62350
Reviewed-on: https://gerrit.instructure.com/138188
Reviewed-by: Felix Milea-Ciobanu <fmileaciobanu@instructure.com>
Reviewed-by: Venk Natarajan <vnatarajan@instructure.com>
Tested-by: Jenkins
QA-Review: Landon Gilbert-Bland <lbland@instructure.com>
Product-Review: Matt Goodwin <mattg@instructure.com>
Removes the develompent flag protection around the Late Policies
feature in New Gradebook. This means users of New Gradebook will now
be able to create Late Policies for their courses.
closes GRADE-332
Test Plan:
1. Start a server without passing the GRADEBOOK_DEVELOPMENT flag.
2. Enter the Gradebook in a course with New Gradebook enabled and
without any late submissions.
3. Click the settings cog. Verify the Late Policy content is available.
4. Verify there is not an alert in the modal stating 'Changing the late
policy will affect previously graded submissions.'
5. In the same course, create an assignment and make it due in the
past. Submit late to the assignment as a student. Do not grade the
late submission.
6. Go to Gradebook and click the settings cog to bring up the Late
Policy information.
7. Verify there is not an alert in the modal stating 'Changing the late
policy will affect previously graded submissions.'
8. Give the late submission a grade, and reload the Gradebook.
9. Click the settings cog to bring up the Late Policy information.
10. Verify there is an alert in the modal stating 'Changing the late
policy will affect previously graded submissions.'
Change-Id: I19dfe24ef5ccab427b15fc58dc09b01ab8dfd0de
Reviewed-on: https://gerrit.instructure.com/134487
Tested-by: Jenkins
Reviewed-by: Indira Pai <ipai@instructure.com>
Reviewed-by: Derek Bender <djbender@instructure.com>
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
Fixes: UIDEV-116
test plan:
- within a course - create an assignment that requires a
"file upload" submission
- have a user/student submit an image/upload
- navigate to the users/files ( > account > files)
- the submissions folder should have a locked folder both in the
side bar and main viewing window
example: https://screencast.com/t/V6PnbKgt
Change-Id: I4f04cfa084101a5a78ea35208327bf366bb079d6
Reviewed-on: https://gerrit.instructure.com/132223
Tested-by: Jenkins
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Fixes: CNVS-39996
test plan:
- initial set-up... to test that a grade has been "dropped" need
to have an assignment group created with at least two graded
assignments/quiz/discussion inside of it
- once the assignment/quiz/discussion has been graded on the
student view the user will be able to see which grade has
been dropped and not being used for the total calculation
- example: https://screencast.com/t/JfwqrvUJK
- note: even tho a score has been marked as dropped it can still
be tested with a different score to then show the user which
would be the next assignment to be dropped
example: https://screencast.com/t/9p39yZzW6kAG
Change-Id: I6fde681d484c50e263a096534af9cbe684a7d015
Reviewed-on: https://gerrit.instructure.com/130006
Tested-by: Jenkins
Reviewed-by: Chris Hart <chart@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Product-Review: Mary Jane Anderson <manderson@instructure.com>
Fixes: CNVS-38642
test plan:
- local set-up ... remove /dist folder since this commit
will need to regenerate the image paths
- as an admin ensure the default canvas logo in the left-hand
nav looks good in both the expanded and collapsed state
- as an admin ensure that a new theme with a custom logo
uploaded still works as expected (for comparison - test
alongside a working sandbox environment)
Change-Id: I7590b6d070dc46c351b2fe26e60455df14f35f63
Reviewed-on: https://gerrit.instructure.com/122863
Tested-by: Jenkins
Reviewed-by: Colleen Palmer <colleen@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Fixes: CNVS-38171
test plan:
- using x-code simulator navigate to local canvas login screen
- the layout should no longer have a patterned background
- enter a false email/password... the error message should now
display under the log in button above the forgot password text
also test the view horizontal or on a tablet to ensure the
the inputs have a restricted width and do not stretch the
entire screen ;)
- *note the mock-up on the ticket shows an option to remember
auth using the toggle (current code did not show that option
therefore may need to be addressed with a new ticket)
Change-Id: I04d4be4e783e78f29dc60269539caa3f93d8b1df
Reviewed-on: https://gerrit.instructure.com/118866
Tested-by: Jenkins
Product-Review: Matthew Rice <mrice@instructure.com>
Reviewed-by: Matthew Rice <mrice@instructure.com>
Reviewed-by: Chris Hart <chart@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
QA-Review: Taylor Wilson <twilson@instructure.com>
In the New Gradebook, the tray icon in the submission cell is now
coming from instructure-icons.
closes CNVS-38105
Test Plan:
1. Enable New Gradebook.
2. Go to the gradebook and verify there is a tray icon when clicking
on a submission cell.
Change-Id: If7c21970cc5d02c4aea0eb3cd1313961c019957c
Reviewed-on: https://gerrit.instructure.com/118221
Tested-by: Jenkins
Reviewed-by: Jeremy Neander <jneander@instructure.com>
Reviewed-by: Shahbaz Javeed <sjaveed@instructure.com>
QA-Review: KC Naegle <knaegle@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
Fixes: CNVS-37057, CNVS-37327
Refs: CNVS-37056
test plan:
- navigate around canvas to ensure the icons are aligned
and showing correctly :D
- overall note - icons are now the "line" version vs the
solid (with this implementation the assignments and
modules pages have removed the circle with background color
for better legibility for the icon)
- the overall base font size for canvas has been increased
to 1rem = 16px (there are still areas that have overriding
css to manipulate the font size smaller than the base and
can be addressed individually)
- this bumps inst-icons to a beta version for testing
Change-Id: I5ef389298257122f0c3016e97beff50ed8925df1
Reviewed-on: https://gerrit.instructure.com/114343
Tested-by: Jenkins
Product-Review: Colleen Palmer <colleen@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Reviewed-by: Chris Hart <chart@instructure.com>
Closes PLAT-2624
Test Plan:
- Create an OriginalityReport with an originality score
set to nil and a workflow state of pending.
- Verify that a clock icon appears in the UI for that
originality report
- Set the workflow state to 'error'
- Verify that a `!` icon appears in the UI for that
originality report in gradebook and on the
student grade page.
- Set the originality score
- Verify that the report icon is rendered as before
- Verify TII and Vericite originality reports render
as before
Change-Id: Ia8d0f9718a41380341ba3e5e985105a363d617ef
Reviewed-on: https://gerrit.instructure.com/116154
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
Product-Review: Karl Lloyd <karl@instructure.com>
closes CNVS-37275
Test Plan:
1. At the account level, 'Allow' the 'New Gradebook' feature flag and
turn the 'New Gradebook Development' feature flag off. At the course
level, enable the 'New Gradebook' feature flag.
2. Go to the gradebook and click on a cell for an active student.
Verify there is a tray icon in the cell and the arrow is pointing
left.
3. Click the tray icon. Verify:
a) A tray opens with 'New goodies coming soon' content.
b) Focus is on the 'X' button in the upper left-hand side of the
tray.
c) The arrow in the tray icon in the cell is now pointing right.
4. Click the 'X' icon. Verify
a) Focus returns to the tray icon in the cell.
b) The arrow in the tray icon in the cell is now pointing left.
5. Reopen the tray by clicking the tray icon. Then, click the tray icon
again. Verify:
a) Focus returns to the tray icon in the cell.
b) The arrow in the tray icon in the cell is now pointing left.
6. Reopen the tray by clicking the tray icon. Then, click on another
cell in the gradebook to make it active. Verify:
a) The tray closes.
b) Focus is on the cell that was just clicked (and focus is not
on the tray icon within that cell).
7. Verify cells for concluded students do not have a tray icon. Verify
cells for students that are not assigned to an assignment do not have
a tray icon. Verify cells for submissions in closed grading periods
do not have a tray icon if you are signed in as a non-admin teacher.
If you are signed in as an admin, those cells should have a tray
icon.
8. At the account level, turn the 'New Gradebook Development' feature
flag on. Go to the gradebook and click on the tray icon in a cell
to open the tray. Verify the tray content is empty.
Change-Id: I1f138e6965a1d35dad61bf8a32851594f6614dc8
Reviewed-on: https://gerrit.instructure.com/115029
Tested-by: Jenkins
Reviewed-by: Gary Mei <gmei@instructure.com>
Reviewed-by: Derek Bender <djbender@instructure.com>
QA-Review: KC Naegle <knaegle@instructure.com>
Product-Review: Christi Wruck
Adds a feature flag for 'New Gradebook Development' and makes the
'Late Policies' tab in the Gradebook Settings Modal show a 'Content
Coming Soon' banner if the feature flag is disabled.
closes CNVS-37240
Test Plan:
1. Go to Account Settings and verify there is a 'New Gradebook
Development' feature flag. It should be turned off by default.
2. Go to New Gradebook in a course and click the Gradebook Settings
Modal cog. The content for the 'Late Policies' tab should show
a gift icon and text that says 'New goodies coming soon!'.
3. Go back to Account Settings and turn the 'New Gradebook Development'
feature on.
4. Go to New Gradebook in a course and click the Gradebook Settings
Modal cog. The content for the 'Late Policies' tab should show
the missing and late policy information.
Change-Id: I847c05603dcc1a45a3ea8fde14f37a3e35f8e4c0
Reviewed-on: https://gerrit.instructure.com/114064
Reviewed-by: Shahbaz Javeed <sjaveed@instructure.com>
Tested-by: Jenkins
Reviewed-by: Derek Bender <djbender@instructure.com>
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
fixes: CNVS-34022
test plan: should include general improvements and bugfixes from
upgrade, but no core functionality should change.
- video and audio player
- speed controls
- quality controls
- caption track controls (including upload and delete)
- note: this does not yet fix all a11y issues
Change-Id: Ifc0afbece6044cd04087f474c9e9c6a30caca74d
Reviewed-on: https://gerrit.instructure.com/111518
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
closes: CNVS-37025
test plan:
* nothing uses this so nothing should change
Change-Id: I105e5c0b05098147e67e600f63c72f6bf153bfdc
Reviewed-on: https://gerrit.instructure.com/112316
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Fixes: CNVS-36212
test plan:
- initial set-up needs to happen at <Your Canvas URL>/plugins/kaltura
(_read wiki for setting up kaltura/notorious_)
- once kaltura is activated - navigate to a course - select "pages"
from the sub-nav... click the + Page button to create a new one
- within the tinymce toolbar there should now be an option to
"Record/Upload Media" click that option (locally there may be some
limitations with uploading an audio-only file [???]) if so try the
"record option"...
example with record option: https://screencast.com/t/LlImaQmz5e
example with default image: https://www.screencast.com/t/YlUaGOIBGnB9
(had to fake the 2nd screenshot from sandbox version vs local)
Change-Id: I5c62c3128e39c1a1152c01d295844c93d7cacbdf
Reviewed-on: https://gerrit.instructure.com/109734
Tested-by: Jenkins
Reviewed-by: Colleen Palmer <colleen@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
QA-Review: Pierce Arner <pierce@instructure.com>
Fixes: FALCOR-176
Test Plan:
- Turn on the New User Tutorial feature for your
institution
- In a course, confirm that the following pages' tutorial trays
have images:
- Announcements
- Assignments
- Collaborations
- Conferences
- Discussions
- Files
- Grades
- Import
- Modules
- Pages
- People
- Quizzes
- Settings
- Syllabus
- Confirm the images look ok in every supported browser
Change-Id: I5035f6bc88d8ed4557e1e76c7707aba69a40e3f7
Reviewed-on: https://gerrit.instructure.com/106002
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
Fixes: FALCOR-129
Test plan:
- Enable new user tutorials
- Open a course's Modules index page in IE11
- When the tray pops out, the SVG issues should be
gone, and it should look like this:
https://www.screencast.com/t/kzIagMXR6
Change-Id: Ibad7b13729e6f3a3bf0b691bc4fe0d6d6961d679
Reviewed-on: https://gerrit.instructure.com/104652
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Dan Sasaki
Product-Review: Chris Hart <chart@instructure.com>
closes FALCOR-109
Test Plan:
- Enable new user tutorials
- Go to the modules page for a course
- The tutorial tray should show the content like this
mockup https://cl.ly/0G1w473T1o3b
Change-Id: Iada14ffcd929742f5ae7172acdae93b3714f0379
Reviewed-on: https://gerrit.instructure.com/103571
Tested-by: Jenkins
QA-Review: Dan Sasaki
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
Product-Review: Christi Wruck
Clint Furse
