External tools were not working if there were query parameters
in the URL (http://dr-chuck.com/ims/php-simple/tool.php?a=1&b=2).
This should now work correctly.
Change-Id: Ibc0b0d61deed508058cadd07bbc2387194926f9e
Reviewed-on: https://gerrit.instructure.com/4936
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
check for presence, validity, and enabled of settings as whole,
rather than if any settings (including defaults) exist
Change-Id: I33a7cbd2da645185cce7bbd7b154e27f28a0ddfe
Reviewed-on: https://gerrit.instructure.com/4899
Tested-by: Hudson <hudson@instructure.com>
Tested-by: Selenium <selenium@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
changes:
* a little i18n work
* show only a certain section
* show attendance
* include ungraded assigments in score
* don't wait for first xhr to fire second
* cool drop down menu thing
Change-Id: Ie93fd06e20aec399710e32441f8d35c686fbbaf2
Reviewed-on: https://gerrit.instructure.com/4868
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Whitmer <brian@instructure.com>
Rather than always showing the term of the course, we're going to show it if
the following conditions are met:
* it's not the "Default Term"
* the user has at least two courses with the same name in different terms
On the full list of enrollments screen, we'll always show the term if it's not
Default Term.
Change-Id: Id1424b13feb0c9cd65eed7cc48e980c3a4603f2d
Reviewed-on: https://gerrit.instructure.com/4907
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Whitmer <brian@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
This also solves the use case of requesting a course by sis id, and
getting the internal canvas id back.
Change-Id: Ie614310a3c5a2eed668e3787a2280a8ae9f89f9b
Reviewed-on: https://gerrit.instructure.com/4901
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Whitmer <brian@instructure.com>
The strategy is that if a term is named "Default Term", that will be a marker
that it's the default term in any language. When displaying the term name, we
check if it == "Default Term" and show the translated version if so. We also
do some special-casing on saving a new term name to make sure the translated
term name doesn't get saved as the new name.
Change-Id: Ic2b6659f75ef5e56bb5aa5fb7b241bba77dee445
Reviewed-on: https://gerrit.instructure.com/4905
Reviewed-by: Jon Jensen <jon@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
- fixed the link on a teacher page in a course to show the report
for that teacher for all students in the course
- added days since submitted for each ungraded assignment
- added sorting of columns
- added link to one-click to message a specific student. This link
will only appear of the current user is a teacher in the course
Change-Id: Ic39ba72fd210411def178dc69ff35006abe96043
Reviewed-on: https://gerrit.instructure.com/4707
Reviewed-by: Brian Whitmer <brian@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
a modal dialog is presented to the user that runs several tests:
connection, LDAP bind, LDAP search, and testing of arbitrary
LDAP credentials.
Change-Id: I7bf53fb856784598367e3481008b9a7be9526c62
Reviewed-on: https://gerrit.instructure.com/4485
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: JT Olds <jt@instructure.com>
also fix some specs that weren't actually testing anything, because no
exception was being raised
Change-Id: I3e61f7c3c80003cacf7b722bd2525705ef786c1e
Reviewed-on: https://gerrit.instructure.com/4855
Reviewed-by: JT Olds <jt@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
We require a term now, there is not all-terms full batch mode anymore.
Change-Id: I85edd67afcfcf86916c93904a7c1a3cfb1f66dba
Reviewed-on: https://gerrit.instructure.com/4850
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: JT Olds <jt@instructure.com>
This way it's easy to tell what job created a file, and it makes cleanup
more reliable, since Dir.mktmpdir will remove the whole directory when
the job ends and the block exits.
Closes#5093
I was a bit worried about the performance impact of making a new
directory for every single job, but on an active job server of ours, it
only seems to add about 160 microseconds per job.
Change-Id: Id4318da20cac75e6ba232ec2250b78c38485f9e4
Reviewed-on: https://gerrit.instructure.com/4811
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
if you minimize a column to it's smallest size
it will change it's formatting and show a tooltip
on hovering. it will also remember you hid it
(per browser/user) and not show it in future.
click a column header to sort.
drag/drop assignment column headers to reorder
(will not be remembered for now)
Change-Id: Ia9d1d8e1bb82ebde85d87fedae80c1d7feb46b6f
Reviewed-on: https://gerrit.instructure.com/4642
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
this was especially needed for the minimizing of
columns in gradebook 2
Change-Id: If6f6bfce25f0dba33c969b2365353b701e7e5429
Reviewed-on: https://gerrit.instructure.com/4639
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
we were adding files to the queue, and then calling uploadNext with
that file specifically. when uploadNext got called again it would find
the same file in the queue and try again.
now just add it to the queue and then process the queue
refs #5143
Change-Id: I53476b3170169a9dc60a9e5edf69a119e2795fbd
Reviewed-on: https://gerrit.instructure.com/4818
Tested-by: Hudson <hudson@instructure.com>
Tested-by: Selenium <selenium@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
This was causing "full batch mode" to delete things that it shouldn't.
Fixes#5084
Change-Id: I6e19820ae9daf0b2096fd569451669ad2bb5f52f
Reviewed-on: https://gerrit.instructure.com/4820
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
also fixed an importer issue, and removed translated js files from
version control (we'll generate them as part of the deploy)
Change-Id: I10be3ab1f4567a1534774f514424fd9966982c62
Reviewed-on: https://gerrit.instructure.com/4686
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
The current version of redis-cache takes only the list of servers, it
doesn't support other config options like key prefix or database number.
Change-Id: If233c46d77b58650627dda75d7a8e1f2f212eb7f
Reviewed-on: https://gerrit.instructure.com/4801
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Zach Wily <zach@instructure.com>
* infini-scroll images tab of wiki side bar
* load file tree piecemeal in wiki_sidebar
* load folder tree only if needed
Change-Id: Ib8d5cb567df8a2ee79935ffb3f8678a7ee5427fe
Reviewed-on: https://gerrit.instructure.com/4671
Tested-by: Hudson <hudson@instructure.com>
Tested-by: Selenium <selenium@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
This was already supported for Syslog, but not for the BufferedLogger
class. Also add an option to disable the context logging.
This also fixes a bug where the session logging was always using the
default session cookie name (_normandy_session), rather than the
configured one.
refs #5094
Change-Id: I4c8389f1051a70c25a92bfe018044cd15f45422b
Reviewed-on: https://gerrit.instructure.com/4795
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
In this spec we call find_element a lot when we expect that the element
probably isn't there. implicit_wait was causing each of those calls to take 3
seconds. For this spec, we manually set it to zero.
Also changed the default 3 second implicit_wait to 1 second for everything.
Also changed the spec to use create_session instead of doing a full login
sequence.
These changes reduced this spec's runtime from 90s to 30.
Change-Id: I9f268ac437eae5ef24ec71a5c1108957b83fd8de
Reviewed-on: https://gerrit.instructure.com/4794
Tested-by: Hudson <hudson@instructure.com>
Tested-by: Selenium <selenium@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
Cody Cutrer