Closes PLAT-4520
Test Plan:
- Install a 1.3 tool in a course
- Copy the course
- Verify there are no content migration warnings
for the tool
Change-Id: If0fc9285a179c768761ff6ff4f3077c3419a8df8
Reviewed-on: https://gerrit.instructure.com/197354
Tested-by: Jenkins
Reviewed-by: Drake Harper <dharper@instructure.com>
Reviewed-by: Marc Phillips <mphillips@instructure.com>
QA-Review: Marc Phillips <mphillips@instructure.com>
Product-Review: Weston Dransfield <wdransfield@instructure.com>
Fixes PLAT-4570
Test Plan
- Create an assignment and associate it with the
plagiarism platform test tool
- Submit to the assignment as a student
- Use the test tool to create an originality report
for the submission
- Create another assignment associated with
the test tool
- Submit to the assignment. When submitting
click the "Click here to find a file you
previously uploaded." link and select the
exact same attachment as the first submission
- Create an originality report for the second
submission
- Verify both submission retain their
individual originality reports
Change-Id: If26c26b9ee6035913c12e12b45182f3dc871e2d8
Reviewed-on: https://gerrit.instructure.com/197288
Tested-by: Jenkins
Reviewed-by: Drake Harper <dharper@instructure.com>
Reviewed-by: Marc Phillips <mphillips@instructure.com>
QA-Review: Marc Phillips <mphillips@instructure.com>
Product-Review: Weston Dransfield <wdransfield@instructure.com>
This change breaks the tray style external tools (i.e commons)
fixes CORE-3062
test plan
- test with commons favorites tool (or any other editor_button tool
configured with use_tray true
- iframe should fill the tray
This reverts commit 7c28ecdb89.
Change-Id: I166084cf7bd0016f44d84d9069ae78b2cb553dcf
Reviewed-on: https://gerrit.instructure.com/197412
Tested-by: Jenkins
Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com>
QA-Review: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
breaks if there are old deleted subscriptions,
due to a uniqueness index
we should only create the tag for the subscription
the discussion is associated with
test plan:
* create two blueprint courses
* associate the first with a child course, then
remove the association
* associate the second with the child course
* add a graded discussion to the blueprint
* sync to child course
* should be able to modify the child course
copy to make it ungraded without an error
closes #COMMS-2125
Change-Id: I255740ff870b8b7f055be7be6b0e24bedae95f90
Reviewed-on: https://gerrit.instructure.com/197394
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins
QA-Review: Steven Burnett <sburnett@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
fixes CORE-3072
test plan
- existing specs should pass
Change-Id: Ia9046c7c834e245a81b0aa84ebc3cfea9ecc0c32
Reviewed-on: https://gerrit.instructure.com/197348
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Fixes COMMS-2126
Test Plan:
* Create a new assignment
* Run a query like this, and notice the attempt 0 submissionHistory
is returned:
```
query {
assignment(id: "62") {
_id
submissionsConnection(
filter: {states: [submitted, unsubmitted, graded, ungraded]}
) {
nodes {
_id
submissionHistoriesConnection(
filter: {states: [unsubmitted]}
) {
nodes {
attempt
}
}
}
}
}
}
```
* Change `unsubmitted` to `submitted in the above query and run it
again. This time, notice that the unsubmitted submission is not
returned
Change-Id: Iec3691912e865def3e950cd3125c17e8dd87fe82
Reviewed-on: https://gerrit.instructure.com/197259
Tested-by: Jenkins
QA-Review: Ryan Norton <rnorton@instructure.com>
Product-Review: Landon Gilbert-Bland <lbland@instructure.com>
Reviewed-by: Cameron Matheson <cameron@instructure.com>
fixes PLAT-4585
Test Plan:
click on an installed lti 1.3 tool and see the deployment id
button, click on it, and see the deployment id
Change-Id: I78a2e977246b4a6524427995f10cf3600b59e090
Reviewed-on: https://gerrit.instructure.com/197321
Product-Review: Jesse Poulos <jpoulos@instructure.com>
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
Tested-by: Jenkins
we were previously titling the upload tab as "Upload" in a2,
but we should instead title it according to the current attempt
that we are on (i.e. Attempt 3)
Test Plan:
* as a teacher, create an assignment
* add a student to the course with the assignment
* as a student, go to the a2 submissions page for that assignment
* with no submission, you should see "Attempt 1":
** above, to the left of the pizza tracker
** as the tab name for the upload tab
* submit to the assignment several times, and with each submission
verify that the attempt number in both locations increments
accordingly
* open the rails console
** a = Assignment.find(id) // where id is the id for the
assignment that you are submitting to
** a.allowed_attempts = 5
** a.save!
* as a student in the a2 submission tab, you should now see
"Attempt n of 5" to the top left of the tracker
* the upload tab should still display "Attempt n"
fixes COMMS-2098
Change-Id: Ibab03f6e987519cf98d151670f0727307f397fc9
Reviewed-on: https://gerrit.instructure.com/197286
Tested-by: Jenkins
QA-Review: Steven Burnett <sburnett@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
Reviewed-by: Steven Burnett <sburnett@instructure.com>
the current Cricket email domain is out of date and needs to
reflect the new domain so that users can continue to receive SMS
Test Plan:
* have a cell on the Cricket network
* add that cell as a contact method for a user
* confirm that the cell receives SMS
fixes COMMS-2121
Change-Id: Ib7ff553df5bf6a7ec34211b5aef357231cbe9018
Reviewed-on: https://gerrit.instructure.com/197304
Tested-by: Jenkins
Product-Review: Ryan Norton <rnorton@instructure.com>
Reviewed-by: Steven Burnett <sburnett@instructure.com>
QA-Review: Steven Burnett <sburnett@instructure.com>
fixes COMMS-2099
TEST PLAN
* Create a course.
* Add two or more students to the course.
* Create an assignment with file upload submission type. Note the
assignemnt id in the url.
* Masquerade as one of the users and submit the assignment. Use a zip
file and an image file (or any other canvadocable mime type) as the
submission files.
* Masquerade and submit the assignment as your other students, using
different canvadocable file types (e.g. pdf, png, jpeg).
* As the instructor/site admin Navigate to the /graphiql endpoint.
* run the following query substituting in the assignment id:
{
assignment(id: "<your_assignment_id>") {
submissionsConnection {
nodes {
_id
user {
name
}
}
}
}
}
* Using those submission ids, run the following query for each
submission id to view the submission preview urls:
{
assignment(id: "<your_assignment_id>") {
submissionsConnection {
nodes {
_id
user {
name
}
attachments {
submissionPreviewUrl(submissionId: "<submission_id>")
displayName
}
}
}
}
}
* Note that the zip file does not have a preview url and verify that the
other attachments do.
Change-Id: Ic8e8c0be994f1d6e4979755674a9e8c3d35c038a
Reviewed-on: https://gerrit.instructure.com/196418
Tested-by: Jenkins
Reviewed-by: Cameron Matheson <cameron@instructure.com>
Reviewed-by: Landon Gilbert-Bland <lbland@instructure.com>
QA-Review: Steven Burnett <sburnett@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
Closes PLAT-4296, PLAT-4559, PLAT-4558
Test Plan:
- Create a text entry submission
- Create an originality report for the submission
- Resubmit the assignment
- Create an originality report with a different
score for the resubmission
- Verify the gradebook submission details dialog
shows the correct report for each submission
version
- Create a text entry submission with an originality report
- Verify the report can be viewed in speedgrader
- Resubmit the assignment and create a new originality report
- Verify speed grader shows the correct originality score for
each submission
- Verify speed grader correctly displays originality reports
tied to an attachment
- Verify speed grader correctly dispalys originality reports
from tii plugin
Change-Id: I433be93083a501cb03cbaa04bb2329c50bbfffca
Reviewed-on: https://gerrit.instructure.com/196697
Tested-by: Jenkins
Product-Review: Jesse Poulos <jpoulos@instructure.com>
QA-Review: Kai Bjorkman <kbjorkman@instructure.com>
Reviewed-by: Marc Phillips <mphillips@instructure.com>
refs CORE-2654
test plan:
* Hope for the best
Change-Id: I593c778cc311af8086c99240f3d57f87c69dde48
Reviewed-on: https://gerrit.instructure.com/197254
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Neander <jneander@instructure.com>
Product-Review: Jeremy Neander <jneander@instructure.com>
closes PLAT-4427
Test Plan:
- see that the bug has been fixed
Change-Id: I50fb60fe1db4d44031581301b4d3b3f58b23808e
Reviewed-on: https://gerrit.instructure.com/197174
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
Tested-by: Jenkins
Product-Review: Marc Phillips <mphillips@instructure.com>
also keeps it undocumented for now
test plan:
* test an lti launch in a course using a variable
in the format:
$Canvas.membership.permissions<permission1,permission2,..>
with a comma-separated list in between the brackets
corresponding to course-level permissions
(see doc/api/roles.html#method.role_overrides.show), e.g.
$Canvas.membership.permissions<read_forum,moderate_forum>
these are the list of permissions to check
when the variable is expanded it should substitute it with a
comma-separated list of permissions filtered to those
that the user has been granted within the course
closes #PLYT-1796
Change-Id: I1c039e04318fcfe8ca5ee450e608bd3fb2affe6b
Reviewed-on: https://gerrit.instructure.com/194797
Tested-by: Jenkins
QA-Review: Nathan Mills <nathanm@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Reviewed-by: Nathan Mills <nathanm@instructure.com>
Reviewed-by: Marc Phillips <mphillips@instructure.com>
closes PLAT-4550
test plan:
- tests pass
- this would be hard to manually qa, but if you want you could add a
sleep to the live event async worker loop, do some stuff that
queues events, ctrl-c the rails server, and watch the loggs for it
to process the events before finally exiting.
Change-Id: I8c82b07ff5eec75cf51a307a2571f3780e75a216
Reviewed-on: https://gerrit.instructure.com/197276
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Also print out debug info while it's trying to pull archives
from AWS S3.
Change-Id: I41dec09de8c67652b4900255a2e53f1655dfab5d
Reviewed-on: https://gerrit.instructure.com/196747
Tested-by: Jenkins
Reviewed-by: Robert Lamb <rlamb@instructure.com>
QA-Review: Tucker Mcknight <tmcknight@instructure.com>
Product-Review: Tucker Mcknight <tmcknight@instructure.com>
Also this makes it so that a `display: none` table is now actually not
rendered on the grade summary page.
Closes: GRADE-2192
Test Plan:
- spec pass
Change-Id: Ibe86c093d6bc2ca560f3305889dc653920596615
Reviewed-on: https://gerrit.instructure.com/195018
Tested-by: Jenkins
Reviewed-by: Keith Garner <kgarner@instructure.com>
Reviewed-by: Adrian Packel <apackel@instructure.com>
QA-Review: Derek Bender <djbender@instructure.com>
Product-Review: Keith Garner <kgarner@instructure.com>
Closes: GRADE-2197
Test plan:
- have a submission with a grade that is not yet posted
- verify the totals column bell icon (icon-mute) has
changed to the eye icon (icon-off)
Change-Id: I4cef7681bcb0e2804c4b5abac1c74918f967a5e4
Reviewed-on: https://gerrit.instructure.com/197191
Tested-by: Jenkins
Reviewed-by: Keith Garner <kgarner@instructure.com>
Reviewed-by: Jeremy Neander <jneander@instructure.com>
QA-Review: Derek Bender <djbender@instructure.com>
Product-Review: Jonathan Fenton <jfenton@instructure.com>
fixes PLAT-4587
Test Plan:
- making a server to server call with the final oidc flow
should return a sane error and not an error_report
Change-Id: I38988c9b3fbe59fb4ace8f045ae468f02a8e276d
Reviewed-on: https://gerrit.instructure.com/197245
Tested-by: Jenkins
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
Product-Review: Marc Phillips <mphillips@instructure.com>
Closes PLAT-4584
Test Plan:
- Send multiple deep linking responses to canvas that use the
same JTI in quick succession.
- Verify Canvas processes each message without showing an
"invalid JTI" error.
Change-Id: I04de165550d554db2942ec9c05e9d97858127a85
Reviewed-on: https://gerrit.instructure.com/197156
Tested-by: Jenkins
Reviewed-by: Marc Phillips <mphillips@instructure.com>
QA-Review: Marc Phillips <mphillips@instructure.com>
Product-Review: Weston Dransfield <wdransfield@instructure.com>
On the dashcard dashboard, on first render we try to render with data
cached in sessionStorage, then once the XHR to get the freshest
data comes back, we render again with the new data.
But the thing is, now that we prefetch that XHR from our rails erb,
by the time we get to this line of code, the XHR might already be
Loaded. So if that’s the case, there is no need to try to render from
sessionStorage with cached data, we can just render with the new data.
Test plan:
* the dashcard dashboard should look the same as before but it should
Load a little faster.
Change-Id: I1132e698ddd667623bb9547150afc8042312ab02
Reviewed-on: https://gerrit.instructure.com/196666
Tested-by: Jenkins
Reviewed-by: Mysti Lilla <mysti@instructure.com>
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
fixes PLAT-4573
Test Plan:
- test that the mobile launch for a 1.3 test tool works
Change-Id: Iab64bb7099a4762d81c285614ac8f698a34e3230
Reviewed-on: https://gerrit.instructure.com/197164
Tested-by: Jenkins
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
Product-Review: Marc Phillips <mphillips@instructure.com>
when we select files to be uploaded, before they are ready for
submitting, we need to save them as attachments on the current
submission draft
Test Plan:
* create an assignment as a teacher
* add a student to the course with the assignment
* as a student, go to the a2 submissions page for that assignment
* you should see the empty Upload tab
* add a file to the upload tab
* while the file is being uploaded, confirm:
** the file upload box disappears
** a loading indicator is displayed
** the submit button is not available
* when the upload completes:
** the file upload box should return
** the file should render inside of the upload box
** the submit button should reappear
** screen reader should confirm that the upload was successful
* refresh the page and confirm the file is still
displayed on the refreshed page
* confirm that:
** you can add multiple files
** you can remove some files
** you can remove all files
** image files render appropriately
** you can click the submit button
fixes COMMS-2024
Change-Id: I31c8a9c716da84afabea20d6ebd07cb1b5610f3a
Reviewed-on: https://gerrit.instructure.com/196850
Tested-by: Jenkins
Reviewed-by: Matthew Lemon <mlemon@instructure.com>
QA-Review: Matthew Lemon <mlemon@instructure.com>
Product-Review: Ryan Norton <rnorton@instructure.com>
LTI keys will always require_scopes and so these
parameters are unnecessary and even misleading.
fixes PLAT-4532
Test Plan:
- tests pass
Change-Id: If1aba14aee878587c9453c4eb536966ad7e6a7a3
Reviewed-on: https://gerrit.instructure.com/197126
Tested-by: Jenkins
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
Product-Review: Marc Phillips <mphillips@instructure.com>
the new flags UI is read-only and a basis for followup stories
closes ADMIN-2699
test plan:
- 'New Feature Flags' shows up on Feature Options for Accounts and
Site Admin. Accounts has on/off, SiteAdmin has off/allow (for now)
- In Accounts page, setting to On and refreshing changes tab name
to Feature Preview and shows a table of some flags
- Clicking the 'Revert to old UI' button reloads page and shows
old 'Feature Options' tab version.
- Contents of new version of page are not part of this story. Just
hooking up the feature flag itself at this point
Change-Id: Id34da3b0e10e90e99057a20cd87d3a031b00c4ae
Reviewed-on: https://gerrit.instructure.com/196501
Reviewed-by: Mysti Lilla <mysti@instructure.com>
Tested-by: Jenkins
QA-Review: KC Naegle <knaegle@instructure.com>
Product-Review: KC Naegle <knaegle@instructure.com>
Fixes COMMS-2116
Test Plan:
- Submit to an assignment multiple times with different attachments
each time.
- Make a graphql query to the submission, including submission
histories > attachments. Notice that the attachments properly
corelate to the different submission histories
Change-Id: I4717097f35eb1c6b09fa7a39914378586e99fa32
Reviewed-on: https://gerrit.instructure.com/196915
Tested-by: Jenkins
Reviewed-by: Cameron Matheson <cameron@instructure.com>
QA-Review: Matthew Lemon <mlemon@instructure.com>
Product-Review: Landon Gilbert-Bland <lbland@instructure.com>
closes CORE-2665
test plan:
1. Upload a document to the course
2. Open a page with CanvasRCE
3. Open the documents tray
4. Add the document to the editor
5. Click or select the link
6. Verify the "Options" button appears in a popover
7. Click the "Options" button
8. Verify the Embedding "Options" tray appears
9. Click the "Close" or "Done" button
10. Verify the tray closes
11. Verify focus returns to the "Options" button
Change-Id: I82e55489b583df5c66d952624f4d791ecb355ae4
Reviewed-on: https://gerrit.instructure.com/197101
Tested-by: Jenkins
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Ed Schiebel <eschiebel@instructure.com>
Product-Review: Jeremy Neander <jneander@instructure.com>
test plan:
* try to create a global notification with a title
longer than 255 characters
* should show immediate error before submitting
closes #CORE-3066
Change-Id: I8f1efce365e3b8704c8763c3f5c86f9b1f360bad
Reviewed-on: https://gerrit.instructure.com/197196
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
fixes CORE-2660 CORE-2662
Test Plan:
- on the computer panel drag or upload a video from your computer
- notice a video preview shows
- ensure when removing the video from the tray it removes the player
- save the video
- notice it shows up in the rce
Change-Id: I1faf312e50e9eb6d49e1da613da0712772ea914d
Reviewed-on: https://gerrit.instructure.com/196865
Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com>
Tested-by: Jenkins
QA-Review: Steven Burnett <sburnett@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
There is a bug in tinymce demonstrated in http://fiddle.tinymce.com/YJgaab/1
and reported as an issue at https://github.com/tinymce/tinymce/issues/5036
where the default_link_target is not set on an anchor if the target_list
is not shown in tinymce's link dialog. Because of this, external links
do not open in a new window.
CORE-3065 was created to eventually resolve the issue
closes CORE-2667
refs CORE-3065
test plan:
- add a course link or course document link to your rce
- save whatever you were editing
- click the link
> expect it to open in a new browser tab (or window,
depending on your browser settings)
- add a navigation course link, save, and click the link
> expect it to load in the current window
- add an external link, save, and click
> while it should open in a new tab, it does not due
to the tinymce bug described above.
Change-Id: I2befef3f41ae85bb33d11d561fd909862942bee3
Reviewed-on: https://gerrit.instructure.com/196958
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
fixes PLAT-4576
Test Plan:
-verify documentation is correct at
/doc/api/public_jwk.html#method.lti/public_jwk.update
Change-Id: I6067f7204d1db5b606233e66915384b5f49e7518
Reviewed-on: https://gerrit.instructure.com/197072
Reviewed-by: Marc Phillips <mphillips@instructure.com>
QA-Review: Marc Phillips <mphillips@instructure.com>
Product-Review: Marc Phillips <mphillips@instructure.com>
Tested-by: Jenkins
The drag handle is now visible when you switch to html mode. HTML mode
and RCE mode should now be the same size, even after a resize. The html
textarea is no longer resizable.
fixes CORE-3048
test plan:
- the html mode textarea should no longer have its own drag handle.
- the status bar's drag handle should be visible in html mode.
- you should be able to resize the editor in both modes.
- when you toggle modes, the size of the editor should be the same, even
when resized.
Change-Id: I7a2d3b6daafc2cfcf9c7cdaf721e54ec57e747f6
Reviewed-on: https://gerrit.instructure.com/196999
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Product-Review: Jon Willesen <jonw+gerrit@instructure.com>
closes ADMIN-2687
test plan:
- Load assignment in A2 and ensure Students tab works:
- 1. Student Tray slides out and closes correctly
- 2. Student row renders
- 3. Searching by student name works
Change-Id: If5b28db29af8fc833cce38c398768886b16bc6a3
Reviewed-on: https://gerrit.instructure.com/195264
Reviewed-by: Carl Kibler <ckibler@instructure.com>
Reviewed-by: Mysti Lilla <mysti@instructure.com>
QA-Review: Carl Kibler <ckibler@instructure.com>
Tested-by: Jenkins
Product-Review: Carl Kibler <ckibler@instructure.com>
wdransfield