Fixes COMMS-2085
Test Plan:
- Create an assignment with multiple submissions
- Leave some comments on some of the submission attempts, using the
next and previous buttons to cycle through submissions
- Notice that the comments will only be displayed for the submission
attempt that it was created on.
- Create a new assignment
- Create a comment on attempt 0
- Submit the assignment
- Notice that on reloading the page, the attempt 0 comments show up on
attempt 1
Change-Id: Ie4e8196504272131a388a913217c30673df81eb3
Reviewed-on: https://gerrit.instructure.com/197899
QA-Review: Ryan Norton <rnorton@instructure.com>
Tested-by: Jenkins
Reviewed-by: Matthew Lemon <mlemon@instructure.com>
Product-Review: Landon Gilbert-Bland <lbland@instructure.com>
refs CORE-2626
Test Plan:
- Start RCE API using the proper ENV variables, I can provide
those upon request
- Go to the Upload Image dialog
- Click the Unsplash Panel
- Type in a search phrase
- You should be able to do a search and get results back
- NOTE: At this point, you can't select an image and have
it be inserted into the RCE
Change-Id: I06832be6ef1c2e299c531c68a8d34782c3cebee0
Reviewed-on: https://gerrit.instructure.com/195273
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
Fixes COMMS-2087
Test Plan:
- Navigate to an assignment 2 page as a student (without being
masqueraded)
- Upload a file so the submit button will display
- Notice that the submit button displays at the bottom of the page and
looks nice
- Visit the same assignment, but this time by masquerading as a
student.
- Notice that the submit button now shows up right after the
masquerading alert bar, and still looks nice.
- Once this hits beta, go to bate and run the same tests, and notice
that the submit button always displays and looks good with and
without masquerading.
Change-Id: Id71e1ffdd4e48dd7590499dd5aa8ef82caee8371
Reviewed-on: https://gerrit.instructure.com/197971
Reviewed-by: Ryan Norton <rnorton@instructure.com>
Tested-by: Jenkins
QA-Review: Landon Gilbert-Bland <lbland@instructure.com>
Product-Review: Landon Gilbert-Bland <lbland@instructure.com>
when an assignment has been submitted or graded (the attempt is
ready for preview) we should display the current grade and
submission time for the attempt according to the design
Test Plan:
* As a teacher, create an assignment
* As a student, navigate to the submission page in A2
* Confirm that no submission date or grade is displayed
* Upload, but do not submit, some files
* Confirm that no submission date or grade is displayed
* Submit to the assignment
* Confirm that the submission date and grade are displayed
* As a teacher, grade the attempt
* Confirm that the submission date and grade are displayed
* The displayed grade should match whatever we display in the top right
* The submission time displayed should be accurate for the
selected attempt
* They should match the design
** They should align just above the content tab bar to the right
** The text should align along the right-hand sidebar
* The display should look acceptable for any grading type (points,
percentage, letter, etc)
fixes COMMS-2095
Change-Id: I40d5cc079adeb3e79060cbb29c35fad7ebf15ba6
Reviewed-on: https://gerrit.instructure.com/197725
Tested-by: Jenkins
Reviewed-by: Steven Burnett <sburnett@instructure.com>
QA-Review: Landon Gilbert-Bland <lbland@instructure.com>
Product-Review: Ryan Norton <rnorton@instructure.com>
fixes COMMS-2127
Reconfigure StepContainer.test, Header.test, and StepItem.test to
test only their level of component and to use React testing
library.
Test Plan:
* Tests pass Jenkins
Change-Id: I30884b9a71ea1605cac0e2d9ca9a39baab00b8f2
Reviewed-on: https://gerrit.instructure.com/197706
Tested-by: Jenkins
Reviewed-by: Ryan Norton <rnorton@instructure.com>
Reviewed-by: Landon Gilbert-Bland <lbland@instructure.com>
QA-Review: Landon Gilbert-Bland <lbland@instructure.com>
Product-Review: Michelle Simmons <misimmons@instructure.com>
Closes PLAT-4442
Test Plan:
- Launch an external tool that has a url, domain, and name
- Verify these fields are included in the asset accessed
event that is sent
- Verify other asset accessed event bodies remain unchanged
Change-Id: Ia728a784b01cc640a8619fa05ca01acae2e918b7
Reviewed-on: https://gerrit.instructure.com/197694
Tested-by: Jenkins
Reviewed-by: Drake Harper <dharper@instructure.com>
Reviewed-by: Clint Furse <cfurse@instructure.com>
Reviewed-by: Marc Phillips <mphillips@instructure.com>
QA-Review: Brent Burgoyne <bburgoyne@instructure.com>
Product-Review: Weston Dransfield <wdransfield@instructure.com>
when using VO with Safari, a descendant of the button
is supplied to the event handler as the event target.
work around this weirdness by moving up the DOM to the button.
test plan:
- in assignments 2, student tab, be sure you can open the
student context tray with VO/Safari
fixes ADMIN-2719
Change-Id: I25d6958cbf4c2cd32b81fee6f2d4fdd99efc5e2f
Reviewed-on: https://gerrit.instructure.com/197787
Tested-by: Jenkins
Reviewed-by: Carl Kibler <ckibler@instructure.com>
QA-Review: Carl Kibler <ckibler@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
wait for the success banner before trying to continue on with
test.
Change-Id: I0af808d85ce20e7d8481069e4f6026ac2ffdb082
Reviewed-on: https://gerrit.instructure.com/197939
Tested-by: Jenkins
Reviewed-by: Jeremy Neander <jneander@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
refs PLAT-4493
Test Plan:
-Create a developer key and verify that it has the new fields
(public-jwk_url and is_lti_key)
Change-Id: I72508ae26709ce5f7560de35d5ee0c03d4000b5d
Reviewed-on: https://gerrit.instructure.com/197314
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
Reviewed-by: Clint Furse <cfurse@instructure.com>
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
Product-Review: Drake Harper <dharper@instructure.com>
tests showing flaky results after cliking link and trying to
interact with the new page before it's finished loading. Add
wait_for_new_page_load before attempting to interact.
Change-Id: I969137152275e174837d6aa5c4a7f7f7435ab610
Reviewed-on: https://gerrit.instructure.com/197914
Reviewed-by: Jeremy Neander <jneander@instructure.com>
Tested-by: Jenkins
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
closes CORE-3021
test plan
- go to /courses/:course:id/assignments/new for example
- click the kb shortcut button in the status bar
> expect the dialog to open
- click the close button or type ESC
> expect the dialog to close and the editor to receive focus
- focus on the assignment name and TAB
> expect the kb shortcut button above the RCE to appear
- click it
> expect the dialog to open
- close the dialog
> expect focus to return to the editor
- type ALT-0 or ALT-F8 (from anywhere in the RCE)
> expect the dialog to open
- close the dialog
> expect focus to return to the editor
Change-Id: Ia8ce42fbf1b52b765e8a8961b8bac1156d4f7780
Reviewed-on: https://gerrit.instructure.com/196913
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
Fixes: GRADE-2257
It appears that several `yarn build:canvas` scripts in
packages/ open files with `rw` permissions that they
don't have at an early enough stage in the Dockerfile.
We were previously making all the directories writeable
but this wasn't going far enough since it was ignoring
files. I have a hunch that the files don't need to be
opened with `rw` permissions but that might be a problem
with babel or something else upstream. Since we eventually
make all files owned by docker:docker might as well do it
sooner with `COPY --chown=docker:docker`.
A follow up patchset should do add this feature to all
the other COPY directives.
Change-Id: I6a09161a34d6895284a87750091de3f82aa44e15
Reviewed-on: https://gerrit.instructure.com/197837
Tested-by: Jenkins
QA-Review: Derek Bender <djbender@instructure.com>
Product-Review: Derek Bender <djbender@instructure.com>
Reviewed-by: Steven Burnett <sburnett@instructure.com>
closes CORE-2903
test plan:
- load a page with the rce
- TAB into the RCE and into the StatusBar
> expect right/left arrows to move focus from one button to
the next.
> expect focus to cycle back to the other
end when you go too far
- tab out of the status bar
- click one of the buttons to give it focus
- use the arrow keys again
> expect focus to move right|left from the starting point
- give he drag handle focus
> expect up/down arrows to resize the RCE w/o scrolling the page
- fire up a screenreader
> expect the button area of the status bar to be announced as a
toolbar
Change-Id: I00e5a761ebc25ae784267c57bb5a653b68ccacba
Reviewed-on: https://gerrit.instructure.com/197059
Tested-by: Jenkins
Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com>
QA-Review: Jon Willesen <jonw+gerrit@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
closes CORE-3078
test plan:
- load a page with the rce
- enter some text and move the text cursor somewhere in the middle of
what you typed
- select Links -> Course Links
- type Escape or click the X to immediately close the tray
> expect focus to return to the editor. The text cursor is where you
left it. If you start typeing, it goes right there. If you had
selected text, it's still selected and typing replaces the selection
- select Images -> upload image
- type Escape or click the X to close the modal
> expect the same reasult as with the tray
- the same should be true for Images -> Course Images or
media -> upload media
Change-Id: I3ea663191be1fa3a8abaf94408d76849f384b47b
Reviewed-on: https://gerrit.instructure.com/197589
Tested-by: Jenkins
Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com>
QA-Review: Jon Willesen <jonw+gerrit@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
fixes PLAT-4441
Test Plan:
- see that they are added correctly given the context
for each value being added
Change-Id: I60127a66981b7a1b8aa1bc157446a3e83c61f379
Reviewed-on: https://gerrit.instructure.com/197643
Tested-by: Jenkins
Reviewed-by: Clint Furse <cfurse@instructure.com>
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
QA-Review: Marc Phillips <mphillips@instructure.com>
Product-Review: Marc Phillips <mphillips@instructure.com>
closes: CORE-3087
I think I finally found what was causing the icons from the icon font
to show up garbled sometimes. It was because the browser was just
guessing about what type of character encoding the file used. By setting
it explicitly as UTF-8 in a response header, it will be unambiguous.
Test plan:
* with canvas_cdn.yml set up
* the fonts from the font icon should not ever show up garbled
Change-Id: Ib5f4995e23d90a9bdd146c74c3a8850e563bba8a
Reviewed-on: https://gerrit.instructure.com/197277
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins
QA-Review: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
closes: CORE-3085
all the browsers we support (except IE11) can handle woff2, so serve
them that. That is better because it has better compression so will
be smaller.
For IE 11 we still serve a woff format. But all the other older formats
aren’t needed anymore though.
Test plan:
* icons should show up the same as before but should download a little
faster since the file is smaller.
Change-Id: I9eb183e1f028a7390d86b8dc901d375df8b334fa
Reviewed-on: https://gerrit.instructure.com/197250
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins
QA-Review: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
test plan:
* configure a tool with a "student_context_card" placement
and the "require_permissions" extension setting set
to a comma-separated list of permissions
* enable the "Student Context Card" feature
* as a teacher, when showing the student context card
(e.g. when clicking on a student name on the roster or gradebook)
it should show a link underneath "Grades" for the tool
(assuming the current user has all of the permissions in
"require_permissions")
* following the link should launch the tool with an
"ext_lti_student_id" param corresponding to the student
being viewed
closes #PLYT-1746 #PLYT-2076
Change-Id: Iace4f0ef035fd1fd3686d4f539db28af5ce2502e
Reviewed-on: https://gerrit.instructure.com/195134
Tested-by: Jenkins
Reviewed-by: Nathan Mills <nathanm@instructure.com>
QA-Review: Nathan Mills <nathanm@instructure.com>
Product-Review: Nathan Mills <nathanm@instructure.com>
update to use react-testing-library with our GradeDisplay
specs instead of ReactDOM
Test Plan:
* the tests should still pass
fixes COMMS-2128
Change-Id: I7c44884d07c907e9cf80f51c8004387730599d9e
Reviewed-on: https://gerrit.instructure.com/197724
Tested-by: Jenkins
Reviewed-by: Michelle Simmons <misimmons@instructure.com>
Reviewed-by: Steven Burnett <sburnett@instructure.com>
QA-Review: Ryan Norton <rnorton@instructure.com>
Product-Review: Ryan Norton <rnorton@instructure.com>
Ensure that setAssignmentPostPolicy does not allow anonymous assignments
to be automatically posted (ever) and allows moderated (non-anonymous)
assignments to be auto-posted only after grades are published.
fixes GRADE-2206
Test plan:
- Set up some assignments
- An anonymous assignment
- A moderated assignment
- Open up /graphiql in your browser
- Run the query, substituting in the assignment IDs in turn:
mutation {
setAssignmentPostPolicy(input: {assignmentId: <id>, postManually: false}) {
postPolicy {
postManually
}
errors {
attribute
message
}
}
}
- For A1, this should return an error
- Using postManually: true in the query instead should not fail but
also should not actually change anything
- For A2, this should also return an error
- But after moderating/posting grades, it should succeed
Change-Id: I3a200a634694914df71d58365e1dde3e40423549
Reviewed-on: https://gerrit.instructure.com/197144
Tested-by: Jenkins
Reviewed-by: Jeremy Neander <jneander@instructure.com>
Reviewed-by: Gary Mei <gmei@instructure.com>
QA-Review: Gary Mei <gmei@instructure.com>
Product-Review: Keith Garner <kgarner@instructure.com>
fixes GRADE-2236
Test plan:
- With Post Policies enabled, open up New Gradebook with a manually
posted assignment
- The old "outline eye" (when an assignment that is manually-posted has
nothing that needs posting) icon should now have a slash through it
- Nothing else should be affected
Change-Id: Ibb531773f4ba25d9850912c9f9e648b0057ec780
Reviewed-on: https://gerrit.instructure.com/197538
Tested-by: Jenkins
Reviewed-by: Gary Mei <gmei@instructure.com>
Reviewed-by: Jeremy Neander <jneander@instructure.com>
QA-Review: Adrian Packel <apackel@instructure.com>
Product-Review: Jonathan Fenton <jfenton@instructure.com>
fixes GRADE-2229
test plan
- export gradebook
- it should work
- set root_account to include integration_ids in gradebook
- export gradebook
- it should include integration_id
- account grade export reports should also use account setting
- import grade export that includes integration_id
- it should import with out error
Change-Id: I7b5eb980492c3ee657e87df27217263c36615cb4
Reviewed-on: https://gerrit.instructure.com/196982
Tested-by: Jenkins
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
Reviewed-by: Keith Garner <kgarner@instructure.com>
Reviewed-by: Nathan Mills <nathanm@instructure.com>
test plan:
- create a quiz that includes a question group that picks 0 questions
(either from a set of questions or a question bank)
- copy the course
- the copy should preserve the question group
fixes ADMIN-2724
Change-Id: If4a0197c307361b3cf1dce210fb6610c4ff05b0e
Reviewed-on: https://gerrit.instructure.com/197302
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: Carl Kibler <ckibler@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
test plan:
- enable student context cards feature
- click a student with an active enrollment
- there should be a message button on the context card
- click a student with an inactive enrollment
- there should not be a message button on the card
fixes ADMIN-2710
Change-Id: Ic633a6e38a20564c7f47a13e4b2e7721e4f7f64d
Reviewed-on: https://gerrit.instructure.com/197137
Reviewed-by: Mysti Lilla <mysti@instructure.com>
Tested-by: Jenkins
QA-Review: Carl Kibler <ckibler@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
Eventually this will be replace by the ability to create new submissions
of an unsubmitted or in-progress state and doing the check based on
that, but for now this should work fine.
Fixes COMMS-2129
Test Plan:
* Jenkins passes
* Create a submission draft for an old submission attempt in an
assignment (via the rails console).
* Insure that submission draft is not returned via a graphql query to
submission_histories
Change-Id: I39f3a16f5d8d28d96236c7fd3d0a38d21a77cec0
Reviewed-on: https://gerrit.instructure.com/197682
Tested-by: Jenkins
Reviewed-by: Michelle Simmons <misimmons@instructure.com>
Reviewed-by: Cameron Matheson <cameron@instructure.com>
QA-Review: Landon Gilbert-Bland <lbland@instructure.com>
Product-Review: Landon Gilbert-Bland <lbland@instructure.com>
I could not find a way to get the describe("lifecycle") tests to run so
I added a testcafe test that confirms the actions tested in those
specs actually work. Except for replacing the textarea out from under
the RCE, which I just don't see as ever actually happening.
closes CORE-2930
test plan:
- the tests all pass
Change-Id: I74129dc22249caade8c8569dbe18849c77b1e58b
Reviewed-on: https://gerrit.instructure.com/197262
Tested-by: Jenkins
Reviewed-by: Jeremy Neander <jneander@instructure.com>
QA-Review: Jeremy Neander <jneander@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
Tool lookups were failing if the tool defined the domain
to have a scheme. Remove the scheme so that it only
checks for the provided domain.
closes PLAT-4545
Test Plan:
- create a test tool with a domain that has a scheme
- in teh console, try to look up the tool using a url
- it should resolve to the created tool
Change-Id: Ice8b3dfddbceae018defb353fd788013b95a6045
Reviewed-on: https://gerrit.instructure.com/197617
Tested-by: Jenkins
Reviewed-by: Clint Furse <cfurse@instructure.com>
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
QA-Review: Marc Phillips <mphillips@instructure.com>
Product-Review: Marc Phillips <mphillips@instructure.com>
test plan:
* in an environment with multiple redis rings
separated by shard (e.g. production) enrolling a user
from one ring (e.g. a site admin user) in to a
course in an other ring should clear their cache
(can be checeked via a call to /api/v1/courses )
closes #CORE-3080
Change-Id: I5d948e942652679c7698415c2ebaf1a5ccedd4e0
Reviewed-on: https://gerrit.instructure.com/197677
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
fixes GRADE-2249
test plan
- existing specs should pass
Change-Id: Icb534bdb00cf983f6d58a8df8054538b65558001
Reviewed-on: https://gerrit.instructure.com/197670
Reviewed-by: Keith Garner <kgarner@instructure.com>
Tested-by: Jenkins
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
fixes PLAT-4590
Test Plan:
-update public jwk on a lti key using the update public jwk
endpoint
-view json in manual edit and verify that the public jwk
has changed
Change-Id: I1ddc6f0b3eca0b64ac0c15cefa44f5868d8bde32
Reviewed-on: https://gerrit.instructure.com/197498
Tested-by: Jenkins
Reviewed-by: Marc Phillips <mphillips@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
Product-Review: Drake Harper <dharper@instructure.com>
test plan:
* should be able to edit a designer's section in a
course through the roster UI
closes #ADMIN-2728
Change-Id: If0855a80138ab3e7b73bf68dcfbcb007e1e74ab2
Reviewed-on: https://gerrit.instructure.com/197529
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Convert post policies from a garden-variety feature flag into a global
setting and remove the old feature flag. Add some helper methods to
handle enabling and disabling, and have everywhere in the code that
references the feature use the new helper methods instead. Also, have
the activation of post policies for a given course depend on whether new
gradebook is active for that course.
closes GRADE-1974
Test plan:
Note that the Post Policies feature flag no longer exists, and instead
there's a setting you'll need to turn on. You can do so in the console
using:
> PostPolicy.enable_feature!
To disable it:
> PostPolicy.disabled_feature!
Note that, even when enabled, it should only apply to courses that have
new gradebook turned on.
- With the new setting ENABLED:
- Courses with new gradebook behave as though post policies is enabled
- Do a bit of smoke testing to see if stuff like posting/hiding and
changing assignment posting policies hasn't broken
- Courses with old gradebook do not
- For example, calling a mutation like postAssignmentGrades on an OG
course should return an error indicating the feature isn't enabled
- With the new setting DISABLED:
- Courses with new gradebook behave as though post policies is
disabled (e.g., old-style muting is active)
- Calling a mutation, as described above, should return an error
Change-Id: I5e223d2c4ca4202cce0641f316ecaa505a66298c
Reviewed-on: https://gerrit.instructure.com/196062
Tested-by: Jenkins
Reviewed-by: Keith Garner <kgarner@instructure.com>
Reviewed-by: Gary Mei <gmei@instructure.com>
QA-Review: Derek Bender <djbender@instructure.com>
Product-Review: Keith Garner <kgarner@instructure.com>
fixes CORE-3034
This reverts commit 626140841b.
Reason for revert: Images are too small, and Inst-FS doesn't currently support specifying the resolution.
Change-Id: I3e7b1180e4e8ada363862887fc851037a9b566f6
Reviewed-on: https://gerrit.instructure.com/196445
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
Fixes PLAT-4592
Test Plan:
When customizing a tool configuration, verify the custom fields
text area is large enought to easily read
Change-Id: If6a219bbe41aeed32fe996e4523d6f9b6c2f0f77
Reviewed-on: https://gerrit.instructure.com/197526
Reviewed-by: Marc Phillips <mphillips@instructure.com>
Tested-by: Jenkins
QA-Review: Marc Phillips <mphillips@instructure.com>
Product-Review: Jesse Poulos <jpoulos@instructure.com>
Closes PLAT-3919
Test Plan:
Verify events tied to a Canvas request now include
a url field.
Change-Id: Iab6af4b5a15a5933f89ed657da59b37dc22ab00f
Reviewed-on: https://gerrit.instructure.com/197359
Reviewed-by: Marc Phillips <mphillips@instructure.com>
Tested-by: Jenkins
QA-Review: Marc Phillips <mphillips@instructure.com>
Product-Review: Oxana Jurosevic
fixes ADMIN-2722
Test plan
- Ensure Unsplash image searching is
enabled
- Search for a nonsense term or nsfw
term
- Ensure you get the text "No Results
found for {search term}"
Change-Id: I7147384b56a8b180498fbd6d5d406b77a5ebec6f
Reviewed-on: https://gerrit.instructure.com/197422
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Daniel Sasaki <dsasaki@instructure.com>
Product-Review: Lauren Williams <lcwilliams@instructure.com>
fixes ADMIN-2711
Test plan
- Set up a student who has two enrollments in different
courses
- In one course, submit an assignment as the student
and then mark that student's enrollment as inactive
- Make sure everything else for that assignment is
graded
- Check /api/v1/users/self/todo and ensure you don't
see the assignment in the list
- Ensure every other submission in
/api/v1/users/self/todo_items_count has been graded
and make sure you can't see a count for the submission
Change-Id: Id01333b990dbbef762b55ca2ba4f98382b0b2ad4
Reviewed-on: https://gerrit.instructure.com/197166
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
fixes CORE-2664 CORE-2663
Test Plan:
- record or drag and drop a video into the video
plugin modal
- in the video that shows up put your cursor on it
- notice the option pop up
- click options pop up
- change the size of the video
- click done
- notice the video resized
Change-Id: Ib17f58dbb639cd11307360527426a9f3b1eaf22f
Reviewed-on: https://gerrit.instructure.com/197048
Tested-by: Jenkins
Reviewed-by: Jeremy Neander <jneander@instructure.com>
QA-Review: Landon Gilbert-Bland <lbland@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
Landon Gilbert-Bland