when submitted comments for attempt 0 (the case where we have
no submissions) the attempt was reading as nil in the validation
and failing to create the comment.
Test Plan:
* as a teacher, create an assignment
* as a student in this assignment who has not yet submitted,
navigate to the Comments tab
* create a new comment on the assignment
* it should successfully create the comment
* comments for attempt 0 and attempt 1 should display
together
* on an assignment with one or more submissions, create a
comment
* it should successfully create the comment
fixes COMMS-2174
Change-Id: If216a541aebf7db2ea7b6942a02d194113cd8e41
Reviewed-on: https://gerrit.instructure.com/199377
Reviewed-by: Steven Burnett <sburnett@instructure.com>
QA-Review: Michelle Simmons <misimmons@instructure.com>
Tested-by: Jenkins
Product-Review: Ryan Norton <rnorton@instructure.com>
when composing a conversation the text on the left side gets
hidden after being wrapped over from the previous line.
this happened because the textarea box extended slightly past the
surrounding div.
Test Plan:
* navigate to the inbox
* click the Compose button to create a new conversation message
* type until just before you reach the right side of the message box
* if you continue typing from here the text should wrap without
cutting off the text or shifting the text to the left
* if you paste a large block of text that scrolls below the bottom
of the message box area, when you click out of the area and click
back in, the bottom of the text should not be cut off
fixes COMMS-2108
Change-Id: I24458c35692e6be77928ee9d89c7c9923a9f625f
Reviewed-on: https://gerrit.instructure.com/199351
Reviewed-by: Steven Burnett <sburnett@instructure.com>
Tested-by: Jenkins
QA-Review: Steven Burnett <sburnett@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
Closes: CORE-3117
Before this change:
* only “Site admins” (aka Instructure employees like CSMs or Engineers)
can turn on the rce_enhancements feature flag in beta
With this change:
* any school admin can turn on this feature flag in beta
Things not changed in this commit, but just to document:
* still, no one can turn this feature flag on in production
* that is because it is marked as `development` which means
`context.feature_enabled?` calls for the feature will always return
false in production
* and it also only went from `hidden` to `hidden_in_prod` which means
that even if it was not marked `development`, it will not be visible
to non-site-admin users in production
* when we are ready for people to turn it on in production, we will have
to make another commit to change this feature flag for that
Change-Id: Ibeb1a4decaa6e034d8eeeec2f95f6db6ace0a274
Reviewed-on: https://gerrit.instructure.com/199221
Product-Review: Laura Leavitt <lleavitt@instructure.com>
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Test Plan:
- Given a quiz in a locale with different number formatting
- Change the points of a question to '1234.5' in that locale
- See it accept and format points correctly on the question and the
header
Closes QO-442
Change-Id: I75c353716718377bb26c1088a4db58aaa7c8f721
Reviewed-on: https://gerrit.instructure.com/198543
Tested-by: Jenkins
Reviewed-by: Jonathan Holt <jholt@instructure.com>
QA-Review: David Tan <dtan@instructure.com>
Product-Review: Kevin Dougherty III <jdougherty@instructure.com>
- A variable named "submission" was actually a hash containing (among
other things) a submission and an assignment, so checking
submission.posted? was not okay
- Moreover, the submission that said submission-hash contained could
have been set to nil if the submission had not yet been posted (or, in
the pre-post-policies world, the assignment was muted). This wasn't an
issue before, but became one since with post policies we check
individual submissions.
fixes GRADE-2268
Test plan:
- Specs pass
- Enable post policies/new gradebook
- Have a course with assignment groups and a drop rule (at least one
"drop highest" or "drop lowest")
- Assign some grades
- Grade calculator should not cause an error
Change-Id: I3a94e7ee4808cc6f38f247b6ee9652ddf6e7f6d0
Reviewed-on: https://gerrit.instructure.com/199187
Tested-by: Jenkins
Reviewed-by: Keith Garner <kgarner@instructure.com>
QA-Review: Adrian Packel <apackel@instructure.com>
Product-Review: Keith Garner <kgarner@instructure.com>
so it's actually enabled with a 'true' value
Change-Id: Ib35669b69880dbf7059fee6eda49fdfc2aaa9314
Reviewed-on: https://gerrit.instructure.com/199344
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
Tested-by: Jenkins
fixes GRADE-2130
Test Plan:
- Create a course, teacher, and assignment with anonymous grading
- Make sure Canvas is configured to deliver mail
- Set teacher notifications to deliver immediately
- As a student, submit and resubmit to the assignment
- As admin, view the teacher's messages (as the teacher sees them):
- Go to /users/[teacherID]/messages
- Assignment Submitted notifications should be from "Anonymous User"
Change-Id: Ie63cbc95f000a1fc55b0d75f00e5e03a9d3da7e2
Reviewed-on: https://gerrit.instructure.com/198269
Tested-by: Jenkins
Reviewed-by: Gary Mei <gmei@instructure.com>
Reviewed-by: Adrian Packel <apackel@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: Keith Garner <kgarner@instructure.com>
also ensure we unshackle the db server automatically
Change-Id: I709c92b0568783fd0b77b5b0518a8bf8783a1d74
Reviewed-on: https://gerrit.instructure.com/199223
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
test plan:
- enable the dashboard card images feature
- choose a course card image for a course
- return to the course settings page
- the kebab menu button for the course should have
hover text that reads "Course image settings"
- the kebab menu button should also be read as
"Course image settings" by screenreaders including JAWS
fixes ADMIN-2739
Change-Id: I3b9c2e8515f712c3d67da49ab17071c2237afdb4
Reviewed-on: https://gerrit.instructure.com/198935
Tested-by: Jenkins
Reviewed-by: Carl Kibler <ckibler@instructure.com>
QA-Review: Daniel Sasaki <dsasaki@instructure.com>
Product-Review: Daniel Sasaki <dsasaki@instructure.com>
The current documentation mentions that a file upload API is
coming soon, while it is already there for quite a while.
closes GRADE-2269
closes GH-1473
Test Plan:
- Build documentation
- Check if the explanation for creating a submission makes more sense now
Change-Id: I468e09fbe30b346d9433ba1425f51d92763f9fc0
Reviewed-on: https://gerrit.instructure.com/199330
Reviewed-by: Derek Bender <djbender@instructure.com>
Tested-by: Jenkins
QA-Review: Spencer Olson <solson@instructure.com>
Product-Review: Spencer Olson <solson@instructure.com>
Change-Id: I3386a91fe814163823353c5a015a6030c96f5810
Reviewed-on: https://gerrit.instructure.com/199317
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
test plan:
* create a course with an active student
* change the course so the course begins in the future
and students are restricted to participating between
course dates
* create a new assignment
* the student should not receive a notification that
the assignment was created
closes #COMMS-2132
Change-Id: I594bdb5fb50ebae28c74a5b842dee3e70a148eab
Reviewed-on: https://gerrit.instructure.com/199327
Reviewed-by: Steven Burnett <sburnett@instructure.com>
QA-Review: Steven Burnett <sburnett@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
Tested-by: Jenkins
This caches/denormalizes the quiz_lti? information from assignments
onto submissions. This makes queries for missing/late Quizzes.Next
quizzes to be easier without having to join three tables. (Future
ticket coming to make this happen.)
closes GRADE-2231
test plan:
- Have a course with a student and a Quizzes.Next assignment and
another non-Q.N assignment. (You can fake the quizzes next assignment
via the rails console)
- On the rails console check the submission object for each
assignment. Confirm that the quizzes.next assignment has
cached_quiz_lti set to true and that the other assignment has it
set to false
- Create another assignment with on paper. Save.
- Switch it to a Quizzes.Next assignment.
- On the rails console check the submission object for each
assignment. Confirm that the new quizzes.next assignment has
cached_quiz_lti set to true
- For the new assignment, in the rails console, find the ContentTag
and .destroy it
- On the rails console check the submission object for each
assignment. Confirm that the new quizzes.next assignment has
cached_quiz_lti set to false
Change-Id: I4bfc1d3a282863dde9de9658b335b9a24b2341e5
Reviewed-on: https://gerrit.instructure.com/197811
QA-Review: James Butters <jbutters@instructure.com>
Tested-by: Jenkins
Reviewed-by: Derek Bender <djbender@instructure.com>
Reviewed-by: Adrian Packel <apackel@instructure.com>
Reviewed-by: James Williams <jamesw@instructure.com>
Product-Review: Keith Garner <kgarner@instructure.com>
to match current behavior
closes #CORE-3140
Change-Id: I8dd9c78c6374dffa9329ce334c1f0c6cff7f8190
Reviewed-on: https://gerrit.instructure.com/199201
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
closes GRADE-2241
Test Plan
- Open a rails console.
- Verify that without New Gradebook enabled, the setting does not
appear.
- Enable New Gradebook.
- Turn on the setting from the course's settings page.
- In the console, verify that this returns true:
`your_course.filter_speed_grader_by_student_group?`
- Turn off the setting from the course's settings page.
- In the console, verify that this returns false:
`your_course.filter_speed_grader_by_student_group?`
Change-Id: I526523ccc073ef66497efe4854ddd50f53a5a9eb
Reviewed-on: https://gerrit.instructure.com/198236
Reviewed-by: Adrian Packel <apackel@instructure.com>
Reviewed-by: Derek Bender <djbender@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: Jonathan Fenton <jfenton@instructure.com>
Tested-by: Jenkins
Fixes: UIDEV-279
Test plan:
- In Canvas, turn on the Underline All Links feature
- Go to the Courses nav tray, and confirm that
only one focus ring is now showing on the course
links:
https://www.screencast.com/t/QZTIMGLOW
- When the Underline All Links feature is ON, the
course links should be underlined.
Change-Id: Id90680d266400d998f559614bc938976adad35f0
Reviewed-on: https://gerrit.instructure.com/199024
Tested-by: Jenkins
Reviewed-by: Pam Hiett <phiett@instructure.com>
Product-Review: Pam Hiett <phiett@instructure.com>
QA-Review: Daniel Sasaki <dsasaki@instructure.com>
fixes COMMS-2165
Test Plan:
- ensure that in your account settings you
have self enrollment turned on the setting
is at the bottom of /accounts/self/authentication_providers
- go to http://localhost:3000/courses/1/users
- click the keebob menu on the top right
- click menu item called export pairing codes
- notice you get a csv that lists every student
- notice that non of the codes are in exponential format
- repeat several times
- notice no code gets in xponential format
- celebrate
Change-Id: Ie053fafeae3dbaa16d621839ed6b51bbe395d5b2
Reviewed-on: https://gerrit.instructure.com/199096
Tested-by: Jenkins
Reviewed-by: Landon Gilbert-Bland <lbland@instructure.com>
QA-Review: Steven Burnett <sburnett@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
fixes COMMS-2161
Before when we were updating a submission draft with new attachments the
view wouldn't update to display those changes. This was due to a bug
where we were returning null instead of the updated submission when
updating state in the view manager. This fixes that.
This is also fixing a bug where after submitting an assignment we would
see the "no submission" svg despite having just submitted. Before we
were required to reload the page to actually view the assignment and its
attachments. This was due to the apollo cache not getting updated
correctly, thus failing to re-render the view. We fixed this by adding
the submission attachments to the response from the createSubmission
mutation. By doing that we are now updating the cache appropriately and
things are just peachy.
TEST PLAN:
* Create a course and add a student to it
* Create an assignment with a file upload submission type
* Masquerade as the student
* Add and remove multiple files to the submission (this should work
totally fine)
* Submit the assignment and note that the submission should show a
preview for the files you submitted (or the no preview available message
svg)
* In Assignments 1 resubmit the assignment multiple times with different
files and in varying quantities.
* In Assignments 2 you should be able to navigate between your various
submission attempts and there should be no problems
Change-Id: I93a8e9804eaeffc87ee8510cc1841b6dc863fcb5
Reviewed-on: https://gerrit.instructure.com/198856
Reviewed-by: Landon Gilbert-Bland <lbland@instructure.com>
Tested-by: Jenkins
QA-Review: Michelle Simmons <misimmons@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
refs: UIDEV-277
TEST PLAN:
- set-up: "Canvas Planner" so need a user that has that as their
dashboard view
- set-up: create an "event" for said user so it shows on their
planner list ... click the event and a modal should trigger - the
title is now using Button vs Link
- within Planner, select the "Gradebook" icon at the top of the page ...
the Course names are now using Button vs Link
- within Planner, select the "Alert/Bell" icon at the top of the page ...
the Assignment names are now using Button vs Link
- within Planner, the list items on the main screen (see event that was
created in the earlier step) the Title is now using Button vs Link
- lastly, ensure titles underline when user feature is enabled
(note: the dashboard titles use onClick so will not underline)
Change-Id: I63e88e6afce1cf36fa4c09ebd5b99fe1a42a744c
Reviewed-on: https://gerrit.instructure.com/198316
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
Tested-by: Jenkins
QA-Review: Daniel Sasaki <dsasaki@instructure.com>
Product-Review: Pam Hiett <phiett@instructure.com>
refs: UIDEV-280
TEST PLAN:
- set-up: ensure "Moderated Grading" is allowed at the SiteAdmin level
- ensure "Moderated Grading" is turned on at the Account level for courses
- navigate to a course within that account, create an assignment or edit
an existing assignment that students have not yet submitted to
- within the assignment edit or creation step select the "Moderated
Grading" checkbox (set yourself as the "Grader that determines the
final grade)
- nest steps are to login as a couple of students for the course and
assignment that has been set-up for Moderated Grading
- next step is to login as a teacher or ta and grade the students
submissions
- lastly, log in as the admin/yourself - navigate to the assignment -
there should now be a "Moderate" button next to the "Published" and
"Edit" buttons... click it
- the students names should now be using Button variant="link" within
the Grade Summary table
Change-Id: Ia09c53ea9f3b9c295c67718f2c428c2f5d07af3c
Reviewed-on: https://gerrit.instructure.com/198497
Tested-by: Jenkins
QA-Review: Daniel Sasaki <dsasaki@instructure.com>
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
Update the react dependency to 16.8 since we're starting to use react
hooks, which requires that version at minimum.
test plan:
- linting still works
- intentionally create a violation of rules-of-hooks. Linting should
find and report the error.
Change-Id: I0baccd64397b31118b96eb390462acf56daeca96
Reviewed-on: https://gerrit.instructure.com/199053
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins
CLOSES: DOC-1081
Also cleaned up formatting, capitalization, and
section order in change log archive page
Test plan:
- rake doc:api
- in API change log page, note entry for 2019-07-13
- in breaking changes page, note new entry
- jenkins is happy
Change-Id: I19d852d003c4a1f18bba1509f5105db782e3339f
Reviewed-on: https://gerrit.instructure.com/199090
Tested-by: Jenkins
QA-Review: Erin Hallmark <erin@instructure.com>
Product-Review: Erin Hallmark <erin@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
refs: UIDEV-276
TEST PLAN:
- within the Admin subNav select "Permissions"
- the table headers and the Permissions column links should not
be underlined by default
NOTE: even if the user turns on the underline links feature these
instances will not underline as they do not have an href but rather
an onClick
Change-Id: I09cf87a66e120e487a44c67bbb737ea7ee8f3d44
Reviewed-on: https://gerrit.instructure.com/198193
Tested-by: Jenkins
QA-Review: Daniel Sasaki <dsasaki@instructure.com>
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
fixes: UIDEV-268
Test plan:
- The heading link with the student's name should
no longer be underlined unless the underline all links
feature is ON, and the font-size should
now inherit from our `large` Button variant:
https://www.screencast.com/t/3gtqOp99
(Confirm that the link still produces ellipsis when
the name is long)
- The link that wraps each Progress component should
no longer cause underlines unless the underline all
links feature is ON. The Progress component should
now show the focus ring when the link is focused:
https://www.screencast.com/t/3WRZJdpR
Change-Id: I85fdfd01b532a7441f35446750b960e57751540e
Reviewed-on: https://gerrit.instructure.com/198053
Tested-by: Jenkins
QA-Review: Daniel Sasaki <dsasaki@instructure.com>
Reviewed-by: Pam Hiett <phiett@instructure.com>
Product-Review: Pam Hiett <phiett@instructure.com>
Fixes: UIDEV-274
Test plan:
- With New Gradebook enabled, click on an assignment
in the main table, then click the Expand Tray icon.
- Confirm that the any links appearing in the tray are
no longer underlined by default:
https://www.screencast.com/t/qPUwxM2be
- Confirm all links still work.
Change-Id: I5de3627034a5fff9dcb6b16e23b1ff0ffe0df705
Reviewed-on: https://gerrit.instructure.com/198302
Tested-by: Jenkins
QA-Review: Daniel Sasaki <dsasaki@instructure.com>
Reviewed-by: Pam Hiett <phiett@instructure.com>
Product-Review: Pam Hiett <phiett@instructure.com>
Fixes: UIDEV-267
Assignments 2 must be enabled at the account level to
review this commit. Once it's enabled, you should see
a button on each assignment to convert it to
Assignments 2
Test plan:
As a teacher/admin, links should no longer be underlined:
- On the student info Tray: https://www.screencast.com/t/SBrfYr3QqN6J
- On the student info Table: https://www.screencast.com/t/zNb3B4CCwAPW
As a student, links should no longer be underlined:
- On the list of modules/assignment groups:
https://www.screencast.com/t/tAGasqSEbO
- On the late policy popover trigger:
https://www.screencast.com/t/NuqP5tKrR3BK
- On the comments section, if you attach a file
to the comment (attach the file via SpeedGrader
as a teacher/admin):
https://www.screencast.com/t/kuHZUjYV
Change-Id: I9b5cf91b0e8f9a72e239ad5378fe2539d979c628
Reviewed-on: https://gerrit.instructure.com/198140
Tested-by: Jenkins
Reviewed-by: Steven Burnett <sburnett@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
QA-Review: Daniel Sasaki <dsasaki@instructure.com>
…instead, just use the default config for the rest of the repo
Test plan:
* cd packages/canvas-planner
* yarn eslint src/components/BadgeList/index.js
* you should not see an error about not being able to find flowtype
Change-Id: I48c4ab3ac20a60352c20c489addb4d4b4a32e83a
Reviewed-on: https://gerrit.instructure.com/199060
Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com>
QA-Review: Jon Willesen <jonw+gerrit@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins
Remove ivars for better flexibility and rework specs for clarity and
maintainability. This work was extracted out of a forthcoming patchset.
Refs: GRADE-2245
Test Plan:
- specs pass
Change-Id: Ide53a2473f2146c1c2410efedb58287e140b0486
Reviewed-on: https://gerrit.instructure.com/198927
Tested-by: Jenkins
QA-Review: Derek Bender <djbender@instructure.com>
Product-Review: Derek Bender <djbender@instructure.com>
Reviewed-by: Adrian Packel <apackel@instructure.com>
Reviewed-by: Keith Garner <kgarner@instructure.com>
We need to do some tweaking and don't want these
to hit production and have developers start
using them as they are currently not right.
closes PLAT-4611
Test Plan:
- generating the api docs should not show the extensions
for the scores and results controllers
Change-Id: I4f401480bee62f70f5a24397513d019d4a0fea79
Reviewed-on: https://gerrit.instructure.com/198953
Tested-by: Jenkins
Reviewed-by: Clint Furse <cfurse@instructure.com>
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
Product-Review: Jesse Poulos <jpoulos@instructure.com>
refs PLAT-4493
Test Plan:
-create a developer key and validate the public jwk url field
is present
-save developer key
-edit developer key and validate public jwk url field is present
-save edit and validate edits were saved to developer key
Change-Id: I9019d116ad9995931757439f4c3d63b3d67a3a5f
Reviewed-on: https://gerrit.instructure.com/197713
Tested-by: Jenkins
Reviewed-by: Marc Phillips <mphillips@instructure.com>
QA-Review: Marc Phillips <mphillips@instructure.com>
Product-Review: Jesse Poulos <jpoulos@instructure.com>
James Williams