fixes LS-2814
flag = none
Test plan:
- Create a k5 course and set it to public visibility
- Open the course without logging in
- Expect to see the course content
Change-Id: Icd05f36e9dd476c742520e41ff758969c0ea6449
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277481
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Jackson Howe <jackson.howe@instructure.com>
This moves the inst_access gem to the public repo and references
the now published inst_access gem instead.
Github:
https://github.com/instructure/inst_access
Rubygems.org:
https://rubygems.org/gems/inst_access
Test Plan:
- Specs pass
flag = none
Change-Id: I6002b118723e5a329202085a6c649a857e34d0e3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277527
Reviewed-by: Michael Ziwisky <mziwisky@instructure.com>
QA-Review: Michael Ziwisky <mziwisky@instructure.com>
Product-Review: Michael Ziwisky <mziwisky@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
flag=none
closes VICE-2214
Test Plan:
- see ticket for designs
- create and publish a discussion
> should see "All Sections" under topic title on landing page
> on mouse over tool tip should render
Change-Id: I1477c016eaf1815edb8e8b663f3929524e069179
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276741
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Caleb Guanzon <cguanzon@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
refs VICE-1995
flag=react_discussions_post
Test Plan:
- turn discussion redesign ff on
- create a discussion with unlock date in the future
- reply to the discussion topic
- enter student view
> replies should be hidden
Change-Id: I347e5c5260507b1b2280b085e98b9c747745cb91
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277460
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Caleb Guanzon <cguanzon@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
closes VICE-2220
flag=discussions_inline_grading
Test Plan:
> should be able to turn on feature flag
Change-Id: Ib1f7b2677004f4921f7fa4848eeb093b859fb7cd
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277539
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Caleb Guanzon <cguanzon@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
refs MAT-508
flag=none
Test Plan:
- Follow the "steps to reproduce" on the ticket
> Verify the issue is no longer reproducable
Change-Id: I55c1a155477629e6eb5d1b2b151efd839e7f88c8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277506
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jon Scheiding <jon.scheiding@instructure.com>
QA-Review: Jon Scheiding <jon.scheiding@instructure.com>
Product-Review: Weston Dransfield <wdransfield@instructure.com>
Fixes a regression that prevented observers from seeing the 'coming
up' list on the classic dashboard.
fixes LS-2812
flag = none
Test plan:
- Create an observer linked to a student in a classic course with
(at least) 1 upcoming assignment
- Visit the classic dashboard as the observer
- Expect to see the upcoming assignment under 'coming up' sidebar
- Visit the classic dashboard as the student
- Expect to see the assignment in the same place
- Visit the k5 dashboard as an observer of a k5 student and switch to
the schedule tab
- Expect to see the student's assignments in the planner
Change-Id: If03b864a558727ba1185c7f126677496adbe8940
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277401
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Nate Armstrong <narmstrong@instructure.com>
QA-Review: Nate Armstrong <narmstrong@instructure.com>
Product-Review: Jackson Howe <jackson.howe@instructure.com>
alert slack channel canvas_builds-noisy on node
failure and do not fail build for rspecq node
failure.
flag = none
Test Plan:
-Jenkins passes normally
-When queue is depleted and node acquired late
-Node will release before any steps are ran
-An RSpecQ node throws an exception during steps
such as can't pull image.
-The stage will get marked as UNSTABLE, following
stages will get skipped.
-Overall build result not affected by this failing
node.
-If tearDownNode stage fails, overall build will be affected.
-RSpecQ Reporter failures do affect overall build result
Change-Id: Iccbb66cad0a988a26bf17c8332a20d8d7d55ee5b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276927
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
refs FOO-1786
flag=none
No code should invoke these helpers anymore
so let's remove them before any more start
TEST PLAN:
1) specs pass
Change-Id: Ia9994424e804426afb90d3bc82e00e6916b0634e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277296
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Ethan Vizitei <evizitei@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
[skip-stages=Flakey]
all manual, and this concludes this cop for the entire codebase, so
change it to error severity to enforce it
Change-Id: I770c62bbd93ccd4f0b11252fd0cf61158f1ee7cb
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277357
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
refs VICE-1995
flag=react_discussions_post
Test Plan:
- discussions redesign ff on
- create a discussion with an availability date in the future
- enter student view
> should see alert saying topic is locked (see ticket for designs)
Change-Id: I99e367822fb832b3678e2d513a505ade192e9ce2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/275340
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
refs VICE-1995
flag=react_discussions_post
Test Plan:
- discussions redesign ff on
- create a discussion with an availability date in the future
- enter student view
> should only see topic title (see ticket for designs)
Change-Id: I3daf2a553633d8761ef6c4bec4aedf773f03922f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/275336
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
refs VICE-1995
flag=react_discussions_post
Test Plan:
- turn discussions redesign ff on
- open network inspector
- go to a discussion
- open graphql response for the discussion
> should see availableForUser on the discussion
Change-Id: Iaa3181307f1aa2d398c4a2c5421b4f188f470b23
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277134
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
refs VICE-1995
flag=react_discussions_post
Test Plan:
- turn discussions redesign ff on
- create a discussion with the available date in the future
- open network inspector and check the graphql respose
> lockedForUser on the discussion should be true
> verify the same with a graded discussion
- set the due date to be in the past
> lockedForUser should be false for graded and ungraded
Change-Id: I99e807530f037b7edff19b7cd459cd19e9f57a65
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276410
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
closes VICE-2218
flag=none
Test Plan:
- go the the discussions landing page
- open the settings modal
- should see:
> "Edit and delete their own replies"
> "Manually mark replies as read"
Change-Id: I07488d779ce906c160103127cdc464dcd33019b4
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277143
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
[skip-stages=Flakey]
all manual
the fixes are a little scattered, since the same method doesn't work
everywhere depending on requirements. mostly I changed to `let`, but
some required `stub_const`. For `let`, I eventually settled on
avoiding a dedicated `let` for the class if it's only used one, and
it's a trivial class just to include the module. otherwise there's
a separate `let` for the class, and if there's only one it's named
`klass` instead of something contrived.
Change-Id: I84734c963d4789be3ec3cd852cca623e7c2a08df
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277285
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
test plan
- have a user that has multiple logins from multiple accounts
- the link to the account should be to the user on other accounts
- the link to the account should be the same as before for same account
Change-Id: If811980f82a7a0da8b5241bc34a6b55034e77e53
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/275978
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Cody Cutrer