Because of concerns with a potential race condition on using just the
incomplete peer review count we've also added the total count of
assigned reviews to the cache key. These two additions still allow us
to take advantage of caching yielding a 90% performance improvement
against a hot cache locally. These numbers may not translate perfectly
to production given that this page may have frequent cache misses. This
is something we should probably take a look at in the logs once this is
in beta/production.
fixes CNVS-7523
Test Plan:
- As an instructor build a class with at least 2 students
- Add an assignment to the class with peer review enabled
- Assign peer reviewers manually
- These should start marked as incomplete with a yellow icon
- As the first student navigate to the assignment and submit it
- As the second student navigate to the assignment
- In the sidebar this student should see that they have an incomplete
review, indicated by the yellow icon
- Complete the review and view the assignment again
- The review should indicate that it is complete with a green
checkmark
- As the teacher view the peer assessments page
- The review you previously completed should show as completed using
the same green checkmark.
Change-Id: I8b71fd8f25c71b8031ab74b57d280c98add2c14e
Reviewed-on: https://gerrit.instructure.com/34420
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Mike Nomitch <mnomitch@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Matt Fairbourn <mfairbourn@instructure.com>
fixes #CNVS-2309
Problem:
Overriding a due date to be earlier than the default was having no
effect because the default date was getting lumped in with the overrides
and treated the same way when deciding which to use.
Solution:
If there are applicable overrides, don't take the default into account.
Notes:
The issue was happening as a result of the way the VariedDueDate class
indiscriminately lumped due dates together and returned the last one.
Part of the solution was removing the VariedDueDate class and instead
relying on the override methods on an Assignment. This was done not
only to fix the bug at hand but also to move toward a more consistent
interface for handling varied due dates.
Change-Id: If9d24725a19b134d5d92d3a5c08d6794f466fa9c
Reviewed-on: https://gerrit.instructure.com/16406
QA-Review: Myller de Araujo <myller@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
test plan:
REFERENCE:
* "Main Assignments Page": "localhost:3000/assignments", or click on
"Assignments" in the menu bar near the top of the page.
* "Right Side Bar": Go to the Main Assignments Page, it's on your
right.
* "Course Assignments Page": Hover over "Courses" in the menu bar
* near the top of the page, click on the course you set up. Once
that page loads, click on "Assignments" tab on the left hand side.
STEPS:
* https://gist.github.com/f12b3694016f3dcc979e
Change-Id: I9a5884ec1057f196ba5b731a2978c874141bec5b
Reviewed-on: https://gerrit.instructure.com/15006
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Amber Taniuchi <amber@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Tyler Pickett