fixes CNVS-27951
also document which methods are not in the
public interface to be clear
which methods are ok for other modules to call
on the service loader
TEST PLAN:
1) go to some RCE use case with the service
enabled
2) make sure only 1 "get_module" call happens
in the network panel
Change-Id: I064436e2a9ea7aa1c340848a2bf3e91dfcd23bb5
Reviewed-on: https://gerrit.instructure.com/74292
Tested-by: Jenkins
Reviewed-by: Jacob Fugal <jacob@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
closes CNVS-27647
Start RCE service integration with granular
feature flags for high risk areas
TEST PLAN:
1) regression test submitting an assignment with a text entry
type
2) with RCE service in the mix and the RICH_CONTENT_HIGH_RISK_ENABLED
flag on (the high risk flag), test submitting the assignment
3) note there will be no sidebar here. We expect there to be no
regressions using the remote editor.
Change-Id: I606a6c4004eea9656b6f4eaf3d883024801f177b
Reviewed-on: https://gerrit.instructure.com/73887
Tested-by: Jenkins
Reviewed-by: Jacob Fugal <jacob@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
fixes PLAT-1369
When the file upload process is initiated, the file name that is
submitted in the initial request is being overwritten with an empty
string in the json response.
Test plan:
* Take the first step in the file upload process documented in the api
docs
* Ensure that in the json response data the
['upload_params']['Filename']
field contains the same file name that was sent in the request
Change-Id: I9335c5c6aecbf85f9900a57323a93f17b9ab0960
Reviewed-on: https://gerrit.instructure.com/74279
Reviewed-by: Brad Horrocks <bhorrocks@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Tested-by: Jenkins
Product-Review: Andrew Butterfield <abutterfield@instructure.com>
fix combox reading with jaws on the message compose "to" field
fixes CNVS-26494
Test Plan:
- As any user of anything migrate to the inbox
- Compose a message
- With all screenreaders navigate to the "To" field of the
compose message. Notice it gives correct instructions
Change-Id: I5e6da7086550c68dca2fd406d853ac6f767b7fc9
Reviewed-on: https://gerrit.instructure.com/74205
Tested-by: Jenkins
Reviewed-by: Matt Berns <mberns@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
test plan:
* as a teacher, create a scheduler appointment group
* as a student, sign up for one of the slots
* remove the student from the course
* the slot should be free
closes #CNVS-27376
Change-Id: I098a8c8ad7b534d86a4f7be390e49d203ccbd4e1
Reviewed-on: https://gerrit.instructure.com/73483
QA-Review: Heath Hales <hhales@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins
Product-Review: James Williams <jamesw@instructure.com>
fixes CNVS-27745
test plan
- in conversations inbox, toggle starred status on a conversation
via the cog menu
- ensure that the title of the conversation's star icon on the
left sidebar reads "Unstar" or "Star" as appropriate. read the
title either with a screenreader or by hovering the mouse over
the icon
Change-Id: I4d2f2d42ff5b0d9de003e8fb3f5036a64d337504
Reviewed-on: https://gerrit.instructure.com/74066
Tested-by: Jenkins
Reviewed-by: Steven Burnett <sburnett@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Joel Hough <joel@instructure.com>
not used
refs #CNVS-27773
Change-Id: I8f41200549af10061aa91984f25df11dd4d5d7c8
Reviewed-on: https://gerrit.instructure.com/74392
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
test plan:
1. have a course with a quiz containing two or more questions
2. copy this course
3. delete one question in the source course's quiz
4. delete the entire quiz from the destination course
5. re-import the source course into the destination
6. confirm the quiz question deleted in step 3 isn't present
in the destination course's quiz
fixes CNVS-27725
Change-Id: Iaa04fce9fa2471a98223fe30a412d0ce1cfe0074
Reviewed-on: https://gerrit.instructure.com/74414
Reviewed-by: Ryan Taylor <rtaylor@instructure.com>
Reviewed-by: James Williams <jamesw@instructure.com>
Tested-by: Jenkins
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
This makes it so using async test features of qUnit works within
the JSX specs.
Change-Id: I602468d7ef70091e603f02bc9558390b94c0bfee
Reviewed-on: https://gerrit.instructure.com/74527
Tested-by: Jenkins
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Clay Diffrient <cdiffrient@instructure.com>
fixes CNVS-28027
TEST PLAN:
1) should be able to enable this flag on prod
Change-Id: Ie03d937d225cc77fcc08ae20c63289f95e45eb89
Reviewed-on: https://gerrit.instructure.com/74457
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins
Product-Review: Ethan Vizitei <evizitei@instructure.com>
QA-Review: Ethan Vizitei <evizitei@instructure.com>
Change-Id: I939e376c4685ed2a0724776bcff0ca4cfc003abe
Reviewed-on: https://gerrit.instructure.com/74498
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
fixes CNVS-12692
test plan
- create a course with more than one instructor
- as a student, use the help menu to send a message to the course
instructor
- as one of the instructors, view the message that was sent
- ensure that all course instructors are listed in the recipient
list
Change-Id: I6281be19cdcedeeb0d885020b8d6a976ce8a940a
Reviewed-on: https://gerrit.instructure.com/72331
Reviewed-by: Steven Burnett <sburnett@instructure.com>
Tested-by: Jenkins
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Joel Hough <joel@instructure.com>
test plan:
* create a course with a group
* add a student to the course and group
* soft-conclude the course by term dates and
check the "Restrict students from viewing after end date"
setting
* the group should not be shown in the list of
"Previous Groups" for the student
(at "/groups")
closes #CNVS-27827
Change-Id: I3051a915af99e10e53ca58caaefcab196b39c9de
Reviewed-on: https://gerrit.instructure.com/74394
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
test plan:
* try Rails.cache.instance_variable_get(:@data).keys, or any other way
you can think of to try and get all keys (or flushdb or other scary
stuff) from redis
* it should raise an error
* Shackles.activate!(:deploy)
* try again
* it should work
Change-Id: I57772df3851fd14b6a46a56c9cd8ef6ddce015e3
Reviewed-on: https://gerrit.instructure.com/73940
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
makes it non-chainable for more scopes
test plan:
* use /api/v1/accounts/:id/users?search_term=<the id of a user>&include[]=last_login
* it should not 500, and return valid info for last_login
Change-Id: I7a4bf9dbc6bcb4e5be15a86d883467036b9de266
Reviewed-on: https://gerrit.instructure.com/74295
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
- allows CYOE listener to avoid api call to reconcile
students/assignments/grades
refs CYOE-80
Test plan:
1. Set up live_events in Canvas
2. Monitor the live_events stream using
`script/tail_kinesis`
3. Create and grade on a student assignment
4. Verify that there are user_id and assignment_id
fields on the `grade_change`, `submission_created`,
and `submission_updated` events
Change-Id: I0c24d6773e5f635b0f6a00cd18865600c498a98d
Reviewed-on: https://gerrit.instructure.com/74155
Reviewed-by: Michael Brewer-Davis <mbd@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>
QA-Review: Dan Minkevitch <dan@instructure.com>
Tested-by: Jenkins
Reviewed-by: Matt Smith <msmith@instructure.com>
Test Plan:
-Specs should pass
-Code review
Change-Id: Ia915a74402259811dd7f3d1ad80c130e2e4efd33
Reviewed-on: https://gerrit.instructure.com/74483
Tested-by: Jenkins
Reviewed-by: Pedro Fajardo <pfajardo@instructure.com>
Product-Review: Matt Fairbourn <mfairbourn@instructure.com>
QA-Review: Matt Fairbourn <mfairbourn@instructure.com>
closes CNVS-27639
Start RCE service integration with granular
feature flags for sidebar areas
TEST PLAN:
1) regression test creating a calendar event
with more options (should not break)
2) with RCE service in the mix and the RICH_CONTENT_SIDEBAR_ENABLED
flag on (the medium risk flag), side bar should show replaced
by dummy sidebar from RCE service
3) note that we do not expect the sidebar to be functional yet
with the service, this is just making sure we can flip the
switch, and didn't break calendar in the process
Change-Id: I7b07ed1522312445ed0f245d794995755341dcf7
Reviewed-on: https://gerrit.instructure.com/73643
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
test plan:
* use the course people page to create a new user as an
observer in a course
* they should recieve an invitation
closes #CNVS-26611
Change-Id: I3f919a9b9907a57efa03d140f789359d0d63b92c
Reviewed-on: https://gerrit.instructure.com/74401
Tested-by: Jenkins
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Allison Weiss <allison@instructure.com>
apparently we like to change param names halfway through the stack
test plan:
* enable pv4
* do an api request for pv4 data, passing start_time and end_time
* it should work
Change-Id: I3fdc7c9105af5f45a2380f15981be03e91caed55
Reviewed-on: https://gerrit.instructure.com/74413
Tested-by: Jenkins
Reviewed-by: Jacob Fugal <jacob@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
closes: CNVS-27362
Test Plan:
- CSS should compile successfully
- No wide breakpoints should be found anywhere in code
- No UI changes
Change-Id: I8c96cce76819b171a332cf76c366c1250791d9e4
Reviewed-on: https://gerrit.instructure.com/74054
Tested-by: Jenkins
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Fixes: CNVS-27536
Test plan:
- With the new UI enabled, log in as any kind of
user and click the Profile link on the main
nav.
- The tray header should now look like this:
http://screencast.com/t/uSdNt9w276Zc
- The tray header should output the user's
display name. If there is no display name, it
will default to full name. If there is no full
name, the email address will be used.
- Long names/addresses will be handled with
ellipses.
- If the user has no avatar, the default avatar
image will be used, same as the primary nav.
Change-Id: I272a3bdf5884e2bcaaab7491d369a615eb0a655b
Reviewed-on: https://gerrit.instructure.com/73685
Tested-by: Jenkins
Reviewed-by: Colleen Palmer <colleen@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
QA-Review: Pedro Fajardo <pfajardo@instructure.com>
refs: CNVS-27362
Test Plan:
- Go to styleguide and "Item Groups"
- The size on the item group title is now 40% from 992px up
Screenshot - http://cl.ly/2k0H3X0C0q3k
Change-Id: Ic5179d027de52aebd90e7708cc47d97eb7076301
Reviewed-on: https://gerrit.instructure.com/74025
Tested-by: Jenkins
Reviewed-by: Pam Hiett <phiett@instructure.com>
Product-Review: Pam Hiett <phiett@instructure.com>
QA-Review: Gentry Beckmann <gbeckmann@instructure.com>
Change-Id: I59159f879a85ff2635aa15026a9e6672bccca29a
Reviewed-on: https://gerrit.instructure.com/74433
Reviewed-by: Michael Hargiss <mhargiss@instructure.com>
Product-Review: Michael Hargiss <mhargiss@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Tested-by: Michael Hargiss <mhargiss@instructure.com>
closes CNVS-27642
Start RCE service integration with granular
feature flags for sidebar areas
TEST PLAN:
1) regression test creating/editing a wiki page
2) with RCE service in the mix and the RICH_CONTENT_SIDEBAR_ENABLED
flag on (the medium risk flag), side bar should show replaced
by dummy sidebar from RCE service
3) note that we do not expect the sidebar to be functional yet
with the service, this is just making sure we can flip the
switch, and didn't break wiki in the process
Change-Id: I16810bf4f3941fd762f7d36f37cc25ab6e521b23
Reviewed-on: https://gerrit.instructure.com/73796
Tested-by: Jenkins
Reviewed-by: Jacob Fugal <jacob@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
This makes it so that multi-line define statements work with
the qunit dep loader for jsx.
Prior to this commit
```
define([
'jsx/account_course_user_search/reducers/rootReducer'
], (reducer) => {
```
is not properly transformed, however
```
define(['jsx/account_course_user_search/reducers/rootReducer'], (reducer) => {
```
does get transformed properly.
Effectively, this replaces the `.` regex operator which doesn't transend
newlines with `[\s\S]` which effectively does the same thing
including newlines as well though.
Change-Id: Ife96438695997050fbdf866b7c319fa1b075875a
Reviewed-on: https://gerrit.instructure.com/74419
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
Tested-by: Jenkins
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Clay Diffrient <cdiffrient@instructure.com>
Refs: CNVS-26581
test plan:
- as an admin using the new and then old ui
- navigate to the admin link from the left-hand nav
- click into "users"
- now click the "add a new user" button from the right-hand side bar
- the modal that launches is now using the enlarge hint-text
example in new ui: http://screencast.com/t/ZVpJgTyABLK
example in old ui: http://screencast.com/t/hMQzCmewi
note: within this commit the input-hint class was removed in favor
of using the _forms.scss class hint-text
Change-Id: I817b2750969bfefbfa148232ccaf9e389125dc2f
Reviewed-on: https://gerrit.instructure.com/73269
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
Tested-by: Jenkins
QA-Review: Gentry Beckmann <gbeckmann@instructure.com>
closes #CNVS-27117
Change-Id: I0770bba397102a3c8fcc5ac114bdeae5cc60c1c8
Reviewed-on: https://gerrit.instructure.com/74407
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
test plan:
* create a discussion topic for a course
* reply to the topic as a student
* delete the topic
* should be able to restore the discussion topic
(to an active state) using the "undelete" endpoint
e.g. /courses/:id/undelete/discussion_topic_(:topic_id)
closes #CNVS-27924
Change-Id: I146930c6e8cc55c93698cd4df72471247e895642
Reviewed-on: https://gerrit.instructure.com/74325
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
when a teacher excuses an assignment for a student
in the gradebook (using EX) and the student deselects
the box "Calculate based only on graded assignments"
on the courses grades page, the score for the excused
assignment will no longer be considered.
closes CNVS-27356
test plan:
1. from within the gradebook give a student a
grade of excused
2. navigate to the student grade page and uncheck
the box "Calculate based only on graded assignments"
3. observe the total score does not include the excused
submission (previously, it would treat the excused
submission as a 0)
Change-Id: I7a0c0fc2a96e2c81c57983c9fd9943b3e030df3b
Reviewed-on: https://gerrit.instructure.com/74282
Tested-by: Jenkins
Reviewed-by: Cameron Matheson <cameron@instructure.com>
QA-Review: KC Naegle <knaegle@instructure.com>
Product-Review: Christi Wruck
change depracted component.getDOMNode() syntax to React.findDOMNode
test plan:
- navigate to a user's Files page
- tab to the +Folder button and press Enter
- enter a name for the new folder and press Enter
- keyboard focus should now be on the newly created folder
fixes CNVS-26562
Change-Id: Id2e7547b9f3b3ff78b21c4d2e7780e9449bf2db5
Reviewed-on: https://gerrit.instructure.com/74067
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
refs: CNVS-27362
Test Plan:
- Go to an assignment that's been submitted > Submission Details
- Details sidebar on right should remain the same width from 992px and up
Screenshot - http://cl.ly/1o3R06433W1F
Change-Id: If002bc7f14da3e4b063a1dd88eda257e13befe15
Reviewed-on: https://gerrit.instructure.com/73995
Tested-by: Jenkins
Reviewed-by: Pam Hiett <phiett@instructure.com>
Product-Review: Pam Hiett <phiett@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
refs CNVS-26643
test plan
- run migrations
- new report should be enabled
Change-Id: Id36a8a61200239cbaf1fb9c1b7301abb7268eafe
Reviewed-on: https://gerrit.instructure.com/74287
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Error was introduced as an alias for ExitException in 2.0; ExitException
was removed in 2.3
Change-Id: I872456ceee1d79b2ac827939ebf2b0fdbb5f5e69
Reviewed-on: https://gerrit.instructure.com/74343
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
fixes CNVS-27986
test plan:
- Create a quiz in Canvas
- Check the "Users can only participate in the course between these dates" box in the course settings
- As a student, attempt to take the quiz
- Ensure that student is able to take the quiz
Change-Id: I9b00d56c1657eb88cc996377f40ff6b1aec5dcee
Reviewed-on: https://gerrit.instructure.com/74381
Reviewed-by: Cody Cutrer <cody@instructure.com>
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
QA-Review: Pedro Fajardo <pfajardo@instructure.com>
Product-Review: Bryan Petty <bpetty@instructure.com>
Tested-by: Jenkins
The previous icon for displaying whether an assignment in the
assignments list view is set to post to SIS wasn't accessible for
colorblind people in that it changed color but not shape. This has now
been replaced with a slightly different icon now so that the shape as
well as color change when it is toggled.
Fixes: SIS-1740
Test plan:
Look at the list assignments view.
Toggle the "post to sis" button for some assignments.
The new icon is filled in with a clear "S"; the old icon is not
filled in with a solid "S". See the Jira ticket for more info.
Confirm all other accessible cases work as expected
Change-Id: Iff4f9bac77081959fb8c8cfb55181f7b3c9ce46a
Reviewed-on: https://gerrit.instructure.com/72597
Reviewed-by: Jayce Higgins <jhiggins@instructure.com>
Tested-by: Jenkins
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Ken Romney <kromney@instructure.com>
Ethan Vizitei