in order to not have to support buttons with .ui-button AND
.button AND .btn classes this simplifies and and makes our
codebase more consistent by deprecating the .button class
with .btn
Change-Id: I4802d785a47b36aa477f302e6ac8c87715db8a62
Reviewed-on: https://gerrit.instructure.com/15194
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
test plan:
* do something that causes a page error
* verify that it looks like this:
http://cl.ly/0t3E2V2H263F3f2g1342
Change-Id: I943ae98f65d14f50b98fe4ad673f6d0aabdac20d
Reviewed-on: https://gerrit.instructure.com/10477
Tested-by: Jenkins <jenkins@instructure.com>
Tested-by: Joe Tanner <joe@instructure.com>
Reviewed-by: Joe Tanner <joe@instructure.com>
javascript-is-required.html made it difficult to autocomplete
public/javascripts. it was unpleasant.
test plan:
* turn off javascript;
* load canvas;
* verify that enable-javascript.html properly loads.
Change-Id: I94997f749c22d1000b7e314cbf1f255a11c7ae80
Reviewed-on: https://gerrit.instructure.com/8751
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Reviewed-by: Ryan Florence <ryanf@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
refs #4487
This consolidates our ErrorReport class with our ErrorLogging mechanism,
it's all in ErrorReport now and you call ErrorReport.log_error or
ErrorReport.log_exception to both create an ErrorReport object, and call
the hooks similar to what ErrorLogging did so that plugins for other
error handling mechanisms can be injected.
ErrorReport has a category field now, similar to how ErrorLogging used
to take a type. the /error_reports UI can filter by category.
The plugin interface was designed with Hoptoad integration in mind, but
it should be pretty general.
Change-Id: I59f7a0d44cf4b6215ad13ff92d30e1d1af607b74
Reviewed-on: https://gerrit.instructure.com/3577
Reviewed-by: Brian Palmer <brianp@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
did this because it was a waste to send it to
every single page view.
plus I hated seeing it in the firebug and web
inspector
fixes: #3874
Change-Id: I3e25cb78cddf9f8f897c81014bb07ca77ccfc361
Reviewed-on: https://gerrit.instructure.com/2363
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>