auto-corrected, with post-review looking for cases where an unqualified
column would now be (incorrectly) qualified (only one found)
Change-Id: I62ef6d40ce9e7bc062db261d9c6fb9383ecd102e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/278432
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
Migration-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
all manual
note that for any methods moved/re-indented, I made no other changes
(except possibly a remove of a `self.` on a method call to call another
now-private method) for ease of review
Change-Id: I0cca6644264a0b46a45a1a5c99021c9deb64fca0
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277532
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
fixes FOO-1203
flag=none
test plan:
- account course and user search should still work
- searching for "9223372036854775808" should not error
Change-Id: I7bcc331d7fd6a77f00e0e326f7ef85bc1892f87b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/252812
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Charley Kline <ckline@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
closes USERS-388
flag = none
test plan:
* /api/v1/accounts/50/users?enrollment_type=student should still work properly
Change-Id: I990f6abbeb1777d48313c7e203b1f02f0fc82e07
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/229621
QA-Review: August Thornton <august@instructure.com>
Product-Review: August Thornton <august@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: James Williams <jamesw@instructure.com>
adding a new parameter so we don't break any existing
behavior
TEST PLAN:
- create a course with 2 student enrollments
- create a group and enroll both students in the group
- deactivate one of the student enrollments
- make a GET request to
/api/v1/groups/:group_id/users?exclude_inactive=true
- see that the inactive student is not returned in the result
fixes KNO-18
flag=none
Change-Id: I6d424607b2a33de52aa6e4303874905dc1439d51
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/221142
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Matthew Lemon <mlemon@instructure.com>
QA-Review: Steven Burnett <sburnett@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
Fixes USERS-70
flag=none
The scopes in user_search didn't bring in all the
right columns out of the users table in order to
be able to properly include the last login info
from the corresponding pseudonyms. As a result, when
on the account people page, one would both have an
active search AND sort by the last_login field, the
last_login column would be nil, and all that data
would vanish out of the UI.
So we've got to explicitly bring in all the columns
(via users.*) for it to work. I also added a test in
case someone breaks this later... it's awfully subtle.
Test plan:
* Rerun the steps to reproduce in the ticket
* When limiting the users list via a search, you
should be able to sort on the "last login" field
and have that column not disappear and also sort
properly (both ascending and descending)
Change-Id: Icd31bfab19e4e074f42ac1105904fcb11a0db10a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/217466
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Tested-by: Jenkins
Reviewed-by: Landon Gilbert-Bland <lbland@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Steve Shepherd <sshepherd@instructure.com>
fixes ADMIN-2844
flag=none
Test plan
- Follow repro steps in ticket
and ensure you only get the user
returned once
Change-Id: I3807ab2bfa6793a6a9d81524a4b42a2910c32cb5
Reviewed-on: https://gerrit.instructure.com/208018
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Mysti Lilla <mysti@instructure.com>
fixes ADMIN-751
Test plan
- Specs pass
- Do smoke test on account and course
search functions
Change-Id: I2c7e32c32bc52c1a364ed40a89db0b7dc9557ffb
Reviewed-on: https://gerrit.instructure.com/200682
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Mysti Lilla <mysti@instructure.com>
closes QUIZ-6435
test plan:
- checkout the patch and spin up local Canvas
- verify the url:
<your canvas>/api/v1/accounts/<account id>/users?enrollment_type=teacher
- it returns all valid teacher in the account (from all courses in
the account)
- verify the url with search term:
<your canvas>/api/v1/accounts/<account id>/users?enrollment_type=teacher&
search_term=<search_string>
(note search_string must have at least 3 characters)
- it returns valid teachers for the search term
Change-Id: I0f917e71d0b4baef97284541dbb82d7966675c6d
Reviewed-on: https://gerrit.instructure.com/193389
Tested-by: Jenkins
Reviewed-by: Mysti Lilla <mysti@instructure.com>
QA-Review: Ben Nelson <bnelson@instructure.com>
Product-Review: Stephen Kacsmark <skacsmark@instructure.com>
test plan:
* sorting by email or sis id should still
work more or less as before and perhaps slightly better
- email should actually use the communication channels
- sis user id should use the one for the current account
if the user has multiple logins
- should work while filtering by role type
closes #CORE-1636 #CORE-1637 #CORE-1687
Change-Id: I2dcbc8ad1584d50642e31f30d1ac785ded647a04
Reviewed-on: https://gerrit.instructure.com/160163
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Tucker McKnight <tmcknight@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
test plan:
* on the account user search page, when searching by
login descending, it should put users without any
login time last
closes #CORE-1688
Change-Id: I2c13c52d6ada64c31865944f4a1bb32ebc2625ad
Reviewed-on: https://gerrit.instructure.com/159807
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
test plan:
- enable the "Account Course and User Search" feature
- ensure "See other users' primary email address"
permission is required to find by email address
- ensure "Read SIS data" or "Manage SIS data" is
required to find by SIS ID
- ensure "View login ids for users" is required
to find by login ID
- ensure you can find users by canvas ID and name
in the same search (where one user's name matches
another user's ID)
also:
- ensure students cannot use the include[]=email
option in the "List users in course" API to
retrieve email addresses of other students
(unless granted "See other users' primary
email address" permission)
fixes ADMIN-836
Change-Id: I9c0a1ba9a643632047f42dc010822b6e5035d0d4
Reviewed-on: https://gerrit.instructure.com/143915
Reviewed-by: Mysti Sadler <mysti@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Matt Goodwin <mattg@instructure.com>
Tested-by: Jenkins
use the code that already exists for enrollment role filtering
test plan:
* shouldn't include deleted enrollments when filtering
by role in the new account user serach
closes #ADMIN-869
Change-Id: I8d32f1a54ad6791ec91540e4e8725abfade791ce
Reviewed-on: https://gerrit.instructure.com/144019
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
refs CORE-778
test plan
- search for a user
- it should work faster
Change-Id: I4f7010ff40ac2329215cc24c1a0af347ec359f74
Reviewed-on: https://gerrit.instructure.com/141602
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
QA-Review: Tucker McKnight <tmcknight@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
fixes CORE-778
test plan
- search for a user with sis_id that matches a
canvas_id
- it should return both users
Change-Id: I3495decec057e57357d6104b0f935086a22f380b
Reviewed-on: https://gerrit.instructure.com/141599
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: Tucker McKnight <tmcknight@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
Fixes ADMIN-687
Test plan
- In the course, load up the user's page
and verify that you can search for a
user without any issues
- In the logs, the queries that show should
register as running on the slave instead
of master
- Verify /api/v1/courses/:id/search_users
works as expected
Change-Id: I013b666b12e90e9d4cd1978e6a61da805f91d0d3
Reviewed-on: https://gerrit.instructure.com/139979
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Mysti Sadler <mysti@instructure.com>
refs CNVS-39879
the additional (unnecessary) join conditions in the subquery were
forcing the out part of the query to evaluate first (the
user_account_associations), and then iterate over all of those
for the subquery, instead of executing the subquery first, once,
and then checking that small result list against
user_account_associations
Change-Id: Iec4fe15dd6a902c4516c0a9e6d8b892a0b8b1fd7
Reviewed-on: https://gerrit.instructure.com/131471
Reviewed-by: James Williams <jamesw@instructure.com>
Tested-by: Jenkins
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
fixes CNVS-39879
* restrict the pseudonyms filter to the current root account
* restructure as a "user_id IN (<union of each subquery>)" rather
than "EXISTS () OR EXISTS () ...". In the case of a lot of users
in an account, and the query is specific, postgres was iterating
the EXISTS queries for every user in the account
Change-Id: I6066d818531e5a73ecefb62cad333bf726bc3f9d
Reviewed-on: https://gerrit.instructure.com/130003
Tested-by: Jenkins
Reviewed-by: Ben Chobot <bench@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Tucker McKnight <tmcknight@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
add the ability to select a role in User Search and
only see users enrolled as that role
closes CNVS-33428
test plan:
- turn on Account Course and User Search feature flag
- go to /accounts/1/search/people
- make sure the new role selector works
- make sure the correct users show up
- make sure keyboard navigation/a11y are good
Change-Id: Ib0620deb4618e06ce202ab41981e1301b3c8d256
Reviewed-on: https://gerrit.instructure.com/119365
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Andrew Katsanevas <akatsanevas@instructure.com>
adds sorting to the 'Courses' and 'SIS ID' columns of the Courses tab
and the 'Name' and 'Last Login' columns of the People tab
closes CNVS-33425
test plan:
- turn on Account Course and User Search feature flag
- go to /accounts/1/search/courses
- make sure Courses and SIS ID columns are clickable and sortable
- make sure that keyboard interaction and a11y looks good
- go to /accounts/1/search/people
- do the same for the Name and Last Login columns of the People tab
add sorting by Teacher column in courses
add sorting by first alphabetical teacher to
the 'Teacher' column of the Courses tab
test plan:
- turn on Account Course and User Search feature flag
- go to /accounts/1/search/courses
- make sure the Teacher column is clickable and sortable
- make sure that keyboard interaction and a11y look good
add sorting by Enrollments column in courses
add sorting by number of students enrolled to
the 'Enrollments' column of the courses tab
test plan:
- turn on Account Course and User Search feature flag
- go to /accounts/1/search/courses
- make sure the Enrollment column is clickable and sortable
- make sure that keyboard interaction and a11y look good
add sorting by Email and SIS ID columns in People
add sorting by 'Email' and 'SIS ID' columns of
'People' search tab
test plan:
- turn on Account Course and User Search feature flag
- go to /accounts/1/search/people
- make sure the Email column is clickable and sortable
- make sure the SIS ID column is clickable and sortable
- make sure that keyboard interaction and a11y look good
change UserPane to extend React.Component
change UserPane.js to be a class that extends React.Component
instead of using the old React.createClass
test plan:
- go to /accounts/1/search/people
- make sure the user search feature works the same as before
fix queries and lint warnings
fix SQL queries based on Tyler's suggestions
and fix some lint warnings throughout
test plan:
- go to /accounts/1/search/courses
- make sure sorts still work
- make sure queries are as correct and efficient
- go to /accounts/1/search/people
- do the same
- make sure Gergich is relatively happy
sort teachers in course and lint fixes
change course search so that teachers are sorted alphabetically
within a course (if it has multiple teachers). also a few lint
fixes here and there.
test plan:
- go /accounts/1/search/courses
- make sure that teachers are sorted within a course
Change-Id: I710878bd8ce98ba2fa4eb0c357721864df338939
add a sortable column for subaccounts to course search
add a new column to course search for subaccount
make it sortable like the other columns
test plan:
- turn on Account Course and User Search feature flag
- go to /accounts/1/search/courses
- make sure the correct subaccounts are showing
- make sure the subaccount column is clickable and sortable
- make sure that keyboard interaction and a11y look good
Change-Id: Ic8b8f258c27c16982a450286f6b715c9e04d425e
fix focus for keyboard navigation in Course Search sorting
prevent the CoursesList from rerendering sometimes on sorts
so that it doesn't lose focus
test plan:
- turn on Account Course and User Search feature flag
- go to /accounts/1/search/courses
- make sure keyboard interaction doesn't lose focus
Change-Id: I6236c92f6e71596d3dc38ef756e6ac808e9e99c2
fix invalid email sorting in User Search
fix the sorting of invalid emails in User Search
so that invalid emails (that don't show up) come last
test plan:
- turn on Account Course and User Search feature flag
- go to /accounts/1/search/courses
- make sure that invalid blank emails are sorted last
Change-Id: I56e6b1e57a1d494e7667c3cfc7b14a10976ec52e
fix invalid emails showing in User Search
fix User Search so that invalid emails don't display when
the "Load More..." button is pressed
test plan:
- turn on Account Course and User Search feature flag
- go to /accounts/1/search/courses
- have more than 10 users so "Load More..." is there
- click "Load More..." and make sure invalid emails don't display
for the newly-loaded users
Change-Id: I5bc23c616ae88da73f8632699c3bde1bffee994d
fix IE11 User Search sorting issue
fix User sorting in IE11 so that it doesn't go back to the
Courses tab when trying to sort
test plan:
- use IE11
- turn on Account Course and User Search feature flag
- go to /accounts/1/search/people
- make sure sorting works (doesn't take you to Courses tab)
Change-Id: I63491ca0b08812e21ed0ed2eb2f8a4bd1b791b89
fix add user in User Search bug where email doesn't show up
fix User Search so that when a user is added, their email
shows up without refreshing the page
test plan:
- turn on Account Course and User Search feature flag
- go to /accounts/1/search/people
- add a new user with a valid email
- make sure it displays before refreshing
Change-Id: Ib339bab3ea858c7c1ab18a6065ef4936941cb24b
remove debugger
Change-Id: Ibf88893ea35d795d8966c7580100ac135c8cfe93
Reviewed-on: https://gerrit.instructure.com/120294
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Andrew Katsanevas <akatsanevas@instructure.com>
Change-Id: Ieef3d3447cfa2b22c9c9f6662688a40ae48a726c
Reviewed-on: https://gerrit.instructure.com/119730
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
closes #CNVS-36161
Change-Id: I90d6d76f06b9bbe8a06b4df7c56f8989cf9c1771
Reviewed-on: https://gerrit.instructure.com/109120
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
fixes gh-1005
test plan:
* use the search api (https://canvas.instructure.com/doc/api/users.html#method.users.index)
with a term that only matches a user's login id
* it should find the user
Change-Id: I9bbefc6fc9dc1c38ae5fd07ead55b3b391f8a80a
Reviewed-on: https://gerrit.instructure.com/105704
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
test plan:
- enable new user search
- create a user but don't confirm their email right away
- ensure the user can be found by account search by
email address
fixes CNVS-33430
Change-Id: I9c61e8389ee6e10d5bd133cb23ab74567e1e24ff
Reviewed-on: https://gerrit.instructure.com/95730
Tested-by: Jenkins
Reviewed-by: Steven Burnett <sburnett@instructure.com>
QA-Review: Heath Hales <hhales@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
fixes CNVS-32260
also do a join instead of a subquery. also revert the reverting of
doing it in SQL instead of loading a bunch of ids into memory
Change-Id: I2089b12378ad5301049a4bb427f92b1603c9c964
Reviewed-on: https://gerrit.instructure.com/91405
Reviewed-by: Rob Orton <rob@instructure.com>
Tested-by: Jenkins
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
was performing an unnecessary added join for course contexts
that joined on _all_ user enrollments
closes #CNVS-30331
Change-Id: Ia0c40002aa8c963289bb00833d7719def0609d46
Reviewed-on: https://gerrit.instructure.com/84445
Reviewed-by: Andrew Butterfield <abutterfield@instructure.com>
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
with qualified_names it can be cached for the wrong shard
closes #CNVS-29003
Change-Id: I229de61b438952093e4f730a66481a624ec4b154
Reviewed-on: https://gerrit.instructure.com/78267
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
fixes PLAT-1447
Test plan:
* Create a course with some students
* Regression test
/api/lti/courses/:course_id/membership_service
* Create a group with some students
* Ensure that
/api/lti/groups/:group_id/membership_service
returns a properly formatted list of group members
Change-Id: Idc03c11728847258d621d365d87238465f739672
Reviewed-on: https://gerrit.instructure.com/77595
Tested-by: Jenkins
Reviewed-by: Nathan Mills <nathanm@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Andrew Butterfield <abutterfield@instructure.com>
closes CNVS-28090
I kind of think we should be returning student view students whenever
the students enrollment type is selected, but that might be a breaking
api change.
Test plan:
Use the course users api to return various enrollment types
(including student_view)
Change-Id: Id8dca01e6f00198fba9e77139b1ca30348a9486c
Reviewed-on: https://gerrit.instructure.com/74611
Tested-by: Jenkins
Reviewed-by: Spencer Olson <solson@instructure.com>
QA-Review: KC Naegle <knaegle@instructure.com>
Product-Review: Cameron Matheson <cameron@instructure.com>
makes it non-chainable for more scopes
test plan:
* use /api/v1/accounts/:id/users?search_term=<the id of a user>&include[]=last_login
* it should not 500, and return valid info for last_login
Change-Id: I7a4bf9dbc6bcb4e5be15a86d883467036b9de266
Reviewed-on: https://gerrit.instructure.com/74295
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Fix the edit for a multi-section course where an assignment
override is made for a student in another section than the
teacher who is editing the assignment.
fixes CNVS-23944
Test Plan:
-Create a course with two sections.
-Add a teacher that can only grade their section.
-Create a quiz or assignment
-Override with only student(s) that the sub-teacher cant see
-Masquerade as the teacher and go attempt to edit the assignment.
-Make a change
-Click save and see that it now saves..
-Repeat with override with mix of students that the sub-teacher
can/cannot see
-Repeat with various combos not stated that you can think of
-Make sure to also test that groups and section overrides still work
Change-Id: I360368bf3340a15452da5e60e734817841df139c
Reviewed-on: https://gerrit.instructure.com/71526
Tested-by: Jenkins
Reviewed-by: Mike Nomitch <mnomitch@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Product-Review: Jason Sparks <jsparks@instructure.com>
test plan:
* should be able to use the course people page to
inactivate users (as long as you have the right to remove them)
* inactivated users should not be able to participate in the
course (as though they were deleted), but should still show
up in the course roster for teachers/ta's/admins
with a label of "inactive"
(they should not show up for students though)
* inactivated users should still show in the gradebook list
(and their grades should be editable)
* they should not show up in other lists, such as in the
list of students to assign to groups, or in the
list of students that can be messaged in the inbox
closes #CNVS-24790
Change-Id: If74a37e70c5f7e2df19ac312b1ad8f9b6e83a913
Reviewed-on: https://gerrit.instructure.com/67570
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins
QA-Review: Ryan Allen <rallen@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
test plan:
* in development mode, enable the
"Course and User Search" feature flag
* should be able to view the "Search" tab on the
sidebar (may need to resave the account to
clear the sidebar cache)
(replaces the "Courses" and "Users" tabs)
* searching for People on the account page
should work pretty good
(tweaks may be forthcoming before removing the
feature flag)
closes #CNVS-24951
Change-Id: I00a8954913201ad87d250fec7704a0bfb31abef9
Reviewed-on: https://gerrit.instructure.com/67321
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Ryan Allen <rallen@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
refs CNVS-3451
test plan:
- make api call to get users in a course
"/api/v1/courses/#{course_id}/users"
with enrollment_state[]=active&enrollment_state[]=invited&
enrollment_state[]=completed
- all users who were invited to the course
are returned even if they arent in it anymore
- make api call to get sections
"/api/v1/courses/#{course_id}/sections"
with "enrollments" in the included section
- all user objects have an attached enrollment
Change-Id: I24d6ee31ca9a5c044efa526e762aa1d504045b99
Reviewed-on: https://gerrit.instructure.com/44717
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Sean Lewis <slewis@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
refactor everything that used to use strings for roles
to use actual role_ids
the apis should be backwards compatible so we don't need
to update (most of) the UI's right away in this commit
test plan:
* regression tests for permissions, role overrides,
alerts (for account roles), enrolling users,
adding account admins, etc.
refs #CNVS-15481
Change-Id: Id57fd3104c5c518b6fbf180609950dcddcdd474d
Reviewed-on: https://gerrit.instructure.com/41208
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Change-Id: I0bc5b04d6210c90aa607e23714e7e78a2964e8ff
Reviewed-on: https://gerrit.instructure.com/29517
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
for rails3 and folio
fixes CNVS-8790
test-plan:
- validate pagination of unassigned group members both for course
groups and account groups
Change-Id: Ic9e842abdbfba714829a123ca0dee4f93e5a1fdc
Reviewed-on: https://gerrit.instructure.com/26534
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Jacob Fugal <jacob@instructure.com>
now that we have SIGHUP, we were changing everything to it anyway,
so just let caching in-proc be the default
Change-Id: Id1b44722522ac9693b17695da7107c99a359d5ac
Reviewed-on: https://gerrit.instructure.com/25020
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
test plan:
* add a user to a course with a login and sis id
* as a restricted user (e.g. student) in the course,
visit the 'People' page
* confirm that searching by the login or the sis id
does not return the user
fixes #CNVS-7521
Change-Id: I282e2faa424378d32115db31ccee13509ee4d080
Reviewed-on: https://gerrit.instructure.com/23262
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
Cody Cutrer