Fixes: UIDEV-203
test plan:
- click account from the main nav
- select files from the sub-nav
- next to the search field the italics should have been removed
example: https://cl.ly/0Z350M0E0P29
Change-Id: Ib83286ff57567b31c2e441da65e7504b3f8df8bb
Reviewed-on: https://gerrit.instructure.com/161087
Tested-by: Jenkins
Reviewed-by: Stephen Jensen <sejensen@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Product-Review: Kyle Follett <kfollett@instructure.com>
Closes ADMIN-1320
Test Plan:
Part A:
* With student planner enabled
* As a student with a past/completed enrollment
* Visit the user dashboard
* The option for "List View" should be available
in the dropdown to change the dashboard view
Part B:
* With student planner enabled
* As a student with a future enrollment
* Visit the user dashboard
* The option for "List View" should be available
in the dropdown to change the dashboard view
Change-Id: I5b425c23797a266427587a5f64e8580bff683915
Reviewed-on: https://gerrit.instructure.com/160366
Tested-by: Jenkins
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Carl Kibler <ckibler@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>
This makes it so everything in app/jsx/account_course_user_search
conforms to our style guide (prettier)
Change-Id: I797121e1002eb1a5bcd28f6a177db3b13ae029eb
Reviewed-on: https://gerrit.instructure.com/159747
Tested-by: Jenkins
Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Change-Id: Ifef519776e4358204dd6625acd6cd9f841cd7fcb
Reviewed-on: https://gerrit.instructure.com/152331
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
just announcements
test plan:
* have a course with an announcement
and a discussion topic both closed for comments
* copy the course
* only the announcement should be closed for comments
closes #ADMIN-1267
Change-Id: Ia8b880161a3b4cc6a9b9e06cb8a3408e2672b49e
Reviewed-on: https://gerrit.instructure.com/158915
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Reviewed-by: Carl Kibler <ckibler@instructure.com>
Tested-by: Jenkins
QA-Review: Carl Kibler <ckibler@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
To make adding additional grant_types easier and cleaner in the
future, refactor the existing Oauth2_provider_controller to
push the token generation to grant type objects.
refs PLAT-3659
Test plan:
- Run through the oauth 2 flow for both grant types
- Everything should still work
Change-Id: Ic5fe4a4cc39231620003977c33350f4d98879b0f
Reviewed-on: https://gerrit.instructure.com/160484
Tested-by: Jenkins
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
Reviewed-by: Nathan Mills <nathanm@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Marc Alan Phillips <mphillips@instructure.com>
Fixes: UIDEV-202
test plan:
- select admin from the main nav
- choose your main account (not site admin)
- select "People" from the sub-nav
- choose a student in order to see their settings page
example: https://cl.ly/042t2I3f0U28
Change-Id: I88ac9cd8fa1a2a363f6956ed198d181e4a9f40a3
Reviewed-on: https://gerrit.instructure.com/161082
Reviewed-by: Stephen Jensen <sejensen@instructure.com>
Tested-by: Jenkins
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Product-Review: Kyle Follett <kfollett@instructure.com>
Fixes: UIDEV-201
test plan:
- navigate to a course ... select an assignment
- scroll to the bottom and click the "+ Rubric" button
- click the "I'll write free-form comments when assessing students"
this action should remove the pre-set Ratings and replace it with
text (example: https://cl.ly/0p1d2Z0w2U0u)
- now click the "Find a Rubric" button - this should show account-wide
rubrics available if one has been set-up in the past...
example: https://cl.ly/0Z1E0b1N0q2F
Change-Id: I877a6a0a4112d0448690fe725c44f8c5b60c3f96
Reviewed-on: https://gerrit.instructure.com/161076
Tested-by: Jenkins
Reviewed-by: Stephen Jensen <sejensen@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Product-Review: Kyle Follett <kfollett@instructure.com>
Closes PLAT-3647
Test Plan:
- Enable the 'Anonymous Grading' FF in your root
account
- Create an assignment with a plagiarism detection tool.
Be sure to select the 'Graders cannot view student names'
option when creating the assignment.
- As a student submit to the assignment.
- Create a pending originality report for the submission.
- In speedgrader click the "resubmit to <tool name>" button.
- Verify the page refreshes and a `plagiarism_resubmit` live
event was emitted.
Change-Id: Ib633b0d2b9807d2c963ecdba00048d4cfb0392a7
Reviewed-on: https://gerrit.instructure.com/160767
Tested-by: Jenkins
Reviewed-by: Nathan Mills <nathanm@instructure.com>
Reviewed-by: Han Ngo <hngo@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Weston Dransfield <wdransfield@instructure.com>
yes, eager load. this query is executed on _every_ _single_
_request_, so if we can do one query instead of two, it can
have a potentially decent impact on queries-per-second. and it's
a belong_to, so we're not bring duplicated data off the wire,
either
Change-Id: I1f0b0fffe762c1c5523e78a16a36cc31150279ea
Reviewed-on: https://gerrit.instructure.com/161078
Reviewed-by: James Williams <jamesw@instructure.com>
Tested-by: Jenkins
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
test plan:
* have a blueprint course and an associated course
* set start and end dates on the associated course
* make a sync from the blueprint without settings
checked
* it should leave the dates alone
* remove the dates on the blueprint course
* make a sync with settings checked
* it should remove the dates on the associated course
closes #ADMIN-1328
Change-Id: I09fbd02da0ef518f363d40fc3c8bfac9bb1d7580
Reviewed-on: https://gerrit.instructure.com/160696
Tested-by: Jenkins
Reviewed-by: Mysti Sadler <mysti@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Fixes: UIDEV-200
test plan:
- choose a course and select "grades" from the sub-nav
- from the cog dropdown choose "gradebook history"
- note: i could not get this running locally but feel confident
in the change that was made... if you run locally the message
that displays under the results should no longer be italic
Change-Id: Icb7ef03e509b2ca3fc47dcbeca05d45cc41bbd53
Reviewed-on: https://gerrit.instructure.com/161038
Tested-by: Jenkins
Reviewed-by: Stephen Jensen <sejensen@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Product-Review: Kyle Follett <kfollett@instructure.com>
Fixes: UIDEV-199
test plan:
- navigate to a course, select 'Grades' from sub-nav
if view is Default Gradebook... select the 'Individual View'
button
- the note at the top under the Page Title should no longer be
italicized
- scroll down to 'Content Selection' choose a student and select
an assignment that the student has not been assigned... the
text that appears in the 'Grading' section should no longer be
italicized
Change-Id: I685349784ed0499940e248906d242cc2e52ea198
Reviewed-on: https://gerrit.instructure.com/160972
Tested-by: Jenkins
Reviewed-by: Stephen Jensen <sejensen@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Product-Review: Kyle Follett <kfollett@instructure.com>
Fixes: UIDEV-198
test plan:
- ensure the italics have been removed within the Right Side Bar
"Nothing for now" / "Nothing for the next week" / "1 more..."
Change-Id: I32d91e0f9b16cf7838e67899aec780e9833fd0b1
Reviewed-on: https://gerrit.instructure.com/160964
Tested-by: Jenkins
Reviewed-by: Stephen Jensen <sejensen@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Product-Review: Kyle Follett <kfollett@instructure.com>
Fixes: UIDEV-196
test plan:
- ensure italics have been removed within Discussions (main page)
- select a discussion topic then...
- reply to a discussion
- edit a discussion comment
- delete a discussion comment
note: in order to see these you will need to select the 'eye'
icon near the 'Unread', 'collapes & expand' buttons
Change-Id: Ie5632ee32e0f088460c781cba3617796077dfc4d
Reviewed-on: https://gerrit.instructure.com/160937
Tested-by: Jenkins
Reviewed-by: Stephen Jensen <sejensen@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Product-Review: Kyle Follett <kfollett@instructure.com>
Adds the @deprecated_method, @deprecated_argument, and
@deprecated_response_field tags for API documentation. Also adds the
'deprecated', 'deprecation_notice', 'deprecation_effective', and
'deprecation_description' attributes for the API models and their
properties.
closes GRADE-1450
Test Plan:
1. Read the deprecation_README provided in this commit and verify you
can deprecate methods, arguments, response fields, models, and
model attributes. This verificiation process should include:
- Verifying the `rake doc:api` command throws an error when invalid
and/or missing parameters are used for the deprecation tags
- Verifying the deprecations show up in the generated documentation
(located at public/doc/api/index.html) after running
`rake doc:api`.
2. Verify the @argument, @response_field, and @model tags still work
and generate appropriate documentation when running `rake doc:api`
Change-Id: If6c2b0ee9fccbbd202990d8835c6266017e2dfa5
Reviewed-on: https://gerrit.instructure.com/138581
Reviewed-by: Gary Mei <gmei@instructure.com>
Reviewed-by: Derek Bender <djbender@instructure.com>
QA-Review: Gary Mei <gmei@instructure.com>
Tested-by: Jenkins
Product-Review: Simon Williams <simon@instructure.com>
Closes PLAT-2222
Test Plan:
- Create an assignment with anonymous_grading set to
true.
- Launch a tool that uses the new
'com.instructure.Assignment.anonymous_grading'
substitution in a context of the assignment.
- Verify the parameter value is 'true'
- Set the anonymous_grading attribute of the
assignment to false.
- Launch the tool again and verify the parameter
value is 'false'
Change-Id: I8de86dd166a4bbae68b63aef08b0e4dc6dc9fbbf
Reviewed-on: https://gerrit.instructure.com/160935
Reviewed-by: Han Ngo <hngo@instructure.com>
Tested-by: Jenkins
Reviewed-by: Nathan Mills <nathanm@instructure.com>
QA-Review: Nathan Mills <nathanm@instructure.com>
Product-Review: Weston Dransfield <wdransfield@instructure.com>
refs #CORE-1717
Change-Id: Idf8da1ea746f8d2190eb66f4cc39e5c1a969c220
Reviewed-on: https://gerrit.instructure.com/161027
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
test plan:
* on the account user search page, when searching by
login descending, it should put users without any
login time last
closes #CORE-1688
Change-Id: I2c13c52d6ada64c31865944f4a1bb32ebc2625ad
Reviewed-on: https://gerrit.instructure.com/159807
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
for planner and calendar events api
also apparently the except(:preload) makes it so
the inverse association for course on enrollments isn't set
Change-Id: Id490aa6b76c7c0b283a6c4a8be13ef2e5d4d9707
Reviewed-on: https://gerrit.instructure.com/160897
Tested-by: Jenkins
Reviewed-by: Mysti Sadler <mysti@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
and add override to force-clear it
Change-Id: I05a4b68be963ca8eceace456cc2d81f4556a9da6
Reviewed-on: https://gerrit.instructure.com/160992
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
fixes CORE-1729
test plan
- sis import refactor should be on
Change-Id: I9d6ec6b9e548b7ded62d940a353ca1930ead4cc4
Reviewed-on: https://gerrit.instructure.com/160998
Reviewed-by: James Williams <jamesw@instructure.com>
Tested-by: Jenkins
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Change-Id: Iec552e761a887cb901b06c2c4652a0ad3838e6f2
Reviewed-on: https://gerrit.instructure.com/161000
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Canvas is moving to a 1px outline on focused items.
In the normal canvas theme, the view calendar link gets
an outline and underline on focus.
With underlined links enabled, the link gets an outline and the
underline disappears on focus.
In high-contrast it's the same, but the outline is darker.
closes ADMIN-1260
test plan:
- load the card dashboard
- press TAB a thousand times until the Show Calendar link gets focus
> expect the view calendar link to be underlined and have a 1px outline
- enable underlined links from the user's settings
> expect the view calendar link to have the outline, but the underline
that was there before focus disappears
- enable high contrast
> expect the view calendar link to behave the same as before, but the
outline is darker
- one of these times, press ENTER while the link has focus
> expect to be taken to the calendar
Change-Id: I95f0668da77ab630e1bc23e8a3a0d7a30c2a824a
Reviewed-on: https://gerrit.instructure.com/159898
Reviewed-by: Mysti Sadler <mysti@instructure.com>
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Tested-by: Jenkins
Product-Review: Dan Sasaki <dsasaki@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
sis_batch has an attribute progress so I renamed
the variable used for the progress object to be
clear that it was not the attribute
fixes CORE-1728
Change-Id: Id5f581f5df8c58d782e54f49b2297461f1d9ad33
Reviewed-on: https://gerrit.instructure.com/160909
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
refs CORE-1728
Change-Id: I08daf7eabfe28afdda5a7a5ebe9bf09b8c04394b
Reviewed-on: https://gerrit.instructure.com/160881
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Ungraded surveys are different from graded quizzes in that they never
get a real Submission, so the code in the Submission model that
completes the planner override is never exercised. Have to special case
this in the Quizzes::QuizSubmission model
fixes ADMIN-1275
test plan
- create an ungraded survey in a course your student is enrolled in
- have the student take the survey
- have the student load the planner
> expect the survey to be marked complete
- create an ungraded survey in a course your student is enrolled in
- have the student load planner
- have the student use the checkbox to complete then un-complete the
ungraded survey
- have the student take the survey
- have the student return to planner
> expect the survey to be marked as complete
Change-Id: Ia54a7a02cca666ab315655fecbdb996a1c605417
Reviewed-on: https://gerrit.instructure.com/160344
Tested-by: Jenkins
Reviewed-by: Mysti Sadler <mysti@instructure.com>
QA-Review: Mysti Sadler <mysti@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
Slow down browser load for JS exceution
Test Plan:
-- Passes Jenkins
Change-Id: Ia90edf2215ed851de59dd76026b9c02d8864343b
Reviewed-on: https://gerrit.instructure.com/160921
Tested-by: Jenkins
Reviewed-by: Robert Lamb <rlamb@instructure.com>
Product-Review: Robert Lamb <rlamb@instructure.com>
QA-Review: Robert Lamb <rlamb@instructure.com>
Closes: CORE-1709
This is what our Jenkins job to pull in every instui RC commit will use
Test plan:
* run `yarn upgrade-instructure-ui`
* it should make a commit that has new entries in yarn.lock for all the
instUI packages that uses the latest rc version on the npm registry
* it should not affect anything else besides yarn.lock
Change-Id: I78cce6e801015819c4e4b27e26ede352deceebb9
Reviewed-on: https://gerrit.instructure.com/160435
Tested-by: Jenkins
Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
closes GRADE-1426
Test Plan:
1. Before running migrations, make sure you have some moderation_grader
records.
2. Run migrations. Verify 1) the moderation_graders table now has a
slot_taken column, and 2) the existing moderation_grader records have
slot_taken set to true.
3. Create a moderated assignment, then log in as a provisional grader.
4. Verify there are no moderation_grader records for the provisional
grader for that assignment.
assignment.moderation_graders.find_by(user: provisional_grader)
=> nil
5. Visit SpeedGrader, but don't grade or comment. Verify a moderation
grader record has been created for the provisional grader, and verify
it has slot_taken set to false.
grader =
assignment.moderation_graders.find_by(user: provisional_grader)
grader.slot_taken?
=> false
6. Leave a submission comment or a grade in SpeedGrader. Verify the
moderation grader record for the provisional grader has been updated
with slot_taken set to true.
grader.reload.slot_taken?
=> true
7. Verify you can roll the migration back. The slot_taken column should
be removed.
Change-Id: I94fafc259df5022ed1af27d3457d8df87947153e
Reviewed-on: https://gerrit.instructure.com/159544
Reviewed-by: Jeremy Neander <jneander@instructure.com>
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Neander <jneander@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
Typing the name alone in the user search box is enough
to populate results. Pressing `enter` will make
the page load again and cause the specs to fail
Test Plan:
-- Passes Jenkins
Change-Id: I48ea1b4f844a2645cd374d4bece3c88bd9a524e6
Reviewed-on: https://gerrit.instructure.com/160941
Tested-by: Jenkins
Reviewed-by: Robert Lamb <rlamb@instructure.com>
Product-Review: Robert Lamb <rlamb@instructure.com>
QA-Review: Robert Lamb <rlamb@instructure.com>
closes CNVS-43231
test plan: tokens generated by canvas can still be decoded by
pandata_events
Change-Id: I99379b7330719b5e98dddc84a8f06974311b9062
Reviewed-on: https://gerrit.instructure.com/159603
Reviewed-by: Addison Higham <ahigham@instructure.com>
Reviewed-by: Brad Horrocks <bhorrocks@instructure.com>
Tested-by: Jenkins
Product-Review: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
closes ADMIN-143
Test plan
- Have a graded quiz, discussion and wiki page
- Try to create planner overrides for the
assignments for all of them
- Ensure the planner override gets created for
the quiz/discussion/wiki page instead
- Have a group discussion
- Try to create a planner override for one of
the child topics
- Ensure the planner override gets created for
the parent topic
- Have an announcement and create a planner
override for it
- Make an api call for the override and ensure
it shows up as "announcement" in the type
instead of discussion_topic
Change-Id: I7940f27508453cdc03366eda10d59e5ca1fbf110
Reviewed-on: https://gerrit.instructure.com/156904
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Mysti Sadler <mysti@instructure.com>
Make the browser wait longer so it does not conflict
with other js executions
Test Plan:
-- Passes Jenkins
Change-Id: I21638b54f7a675348b84632bba49c85fe61f4bcc
Reviewed-on: https://gerrit.instructure.com/160913
Tested-by: Jenkins
Reviewed-by: Robert Lamb <rlamb@instructure.com>
Product-Review: Robert Lamb <rlamb@instructure.com>
QA-Review: Robert Lamb <rlamb@instructure.com>
fixes ADMIN-1280
test plan:
- Navigate to the Course Settings page
- Click on "Validate Links in Content"
- Inspect the heading and note that it's an h1
Change-Id: Id253d2e0d489617ea0ea63927ddcb5084ca46189
Reviewed-on: https://gerrit.instructure.com/158711
Product-Review: Dan Sasaki <dsasaki@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins
fixes ADMIN-1285
test plan:
- Navigate to a course's Settings page
- Click on Import Course Content
- Move through the page with a screen reader
- Note that each horizontal rule is read to the SR
Change-Id: Ic16bcf0fa78dbc5d114286f674f1588021a70cc9
Reviewed-on: https://gerrit.instructure.com/158823
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Luke Kingsley <lkingsley@instructure.com>
Product-Review: Matt Miller <mmiller@instructure.com>
Tested-by: Jenkins
since the method itself just returns a scope
Change-Id: Ifefa2581fce0c7b5669c4c6ed05fa8529d285eb4
Reviewed-on: https://gerrit.instructure.com/160877
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
closes GRADE-1459
test plan:
1. Select or create two moderated assignments
a. one with students anonymized
b. one with students not anonymized
2. Ensure both assignments have:
a. provisional grades
b. the same final grader
3. Sign in as the final grader
4. Visit the moderation page for the anonymous assignment
5. Verify the student names link to the same students in SpeedGrader
6. Visit the moderation page for the non-anonymous assignment
7. Verify the student names link to the same students in SpeedGrader
Change-Id: I35ec98cc39f47a53c88be42606fffc397cdd600c
Reviewed-on: https://gerrit.instructure.com/160705
Tested-by: Jenkins
Reviewed-by: Gary Mei <gmei@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
QA-Review: Adrian Packel <apackel@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
Refs COMMS-1375
Test Plan:
* Make a permissions with a really long name
* Click on the permission in the table, make sure the full name is
displayed in the permission tray
Change-Id: I847c03bf4c5a2f1e78e7112112abc8d6ccd5e7cd
Reviewed-on: https://gerrit.instructure.com/160807
Reviewed-by: Steven Burnett <sburnett@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
QA-Review: Steven Burnett <sburnett@instructure.com>
Tested-by: Jenkins
from folders and attachments. these are set but never looked at
refs ADMIN-1329
Change-Id: Icfe1bf07c1a6ab62cf2354be59e4a8d7b686ef5d
Reviewed-on: https://gerrit.instructure.com/160621
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Product-Review: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
closes: CORE-1632
Test plan:
Have enough courses or users to have 10 pages of results in the account
course/users search
* Go to the Courses tab in an account
* Go to the bottom of the page
* Try to navigate with the last page link that is next to the ellipsis
* it should work, without throwing any JS errors in the console
* try to click on the link back to the first page, it should also work
Change-Id: I0d2d61a37eaedfbde54089bb190b000ec40a91ce
Reviewed-on: https://gerrit.instructure.com/159746
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
Steven Burnett