This reverts commit 882a1891e0.
This reverts commit a29454866d.
Test Plan:
- Make sure you can take quizzes with question types other than MC.
Change-Id: I37481728e387b08d5e6adb5bd03d4dec6082559b
Reviewed-on: https://gerrit.instructure.com/57234
Reviewed-by: Cameron Sutter <csutter@instructure.com>
Product-Review: Cameron Sutter <csutter@instructure.com>
QA-Review: Adam Stone <astone@instructure.com>
QA-Review: Derek Hansen <dhansen@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Tested-by: Ryan Taylor <rtaylor@instructure.com>
fixes CNVS-21335
Test Plan:
* As an admin create a sub-account
* As an admin in the sub account click the user tab (left nav)
* Click “Add a New User"
* Fill out all the fields and click the blue “add user” button
* Refresh the page
* The new user should appear as a user in the sub account
Change-Id: Ib18693a0dc3c7daa60f397b940773a545b49e722
Reviewed-on: https://gerrit.instructure.com/57249
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Fixes PLAT-1117
Test Plan:
- Check https://instructure.atlassian.net/browse/PLAT-1117 for details on how this change should work
- Check to make sure each of the following placements works like the description of PLAT-1117 outines
- user_navigation
- course_navigation
- account_navigation
- course_home_sub_navigation
- course_settings_sub_navigation
- global_navigation
- assignment_menu
- file_menu
- discussion_topic_menu
- module_menu
- quiz_menu
- wiki_page_menu
- migration_selection
- link_selection
- assignment_selectino
- editor_button
Change-Id: Ib56d4c8c386975dcb86d79267cf2e69949146066
Reviewed-on: https://gerrit.instructure.com/56467
Reviewed-by: Nathan Mills <nathanm@instructure.com>
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
Product-Review: Weston Dransfield <wdransfield@instructure.com>
Refs: CNVS-21516
Sets the font-size of the .ic-label class to 14px
instead of 15px.
Test Plan:
- Open Canvas in either UI.
- Go to /styleguide.
- Click on Scaffold > Forms from the top menu
- Find a label in the Forms section with the
class .ic-label
- Open Inspector and make sure the font-size is
14px, not 15px
Change-Id: I6e50c20a9ad9100086b199ffeaf3cdafbbad9abb
Reviewed-on: https://gerrit.instructure.com/57219
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Tested-by: Jenkins
QA-Review: Nathan Rogowski <nathan@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
fixes CNVS-21047
Also removed a bunch of fat arrows that were driving my linter up the wall.
Test Plan:
1. Create a course
2. Enable grading periods
3. Create at least 2 grading periods
4. Have at least one assignment in each grading period
5. In gradebook, select "All Grading Periods"
6. Verifiy that the assignments for all grading periods displays
Change-Id: If2d851d4a57100e5275bf281c1f364225a6f7309
Reviewed-on: https://gerrit.instructure.com/56802
Tested-by: Jenkins
Reviewed-by: Spencer Olson <solson@instructure.com>
Reviewed-by: Derek Bender <dbender@instructure.com>
QA-Review: Adrian Foong <afoong@instructure.com>
Product-Review: Cody Poll <cpoll@instructure.com>
closes CNVS-15282
Previously for users that have multiple pseudonyms,
the "sis_pseudonym" might be selected differently depending
on whether the pseudonyms collection was already loaded or not
because no specific order clause was given. This patchset
makes it so that all sis pseudonym selection strategies
order the data set the same way (by "unique id") so that
you can count on getting a deterministic result.
Also, user.rb is huge, so I took the opportunity to split out a
SisPsuedonym class. There may be room to move more
functionality into it later liked deciding what pseudonym to
fall back to in cases where the current strategy finds
nothing, but this is a good first step. I switched all the use
cases I could find of the old interface on user.rb, but left the
method in place for now in case other plugins or extensions make use of
it. We can wait a while and let the deprecation warnings take effect
before removing it.
TEST PLAN:
1) download a gradebook csv export for a course
2) make sure the SIS Login ID is the same as the secondary
ID for each user that you see in the gradebook view itself.
Change-Id: Ib18b40acbaf3a8f4352fd6ee8e0826897e3edf49
Reviewed-on: https://gerrit.instructure.com/57001
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: August Thornton <august@instructure.com>
closes CNVS-21324
javascript timezone locale file for swedish already existed, and used it
as a template for danish given their similarities, then updated based on
http://std.dkuug.dk/cultreg/registrations/narrative/da_DK,_4.3.html
Change-Id: I28d03ee26f04e7802b31992a63ec8051f43f29ce
Reviewed-on: https://gerrit.instructure.com/56981
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: August Thornton <august@instructure.com>
if a student is enrolled in more than one class,
the 'for the course' dropdown will be visible to the
student's observers when the observer is viewing the
student's grade summary page.
closes CNVS-20860
test plan
- create a user who is in multiple courses
- add an observer to that user for the courses
you created
- go the grade summary page as the observer
- you should see the 'for the course' dropdown
- ensure the observer only sees the courses that
they were given permission to observer
Change-Id: Ib30e6747b4b1edce76be9fe1fce1ce5f9a31a92f
Reviewed-on: https://gerrit.instructure.com/56955
Tested-by: Jenkins
Reviewed-by: Cody Poll <cpoll@instructure.com>
QA-Review: Jason Carter <jcarter@instructure.com>
Product-Review: Dylan Ross <dross@instructure.com>
Refs: CNVS-21198
I ended up using text as well as the panda-loader
image because I found the loader image would
generally load after or at the same time as the
course data. Please see the screencast below.
http://screencast.com/t/QAVAmxAy9
UPDATE - Jen suggested CSS-only preloading, which
seems to have worked great. The panda-on-a-bike is
now being loaded as a background of another element
and then is positioned off-screen.
QA Test Plan:
- Make sure the Use New Styles feature flag is on
and your cache is cleared
- Load the Canvas dashboard (or any other page)
- Before everything has finished loading, click
on the Courses, Accounts or Groups links in the
primary navigation
- You should now see the word "Loading ..." before
the content loads. If the content takes long
enough to load, the animated GIF of the panda on
a bike should appear.
Change-Id: Ib8c8cd73c94e7d735db505d7ba2e2276c48597e0
Reviewed-on: https://gerrit.instructure.com/57100
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Tested-by: Jenkins
QA-Review: Nathan Rogowski <nathan@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
closes CNVS-21340
this initializer was producing the right keys, but not
with indifferent access, so string access wasn't working and the
linkedin registered service would just die.
Also fixed a problem in the twitter connector which has the same
issue with running a find at initialization time.
TEST PLAN:
1) linked in as a registered service should not break horribly
2) twitter as a registered service should not break horribly
Change-Id: Iaa3a5c7f3f0ac5561079a334493d215399d45d76
Reviewed-on: https://gerrit.instructure.com/57186
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
Tested-by: Jenkins
closes CNVS-21204
make firefox treat rce image linking appropriately. Prior to this
patchset it would make the alt text a link instead of wrapping the image
tag in a link tag. The reason is the way we decide whether to wrap
DOM content, or make a new text link and replace existing DOM. In the
case of some DOM element which has HTML, but for which
"editor.selectContent({format: 'text'})" returns a blank string, we've
usually interpreted that as something image-like that should probably
just be wrapped. The problem is that Firefox gives us the alt
text when we ask for the "text" of that node, throwing off our
check. This patchset makes the text extraction explicitly check
for the case of an image node with alt text and treat that the same
for the purpose of content sniffing, and seems to fix the problem.
TEST PLAN:
1) use firefox
2) go to any RCE
3) embed an image
4) now select the image and try to make it a link
5) it should work
Change-Id: I65695b1d73d3c4855c8d63848578ba94a4c5c672
Reviewed-on: https://gerrit.instructure.com/57181
Tested-by: Jenkins
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Fixes CNVS-21486
Test plan:
- Create quiz, do not publish it
- View quiz list
- Attempt to view quiz
Change-Id: I0912b5035debc2b484ece04692a8002217255cbf
Reviewed-on: https://gerrit.instructure.com/57163
Tested-by: Jenkins
Product-Review: Matt Fairbourn <mfairbourn@instructure.com>
QA-Review: Adam Stone <astone@instructure.com>
Reviewed-by: Cameron Sutter <csutter@instructure.com>
Small wording tweaks requested by UI team to
primary navigation in new UI.
Fixes: CNVS-21363
Test Plan:
- Make sure that the Use New Styles flag is
turned ON.
- On the main navigation, underneath the profile
pic, it should now read "Account" (not Profile).
- The title of the tray that slides out when you
click on Account should now be "Account"
- On the main navigation, the Accounts link has
been renamed "Admin"
- The title of the tray that slides out when you
click on Admin should now be "Admin"
- Click on the Courses link on the main navigation.
The "All courses" link on the tray should now
have a gray border on top of it.
Change-Id: I6693f507ca6d75608aeed8c454ed008e3d24d187
Reviewed-on: https://gerrit.instructure.com/56944
Tested-by: Jenkins
QA-Review: Nathan Rogowski <nathan@instructure.com>
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
When zipping assignment submissions for download, deleted files should not be
added to the zip.
fixes CNVS-12167
There is an edge case that is covered - that of a small course where maybe 1 or
2 submissions may exist, and the file for each has been deleted. By marking
success if the file is deleted, we keep it from erroring out, and will download
an empty zip. Jenkins shows no regressions for this, so we should be good.
Test Plan:
A: As a teacher:
1. Create a file-upload assignment as a teacher
B: As a student:
1. Submit a file upload for the assignment
2. Delete the upload (/users/:user_id/files)
C: As a teacher:
1. View the students submission in speed-grader
2. Click download icon
3. Verify that a page not found error is displayed
4. Return to assignment page
5. Click "Download Submissions"
6. Verify that the zip file downloaded
7. Double-click on zip file
8. Verify that the resulting file does not contain the deleted file
The resulting file may simply be a .cfgz or similar file. This signifies
an empty zip file in this case.
Change-Id: I6344cadb92d4e13bd23ade4c4e34111751bcecd1
Reviewed-on: https://gerrit.instructure.com/53574
Tested-by: Jenkins
Reviewed-by: Strand McCutchen <smccutchen@instructure.com>
QA-Review: Adrian Foong <afoong@instructure.com>
Product-Review: Cody Poll <cpoll@instructure.com>
When an anonymous peer review involved a rubric, displaying
the rubric would reveal the identity of the reviewer. Now,
the text "Anonymous User" appears if the reviewer is supposed
to remain anonymous.
fixes CNVS-21357
Test plan:
1. Ensure a teacher and two students are enrolled in a course.
2. As the teacher, create an assignment which requires peer review.
- Ensure the reviews are supposed to be anonymous
- Ensure that a rubric is to be used for the review
3. As student1, submit the assignment.
4. As student 2, submit a peer review involving a comment & rubric.
5. As student 1, go to `grades` and click the "see rubric results"
link for the peer reviewed assignment.
6. Ensure that the rubric displays "Anonymous User"
7. As the teacher, edit the assignment to make reviews not anonymous
8. As student 1, go to `grades` and click the "see rubric results"
link for the peer reviewed assignment.
9. Ensure that the rubric displays the reviewer's identity.
Change-Id: Iee31bf43941b63e53f7e396635f07476b7dfa54d
Reviewed-on: https://gerrit.instructure.com/57127
Reviewed-by: Spencer Olson <solson@instructure.com>
Tested-by: Jenkins
QA-Review: Derek Hansen <dhansen@instructure.com>
Product-Review: Cody Poll <cpoll@instructure.com>
when a gradebook is successfully uploaded, a
green success banner will show.
closes CNVS-20359
test plan:
import a Gradebook CSV (with changes made to scores).
verify that after the gradebook is done uploading,
you are redirected to the Gradebook and there is a
green banner at the top of the page that says
'Upload successful'. refresh the page and verify that
a green banner does _not_ appear with the success
message.
Change-Id: I29346498a3c1ae7158e7ac2f11de3f7ca5b8d806
Reviewed-on: https://gerrit.instructure.com/57062
Tested-by: Jenkins
Reviewed-by: Cody Poll <cpoll@instructure.com>
QA-Review: Derek Hansen <dhansen@instructure.com>
Product-Review: Spencer Olson <solson@instructure.com>
the sis assignments integration api is not paginated and didn't fulfill
all necessary use cases, so we are removing it before it hits
production. there is a replacement api that will be merged following
this commit.
test plan:
* querying the api should return a 404 error
* /api/sis/grade_export/accounts/:account_id/assignments
* generated api documents should not reference 'SIS Integration'
closes CNVS-21494
Change-Id: I1d7a15fa08ac4e9a10bdc1c366ff8d87338d9808
Reviewed-on: https://gerrit.instructure.com/57171
Tested-by: Jenkins
Reviewed-by: Brad Humphrey <brad@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
QA-Review: Derek Hansen <dhansen@instructure.com>
Product-Review: Brad Humphrey <brad@instructure.com>
fixes CNVS-19373
test plan:
* as a teacher
* create a quiz that is locked after the next minute or less
- preview the quiz
> there should not be a little dialog that pops up and says
that you only have 9 seconds left to take the quiz
- leave the preview and try it again, making sure the locked
date/time has passed
Change-Id: I8a75a63e41f49c64a62442b5fed77e26e52c358e
Reviewed-on: https://gerrit.instructure.com/56663
Reviewed-by: Brian Finney <bfinney@instructure.com>
Tested-by: Jenkins
QA-Review: Adam Stone <astone@instructure.com>
Product-Review: Jason Sparks <jsparks@instructure.com>
fixes CNVS-21330
Error messages for duplicate sis id's were not being displayed when
creating a new user for sub accounts. Error messages should now show up.
Test Plan
Given you have SIS accounts enabled for your account
And you have a sub-account created
And you have a user with 1000 as the SIS id created
When you attempt to create another user
And you use 1000 for it's SIS id
Then you should get an error message that says that id is taken
And that user should have not been created
Change-Id: I91300d67867a0213ae0763cdd1e51cfa26c50ba4
Reviewed-on: https://gerrit.instructure.com/57097
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Fixes CNVS-20686
Test plan:
- As a student, sign up for a scheduler appointment timeslot
- Go to the week tab
- Click on the appointment
- Ensure that the popup has an Un-reserve link
- Click the Un-reserve link and ensure that the timeslot has
been unreserved
- Do the same for the month view
Change-Id: I006979c7fc6cd74643420455a167f66c00c6f998
Reviewed-on: https://gerrit.instructure.com/56086
Reviewed-by: Andrew Butterfield <abutterfield@instructure.com>
Tested-by: Jenkins
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Alex Boyd <aboyd@instructure.com>
Fixes CNVS-20356
Test plan:
- Go to the calendar, then go to the scheduler
- Click 'Create an appointment group'
- Choose a calendar and give it a name, but do not add a time
slot
- Click 'Save'
- Verify that an alert shows up telling you that you need at
least one time slot
- Do the same thing over again, but hit 'Save and Publish' this
time
- Verify that the same thing happens
Change-Id: I336707fe463bbdfeed63e7b797f194c3cc56d887
Reviewed-on: https://gerrit.instructure.com/56385
Reviewed-by: Andrew Butterfield <abutterfield@instructure.com>
Tested-by: Jenkins
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Alex Boyd <aboyd@instructure.com>
fixes CNVS-21444
test plan:
- go to assignment and quiz show pages
as a teacher
- the description's box is rounded
- the due dates table has a white header
- there is a bit more whitespace in the
table
Change-Id: I94b0a92fca3d3624610d2f6c02e71e009f550895
Reviewed-on: https://gerrit.instructure.com/57060
Tested-by: Jenkins
Reviewed-by: Brian Finney <bfinney@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Jason Sparks <jsparks@instructure.com>
fixes CNVS-20834
test plan:
- make a survey (graded or ungraded)
- make a fill in the blank question
with a few answers
- save and go back to the question edit page
- when you re-edit the question you just made
you see the answers to the question
- when you update that question, you see the
updated answers when you try to edit it again
- take this survey as a student and esure it works
like normal
Change-Id: I9a592e644c57bdfb7d734ce4e79a36537589ef2a
Reviewed-on: https://gerrit.instructure.com/57028
Tested-by: Jenkins
Reviewed-by: Brian Finney <bfinney@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Product-Review: Jason Sparks <jsparks@instructure.com>
fixes CNVS-21479
test plan: make API requests to canvas, and verify that the X-Canvas-Meta
response header includes the controller, action, and context fields.
Change-Id: Ib2c8724d295d192c8b80125439cf68a7a6215c6f
Reviewed-on: https://gerrit.instructure.com/57143
Reviewed-by: Cody Cutrer <cody@instructure.com>
Reviewed-by: Zach Wily <zach@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Tested-by: Jenkins
Product-Review: Brian Palmer <brianp@instructure.com>
test plan:
* regression test module sequence footer
refs #CNVS-21317
Change-Id: I110fa2a5f00d4fe9f6be3c7b100cbf2b098b1358
Reviewed-on: https://gerrit.instructure.com/56986
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
closes CNVS-21297
These settings are referenced everywhere else with "consumer"
prefixes rather than "client" prefixes, this fixes that typo.
Also makes the config hash with indifferent access,
wraps the configuration in a testable object, and
relaxes the twitter gems' requirement for a Proc,
letting it be satisfied with a callable object.
(also started unit tests on that object
since I was touching it anyway and it had none)
TEST PLAN:
1) twitter as a registered service works
Change-Id: I9daf03547c3e60b99bdd6c24a4c632b0f8b6b091
Reviewed-on: https://gerrit.instructure.com/57074
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
content_tags_visible_to now always returns an array
test plan:
* should not receive errors when viewing module item
api show endpoints (also mark_done)
as a student with differentiated assignments on
closes #CNVS-21464
Change-Id: Ie5aa0f620b02d508656fa552576253eb475f5849
Reviewed-on: https://gerrit.instructure.com/57116
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
a lot of time was being spent running unnecessary
permissions checks on a users' courses
up to ~75% of UsersController#dashboard_sidebar
refs #CNVS-21317
Change-Id: Ic3ecd1e6c357e8347133f10e027dc028c6b5cd83
Reviewed-on: https://gerrit.instructure.com/56880
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Fixes CNVS-20968
Test plan:
- When viewing a group set, click "+ Group"
- With the screenreader turned on, focus the name field
- Ensure that your screenreader notes that the field is required
Change-Id: Ic9892a634515bd40bf26b26bfd35e6586fc0221c
Reviewed-on: https://gerrit.instructure.com/56670
Tested-by: Jenkins
Reviewed-by: Matthew Wheeler <mwheeler@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Alex Boyd <aboyd@instructure.com>
Fixes CNVS-20894
Test plan:
- Set up outgoing email through the Amazon SES test account
- Set up bounce_notifications.yml with the SQS test creds
- Set a user's email address to bounce@simulator.amazonses.com
- Cause a message to be sent to that user
- Wait for the bounce notification processor to run (~5 minutes)
- At a Rails console, check the CommunicationChannel's
last_bounce_at and verify that it roughly corresponds to when
the initial message was sent
- Check the CommunicationChannel's last_bounce_details and ensure
that they have been filled in
- Cause another message to be sent to the user and wait for the
bounce notification processor to run again
- Check the CommunicationChannel's last_bounce_at and ensure that it
has changed
- Check the CommunicationChannel's last_bounce_details and ensure
that they have also changed
- Change the CommunicationChannel's path to be
suppressionlist@simulator.amazonses.com
- Cause another message to be sent to the user and wait for the
bounce notification processor to run again
- Check the CommunicationChannel's last_bounce_at and ensure that it
has _not_ changed
- Check the CommunicationChannel's last_suppression_bounce_at and
ensure that it is now filled in
- Check the CommunicationChannel's last_bounce_details and ensure that
they have _not_ changed
- Set another user's email address to success@simulator.amazonses.com
- Cause a message to be sent for that user and ensure that it is
sent successfully
Change-Id: I771f59a5e9b33d415dd38c3d4a80f65fc1e003bd
Reviewed-on: https://gerrit.instructure.com/55660
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Reviewed-by: Andrew Butterfield <abutterfield@instructure.com>
Tested-by: Jenkins
QA-Review: Heath Hales <hhales@instructure.com>
Product-Review: Peyton Craighill <pcraighill@instructure.com>
Fixes CNVS-18768.
test plan:
- Set course dates to the past
- Set section dates to the present
- Assign a quiz to that section
- Take Quiz button should not appear
Change-Id: I64d966cde8ffe2e2a69434cad4cf154c730845ce
Reviewed-on: https://gerrit.instructure.com/54603
Tested-by: Jenkins
Reviewed-by: Ryan Taylor <rtaylor@instructure.com>
QA-Review: Adam Stone <astone@instructure.com>
Reviewed-by: Brian Finney <bfinney@instructure.com>
Product-Review: Matt Fairbourn <mfairbourn@instructure.com>
Fixes CNVS-20408
Fixes CNVS-21260
Test Plan:
NOTE: You will need to have the Academic Benchmarks API key, and you
will need to run this from an IP address inside the Instructure
network
* As a site-admin, make the following requests and verify that they
work. Do the same as a regular account admin, a teacher, and
a student, and verify that those DO NOT work (should return 401
unauthorized
- Through the API, query for available GUIDs to import
- Get to "/api/v1/accounts/#{@account.id}/outcomes_import/available"
- Through the API, schedule a GUID for importing
- Post to "/api/v1/accounts/#{@account.id}/outcomes_import" with
guid as argument
Change-Id: Ia7f199416f46da2aae4a356d5fa6c3c1d5845bfa
Reviewed-on: https://gerrit.instructure.com/54648
Tested-by: Jenkins
Reviewed-by: Cameron Sutter <csutter@instructure.com>
Product-Review: Cameron Sutter <csutter@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
fixes CNVS-21139
Test Plan:
- Go to the feature flags
- Course Catalog should now be Public Course Index
Change-Id: Icdced7ef68a279f9d8e9fedd5ba3b9feb60f04ae
Reviewed-on: https://gerrit.instructure.com/57058
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
fixes CNVS-21292
Button type wasn't set on a form button which was causing issues
Test Plan
Given I'm a user that can create modules(chrome, safari, firefox)
And I'm on the modules page
When I click "Add Module"
And fill in a module name
And press enter
Then the form should submit
And the dialog should close
And the new module should appear on the page
Change-Id: I7149fc956dc8ef787b2026fbda89e2663757cfdb
Reviewed-on: https://gerrit.instructure.com/56826
Tested-by: Jenkins
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Sterling Cobb <sterling@instructure.com>
Fixes PLAT-1128
Test Plan:
- Install lti test tool (https://github.com/rivernate/lti_tool_provider_example) and make sure the module item placement is selected
- Add a module item and choose 'External Tool' as the type.
- Find the app you just installed and click on it.
- When the modal pops up click the green '+' in the top right cortner to add a content-item
- Fill in the values however you want, just make sure 'Presentation Target' is set to 'window'
- Click 'submit' and then 'Add Item'
- Click the link in the module item and make sure it goes to a page with a button that says 'load <tool name> in a new window.'
- Click the button and make sure the tool loads in a new tab
- add another content item but this time set 'Presentation Target' to 'frame'. Make sure this tool loads in an iframe rather than a new tab
Change-Id: Ic6654bf40dd5aef0141aa4199b13bb58e03906eb
Reviewed-on: https://gerrit.instructure.com/56971
Tested-by: Jenkins
Reviewed-by: Nathan Mills <nathanm@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Weston Dransfield <wdransfield@instructure.com>
Refs: CNVS-21032
This commit introduces a new and improved checkbox-that-
looks-like-a-toggle-switch, designed to address the
problems with the original .ic-Toggle.
Note: This toggle is NOT being used anywhere right
now except the styleguide.
Test Plan:
- In either Canvas UI, go to
[canvas-url]/styleguide#forms
- Scroll down until you reach the Super Toggle
Checkbox section.
- Test the new super toggle checkbox in supported
browsers.
Change-Id: I092fd0d45c6efef178a276d78e618391a3cfa715
Reviewed-on: https://gerrit.instructure.com/56219
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Tested-by: Jenkins
QA-Review: Nathan Rogowski <nathan@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
to improve average performance
refs #CNVS-21317
Change-Id: I018416dea776d0dc235f5882682a3faa11561d3d
Reviewed-on: https://gerrit.instructure.com/57066
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
test plan:
* import a sis csv file longer than 4096 bytes with utf8 characters
split at the 4096 byte point
* should not fail with "Invalid utf-8 error"
closes #CNVS-20678
Change-Id: I642f24391bfaed48e16130989710056664ab4fd5
Reviewed-on: https://gerrit.instructure.com/56918
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
test plan:
* hide the files navigation tab for a course
* as a student, the files tab in the wiki sidebar should not be
shown
closes #CNVS-20096
Change-Id: Id7b7dd6f501e1e2941714fe743113c0ae8dc5766
Reviewed-on: https://gerrit.instructure.com/56931
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Ryan Taylor