without a __FILE__ passed to instance_eval with a string, ruby wasn't
giving backtraces for anything below, even after calling back to non-evaled
code
Change-Id: Iee74423f7839bbbb44c9a3761220a045d8071681
Reviewed-on: https://gerrit.instructure.com/57377
Tested-by: Jenkins
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Test Plan:
- If it passed Jenkins, it is good.
Change-Id: I16d10300bf21a6d97f5520075230cdf66abcca4e
Reviewed-on: https://gerrit.instructure.com/57286
Tested-by: Jenkins
Product-Review: Ryan Taylor <rtaylor@instructure.com>
QA-Review: Ryan Taylor <rtaylor@instructure.com>
Reviewed-by: Mike Nomitch <mnomitch@instructure.com>
- Adds radio button for Edit Settings Module for CNVS-20853
- Changes prerequisite list to the header of the module
- adds "pill" info section that says if this is an ALL or OR type of module
- Features will be behind a feature flag
Change-Id: Iee0c32234a49eb3d4ac7fcd5d7ff7b1309d0d53f
Reviewed-on: https://gerrit.instructure.com/56297
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>
Tested-by: Jenkins
refs CNVS-19605
Note: added two new icons to the canvas iconset (equation, equella)
Test plan:
- Enable the kaltura plugin at /plugins/kaltura (see https://gollum.instructure.com/OtherServiceTestAccounts#Notorious-(NO-MORE-KALTURA-YAY))
- Enable the Equella feature for the account
- Verify that the link, image, equation, record video and equella icons are updated (http://cl.ly/image/2H3m331w0f1O)
- Hover states should match the other menu buttons
Change-Id: I91c298f3dcb2146748d6104342aa265eb43462e9
Reviewed-on: https://gerrit.instructure.com/56283
Tested-by: Jenkins
Reviewed-by: Colleen Palmer <colleen@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Fixes CNVS-21134
The cog dropdown was being cut off when positioned on
the rightmost side of a div with a #content id because
it had overflow set to hidden.
Test Plan:
-Navigate to the calendar, then to the scheduler. Create
an appointment group. Select the cog dropdown on the
right side of the appointment group. It should not be
cut off.
-Create a course with modules. Set the course home page
as the modules page. Select any of the cog dropdowns on
the any of the modules. None of them should be cut off.
-Navigate to people within a course. Select the cog
dropdown on any person. It should not be cut off.
Change-Id: I5614665eae65d03e6689e5705fdf2806c5390150
Reviewed-on: https://gerrit.instructure.com/57197
Tested-by: Jenkins
Reviewed-by: Colleen Palmer <colleen@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
QA-Review: Adrian Foong <afoong@instructure.com>
Fixes CNVS-206051
Testing Plan:
1. Go to the Modules page.
2. Press the "," key to open the menu to see what the hotkeys are.
3. Try out all the listed shortcut keys (j, k, e, d, i, o, n, up, down, space)
to ensure they work as expected
Change-Id: I45cde62c38684394008a01a08ddb5d9a9e1d1342
Reviewed-on: https://gerrit.instructure.com/55094
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>
This is for cleanup and to use against a script that will parse the lines
Test plan: pass jenkins
Change-Id: Ic019897d974f11e19f797c228b738f843ebdf1dd
Reviewed-on: https://gerrit.instructure.com/57325
Tested-by: Jenkins
Reviewed-by: August Thornton <august@instructure.com>
QA-Review: Derek Hansen <dhansen@instructure.com>
Product-Review: Derek Hansen <dhansen@instructure.com>
test plan:
* set up sso on a different shard
* log in via twitter
* it should work
Change-Id: If6c52892342cae513701c925087a23678b818e6d
Reviewed-on: https://gerrit.instructure.com/57312
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
test plan:
* syllabus should work as before
* modules loading of assignment due dates should work
as before
* assignments api should work as before
refs #CNVS-21476 #CNVS-21317
Change-Id: Iba183d6fda604acb29e9685f0f32be74ad27b898
Reviewed-on: https://gerrit.instructure.com/57215
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
we are swallowing a bunch of errors in broadcast policy methods that
check differences in workflow state between the old and new objects.
instead, let's let these fail and fix bugs that may come from using
these methods incorrectly.
fixes CNVS-21212
test plan:
- this would manifest itself as a error when trying to check the
conditions for whether or not to send a notification on the following
models:
* announcement
* assignment
* calendar
* content_export
* course
* discussion
* enrollment
* group_membership
* quiz_submission
* submission
* wiki
- so the best way to test is to get notifications to send for these
models under different conditions and make sure they work correctly
Change-Id: Ia9d6d0c37101b2d0859d5753835227d314955c3d
Reviewed-on: https://gerrit.instructure.com/54541
Tested-by: Jenkins
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
test plan:
* activate the api one of the following ways:
* install a post_grades lti tool
* enable the bulk_sis_grade_export feature
* GET /api/sis/accounts/:account_id/assignments
* published assignment details for the account should be returned
* results should be paginated
* GET /api/sis/courses/:course_id/assignments
* published assignment details for the course should be returned
* results should be paginated
closes CNVS-20944
Change-Id: Iab5d9ac03d9aa29cad3ebdf74e4f48eb14c4a709
Reviewed-on: https://gerrit.instructure.com/56653
Tested-by: Jenkins
Reviewed-by: Andrew Butterfield <abutterfield@instructure.com>
QA-Review: Derek Hansen <dhansen@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
Product-Review: Mark Severson <markse@instructure.com>
Completes the intent of c6e91b57e5
Test Plan:
- Fixes plugins build.
Change-Id: I1d755978da59eb6ab25d2a0694e1baa04d4ebca2
Reviewed-on: https://gerrit.instructure.com/57294
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins
Product-Review: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
test plan: a user in a custom account role that enables
"View all grades" permission, but does _not_ enable
"Manage courses", should be able to view grader comments
on a rubric in SpeedGrader
fixes CNVS-5563
Change-Id: Ib80bb49aaa6db0bf54c131e5917b5c8f5caa1f8a
Reviewed-on: https://gerrit.instructure.com/57246
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
closes CNVS-21036
Test Plan
- As admin go to Settings and find the new styles flag
- Instead of "Use New Styles" the label should now say "New UI"
- The dropdown description should say "This enables an updated
navigation, new dashboard and a simpler, more modern look and feel."
Change-Id: I92cc5a9a4f28bc23f638500cfbbc280550858b47
Reviewed-on: https://gerrit.instructure.com/57000
Tested-by: Jenkins
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Fixes: CNVS-21372, CNVS-21367, CNVS-21354
Small edits based on feedback from customers
at InstCon.
I also improved the dashboard card :hover and
:focus states. If the UI is not high contrast,
:hover/:focus is indicated by a subtle animation
of the course name, as well as a slight darkening
of the card background color. In high contrast,
the user still gets the underline.
I also reduced the padding/margin between the cards
and the padding of the main container slightly
so the cards don't look as scrunched up btw
~900-1100px, when there are three columns but the
middle container is pretty small.
Test Plan:
- Make sure the Use New Styles feature flag is ON.
- The entire dashboard card header (the colored part)
should now be clickable as a link
- Long course names should wrap instead of becoming
ellipses.
- In the dashboard card "actions" area (the links at
the bottom), the icon for Files should be a
folder icon, not a suitcase icon.
Change-Id: I8c5580fb27899bacfd16a5e3c4c1011b68f6ad06
Reviewed-on: https://gerrit.instructure.com/57025
Tested-by: Jenkins
Reviewed-by: Colleen Palmer <colleen@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Adds a spec to test js_env is set correctly for external content
controller
Fixes PLAT-1123
Test Plan:
run the spec
Change-Id: Ia041095089ea79192db6224b706441d2e9cc26ab
Reviewed-on: https://gerrit.instructure.com/57289
Reviewed-by: Nathan Mills <nathanm@instructure.com>
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
Product-Review: Brad Horrocks <bhorrocks@instructure.com>
if they're not valid UTF-8, interpret them in CP437 (which is
the original encoding used by PKZIP)
test plan: you should be able to upload and extract the
zip file attached to the ticket
fixes CNVS-21430
Change-Id: Ieaf16b03b390403ceec406ec27535c4da20eb6be
Reviewed-on: https://gerrit.instructure.com/57118
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
test plan:
- in a root account's Sub-Accounts tab,
- create a subaccount containing no courses (directly),
but a sub-sub-account with courses
- try to delete the subaccount
- you should get an error message indicating the subaccount
can't be deleted because it contains courses
fixes CNVS-21463
Change-Id: I8542d51d992658e4fa852d9a7aaa1e72798ab769
Reviewed-on: https://gerrit.instructure.com/57149
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
fixes CNVS-21040
Users who have view permissions but do not have edit permissions should
be able to export the gradebook to a CSV file. (For example, TAs might
have these permissions)
Previously, there was an "Export" button, but it would cause an error
when clicked
Test plan:
* Create or edit a role in which users can view grades but cannot edit
grades
* Enroll a user with this role in a course
* Ensure that this user is able to export the gradebook to a CSV file
Change-Id: I2494bb8598ffb70bf55303c0b589f03213ec6d99
Reviewed-on: https://gerrit.instructure.com/56980
Tested-by: Jenkins
Reviewed-by: Dylan Ross <dross@instructure.com>
QA-Review: Jason Carter <jcarter@instructure.com>
Product-Review: Christi Wruck
fixes CNVS-21172
somewhat related to CNVS-21106
Rounds grade totals in the gradebook to 2 decimal places when the option
"Set Group Weights" > "Weight final grade based on groups" is enabled.
It previously rounded correctly when this setting was disabled; the
behavior when this setting was enabled was overlooked
Note that trailing zeros will not be shown. For example, a score of
exactly 73.3% will be shown as "73.3%" rather than "73.30%"
Test plan:
* Go into the gradebook, click on the options gear, and enable the
checkbox under "Set Group Weights" > "Weight final grade based on
groups"
* Ensure that the total grades are rounded to 2 decimal places
* In general, make sure all grade displays in the gradebook are rounded
to 2 decimal places
Change-Id: I91600cf1daa86e4c5a8cb4b6a1fe7a05d4ceef49
Reviewed-on: https://gerrit.instructure.com/57022
Tested-by: Jenkins
Reviewed-by: Cameron Matheson <cameron@instructure.com>
QA-Review: Derek Hansen <dhansen@instructure.com>
Product-Review: Christi Wruck
fixes CNVS-16062
I paired with Andrew Huff on this work.
Test plan:
1. Create a media recording assignment
2. Submit a media recording as a student.
3. Go to the individual view gradebook.
4. Select the media assignment
5. Verify the submissions download button is not displayed.
Change-Id: I6f2dcba45b887ff5d6854e4d48a0837c43006276
Reviewed-on: https://gerrit.instructure.com/55679
Tested-by: Jenkins
QA-Review: Nathan Rogowski <nathan@instructure.com>
Reviewed-by: Josh Simpson <jsimpson@instructure.com>
Product-Review: Strand McCutchen <smccutchen@instructure.com>
Product-Review: Christi Wruck
fixes CNVS-18645
When a teacher clicks on a online url submission link
it should behave like an external link and open in
a new tab. This behavior should be maintained even if
the link is internal.
Test plan:
0. In a published course with students…
1. Add a URL submission assignment and publish it.
2. As a student submit http://placekitten.com as
the assignment submission.
3. As a teacher view the submission in speedgrader,
and click the submission links in the left frame.
4. Confirm that these links open in a new tab or window.
Change-Id: Id2dc922b0b942344bcc88f56e565bd71105cb48f
Reviewed-on: https://gerrit.instructure.com/53115
Tested-by: Jenkins
Reviewed-by: Dylan Ross <dross@instructure.com>
QA-Review: Adrian Foong <afoong@instructure.com>
Product-Review: Christi Wruck
Fixes CNVS-20858 and CNVS-20711
Test plan:
- Create a quiz with a matching question
- Add comments on the matching answers and save
- Edit matching question and save
- Edit and preview quiz, maching prompts should be correct
Change-Id: I9ce30aef94769bf353fface3e5ea656af3dfbc5b
Reviewed-on: https://gerrit.instructure.com/57238
Tested-by: Jenkins
Reviewed-by: Ryan Taylor <rtaylor@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Product-Review: Brian Finney <bfinney@instructure.com>
LTI link in iframe with thumbnail
LTI link as url to new window
LTI link as iframe
Regular URL in current frame
Regular URL in iframe with thumbnail
Fixes: PLAT-1122
Test Plan:
Regression test LTI Launches in TinyMCE :D
Change-Id: I2b43398a2cdc4707e898a68848e7260adc9a4079
Reviewed-on: https://gerrit.instructure.com/57122
Tested-by: Jenkins
Reviewed-by: Nathan Mills <nathanm@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Brad Horrocks <bhorrocks@instructure.com>
closes CNVS-21519
Unable to make use of Canvas.timeout stuff because this is a seperate
gem which shouldn't reach into canvas, so set timeout at 30s.
TEST PLAN:
1) google drive collaboration regression (behavior should not change)
Change-Id: I310421c32070ef149b26713cf4e0fabceb0e8203
Reviewed-on: https://gerrit.instructure.com/57229
Reviewed-by: Brad Horrocks <bhorrocks@instructure.com>
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
test plan:
* modules index should behave as before
refs #CNVS-20706 #CNVS-21317
Change-Id: Iaf51ec861adb0f0189d30aa0c29f3c2e94159d62
Reviewed-on: https://gerrit.instructure.com/57179
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
test plan:
* create a course with a student
* create an assignment
* create a module and add the assignment
as an item
* add a completion requirement to submit the
assignment
* in the gradebook, mark a grade for the student
in the assignment
* as the student, it should not show the requirement
as completed
* it should still complete on assignment submission
* should still work with quiz assignments as well
closes #CNVS-21460
Change-Id: I8bbc306c067a3bed7da7a9fc0cd00d3e046b1293
Reviewed-on: https://gerrit.instructure.com/57183
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
Adds recurring calendar events feature.
closes CNVS-19381
Test Plan:
* As a teacher, go to the Calendar
* Click the "+" (Create New Event) button
* Add some event details, then check the "Repeat"
checkbox
* Additional fields should appear regarding repeat
information
* Change the repeat fields, then save the event
* The event should create, then the calendar should
reload and show the duplicated events
Change-Id: I2923721edb773bbe0c7b228554b21389ea0ea153
Reviewed-on: https://gerrit.instructure.com/51976
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
Every time we add an event type, we get a blank bar on the event log.
This ticket defaults to ignoring events which we are explicitly
handling.
Closes CNVS-21195
Test Plan:
- View the QLA log view for any recently completed quiz submission
and see that there are no blanks anymore.
Change-Id: I11d3b2cb315fa6d884c12633ece10119802f3b83
Reviewed-on: https://gerrit.instructure.com/56833
Tested-by: Jenkins
Reviewed-by: Brian Finney <bfinney@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Product-Review: Jason Sparks <jsparks@instructure.com>
fixes CNVS-21231
test plan:
- try to create an outcome with a friendly name > 255 characters
- you should get an error in the app that explains the problem
- also try with the API, you should get a 400 error
Change-Id: Ie69a57d6ae05a35cd6878dac3a5fc5bbca288f1c
Reviewed-on: https://gerrit.instructure.com/56838
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Reviewed-by: Benjamin Porter <bporter@instructure.com>
Tested-by: Jenkins
Product-Review: Simon Williams <simon@instructure.com>
Transifreq