Fixes: CNVS-21594
Code Review Test Plan:
- You will need to install Roll Call locally
- Lucky for you, the instructions are awesome, and it
takes all of 10 minutes:
https://gollum.instructure.com/Rollcallhttps://gollum.instructure.com/OtherServiceTestAccounts
- Make sure the Use New Styles feature flag is ON
- Go to a course, and click on Attendance in the
context menu
- The Roll Call layout should now look like this,
with the LTI tool iframe taking up any available
space between the breadcrumbs and the footer:
http://cl.ly/image/1j1B2t1W0Y2M
***
QA Note: I was unable to test this on IE10 because
Virtual Box wouldn't load Roll Call inside Canvas
due to security restrictions. If possible, please
test in IE10 to make sure we're good there. Thanks!
***
Change-Id: I3a0ef522f1fd72a367d867a1674ca43b1cfcacb5
Reviewed-on: https://gerrit.instructure.com/57429
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Tested-by: Jenkins
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
The content migrations for outcomes importing are not scoped to an account
or a course, since the academic benchmarks standards are imported globally
per shard.
Fixes CNVS-21782
Test Plan:
1. Kick off an outcomes import task
- curl -H 'Authorization: Bearer <api-key>'
--data 'guid=<some-guid>'
'http://<canv-domain>/api/v1/global/outcomes_import'
2. Query it through this endpoint and make sure it works
- curl -H 'Authorization: Bearer <api-key>'
'http://<canv-domain>/api/v1/global/outcomes_import/migration_status/<migration-id>'
Change-Id: I8ff3a5206bb7aa5f97d615912c60341fedcaf855
Reviewed-on: https://gerrit.instructure.com/58034
Tested-by: Jenkins
Reviewed-by: Cameron Sutter <csutter@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Product-Review: Benjamin Porter <bporter@instructure.com>
turn back; it's too late to change now
refs #CNVS-21596
Change-Id: Ia2ed649e9ee700219479cee7aab48c51fe4d6c4b
Reviewed-on: https://gerrit.instructure.com/58052
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Tested-by: Jenkins
fixes: CNVS-21379
This allows the Canvas Preview in Theme Editor mode to stay in one place
when the Theme Editor UI extends the high enough to scroll.
Test Plan:
- Go to theme editor
- Click on Watermarks area
- You should now be able to scroll through the items in the Theme Editor UI
while the Preview on the right remains on the screen (doesn't scroll out of
browser window)
Change-Id: Ifa38b745084b3a8f12dfe05b2988b2fa7527a40c
Reviewed-on: https://gerrit.instructure.com/56396
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Tested-by: Jenkins
QA-Review: Myller de Araujo <myller@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
fixes: CNVS-21432
This brings our secondary blue color back to the darker blue we had originally
had in there.
Test Plan:
- Turn on new ui
Main navigation background:
- Was: http://cl.ly/image/0i2v0E0v0D3u
- Is now: http://cl.ly/image/0u2w270h0b0j
Change-Id: Ib729395d4449f949d190cdd7b59c70a6da2a623e
Reviewed-on: https://gerrit.instructure.com/57862
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Tested-by: Jenkins
QA-Review: Myller de Araujo <myller@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
refs: CNVS-20551
We had a few inline styles that we wanted to move into the main Theme Editor
stylesheet for consistent css.
Test Plan:
- Go to theme editor
- Nothing should change
What could change if this isn't working:
- overlay for preview wouldn't appear
- iframe would be in a small window (not reach the full height of the screen)
Change-Id: I700095bce2139547280f1dca2551f69231058724
Reviewed-on: https://gerrit.instructure.com/56394
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Tested-by: Jenkins
QA-Review: Myller de Araujo <myller@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
fixes: CNVS-20551
This adds the final UX polish to bring it up to par with what UX wants
theme editor to look like. This fixes the ui for the theme editor ui
when you upload an image. It also tweaks the Windows logo upload and
the tile color helper text.
Please take a look at this screen for comparison:
http://cl.ly/image/2q1g1Q0R3C3t
Test Plan:
- In new UI go to theme editor
(Account Settings > Open Editor)
- The theme editor UI should now resemble the above screenshot
Change-Id: I986504edcddd84f6954916a71f1618c28ed94699
Reviewed-on: https://gerrit.instructure.com/56392
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Tested-by: Jenkins
QA-Review: Myller de Araujo <myller@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
refs: PFS-2071, PFS-2072, PFS-2073, PFS-2074
**Test Plan
PFS-2071
1. Create course with assignment, teacher and two students
2. setup peer reviews on assignment
3. As student 1 create a submission
4. As student 2 peer review submission, leave comments
5. execute the following api courses/:course_id/assignments/:assignment_id/peer_reviews
6. As account admin all information should be shown
7. As teacher all information should be shown
8. As student should see all information
9. Repeat above but set anonymous peer reviews on assignment
10. As account admin all information should be shown
11. As teacher all information should be shown
12. As student should see comments but all reviewer
information should not be shown
13. include the following include parameters, include[]=submission_comments,
include[]=user make sure additional information is shown according to parameter.
PFS-2072
1. Follow setup from PFS-2071
2. execute a get on the following api
/api/v1/courses/:course_id/assignments/:assignment_id/submissions/:submission_id/peer_reviews
3. validate that only peer reviews for the given submission are shown
PFS-2073
1. Follow setup from PFS-2071
2. execute a post on the following api, including a user_id parameter
/api/v1/courses/:course_id/assignments/:assignment1_id/submissions/:submission_id/peer_reviews
3. validate that user from user_id parameter is added as a reviwer on the submission
PFS-2074
1. follow setup from PFS-2071
2. execute a delete on the following api, including a user_id parameter
/api/v1/courses/:course_id/assignments/:assignment1_id/submissions/:submission_id/peer_reviews
3. validate that user from user_id parameter is removed as a reviewer on the submission
(cherry picked from commit 91744bbcd5a81be968139b1f68b65c3e9eaa7b4a)
Change-Id: Ic09a16956cddb2f113625ff61bc733503d713abb
Reviewed-on: https://gerrit.instructure.com/56936
Tested-by: Jenkins
QA-Review: Adam Stone <astone@instructure.com>
Reviewed-by: John Corrigan <jcorrigan@instructure.com>
Product-Review: Brandon Broschinsky <brandonbr@instructure.com>
refs: PFS-2039, CNVS-18186, PFS-2040, CNVS-18187
**Test Plan
1. Create assignment in course
2. require peer reviews on assignment, and select anonymous peer
reviews.
3. create a couple student enrollments in course, and teacher
4. assign peer reviews for assignment
5. as on student submit an assignment.
6. as a user assigned to peer review go to home page make sure
anonymous user shows for user on peer review.
7. go to perform peer review, make sure the students name
who made the submission doesn't show.
8. make comment on review and make sure anonymous user shows
when student reviews comments.
9. do the above without anonymous review checked and make sure
the names are visible.
1. Enable crocdoc
2. submit an assignment with an attachment for an assignment
with anonymous peer reviews.
3. review assignment in crocdoc, user should not be able
to view or create annotations.
1. make sure that anonymous peer reviews are available when creating
an assignment
2. make sure anonymous peer reviews are not available when creating
a graded discussion.
Change-Id: I30220042ab9e30b226385398c63eb8792e640197
Reviewed-on: https://gerrit.instructure.com/56624
QA-Review: Adam Stone <astone@instructure.com>
Reviewed-by: John Corrigan <jcorrigan@instructure.com>
Tested-by: Jenkins
Product-Review: Brandon Broschinsky <brandonbr@instructure.com>
closes CNVS-21601
test plan:
- Differentiated Assignments should be on for all courses in all accounts
Change-Id: I24142a2e8e20186c62de5ef8db909e13b87f44e6
Reviewed-on: https://gerrit.instructure.com/57502
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Reviewed-by: Mike Nomitch <mnomitch@instructure.com>
QA-Review: Jason Carter <jcarter@instructure.com>
Product-Review: Cameron Sutter <csutter@instructure.com>
fixes: PFS-2181, PFS-2182
**test plan
1. execute an api to request to retrieve a course
2. validate that grading_standard_id is part of the result object
3. do validation with/without standard set
4. update/create a course via api, validate that
grading_standard_id is included in response
Change-Id: Ia0a9a4945035b0b1291883b4db10bef98413ee52
Reviewed-on: https://gerrit.instructure.com/57678
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Pedro Fajardo <pfajardo@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
Fixes PLAT-1118
Test Plan
Make sure auto_create: false is sent as a post param during a content item selection request
Change-Id: I092e99d282be0d2b33489b0ac2acc95d5a3777f8
Reviewed-on: https://gerrit.instructure.com/57277
Tested-by: Jenkins
Reviewed-by: Nathan Mills <nathanm@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Weston Dransfield <wdransfield@instructure.com>
Fixes PLAT-1120
Test Plan
- Make sure the link labeled 'Canvas Community topics about Lti topics'
is no longer in the paragraph at the top of the external apps settings page.
Change-Id: Icf14d1a1c3fbbc702a41c1435abcc48972409de2
Reviewed-on: https://gerrit.instructure.com/57037
Tested-by: Jenkins
Reviewed-by: Brad Horrocks <bhorrocks@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Weston Dransfield <wdransfield@instructure.com>
also random spec file tweak
refs #CNVS-21596
Change-Id: Ia009265af517e7902cd915b48eb8d08d75ee1d74
Reviewed-on: https://gerrit.instructure.com/57828
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
with_exclusive_scope is deprecated
refs #CNVS-21596
Change-Id: I5f7d2744f8084a032100b54cf0d34118373e59ce
Reviewed-on: https://gerrit.instructure.com/57812
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
refs #CNVS-21596
Change-Id: Ic27fed7ce841b439476e65932dd52f8fec38e37b
Reviewed-on: https://gerrit.instructure.com/57814
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
test plan:
* create a discussion topic locked by date in the past
(i.e. now "closed for comments")
* copy the discussion topic to a new course, using the
"Remove Dates" option
* the new topic should not be locked
closes #CNVS-21707
Change-Id: I9e8adcaa5f8694da23172bcc1938a029f6cd0d9a
Reviewed-on: https://gerrit.instructure.com/57811
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Stephen Jensen