since this new class descends from RuntimeError, the current
SisBatch#process error handling will catch the exception.
closes#4416
Change-Id: I91ac80650a4a214c469185012523d8a078d7bd12
Reviewed-on: https://gerrit.instructure.com/3502
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Zach Wily <zach@instructure.com>
The verbiage said peer reviews were "due" at a certain
date, but the code was actually using that date to decide
when to *assign* the peer reviews. This starts the
process of renaming that column.
fixes#4118
Change-Id: I1c476c97495de6fa0c76ff33658b37ffa02e9022
Reviewed-on: https://gerrit.instructure.com/2958
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
Tested-by: Brian Whitmer <brian@instructure.com>
note that we still call fillFormData for replies. this just ensures we
don't bring along the previous body, attachments, recipients, etc.
Change-Id: I986813ae2f31dcaf55412c25073eff525431f1ad
Reviewed-on: https://gerrit.instructure.com/3484
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Whitmer <brian@instructure.com>
A typo "responds_to instead of respond_to" was throwing an exception,
which was getting swallowed by our rescue-all.
Change-Id: I38193ed8035cd656e6c03e81e7eee2419165212b
Reviewed-on: https://gerrit.instructure.com/3490
Reviewed-by: Zach Wily <zach@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
Refactor to use it in places where it makes sense. This eliminates all
the places where were were calling File.read or otherwise reading into
memory potentially large files just to write them back out.
Change-Id: I679ce9979933140340b30cc043540ca3f834097e
Reviewed-on: https://gerrit.instructure.com/3324
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
Students can now opt-in to receiving actual scores
in email/sms/facebook notifications about homework
grades. This ability can be manually disabled at
the root account level if necessary.
fixes#4479
Change-Id: I1b769bef140719578fa345ca519999a2834b00f8
Reviewed-on: https://gerrit.instructure.com/3473
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
before, the javascript would die because it is all
designed expecting there to be students.
Change-Id: I164d9cb7c3706b6afef810c9f054b3b367d9974b
Reviewed-on: https://gerrit.instructure.com/3463
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Whitmer <brian@instructure.com>
broke because there is no longer an Object#to_csv
but there is an Array.to_csv
Change-Id: I0569f5a6111ad18871c59b5674b535165273b4c9
Reviewed-on: https://gerrit.instructure.com/3464
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
The current link only worked for collaborations associated with
courses, not any type of group. For groups, we need to use the full
collaboration ID in the URL, since there is no collaborations tab.
Also, we need to use base_ar_class, since it might by a
CourseAssignedGroup.
Change-Id: Idf215ce5c3d922bffb7c47cf17e0ff0dab21cab1
Reviewed-on: https://gerrit.instructure.com/3445
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Whitmer <brian@instructure.com>
fixes#4477
long-term we should probably move a lot of this data out of this column.
Change-Id: Ib2bc853eb7c3fe4d3c79240d3a5a491c1b2e41fc
Reviewed-on: https://gerrit.instructure.com/3471
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
turns out that in firefox, setTimeout(someFn) will pass a "lateness"
number value as the first parameter to someFn
http://benalman.com/news/2009/07/the-mysterious-firefox-settime/
therefore, first_time was always true and firefox looped forever for any
files sidebar with > 50 files
Change-Id: Iabb4981ae42eb810123df14cba9e837eb1f9f128
Reviewed-on: https://gerrit.instructure.com/3461
Reviewed-by: Zach Wily <zach@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
i.e. when "No student have been added for this course"
Change-Id: I739a227999268d4bccd804e70ed6075ed32665d0
Reviewed-on: https://gerrit.instructure.com/3457
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Some of the migrators for external migrations separate
announcements from discussions. This just tags all those
announcements as such so they'll be imported correctly
closes#4463
Change-Id: I9379f679665a7414098eaa84860c4b399ea1fd50
Reviewed-on: https://gerrit.instructure.com/3452
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Bracken Mosbacker <bracken@instructure.com>
Cody Cutrer