Fixes CNVS-10783
Test plan:
- Create a course
- Create a group in said course
- Add a user to said group
- As the user, visit /groups and ensure you see the group that
you were added to under "current groups"
- Conclude the course
- As the user, visit /groups and ensure you now see the group
under "previous groups"
- Do the same thing but with the course being soft concluded
(i.e. set a course end date that's in the past instead of
using the "conclude course" button)
- Have both a group in a concluded course and a group in an
active course at the same time and ensure that they still
show up correctly
Change-Id: Ibb940239a8604455d418111ef60c30d0cb3113d4
Reviewed-on: https://gerrit.instructure.com/57431
Reviewed-by: Andrew Butterfield <abutterfield@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
Tested-by: Jenkins
QA-Review: Adrian Russell <arussell@instructure.com>
This commit adds a button to assignments so that they can
get to a moderation page. It adds the necessary routes and
views to support that. It currently has a react app placeholder
that will become the actual moderation screen.
closes CNVS-22003
refs CNVS-21960
refs CNVS-22197
Test Plan:
- Enable Moderated Grading
- As a Teacher:
* Create an assignment making sure to check the option to allow
moderated grading.
* Publish the assignment
* A Moderate button should appear.
* Unpublish the assignment
* The moderate button should disappear.
* Publish it again and click on the moderate button.
* You should see a page that says "ModerationApp Placeholder"
* Edit the assignment and turn off moderated grading
* Go to <canvas_url>/courses/<course_id>/assignments/<assignment_id>/moderate
* You should see a Page Not Found message
* Re-enable moderated grading
- As a regular student:
* Attempt to go to:
<canvas_url>/courses/<course_id>/assignments/<assignment_id>/moderate
* You should get an unauthorized message
Change-Id: I3bbe06bdf6e999d4ab0947903aa5b863f2cf19e5
Reviewed-on: https://gerrit.instructure.com/61461
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
fixes CNVS-22712
test plan
- regression test conversations, especially things involving
changing recipients (adding recipients to an existing convo,
forwarding)
Change-Id: I01628a0b9ed5c56a05ae8515c540f5f189973cc3
Reviewed-on: https://gerrit.instructure.com/61799
Tested-by: Jenkins
Reviewed-by: Matthew Wheeler <mwheeler@instructure.com>
QA-Review: Adrian Russell <arussell@instructure.com>
Product-Review: Joel Hough <joel@instructure.com>
fixes CNVS-21057
test plan:
- go to assignment edit page
- insert this string into the box
"//<<>> foobar"
- highlight that string and turn it
into a link using the sidebar
- the link shows up with the text
you inputted, not an escaped version
- try with some other strings
(and a <script> tag that tries to
alert something)
Change-Id: I88f11b770c71b039255a6ece799479fce869c754
Reviewed-on: https://gerrit.instructure.com/61751
Tested-by: Jenkins
Reviewed-by: Jacob Fugal <jacob@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Jacob Fugal <jacob@instructure.com>
fixes CNVS-20291
test plan:
- make a page & set it to the front page
- go the pages (you'll see this page)
- keyboard navigate over to the settings menu
and open it with enter or space
- the Delete option should be diabled but it
should still have an outline showing that
focus is on it
- hitting the down arrow makes the outline go away
(when you focus on something else)
Change-Id: Icbb160adce00f2924a5ab9e503e6d6e3699e8d72
Reviewed-on: https://gerrit.instructure.com/61781
Tested-by: Jenkins
Product-Review: Nathan Rogowski <nathan@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Reviewed-by: Jacob Fugal <jacob@instructure.com>
fixes PFS-2345
Test Plan:
* perform GET /api/v1/courses/:course_id/outcome_results
* in URL param user_ids[], pass in a sis_user_id in format
user_ids[]=sis_user_id:1234
* verify results
Change-Id: I76c8cca719ffa33863fd3056526c69241ee4fec8
Reviewed-on: https://gerrit.instructure.com/60416
Reviewed-by: John Corrigan <jcorrigan@instructure.com>
Tested-by: Jenkins
QA-Review: Adam Stone <astone@instructure.com>
Product-Review: Nick Nelson <nick@instructure.com>
fixes CNVS-20648
test plan:
- add enough LTI tools that the blue
'More External Tools' button shows
up on TinyMCE
- use keyboard to navigate to this button
- enter & space both open the dropdown
- he up/down arrows allow you to navigate
in it
Change-Id: Id00c3c864f2f2e177ce5b3e6e9c332d65f5a6cb9
Reviewed-on: https://gerrit.instructure.com/61695
Tested-by: Jenkins
Reviewed-by: Jacob Fugal <jacob@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Product-Review: Nathan Rogowski <nathan@instructure.com>
FIxes CNVS-20918
Test Plan
- There should be a flash message notifying successful deletion
when a Discussion or Announcement is deleted.
Change-Id: I2cb5a1407a40ba54d3eb4156d64c0f43fac2cf1f
Reviewed-on: https://gerrit.instructure.com/60685
Reviewed-by: Matt Berns <mberns@instructure.com>
Tested-by: Jenkins
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
fixes CNVS-22117
test plan:
Prerequisites: A course that is not concluded in any way,
with a student enrolled and an online submission assignment
that is available for submission.
- As the student - submit a file for the assignment.
- Go to your personal files page (click on name or settings in the global nav - top right, then files)
- Try to delete the file you submitted
- Observe that you receive an "Unauthorized" message.
- As the teacher, view the student's submission in SpeedGrader and click on the download icon for the submitted file
- Should be able to download still
Change-Id: I299249ca0e1287002972bb1f6916a3d52b828a9c
Reviewed-on: https://gerrit.instructure.com/61576
Tested-by: Jenkins
Reviewed-by: Ryan Taylor <rtaylor@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Jason Sparks <jsparks@instructure.com>
fixes CNVS-22054
Test plan:
1. Create a course with assignments in past grading periods,
future grading periods, current grading periods, and
assignments without due dates.
2. Export the gradebook from that course.
3. Confirm that assignments in the current grading period
are exported.
4. Confirm that assignments without due dates are exported.
5. Confirm that assignments in past grading periods
are NOT exported.
6. Confirm that assignments in future grading periods
are NOT exported.
Change-Id: Ie2dde8673196d53fc7d7fd41ae3d833b4ab50cd9
Reviewed-on: https://gerrit.instructure.com/59804
Tested-by: Jenkins
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
QA-Review: Jason Carter <jcarter@instructure.com>
Product-Review: Strand McCutchen <smccutchen@instructure.com>
refs CNVS-22335
Test Plan:
- Load up files, make sure the usage indicator in the bottom
left corner is working.
Change-Id: I9ca11f4e8307947aa1c9411de89ae84681866e2e
Reviewed-on: https://gerrit.instructure.com/61587
Tested-by: Jenkins
Reviewed-by: Dan Minkevitch <dan@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
test plan:
* create a locked file in a course
* soft-conclude the course for a teacher
by restricting term dates to the past for teachers
* the teacher should still be able to download and
preview files in the course
closes #CNVS-22702
Change-Id: Ifd672aacaa99a30e758f68760d22a692ba37f443
Reviewed-on: https://gerrit.instructure.com/61759
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
fixes CNVS-19985
test plan
- have an account with an adobe conference
- misconfigure adobe connect (by putting in an invalid domain,
for instance)
- view the conference index page
- ensure that the index renders without the adobe conferences and
an error is flashed at the top of the page saying some conferences
are hidden
- ensure that an error report appears with a conference related
error
Change-Id: Iaf33cf88f8da4b29f57209b3a728afe58bffc277
Reviewed-on: https://gerrit.instructure.com/59997
Reviewed-by: Matthew Wheeler <mwheeler@instructure.com>
Tested-by: Jenkins
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Peyton Craighill <pcraighill@instructure.com>
Closes CNVS-21521
Test Plan:
- Regression test that due_dates, closing "end_at" dates and all
things quiz time limits/moderation are all good.
- Good luck!
Change-Id: Id5ad6c0028e06e67caea28fce514190730a02e44
Reviewed-on: https://gerrit.instructure.com/59020
Tested-by: Jenkins
Reviewed-by: Cameron Sutter <csutter@instructure.com>
Product-Review: Pedro Fajardo <pfajardo@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
refs #CNVS-22013
Change-Id: I896d0e7cab498c40d76cce9e3aa450eda66bd548
Reviewed-on: https://gerrit.instructure.com/61521
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
we already have logic in Canvas::Security to
protect us against brute force, and AuthLogic
is just checking the updated_at to see if they can
attempt to login again if failed_login attempts is
over 50
fixes CNVS-22681
test plan
- update a pseudonyms failed_login_count to > 50
- p = Pseudonym.last
- p.failed_login_count = 54
- p.save!
- attempt to login
- it should work
Change-Id: I72ebf54306c4fe6bd46d172d31b8f732555107a7
Reviewed-on: https://gerrit.instructure.com/61595
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Reviewed-by: Jacob Fugal <jacob@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
test plan:
- enable moderated grading for an assignment
- confirm that teachers/TAs in SpeedGrader create and edit
provisional grades:
1. each grader's assigned grades and submission comments
persist for that user, but are not visible to other
graders
2. grades and submission comments are not visible in the
gradebook
3. grades and submission comments are not visible to the
student (it does not yet appear to be graded)
4. if a student resubmits an assignment after a
provisional grade was assigned, and a provisional
grader loads speedgrader after this, the assignment
dropdown should indicate the resubmission has
occurred
fixes CNVS-22684
fixes CNVS-22685
Change-Id: I4a761598fe8fdcb72caf435400176a6b5ddb1876
Reviewed-on: https://gerrit.instructure.com/61618
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
test plan: test in conjunction with g/61618,
which builds on this commit
fixes CNVS-22010
fixes CNVS-22011
Change-Id: I231069edf83c616293236afcfed2021c1f87d5b6
Reviewed-on: https://gerrit.instructure.com/60633
Reviewed-by: James Williams <jamesw@instructure.com>
Tested-by: Jenkins
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
Fixes PFS-2501
Test Plan:
* GET /api/v1/courses/:course_id/outcome_results
with include[]=outcomes and outcome_groups
should return the following as integers:
* outcome_results id
* outcomes id and context id
* outcome_groups id
Change-Id: I3fba74fe3839827e2aa08347a3f4843657a555a9
Reviewed-on: https://gerrit.instructure.com/61661
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
Product-Review: Tyson Brown <tbrown@instructure.com>
refs CNVS-22521
old ones will continue to be saved in the db, so this shouldn't be
considered a breaking change
test plan:
* launch an LTI tool
* it should still work
Change-Id: Iad24497759287a987a0715f31c08a13a79ee51ea
Reviewed-on: https://gerrit.instructure.com/61697
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
fixes CNVS-22527
test-plan:
- when "Updated Terms of Use" page displays, should not include any
custom account CSS
Change-Id: I98bcc48e1bf4f281ee34db8ee50ed204defc437d
Reviewed-on: https://gerrit.instructure.com/61659
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
Fixes CNVS-22439
Test plan:
- Use a screen reader
- Visit the questions tab of the quiz edit screen
- Add questions, and question groups.
- Verify that questions and question groups are wrapped in a region with an
appropriate name
- Verify that the page has not changed visually.
Change-Id: Idbe12bf109b399fdfa5c2cb3617dd75fb13afc6a
Reviewed-on: https://gerrit.instructure.com/60512
Tested-by: Jenkins
Reviewed-by: Matt Berns <mberns@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
fixes CNVS-22005 CNVS-22033 (refs CNVS-19381)
test plan:
- With user calendar do
- a recurring calendar event with 1-90 repeats
- event with no repeats
- With a course calendar do
- repeats with all sections different dates
- repeats with all sections same dates
- all sections different dates no repeats
- all sections same dates no repeats
- regular calendar event with repeats
- regular calendar event with no repeats
- As a teacher, go to the Calendar
- Click the "+" (Create New Event) button
- Add some event details, then check the "Repeat"
checkbox
- Additional fields should appear regarding repeat
information
- Change the repeat fields, then save the event
- The event should create, then the calendar should
reload and show the duplicated events
Change-Id: If8c90870d5c4b885a60810dc18868190a5639a5c
Reviewed-on: https://gerrit.instructure.com/61209
Reviewed-by: Jonathan Featherstone <jfeatherstone@instructure.com>
Tested-by: Jenkins
QA-Review: Adrian Russell <arussell@instructure.com>
Product-Review: Peyton Craighill <pcraighill@instructure.com>
closes #CNVS-22718
Change-Id: Ibccf62c76230ca665a043eb423fe88c7b8be5b00
Reviewed-on: https://gerrit.instructure.com/61745
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
Tested-by: Jenkins
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Test Plan:
- pass Jenkins
- check for syntax errors
- make sure new test_ids match up to an existing test case in TestRails
mhargiss,panda,2
Change-Id: Ie6045f5ca4da9d129917e12f7bb02f5e56bb5093
Reviewed-on: https://gerrit.instructure.com/61724
Tested-by: Jenkins
Reviewed-by: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Michael Hargiss <mhargiss@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Change-Id: Iee1b920551a4698a9555e5800704462c7f6e11c6
Reviewed-on: https://gerrit.instructure.com/61714
Tested-by: Jenkins
Product-Review: Jacob Fugal <jacob@instructure.com>
QA-Review: Jacob Fugal <jacob@instructure.com>
Reviewed-by: James Williams <jamesw@instructure.com>
test plan:
* "Manage Global Announcements" permission
should work for root accounts
and should not be shown on sub account pages
closes #CNVS-22666
Change-Id: I7ad8dfeaa4c6a8f525b834e22402f29d04bc90d5
Reviewed-on: https://gerrit.instructure.com/61663
Tested-by: Jenkins
Reviewed-by: Jon Willesen <jonw@instructure.com>
QA-Review: Charles Kimball <ckimball@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
refs CNVS-22335
Test Plan
- Upload zip files to the files section
- Make sure the expand form is still working
- Make sure its formatted styled right too
Change-Id: I9ce49f9ce5450d507199451da13f5548e92291f7
Reviewed-on: https://gerrit.instructure.com/61532
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Sterling Cobb <sterling@instructure.com>
sshepherd,panda,5
Test Plan:
- Run specs
- Check for spelling errors
- Analyze methods and examples
Change-Id: I2b0c8dbbfb9c13eb857512c9a3ba55d097d536ca
Reviewed-on: https://gerrit.instructure.com/61719
Reviewed-by: Michael Hargiss <mhargiss@instructure.com>
Tested-by: Jenkins
Product-Review: Steven Shepherd <sshepherd@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
refs CNVS-22335
Test Plan:
- Go to files
- Open a folder with lots of files to load
- You should see a "Loading more results..." message at the
bottom of the list of files. Once everything is loaded it
should go away.
Change-Id: I9fae1fbc62576c3a5005d5eec2b1bbf3b7cf4968
Reviewed-on: https://gerrit.instructure.com/61517
Reviewed-by: Sterling Cobb <sterling@instructure.com>
Tested-by: Jenkins
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
Fixes CNVS-8632
Test plan:
- Publish a quiz with an essay question
- Take the quiz
- Grade the quiz
- When no value is entered ('--' still present) the question should
still be considered needing review
- The '--' in the points field for the essay question should disappear
if a value is entered.
Change-Id: I6a6b0c15738c067f83722576cd3690e993c57e5d
Reviewed-on: https://gerrit.instructure.com/55917
Tested-by: Jenkins
Reviewed-by: John Corrigan <jcorrigan@instructure.com>
QA-Review: Jason Carter <jcarter@instructure.com>
Product-Review: Ryan Taylor <rtaylor@instructure.com>
refs CNVS-22335
Test Plan:
- Go to files
- Make sure when you drag folders/files around
you see thumbnails under your mouse and a red
badge containing a count of the files/folders
you are moving
Change-Id: I5421c0c7242ce90f2b27873ed3b2b270b2c4c49a
Reviewed-on: https://gerrit.instructure.com/61489
Tested-by: Jenkins
Reviewed-by: Dan Minkevitch <dan@instructure.com>
QA-Review: Charles Kimball <ckimball@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
closes #CNVS-22631
Change-Id: I5b47216fb972c45b275dbfe7c8e93ba1a934e9d2
Reviewed-on: https://gerrit.instructure.com/61665
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
fixes CNVS-22173
test plan:
- if local, run 'rake db:load_notifications'
- create a new user via the API
- with user[skip_registration] true
& communication_channel[skip_confirmation] true
& communication_channel info
- masquerade as the user and go to
/profile/settings
- there IS NOT a message telling you that
you must verify your email address
- with user[skip_registration] true
& pseudonym[send_confirmation] true
& communication_channel info
- the user gets an email telling them
they have been registered
- there IS NOT a message telling you that
you must verify your email address
- with user[skip_registration] false
& communication_channel[skip_confirmation] true
& communication_channel info
- masquerade as the user and go to
/profile/settings
- there IS a message telling you that
you must verify your email address
- create a new user via the API, but associate
this user with an already made pseudonym
(use enable_sis_reactivation and sis_user_id
to do so)
and set pseudonym[send_confirmation] to true
- they DO get an email saying that they have
been registered
Change-Id: I60d0fe013cef1648abd838fd53d9992facf0e106
Reviewed-on: https://gerrit.instructure.com/59726
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
Product-Review: Jacob Fugal <jacob@instructure.com>
when there are more than 50 courses.
fixes CNVS-9257
test plan:
-create a question bank with more than 50 questions
-reload page
-click on the "more questions" link at bottom of page
-click on the "move/copy question to another bank" link on
51st question
-move to another question bank
-check bank to ensure that it was moved
Change-Id: I7f70dab2d8c626e79b854e555d9dd72d34fb79aa
Reviewed-on: https://gerrit.instructure.com/60396
Tested-by: Jenkins
Reviewed-by: John Corrigan <jcorrigan@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Davis McClellan <dmcclellan@instructure.com>
fixes CNVS-21986
test plan:
- navigate to a created assignemnt
- click add rubric
- inspect the table rows to find scope
Change-Id: Ib7090ebfb78e6e39316c5f6ffe221c127bcaa77c
Reviewed-on: https://gerrit.instructure.com/60150
Tested-by: Jenkins
Reviewed-by: Matt Berns <mberns@instructure.com>
QA-Review: Adam Stone <astone@instructure.com>
Product-Review: Davis McClellan <dmcclellan@instructure.com>
app/views/quizzes/quizzes/show.html.erb for accessability
fixes CNVS-21981
test plan
-navigate to quiz show page
-alt text should now be null for hidden image next to the
"Save It Now" button.
Change-Id: I7b29b75b45234dac21e89da6ff0b38929f96c48d
Reviewed-on: https://gerrit.instructure.com/60056
Reviewed-by: Cameron Sutter <csutter@instructure.com>
Tested-by: Jenkins
QA-Review: Adam Stone <astone@instructure.com>
Product-Review: Davis McClellan <dmcclellan@instructure.com>
fixes CNVS-22581
test plan
- setup open registration
- in console set root_account setting
- a = Account.root_accounts.active.find(id)
- a.settings[:fft_registration_url] = "http://www.canvaslms.com/try-canvas?lead_source_description=canvas.instructure.com_fft_canvas_"
- a.save!
- click on "I'm a teacher" YOUR_CANVAS/register_from_website
- it should redirect to canvaslms try canvas link
- remove setting
- it should bring up form to register locally
Change-Id: I14f6daacffceda4dd25b4829558f9f9472618104
Reviewed-on: https://gerrit.instructure.com/61446
Reviewed-by: Jacob Fugal <jacob@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
Tested-by: Jenkins
refs CNVS-22335
- Converts:
- DialogPreview
- FilesystemObjectThumbnail
Test Plan:
- Make sure DialogPreview and FilesystemObjectThumbnail
work in New Files
- DialogPreview shows up in the Usage Rights dialog as well as
the restricted access dialog. FilesystemObjectThumbnail shows
up anywhere thumbnails are shown.
Change-Id: I2e0b0b83cc69e18c24946c21c5545cfca0266bf3
Reviewed-on: https://gerrit.instructure.com/60272
Tested-by: Jenkins
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>
QA-Review: Charles Kimball <ckimball@instructure.com>
Cody Cutrer