make it so we can turn on this feature flag for everyone in
production. this means we have to remove the development flag.
closes CNVS-22780
test plan:
- make rails think it's on prod, and not a test cluster
- In the console: Account.site_admin.enable_feature!(:nc_or)
- nc or should be forced on everywhere
Change-Id: I2988b020d619a93052aa0df1e11639cc3d446191
Reviewed-on: https://gerrit.instructure.com/61977
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Tested-by: Jenkins
Product-Review: Jon Willesen <jonw@instructure.com>
Fixes CNVS-22564
Test plan:
- Create multiple modules in a course.
- Visit the modules page with a screen reader
- Verify that you can jump from module to module with the h key
Change-Id: I9999c54ab950e1ad416848b46307e489a77ef087
Reviewed-on: https://gerrit.instructure.com/61177
Tested-by: Jenkins
Reviewed-by: Jon Willesen <jonw@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
sshepherd,panda,7
Test Plan:
- Run specs
- Check for errors in priority and test_id
Change-Id: I9285b69f9e30f8091e2565416018023b79f75867
Reviewed-on: https://gerrit.instructure.com/62133
Reviewed-by: Jahnavi Yetukuri <jyetukuri@instructure.com>
Tested-by: Jenkins
Product-Review: Steven Shepherd <sshepherd@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Test Plan:
- pass Jenkins
- check for syntax errors
- make sure new test_ids match up to an existing test case in TestRails
mhargiss,panda,11
Change-Id: Ifabf373af44c71f0585cb375272bfa26597dea51
Reviewed-on: https://gerrit.instructure.com/62016
Tested-by: Jenkins
Reviewed-by: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
There are several fatal errors that can be encountered in an import.
these were previously being reported as warnings, which is not accurate.
Additionally, the error message was not being set properly so in the
outcomes import API we were getting back a null error message.
Fixes CNVS-22517
Test Plan:
Most of these conditions are difficult to reproduce because they result
from the Academic Benchmarks server. Therefore, there isn't really a
practical test plan we can do without building an emulator (which I
actually would like to do when we have a little time)
Change-Id: I521fc5250a3369497944cda5e44bbbc622f46681
Reviewed-on: https://gerrit.instructure.com/60876
Reviewed-by: John Corrigan <jcorrigan@instructure.com>
Product-Review: Benjamin Porter <bporter@instructure.com>
QA-Review: Benjamin Porter <bporter@instructure.com>
Tested-by: Jenkins
Canvas.assignment.unlockAt.iso8601 Canvas.assignment.lockAt.iso8601 Canvas.assignment.dueAt.iso8601
fixes PLAT-1211
test-plan:
install the test tool with Canvas.assignment.unlockAt.iso8601 Canvas.assignment.lockAt.iso8601 Canvas.assignment.dueAt.iso8601 setup as a custom variable
launch the tool
it should return back the above date varibles in iso8601 format.
Change-Id: I6a816e8318cb70d50a0cf39f2138f4e395f39676
Reviewed-on: https://gerrit.instructure.com/61806
Tested-by: Jenkins
Reviewed-by: Nathan Mills <nathanm@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Josh Orr <jgorr@instructure.com>
fixes PLAT-1207
test-plan:
submit a doc using the turnitin assignment
the UI should show it as pending in speedgrader until it is done.
Change-Id: I02f8736c4c5c63d82ddba3ff741e4efd4cf15205
Reviewed-on: https://gerrit.instructure.com/61771
Tested-by: Jenkins
Reviewed-by: Josh Orr <jgorr@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Nathan Mills <nathanm@instructure.com>
test plan:
* using the respondus lockdown browser, should be able to log out
after submitting a quiz requiring the lockdown browser
closes #CNVS-22838
Change-Id: If7b28977fe9ed51444fca145b841cc15ca71eb49
Reviewed-on: https://gerrit.instructure.com/62099
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Tested-by: Rob Orton <rob@instructure.com>
this was just a blank file, so there was no point
in loading it and it was causing brandable_css to
break since it had nothing in it.
we can add it back if/when we actually do something
with css in assignment_moderation
Change-Id: If2ce77ad3b3568663a47378412a53240a99e1269
Reviewed-on: https://gerrit.instructure.com/62094
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Also added priority tag to a few I missed
sshepherd,panda,4
Test Plan:
Run specs
Change-Id: I279b73a6f586cf0c19eaf2dcd7c4ef3ff0a6f6a6
Reviewed-on: https://gerrit.instructure.com/62069
Reviewed-by: Derek Hansen <dhansen@instructure.com>
Product-Review: Steven Shepherd <sshepherd@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Tested-by: Jenkins
fixes: CNVS-22835
this is just a quick fix so it works like it used
to. We really should re-do that entire page so
it does not fragilely depend on css and js from
the rails app & load it in a way that is different
from everything else. We'll do that as a separate
ticket.
Change-Id: I362b66f968015520d9b44e787d84021fa258218b
Reviewed-on: https://gerrit.instructure.com/62092
Reviewed-by: Rob Orton <rob@instructure.com>
Tested-by: Jenkins
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
fixes CNVS-22655
fixes CNVS-22833
the can_take_quiz? method renders an access_code restriction template or
an ip restriction template if those things are required for the quiz.
previously, those were presented when trying to take the quiz, but
a recent change made it so that they were presented when simply trying
to view the quiz. this reverts to the previous behavior.
test plan:
- as a teacher, create an access code or ip restricted quiz, publish it
- as a student, you should be able to view the quiz without being
prompted for an access code (or from an invalid ip)
- as a student, when trying to take the quiz, the restrictions should
apply correctly
- as a student who meets the restrictions, you should be able to take
the quiz
Change-Id: Iedc78c3728501da56710e00857527a7323633eeb
Reviewed-on: https://gerrit.instructure.com/62089
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Adam Stone <astone@instructure.com>
QA-Review: Pedro Fajardo <pfajardo@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
Tested-by: Rob Orton <rob@instructure.com>
fixes CNVS-22834
Change-Id: I64c4ec47343ad34852691cb94271e98f5d1d65f8
Reviewed-on: https://gerrit.instructure.com/62091
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Tested-by: Rob Orton <rob@instructure.com>
Rectifies a regression in the the recent refactoring of quiz
eligibility.
Closes CNVS-22755
Test Plan:
- Create a quiz with 2 allowed attempts
- Take it twice and see no "Take the Quiz Again" button on completion.
Change-Id: Ifc4f503746f64b0083365bd394e71e8c6e0d97e8
Reviewed-on: https://gerrit.instructure.com/61951
Tested-by: Jenkins
Reviewed-by: Matt Berns <mberns@instructure.com>
QA-Review: Pedro Fajardo <pfajardo@instructure.com>
QA-Review: Adam Stone <astone@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
test plan
- spec should pass
Change-Id: I92c30d8f794298d8c96d68a4fe696f5c3a958528
Reviewed-on: https://gerrit.instructure.com/62090
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Tested-by: Jenkins
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Change-Id: I0d4b2fc27daa7138719699153ee29cc2ee23f4fe
Reviewed-on: https://gerrit.instructure.com/62088
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Tested-by: Rob Orton <rob@instructure.com>
fixes CNVS-22607
Test plan:
* set up a section limited TA
* download gradebook csv
* ensure you can only see students in your section
Change-Id: I20c67d832f7cb234f7527d53747770c0092e9a0d
Reviewed-on: https://gerrit.instructure.com/61886
Reviewed-by: Dylan Ross <dross@instructure.com>
QA-Review: Derek Hansen <dhansen@instructure.com>
Tested-by: Jenkins
Product-Review: Cameron Matheson <cameron@instructure.com>
This makes it so keyboard only and screenreader users can see
the list of courses, accounts, and groups in the new UI. It does
so by checking to see if the items for the tray have been loaded
or are loading. If not it will trigger them to load when the
tray itself opens.
fixes CNVS-22736
Test Plan:
- Using only the keyboard open the Course, Admin, and Group
global menu items.
- The list of courses, accounts, and groups should be populated
or triggered to populate (and finish loading)
- Do the same with screenreaders
Change-Id: I974c32023de01dbca43c36a51e23e6308931291e
Reviewed-on: https://gerrit.instructure.com/61908
Reviewed-by: Dan Minkevitch <dan@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Tested-by: Jenkins
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
added teacher specs for several I only had student context tests for
sshepherd,panda,17
Test Plan:
- Run specs
- Check for test_id/priority errors
Change-Id: If9bcd8780ee7e7c816ef5debc31a8af1f31920fb
Reviewed-on: https://gerrit.instructure.com/62030
Reviewed-by: Derek Hansen <dhansen@instructure.com>
Product-Review: Steven Shepherd <sshepherd@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Tested-by: Jenkins
Written a bunch of specs to regression test the quizzes functionality
for various hierarchy levels
dsoundarrajan, panda, 12
Change-Id: I6e95b0c1f262488d164101db42aaba4f958e2274
Reviewed-on: https://gerrit.instructure.com/61987
Reviewed-by: Derek Hansen <dhansen@instructure.com>
Tested-by: Jenkins
Product-Review: Derek Hansen <dhansen@instructure.com>
QA-Review: Derek Hansen <dhansen@instructure.com>
Account admins can now create developer keys for the domain root
accounts
Fixes PLAT-1190
Test Plan:
You should now be able to create developer key as an account admin
make sure the account admin can't access other accounts dev keys
Change-Id: I79b9c825521a980a8822693a316fdb9937340557
Reviewed-on: https://gerrit.instructure.com/61172
Tested-by: Jenkins
Reviewed-by: Nathan Mills <nathanm@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Brad Horrocks <bhorrocks@instructure.com>
closes: CNVS-22806
Test Plan:
- Go to tinymce editor
- Make sure html path shows below editor
Change-Id: Ieafda7d14abe097c3c233cf397b4d844cc63fea0
Reviewed-on: https://gerrit.instructure.com/62012
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
Tested-by: Rob Orton <rob@instructure.com>
Change-Id: I8f299dde7b6980d735e362e0537793e3deb53870
Reviewed-on: https://gerrit.instructure.com/61737
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
test plan:
* specs
closes #CNVS-22748
Change-Id: I1c8916fe7510dcaa39ff51c8dab7c1a42c886e92
Reviewed-on: https://gerrit.instructure.com/61965
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Change-Id: I653ebae164ea588756b16091af9033bda988e35e
Reviewed-on: https://gerrit.instructure.com/62005
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
In the gradebook individual view's grading section, if a student has
no submission the helper message of "This assignment has been
resubmitted since it was graded last" does not appear. Because of
this, there will not be confusion by a teacher if an assignment was
submitted or not.
fixes CNVS-21691
test plan:
- Create and publish a course with two students
- Create a student group and add both students to it
- Create and publish an assignment using the blue '+ Assignment' button
- Click on the 'Grades' link in the left column to go to the Gradebook
- Click on the 'Switch to Individual View' link in the top right
- Select one of the students
- Select the assignment
- Observe that "This assignment has been resubmitted since it was
graded last" does not appear
Change-Id: I06f0dcb8d0e37d5150e1b20efee6d08143226017
Reviewed-on: https://gerrit.instructure.com/61839
Reviewed-by: Spencer Olson <solson@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Tested-by: Jenkins
Product-Review: Josh Simpson <jsimpson@instructure.com>
Test Plan:
- pass Jenkins
- check for syntax errors
- make sure new test_ids match up to an existing test case in TestRails
mhargiss,panda,13
Change-Id: I314135cb274f1cc5b27e76008b7a23c5c3558849
Reviewed-on: https://gerrit.instructure.com/61995
Reviewed-by: Jahnavi Yetukuri <jyetukuri@instructure.com>
Tested-by: Jenkins
Product-Review: Michael Hargiss <mhargiss@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
in massively sharded databases where there's a type for every table,
this reduces the number of rows queried and unused... massively
Change-Id: Ib9bcf70d060f5ba48ebedaa7108d9d364430c638
Reviewed-on: https://gerrit.instructure.com/61975
Tested-by: Jenkins
Reviewed-by: Brian Palmer <brianp@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Change-Id: If60f87ce1e5e07a68a9ab8c615e0e24be8c12a46
Reviewed-on: https://gerrit.instructure.com/62004
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
refs CNVS-22335
Test Plan
- go to the files section
- make sure pressing and using the upload button works
- you should still be able to upload files
Change-Id: I835b451d624ed6d6bc194f322691055d3d5411a2
Reviewed-on: https://gerrit.instructure.com/61634
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Charles Kimball <ckimball@instructure.com>
Product-Review: Sterling Cobb <sterling@instructure.com>
- f, ff, fln can still be used the old way
or the new way - as an instance method of
Selenium::WebDriver::SearchContext, this makes them chainable
- added other methods as well
- see implementation in alerts and calendar2 tests
Change-Id: I24dbde72dca9eac84c016009376015df86d53cf7
Reviewed-on: https://gerrit.instructure.com/61945
Reviewed-by: Michael Hargiss <mhargiss@instructure.com>
Reviewed-by: Jahnavi Yetukuri <jyetukuri@instructure.com>
Tested-by: Jenkins
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Fixes CNVS-22630
Test Plan:
Smoke test IMP against both types of queues
Change-Id: Icb88864b600ff76b389cd3858b70ee7898ec05f8
Reviewed-on: https://gerrit.instructure.com/61442
Tested-by: Jenkins
Reviewed-by: Joel Hough <joel@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Matthew Wheeler <mwheeler@instructure.com>
refs CNVS-22335
Test Plan:
- Make sure you can publish/unpublish files on the files
page and the modules page
Change-Id: Ib8d1e38fa0bb5198ef359bfbebdd55546b820913
Reviewed-on: https://gerrit.instructure.com/61572
Tested-by: Jenkins
Reviewed-by: Sterling Cobb <sterling@instructure.com>
QA-Review: Charles Kimball <ckimball@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
Kenneth tools relies on this path being on the page in order for their stuff
to work. This brings back the html elementpath below tinymce, but hides it
using css from the UI so it isn't visible.
closes: CNVS-22759
Test Plan:
- Open up a view that had TinyMCE
- You should not see any html elementpath below the editor
Example with path: http://cl.ly/image/1O3u3J3j361w
Example without path: http://cl.ly/image/050n0Q1B1P2g
Change-Id: I93e7fa65c1d05a105c7e80e7b65ba4e4176fec4e
Reviewed-on: https://gerrit.instructure.com/61956
Reviewed-by: Mike Nomitch <mnomitch@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Stephen Jensen <sejensen@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins
test plan:
* the "Approved Integrations" header on the user
profile edit page should be translated correctly
(among others)
closes #CNVS-22567
Change-Id: Ib40b8e16f7506a85a808077a49fc7e1b3dd1a6da
Reviewed-on: https://gerrit.instructure.com/61652
Tested-by: Jenkins
Reviewed-by: Jon Willesen <jonw@instructure.com>
QA-Review: Charles Kimball <ckimball@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Test Plan:
- pass Jenkins
- check for syntax errors
- make sure new test_ids match up to an existing test case in TestRails
mhargiss,panda,9
Change-Id: I0809439031e9430000dcfbc50cf19eb443c03864
Reviewed-on: https://gerrit.instructure.com/61935
Tested-by: Jenkins
Reviewed-by: Derek Hansen <dhansen@instructure.com>
Product-Review: Derek Hansen <dhansen@instructure.com>
QA-Review: Derek Hansen <dhansen@instructure.com>
Test Plan:
- pass Jenkins
- check for syntax errors
- make sure new test_ids match up to an existing test case in TestRails
mhargiss,panda,9
Change-Id: Ibe4e977d766243f08f97deb29fd04825d2467ccb
Reviewed-on: https://gerrit.instructure.com/61934
Tested-by: Jenkins
Reviewed-by: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Michael Hargiss <mhargiss@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
closes #CNVS-22628
Change-Id: Ie1a997653d70fe5062295ff5b5e5fb7c2b32fe4c
Reviewed-on: https://gerrit.instructure.com/61738
Tested-by: Jenkins
Reviewed-by: Jon Willesen <jonw@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Fixes: CNVS-22399
Test Plan:
- Navigate to profile/settings
- View the text description of the
data fields:
http://www.screencast.com/t/a9pJ1yxIYxI
- Previously the text had a color
value of #888 which was not
accessible
- Now the text has a value of #333
which passes accessibility
http://webaim.org/resources/contrastchecker/
Change-Id: I0940d17f0b866ff89901a20271027edb80504712
Reviewed-on: https://gerrit.instructure.com/61487
Tested-by: Jenkins
QA-Review: Nathan Rogowski <nathan@instructure.com>
Reviewed-by: Colleen Palmer <colleen@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
When an ePortfolio page has a rich text section with an embedded
image, the image appears as a seperate file in the .zip download and
appears inline in the page's html file. Because of this, an
ePortfolio user will be able to embed images in rich text sections.
fixes CNVS-21702
test plan:
- Have (or upload) an image stored in the Files page
- Create a new ePortfolio
- Click on the default Welcome page and then click on Edit This Page
- Select Rich Text Content from the Add Content menu
- In the editor, embed your image from your Canvas files
- Click "Save Page"
- Return to the ePortfolio main page via the navagation breadcrumbs
- Click "Download the contents of this ePortfolio as a zip file"
- Unzip the downloaded zip file and observe that the image is there
along with Home_Welcome.html.
- Open the "Home_Welcome.html" file in a web browser.
- Observe the image inline on the page.
Change-Id: I0638df03d94eab3e37eb91b9daeb898c20cc42d5
Reviewed-on: https://gerrit.instructure.com/61159
Tested-by: Jenkins
Reviewed-by: Dylan Ross <dross@instructure.com>
Reviewed-by: Cody Poll <cpoll@instructure.com>
QA-Review: Jason Carter <jcarter@instructure.com>
Product-Review: Christi Wruck
sshepherd,panda,12
Test Plan:
- run specs
- look for any spelling errors
Change-Id: I5a9302b6ac7726c12fa7c8c5b045f1d3ab00fbc7
Reviewed-on: https://gerrit.instructure.com/61904
Tested-by: Jenkins
Reviewed-by: Heath Hales <hhales@instructure.com>
Product-Review: Steven Shepherd <sshepherd@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
refs 22742
This store is very simple. Just a list of students with change
handlers.
Test Plan
- Make sure tests are passing
- Array of students can be loaded in
Change-Id: I3b3700cb8e5799258a606b126d9a0e4a3bcc49c5
Reviewed-on: https://gerrit.instructure.com/61909
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Sterling Cobb <sterling@instructure.com>
QA-Review: Sterling Cobb <sterling@instructure.com>
Fixes: CNVS-22433
Test Plan:
- In the NUI, as a teacher, create an
assignment with a long title (around
50+ characters)
- Submit the assignment as a student
- As the teacher, grade this assignment
and leave lengthy feedback (more
than 120 characters)
- Return to the dashboard as a student
- Before, in firefox, an error would
occur where the text would condense
the dashboard excessively:
http://screencast.com/t/MaxfvKPaerDm
- Now the behavior for 'Recent Feedback'
on the right side should be the same
across all browsers (especially
firefox)
- The assignment title should wrap
to the next lines when large
- The comment should present an
ellipsis after 120 characters
- As can be seen here:
http://www.screencast.com/t/yWCa4KC7
Change-Id: Idd94ad351815d2e283499f3802c4295d9a040c51
Reviewed-on: https://gerrit.instructure.com/61424
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Tested-by: Jenkins
Product-Review: Colleen Palmer <colleen@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Jon Willesen