flag=none
fixes VICE-771
test plan:
- visit /accounts/self/settings
- scroll down and enable personal pronouns
- hover over info icon
- verify tooltip shows
'These pronouns will be available to Canvas users
in your account to choose from.'
Change-Id: Ie46b06eb306930161eec8fab5cec57c1b7c7137a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/249634
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Davis Hyer <dhyer@instructure.com>
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
Change-Id: I68773609a74cbb5815f5f2ba695e81a15805eecd
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/249484
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Change-Id: Id1f854ab2b9b4c7319e775b20828d766c5e32154
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/249483
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
closes EVAL-624
flag=view_ungraded_as_zero
Test plan:
- Enable the "View Ungraded as Zero View in Gradebook" feature
- Open the Network tab in your browser's developer tools
- Open Individual Gradebook for a course
- Check that enabling/disabling the "Treat Ungraded as 0" checkbox
sends a request to the gradebook_settings URL for the course
containing the corresponding true/false value
- Check that your changes to the setting persist between reloads of
the page
- In a Rails console, check that the preference value for that
user/course is set appropriately:
> UserPreferenceValue.find_by(
user_id: <user ID>,
key: "gradebook_settings",
sub_key: Shard.global_id_for(<course ID>)
)
should return a hash including the correct value for
"view_ungraded_as_zero"
- Check that the setting is synced between New Gradebook and Individual
Gradebook when you switch between them (note that any already-open
windows will need to be reloaded to pick up the changes)
- Disable the "View Ungraded as Zero View in Gradebook" feature
- Open Individual Gradebook and check that toggling the setting does
*not* send a request to the server, but the value persists between
reloads of that particular browser
- Check that an old IG setting is honored when enabling the feature and
immediately opening IG:
- Disable the feature flag
- Create a new course, or use one for which you've never set the
preference
- Open Individual Gradebook and enable the setting
- Enable the feature flag
- Open New Gradebook for the course and verify that the "View Ungraded
as 0" menu item is *not* checked (do not enable it yet!)
- Open Individual Gradebook and verify that the setting *is* checked
- From this point on, any change in either of the gradebooks should
update the value for both of them
Change-Id: I2f2921f1ded63a2daa7c83b30d8b879b86fd1a28
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/248896
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Jody Sailor
Reviewed-by: Spencer Olson <solson@instructure.com>
Reviewed-by: Gary Mei <gmei@instructure.com>
QA-Review: Kai Bjorkman <kbjorkman@instructure.com>
refs DE-23
Test Plan
1. Ensure that build works against master
2. Ensure that build works against specific patchset
Change-Id: I898cb46db5c7287358bae80133685deecce9aab6
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/249700
Reviewed-by: Kyle Rosenbaum <krosenbaum@instructure.com>
Reviewed-by: James Butters <jbutters@instructure.com>
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Aaron Ogata <aogata@instructure.com>
Product-Review: Aaron Ogata <aogata@instructure.com>
test plan:
- enable recent history feature
- in separate browsers, log in as a student
and as an admin masquerading as the student
- both users should see the student's activity in the
recent history
- the masquerading admin's activity should not appear
to either user
flag = recent_history
fixes LS-1533
Change-Id: Ib656a2faee2eeb5ba1fc77734a02c70f018d9c57
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/249711
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
QA-Review: Jackson Howe <jackson.howe@instructure.com>
Product-Review: Peyton Craighill <pcraighill@instructure.com>
test plan
- specs should pass
Change-Id: Ib13398d368c81dd4d29e1245ed971fd2ef2b3fbf
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/249768
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Mysti Lilla <mysti@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
Fixes INTEROP-6252
flag=none
Test Plan:
- Install multiple plagiarism detection tools
in the same account with _different_ resource
type codes. Each tool should also have a different
endpoint
- Associate an assignment with one of the tools
- Submit and verify an event is sent to the tool
with the matching resource type code
- Verify events were not sent to the other tools
Change-Id: I5892451c2ac3af64254881319d6f1143703a5cb6
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/249776
Reviewed-by: Mysti Lilla <mysti@instructure.com>
QA-Review: Tucker Mcknight <tmcknight@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Weston Dransfield <wdransfield@instructure.com>
fixes INTEROP-6250
flag=none
Test plan
- Set up tools with varying endpoints and verify
we're sending the "closest/latest" endpoint ids
from among a plethora of similar tools on courses/
sub-accounts/accounts
- Verify the migration does the same thing
Change-Id: Iac761e94cfeee01588cae5cd8b4797faa1bcb643
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/249736
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
Reviewed-by: Xander Moffatt <xmoffatt@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Tucker Mcknight <tmcknight@instructure.com>
Product-Review: Weston Dransfield <wdransfield@instructure.com>
fixes FOO-631
flag = none
test plan:
- Have an account with at least one term
- Navigate to the Courses tab of an account
- Click into the "filter by term" drop down and note that it
lists all terms
- Click off on to another part of the page that wont navigate
you away
- Click back in to the drop down and note that you still see the
headers and all the previous terms as you did before
- Type into the searchable select input with enough characters
to match a single term
- Click off on to another part of the page
- Verify that term was automatically selected after clicking
back into the searchable select input
- You should still see all the available terms
- Type characters that won't provide a match into the searchable
select input
- Click off on to another part of the page
- Verify those characters remain as the input value, but stay
invalid with a "No matches to your search"
- The input will not be valid until those search characters
provide a match and you *shouldn't* see any group headers
or terms if attempting to click on the search dropdown
Change-Id: I8ca881c654c329fd561ed8c98a6daf7f20553c6b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/249628
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ahmad Amireh <ahmad@instructure.com>
QA-Review: Ahmad Amireh <ahmad@instructure.com>
Product-Review: Ahmad Amireh <ahmad@instructure.com>
fixes EVAL-1258
flag=none
Test plan:
- Have a course with a student
- Create a quiz (in old quizzes)
- In the Gradebook, change the quiz to be manually posted
- As the student, take and submit the quiz
- In a Rails console, look up the submission ID of that student's
submission
- As the student, submit a GraphQL request for that submission ID:
query MyQuery {
submission(id: "<submission id>") {
id
body
score
submissionHistoriesConnection(first: 10) {
nodes {
body
score
}
}
}
}
- The "body" attribute, in both the submission itself and the history
nodes, should be returned as null
- As the teacher, run the same query and check that you do get a
response for the body
- As the teacher, post grades for the quiz in Gradebook
- Re-run the query as the student and check that the body attribute is
now populated
Change-Id: I09c968a509fbf0510ad4e5f07e4c63f1d74eb9bd
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/249727
Reviewed-by: Gary Mei <gmei@instructure.com>
Reviewed-by: Syed Hussain <shussain@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
QA-Review: Gary Mei <gmei@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Syed Hussain <shussain@instructure.com>
Previously, if the user tried to save an invalid hexcode in the
ColorPicker, an alert would tell them the color was invalid. This
made it difficult for SR users to know ahead of time if the hexcode
was valid. Now, the Apply button is disabled until a valid color is
entered, and a screenreader message about the field being invalid is
announced when the user leaves the input field to supplement
the invalid icon that is displayed to sighted users. Tooltip also
added to the icon.
fixes LS-1437
flag=none
Test plan:
- Open color picker (there's an instance on the dashboard and in
calendar)
- Type in an invalid hex code, expect apply button to be disabled
and to see an icon with tooltip
- Enter valid hex code, or click one of the predefined colors,
expect apply button to now be enabled
- Expect functionality to still work
- Turn on SR - when hexcode is invalid, tab out of input field,
expect to hear a message saying color is invalid
Change-Id: Ife58de18489bb698084738e886ab8245f1fa94f9
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/249181
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jackson Howe <jackson.howe@instructure.com>
After adding a description to an outcome and attaching it to a rubric as a
criterion, there is still a "View longer description" button. This is
inconsistent with the longer descriptions on standard criterion,
which do not have that link.
closes OUT-2123
flag=none
test plan:
- View an existing rubric or create a new rubric
- Add an outcome criterion with description
- You should see outcome long description without html tags
and media (videos)
- You shouldn't see "View longer description" button
Change-Id: I25e3c2633017eb8c49304bd3968c2642969ecc0a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/249039
Reviewed-by: Augusto Callejas <acallejas@instructure.com>
Reviewed-by: Michael Brewer-Davis <mbd@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Pat Renner <prenner@instructure.com>
Product-Review: Jody Sailor
closes EVAL-1244
flag=none
You can't use/grade with/interact with rubrics in Gradebook (Individual
or Grid), so we shouldn't be fetching them.
Test Plan:
1. Create a course that has assignments with rubrics attached to them.
Have some of the assignments use the rubric for grading, and others
not use the rubric for grading.
2. In Gradebook (individual AND grid), verify all interactions with the
assignments with rubrics are unchanged from the behavior on master.
You should be able to grade students for the assignments, view
grades, mark as late or missing, etc. To be able to view or grade
using the rubric, you have to go to SpeedGrader (as you always have).
Change-Id: I323da11ca846026a8ef5929f631b969cb0ebc964
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/248933
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Jody Sailor
QA-Review: Kai Bjorkman <kbjorkman@instructure.com>
Reviewed-by: Adrian Packel <apackel@instructure.com>
Reviewed-by: Syed Hussain <shussain@instructure.com>
test plan:
- enable recent history feature
- perform an API call to /api/v1/courses/X/modules
- this should not appear in the recent history
(and certainly not show you JSON when you click it)
- go to the course module index in the browser
- this should appear in the recent history
- download a file from the kebab menu in the
files tab
- this should not appear in the recent history
- preview an image file by clicking its name in
the files tab
- this should appear in the recent history
flag = recent_history
fixes LS-1531
Change-Id: I55c60903e100c7f4a967b6cdb859c6f76f18a78d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/249641
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: Jackson Howe <jackson.howe@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
This resolves the issue where the duplication is marked as timedout
on the canvas side but the external tool is still processing data.
This allows for a state recovery to occure instead of the user
needing to click the "retry" button manually.
Test Plan:
- Specs Pass
Fixes: QUIZ-7887
flag = none
Change-Id: Ie6d25510d112a3557e6db75966dc7a8560982987
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/249665
Reviewed-by: Stephen Kacsmark <skacsmark@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Mark McDermott <mmcdermott@instructure.com>
Product-Review: Alex Slaughter <aslaughter@instructure.com>
Caleb Guanzon