This patchset updates the new gradebook feature flag to 1) allow
teachers to enable the new gradebook for a course (if the admin has
set new gradebook to allow) and 2) disable the ability to turn off the
new gradebook for a course if backwards incompatible features are
used. For now, the features that would stop a move backwards are
enabled late or missing policies, or any submission that had a
late_policy_status manually set.
closes GRADE-691
test plan:
- As an admin, in the account settings set new gradebook to allow
- Create a course with a teacher, a ta, a student, and an assignment
- As a ta, go the course settings and confirm you can't configure new
gradebook
- Perform the following actions as a teacher unless otherwise
specified
- go to the course settings and enable the new gradebook
- in the gradebook, configure a late policy
- go the course settings and confirm you can't turn off new
gradebook
- as an admin, go to the course settings and confirm you can't
turn off new gradebook
- in the gradebook, turn off the late policy and configure a
missing policy
- go the course settings and confirm you can't turn off new
gradebook
- as an admin, go the course settings and confirm you can't turn
off new gradebook
- in the gradebook, turn off the missing policy
- go the course settings and confirm you can turn off new
gradebook (but leave it enabled)
- as an admin, go the course settings and confirm you can turn off
new gradebook (but leave it enabled)
- go into the gradebook, set a missing or late status on the
assignment for the student
- go the course settings and confirm you can't turn off new
gradebook
- as an admin, go the course settings and confirm you can't turn
off new gradebook
Change-Id: Ibfde1398c60254de1fd2b9697e8155fabbb1b781
Reviewed-on: https://gerrit.instructure.com/134521
Tested-by: Jenkins
Reviewed-by: Shahbaz Javeed <sjaveed@instructure.com>
Reviewed-by: Derek Bender <djbender@instructure.com>
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
test plan:
- have assignments and wiki pages with unclosed html tags in their names
(e.g., <style> and no corresponding </style>)
- these items should copy correctly via course copy
or export/import. in particular, check:
1. the HTML tags appear literally in the names
(they are not filtered out)
2. all items are copied
3. item body text is also copied
fixes ADMIN-583
Change-Id: Ic1fc006fca0c1e0af0dec05ebf7cff2041c179f3
Reviewed-on: https://gerrit.instructure.com/134720
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
closes CORE-673
test plan:
- ensure rcs flag is enabled
- run latest RichContentService locally w/ flickr api key
- insert a flickr image
- should be linked to image on flickr website
- test with a wiki page
- test uploading an image from the images tab in the sidebar
- it should have the place to enter alt text or decorative
- save the page
- it should render image and have correct alt text
- edit wiki page
- test uploading a pdf from the files tab
- save the page
- the inline preview should work (canvadocs plugin must be enabled)
- smoke test common rce workflows
Change-Id: Ia8c9c020d4318729cc0f15bd60a05672614863ec
Reviewed-on: https://gerrit.instructure.com/134639
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
Fixes: UIDEV-137
test plan:
- as a user turn on recent activty for dashboard view
- using vo, jaws, nvda... ensure the "ignore x" reads properly
so there is context as to what is being ignored
Change-Id: Ia1699ea657425b40f72176a714091475bfd3eddc
Reviewed-on: https://gerrit.instructure.com/134702
Tested-by: Jenkins
Reviewed-by: Stephen Jensen <sejensen@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Product-Review: Pam Hiett <phiett@instructure.com>
Discussion topics can be unread even without replies if the user hasn't
looked at the topic yet. This is why it was showing up in the
new_activity filter. This makes the new_activity flag consistent with
the filter.
fixes ADMIN-564
test plan:
* In the student planner, unread discussion topics with no replies
should have the blue dot for new activity and be consistent with the new
activity filter in the api.
Change-Id: Iba112043c8544c4bc73fac5ecd579187969e9a57
Reviewed-on: https://gerrit.instructure.com/134441
Tested-by: Jenkins
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Jon Willesen <jonw+gerrit@instructure.com>
We were missing tests for planer notes on course calendars.
fixes: ADMIN-120
test plan:
- the selenium tests in calendar2_with_planner_notes_spec.rb succeed
- QA is satisfied test coverage is adequate
Change-Id: Ic1523fc1489f64af2218a0c2d62e3a720d0b2ae5
Reviewed-on: https://gerrit.instructure.com/134908
Tested-by: Jenkins
Reviewed-by: Robert Lamb <rlamb@instructure.com>
Product-Review: Robert Lamb <rlamb@instructure.com>
QA-Review: Robert Lamb <rlamb@instructure.com>
…but still force `let foo=1, bar=2` to be:
let foo=1
let bar=2
I don’t actually find any value in enforcing this rule at all and think
we could ignore it altogether but rather than advocating we remove it
completely, this commit just makes it so you can combine uninitialized
variable declarations at the top.
I frequently see this in spec files where we do something like
let subject, result, whatever
//and then in a ‘beforeEach()’ we assign values to those
//and then in each test(..) they are used
What say ye all?
Test plan:
* look at follow-on commit to this that changes MessageStudentsSpec.js
* it should not have eslint errors about:
`error Split 'let' declarations into multiple statements`
Change-Id: I7aafac3a395bac221e9e9b3111a82d0af4671ddb
Reviewed-on: https://gerrit.instructure.com/134822
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
We just had a thing where a commit made it through that added an
.only(…), which made it so Jenkins would only run that one test.
This should help prevent that.
And it should help us write more helpful tests too.
Test plan:
* change a test from “test(” to “Qunit.only(“, eslint should print an
error.
Change-Id: If43640a74cadbe88ed8d49a9c66232356a339104
Reviewed-on: https://gerrit.instructure.com/134893
Reviewed-by: Jeremy Neander <jneander@instructure.com>
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
closes GRADE-368
test plan:
* Create and publish a course and enroll five students in it
* Create and publish an assignment and add an override with a due date
that includes all five students
* Go to the assignment details page
* Verify it shows one override with its corresponding due date and the
description "5 students"
* Conclude the enrollment of one of the students and go back to the
assignment details page
* Verify it now shows one override with its corrseponding due date and
the description "4 students"
* Deactivate another student and go back to the assignment details page
* Verify it now shows one override with its corrseponding due date and
the description "3 students"
* Restore the enrollment of both students and go back to the assignment
details page
* Verify it now shows one override with its corrseponding due date and
the description "5 students"
Change-Id: I260260e27078583849022aa129c986ba76069d04
Reviewed-on: https://gerrit.instructure.com/132510
Reviewed-by: Spencer Olson <solson@instructure.com>
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
QA-Review: Indira Pai <ipai@instructure.com>
Reviewed-by: Derek Bender <djbender@instructure.com>
Tested-by: Jenkins
Product-Review: Keith T. Garner <kgarner@instructure.com>
this commit removes jquery.elastic from speed_grader.js and replaces the
auto growing behavior with an instructure-ui TextArea component that has
this behavior built-in.
I attempted to also remove jquery.elastic from canvas but it appears
that this will take more consideration for the two remaining places in
the Conversations project area.
fixes: GRADE-669
Test Plan:
- Given a course with at least one student and a graded assignment
- Given speedgrader
- Given some text in the comment box
- Given adjusting the comment box size to a larger size
- Given clicking inside the comment box to give it focus
- When clicking submit
- Then the comment successfully submits
Change-Id: I5061252e319fa50f8db4fad0b781bd316791216b
Reviewed-on: https://gerrit.instructure.com/134009
Tested-by: Jenkins
Reviewed-by: Shahbaz Javeed <sjaveed@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
QA-Review: Indira Pai <ipai@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
Because of this line, Jenkins has only been running this one test since
Yesterday at 4pm
I’ll see if I can add a separate commit to add a linter for this
Test plan:
* look at the linters and js build and it should have a lots of tests,
not just one
Change-Id: I9b01496d205f49a97f27066a3a3da8f225b9214d
Reviewed-on: https://gerrit.instructure.com/134885
Reviewed-by: Brad Horrocks <bhorrocks@instructure.com>
Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com>
Tested-by: Jenkins
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
closes GRADE-701
test plan:
* Create and publish a course and enroll five students in it
* Create and publish an assignment and add an override with a due date
that includes all five students
* From the Rails console, verify all students have the same due date
# a is the Assignment you created above
a.reload.submissions.map(&:cached_due_date)
* Go to the assignment details page
* Verify it shows one override with its corresponding due date and the
description "5 students"
* Conclude the enrollment of one of the students and go back to the
assignment details page
* Verify it now shows one override with its corresponding due date and
the description "4 students"
* Change the due date of the override to a different date
* From the Rails console, verify all students have the same due date
except the concluded student, who should still have their old due
date
# a is the Assignment you created above
a.reload.submissions.map(&:cached_due_date)
* Deactivate another student and go back to the assignment details page
* Verify it now shows one override with its corresponding due date and
the description "3 students"
* Change the due date of the override to a different date
* From the Rails console, verify all students have the same due date
except the concluded student, who should still have their old due
date. The inactive student should have their due date updated to the
one you just entered
# a is the Assignment you created above
a.reload.submissions.map(&:cached_due_date)
* Restore the enrollment of both students and go back to the assignment
details page
* Verify it now shows one override with its corresponding due date and
the description "5 students"
* Change the due date of the override to a different date
* From the Rails console, verify all students have the same due date
including the student who was previously concluded but was just
unconcluded
# a is the Assignment you created above
a.reload.submissions.map(&:cached_due_date)
Change-Id: Ifd64afcfffb5924f29710545d403e53470241a41
Reviewed-on: https://gerrit.instructure.com/134158
Reviewed-by: Derek Bender <djbender@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
Tested-by: Jenkins
QA-Review: Indira Pai <ipai@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
closes PLAT-2927
Test Plan:
- Under an assignment creation, select online
- Click only the Text Entry box
- The plagiarism Review section should appear
- Save the submission
- As a student, submit the assignment after entering text in the
field
- Submission should submit with the body to the TP
Change-Id: Ice010860a8bc89e0ead02c257baaad1bc4e91b23
Reviewed-on: https://gerrit.instructure.com/134430
Tested-by: Jenkins
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Karl Lloyd <karl@instructure.com>
closes CORE-358
This makes it so files uploaded to groups via the sidebar
get the proper attributes to allow inline preview options
to show up in the RCE.
Test Plan:
- Go to a group and create a page
- On that page use the sidebar to upload a file
- Click on the link that appears in the RCE
- Click the link button in the RCE toolbar
- You should see 2 checkbox options related to inline previews
Change-Id: Ic046e737a6ef05c7dc7b7fcc92267832a161d566
Reviewed-on: https://gerrit.instructure.com/134320
Tested-by: Jenkins
Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com>
QA-Review: Tucker McKnight <tmcknight@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
Closes: CORE-720
We have this thing where you can add ?optimized_js=0 to the url of any
page and it will try to serve the dev js bundles. But at deploy time
we weren’t actually building the dev bundles so they weren’t available.
(You can see this by going to a page right now in prod and adding
?optimized_js=0 to the url and seeing all the 404s for the js bundles).
This makes it so we build both so if you do the ?optimized_js=0 thing,
they will exist and it will work.
Test plan:
* run RAILS_ENV=production bundle exec rake canvas:compile_assets
* start a server in prod mode
* go to a page, all the js should be minified
* go to the same page with ?optimized_js=0 at the end of the url
* all the js should work and should be the same as what you see in dev
mode
* the selenium Jenkins build should not take any longer than it normally
Does since it should not build both bundles.
Change-Id: I612222cfc4ef5282a986a2467e76d70ffcf30629
Reviewed-on: https://gerrit.instructure.com/134107
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
fixes GRADE-271
Test Plan:
1. Modify a local copy of config/locales/is.yml, adding
the following translation key:
csv:
column_delimiter: ";"
2. Change Canvas settings to Íslenska (Icelandic):
- root account settings
- user profile
- course settings
3. Create at least two students and at least two
assignments for a course.
- name at least one assignment with non-ASCII
Icelandic characters such as "ð"
- name at least one assignment with multi-byte
Unicode characters, such as "文章"
4. Grade the assignments, covering the following:
- decimal grade (with comma as decimal separator)
- integer grade
- empty grade
5. Go to (old) gradebook, export grades and download it
6. Configure Microsoft Excel for Icelandic language
7. Open the download in Excel. Verify that rows and
columns are interpreted correctly, and that non-
ASCII characters are displayed correctly.
8. Import the download in Google Sheets, specifying
semicolon as the custom delmiter. Repeat the
verification from (7)
9. Repeat steps 3-8 using new gradebook.
10. Repeat steps 3-8 using US English for all
language settings.
11. Copy the Icelandic and English grade exports and
modify some student grades
12. Import the modified Icelandic export file, while
configured for US English. Verify that student
grades are updated.
13. Import the modified English export file. Verify
that student grades are updated.
Change-Id: Icf7fcdadae5b22fad524a224d956fd93c2438b57
Reviewed-on: https://gerrit.instructure.com/128786
Reviewed-by: Jeremy Neander <jneander@instructure.com>
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
Tested-by: Jenkins
QA-Review: Indira Pai <ipai@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
Removes the develompent flag protection around the Late Policies
feature in New Gradebook. This means users of New Gradebook will now
be able to create Late Policies for their courses.
closes GRADE-332
Test Plan:
1. Start a server without passing the GRADEBOOK_DEVELOPMENT flag.
2. Enter the Gradebook in a course with New Gradebook enabled and
without any late submissions.
3. Click the settings cog. Verify the Late Policy content is available.
4. Verify there is not an alert in the modal stating 'Changing the late
policy will affect previously graded submissions.'
5. In the same course, create an assignment and make it due in the
past. Submit late to the assignment as a student. Do not grade the
late submission.
6. Go to Gradebook and click the settings cog to bring up the Late
Policy information.
7. Verify there is not an alert in the modal stating 'Changing the late
policy will affect previously graded submissions.'
8. Give the late submission a grade, and reload the Gradebook.
9. Click the settings cog to bring up the Late Policy information.
10. Verify there is an alert in the modal stating 'Changing the late
policy will affect previously graded submissions.'
Change-Id: I19dfe24ef5ccab427b15fc58dc09b01ab8dfd0de
Reviewed-on: https://gerrit.instructure.com/134487
Tested-by: Jenkins
Reviewed-by: Indira Pai <ipai@instructure.com>
Reviewed-by: Derek Bender <djbender@instructure.com>
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
test plan:
* have a blueprint course with a course home
set to a wiki front page
* sync it to an associated course (with settings)
* create another page in the blueprint
and set it to the front page
* sync settings over to the associated course
* it should set the new page as the front page
in the associated course
closes #ADMIN-582
Change-Id: Id449bc39b267986bd3278622be4ebbed6e6c09b4
Reviewed-on: https://gerrit.instructure.com/134634
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
titles should theoretically be unique but apparently
sometimes they aren't
closes #ADMIN-588
Change-Id: I1510494a63bc9d440ba4f0007223ad6d33e93865
Reviewed-on: https://gerrit.instructure.com/134746
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Quiz submission data in serialized columns is sometimes stored in binary
format (see https://github.com/ruby/psych/issues/278). This tends to
happen when strings contain non-printing control characters like `\b`
(backspace). When retrieved from the database, these strings are given
the encoding ASCII_8BIT, even if they are valid UTF-8. This causes the
quizzes history page to fail with a 'incompatible character encodings'
error when a quiz contains a fill multiple blanks question.
This commit fixes the issue by forcing all serialized quiz submission
data back to UTF-8 before rendering.
Fixes QO-288
Refs CNVS-40243
Refs CNVS-39936
Refs CNVS-38869
Refs CNVS-37031
Refs CNVS-36209
Refs CNVS-36202
Refs CNVS-36148
Test plan:
- Create a Quizzes 1 quiz
- Add a 'fill in multiple blanks' question that contains 1 blank and at
least 1 non-ASCII character
- Take the quiz using IE 11 on Windows
- Type or paste 1 or 2 non-ASCII characters (e.g. 你好) into Notepad.
It's important not to insert more than 2 characters, as the heuristic
that psych uses to determine whether to encode a string as binary
depends on the string length.
- In Notepad, press ctrl+backspace. You should see a small square appear
alongside the 1 or 2 characters inserted in the previous step. This
square is actually an ASCII backspace character
- Select the text in Notepad and copy-paste it into the blank space in
the quiz question
- Submit the quiz
- Check that the quiz results are displayed without error
Change-Id: I0df5b5b2296f8c436ec219e1d53c9dd5da57c622
Reviewed-on: https://gerrit.instructure.com/133733
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Michael Hanks <mhanks-c@instructure.com>
Tested-by: Jenkins
Product-Review: Omar Khan <okhan@instructure.com>
closes OUT-1719
test plan:
- create an assignment and attach a rubric
- go to speedgrader
- as the teacher, open the rubric and give the student
points that exceed the max points possible
- save the rubric - the score should show immediately
and also persist after save
- change the score to 0
- the score should show immediately and immediately
persist upon reload
- remove the score entirely
- the score should be removed immediately and the
removal should persist after reload
Change-Id: Ib0c6784592c58194620e5a2e61762aff9322f84b
Reviewed-on: https://gerrit.instructure.com/134421
Tested-by: Jenkins
Reviewed-by: Michael Brewer-Davis <mbd@instructure.com>
Reviewed-by: Neil Gupta <ngupta@instructure.com>
QA-Review: Andrew Porter <hporter-c@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
fixes GRADE-699
test plan:
1. Create a Course with more than 10 Students
2. Visit the Course in New Gradebook
3. Verify all Student Submissions are loaded
4. Visit the Course in Old Gradebook
5. Verify all Student Submissions are loaded
Change-Id: I70a9c6f03364d1f5bdd03cf35fd734e52aaa5537
Reviewed-on: https://gerrit.instructure.com/134534
Tested-by: Jenkins
Reviewed-by: Spencer Olson <solson@instructure.com>
Reviewed-by: Derek Bender <djbender@instructure.com>
QA-Review: Indira Pai <ipai@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
refs RECNVS-105
before we returned null for the whole grades object but that is
worse because then you can't access the htmlUrl
Test plan:
- set up a course with no assignments
- make sure you can query the grades for student enrollments (the
grades should be null, but the htmlUrl should work
Change-Id: I459f97193595ebaac52e063063d88b41301922fd
Reviewed-on: https://gerrit.instructure.com/134561
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
Reviewed-by: Neil Gupta <ngupta@instructure.com>
Tested-by: Jenkins
QA-Review: Collin Parrish <cparrish@instructure.com>
Product-Review: Cameron Matheson <cameron@instructure.com>
refs COMMS-554
test plan:
- in a course, create some announcements
- navigate to the announcements page and note it loads the old page
- turn on section specific announcements feature flag at the account
level
- navigate to the announcements page
- note that you see a 'Announcements (2) items on page x' with
the number in the parens matching the number of announcements
in that course
Change-Id: I6982aa2b20864f96ae61a052b33948f65bf549e2
Reviewed-on: https://gerrit.instructure.com/134425
Reviewed-by: Steven Burnett <sburnett@instructure.com>
QA-Review: Venk Natarajan <vnatarajan@instructure.com>
Tested-by: Jenkins
Product-Review: Aaron Kc Hsu <ahsu@instructure.com>
fixes gh-1159
test plan:
- try to create an audio tag with the controls attribute
- it should persist across save
Change-Id: I84ec4ce6fecacdbaff91d8d53e8dde4b7ab5c736
Reviewed-on: https://gerrit.instructure.com/133028
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
Fixes: UIDEV-135
note: while here... updated text for consistency and to align
with what design wanted
test plan:
- as an admin, ensure that account allows adding course images
to the dashboard cards
- navigate to a course, select "settings" from the sub-nav
- on the first tab "course details" if there isn't an image
currently... click the "choose image" button _or_ if there
is an image select the "choose image" option from the cog
- the full-screen modal should now have a close button without
a background color/shape
example: https://screencast.com/t/Jml37Nx3Z
Change-Id: Iade89bd0098cc064c19807fe84352fae0944c03e
Reviewed-on: https://gerrit.instructure.com/133910
Tested-by: Jenkins
Reviewed-by: Stephen Jensen <sejensen@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Product-Review: Kyle Follett <kfollett@instructure.com>
fixes OUT-1688
Test Plan
* Make sure Mastery Paths is all setup using the README in
the Mastery Paths Repository
* Make sure Course has Mastery Paths on it
* Create a Discussion topics that is tied to a group
* Go to the page for that group
* Try to access mastery paths from the cog within a group
* Check to make sure correct permissions are unchanged for
Teacher, Student, and Admin For Accessing Course Edit Page
* Verify that there is no error in error_reports
Change-Id: Ic9fc62378dcafc03ab00c56b6297a9bd6aa0d219
Reviewed-on: https://gerrit.instructure.com/133537
Tested-by: Jenkins
Reviewed-by: Michael Brewer-Davis <mbd@instructure.com>
QA-Review: Leo Abner <rabner@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
fixes COMMS-567
test plan:
- test in Safari 10 and 11
- enable user avatars
- go to /profile/settings and click the edit button on the user avatar
- select the "Take a Picture" tab
- note that webcam picture capture works
Change-Id: I54a117a9629e11225944288cfaffa90c119187cf
Reviewed-on: https://gerrit.instructure.com/134362
Tested-by: Jenkins
Reviewed-by: Venk Natarajan <vnatarajan@instructure.com>
QA-Review: KC Naegle <knaegle@instructure.com>
Product-Review: Felix Milea-Ciobanu <fmileaciobanu@instructure.com>
fixes CORE-45
test plan:
- config local canvas to use local mathman
- in equation editor, paste the pound symbol: £
- save the equation
- verify the pound symbol is rendred in the image
Change-Id: I24cfc8788de784e21214c39b65c919b4b2117ff9
Reviewed-on: https://gerrit.instructure.com/132330
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: brian kirkby <bkirkby@instructure.com>
QA-Review: Collin Parrish <cparrish@instructure.com>
Tested-by: Jenkins
Allows for lti launch where you can expand the display name of
a user in lti tools for use.
closes PLAT-2776
Test Plan:
- Create an lti config that uses Person.name.display
- Do an lti launch and verify that the expanded value as a param
- For LTI 2, create a tool proxy that includes the Personl.name.display
capability
- Repeat step 2
Change-Id: I7f919bb9af2bb1efb42d8a3bd76cfb3b69378152
Reviewed-on: https://gerrit.instructure.com/134518
Tested-by: Jenkins
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Marc Alan Phillips <mphillips@instructure.com>
fixes COMMS-538
Test Plan
* Go to conversations page
* Check and uncheck a box
* Check to make sure the checkbox retains focus
Change-Id: I2bcbdfbefa55ad4f30c3f051cbe5b563e3439c2f
Reviewed-on: https://gerrit.instructure.com/134187
Reviewed-by: Felix Milea-Ciobanu <fmileaciobanu@instructure.com>
Tested-by: Jenkins
QA-Review: Nathan Rogowski <nathan@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
fixes CORE-676
also, always fudge dates coming in to these helpers, so that you don't have to
remember to fudge them if you already have a date object.
oh, and switch a broken call to tTimeToString to use tDateToString (medium
isn't a valid time format)
test plan:
* enable page views
* change your time zone in canvas to something that doesn't match your
computer/browser
* view your users page, with page views
* the timestamps should be in the canvas time zone, not the computer's
time zone
* ditto for checking audit logs
* ditto for editing calendar events
Change-Id: I7771bbea59fec94945c34cdcff88605697209d51
Reviewed-on: https://gerrit.instructure.com/134123
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
see https://bugs.chromium.org/p/chromium/issues/detail?id=720283
and https://bugs.chromium.org/p/chromium/issues/detail?id=490015
Basically, chrome is preventing us from using Navigator.sendBeacon
to clear the accessCode. Since it seems there is code already in
place as a backup to Navigator.sendBeacon, seems reasonable to just
use that code in all cases.
fixes QO-99
test plan:
- take a quiz with an access code in chrome (version 60 or greater)
- leave in the middle of the quiz (close the tab)
- open up the quiz again and attempt to resume it
- should be prompted to put in the access code again
- also test in all other supported browsers to make sure an access
code is required any time you attempt to resume a quiz
Change-Id: I67c75bc37ce4d53151f4f218297e78b97ed0da66
Reviewed-on: https://gerrit.instructure.com/134325
Tested-by: Jenkins
Reviewed-by: Davis Lynn McClellan <dmcclellan@instructure.com>
QA-Review: David Tan <dtan@instructure.com>
Product-Review: Kevin Dougherty <jdougherty@instructure.com>
fixes OUT-1675
test plan:
- in a course with CYOE enabled, create a quiz
- for ease of testing, ensure quiz is set up
for retakes and using the latest score
- create some assignments and lock them to mastery paths
- create at least one wiki page, and also enable
the 'mastery paths' checkbox on them (found under
the textbox for editing content)
- add the assignments and page(s) to mastery paths on
the quiz. Ensure the page(s) are on their own tiers
for ease of testing
- create a module, add the quiz as the first item, the page(s)
immediately following it, then the other assignments
- on the quiz, get a score that does NOT unlock the tier
that the page(s) exist on
- the 'next' button for progressions should skip the still
locked page (once paths finish processing or you make any
necessary path selections, based on how you set things up)
- retake the quiz, and get a score that DOES unlock the page(s)
- the next page should appear as expected as the next item in
the path progression one paths finish calculating
- teachers should not experience any changes in behavior,
this should only impact students
Change-Id: Ibd2dd664723e1006944a1d9410ce3b442ae6ade7
Reviewed-on: https://gerrit.instructure.com/132873
Tested-by: Jenkins
Reviewed-by: Neil Gupta <ngupta@instructure.com>
QA-Review: Leo Abner <rabner@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
Keith Garner