fixes CNVS-25467
fixes CNVS-25468
test plan:
- Go to assignment and quiz page
- Ensure that "Post grade to SIS enabled" icon is attached to
all assignments that have the option enabled and that
"Post grade to SIS disabled" icon is on the rest.
- Click "Post grade to SIS enabled" icon and ensure that
it toggles on the screen and that the option toggles for the
assignment
- Ensure that the icon is accesible
- Check that tooltip on icon is correct on both toggle positions
- Disable post grades to SIS at the account level
- Check both quizzes and assignments to ensure that the icon is
no longer there
Change-Id: Ib6682a7ca4d77dcc9a5e05095e33920eac981e9b
Reviewed-on: https://gerrit.instructure.com/68635
Tested-by: Jenkins
Reviewed-by: Ryan Taylor <rtaylor@instructure.com>
QA-Review: Rajkumar Kethavath <rkethavath@instructure.com>
Product-Review: Jason Sparks <jsparks@instructure.com>
Support passing a class for an icon for styling goodness.
added support for `canvas_icon_class` allowing use od css classes from canvas
style guide which can make it look better and maintain our styling
standards.
Fixes PLAT-1222
Test Plan:
prereq's
- "LOR External Tools" feature flag enabled
- (notice the lack of lti example tool, you dont need it)
A new commons icon has been added so you should probably run the
following
`bundle exec rake brand_configs:clean canvas:compile_assets`
Add a new LTI tool to the account using [this xml](https://gist.github.com/defektive/dbd182cb04500e236bde)
check placements to make sure they show a fancy new icon instead of a
crappy star. course_home_sub_navigation should show up as the commons icon
placements to look at
:assignment_menu - cog on an assignment
:course_home_sub_navigation - right side of page
:course_settings_sub_navigation
:discussion_topic_menu
:file_menu (no icon)
:global_navigation (no icon)
:module_menu
:quiz_menu
:wiki_page_menu
Change-Id: Ib462e928a5a3811df490f9bf2441b755db2882a9
Reviewed-on: https://gerrit.instructure.com/62492
Tested-by: Jenkins
Reviewed-by: Nathan Mills <nathanm@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Brad Horrocks <bhorrocks@instructure.com>
refs CNVS-19605
Note: added two new icons to the canvas iconset (equation, equella)
Test plan:
- Enable the kaltura plugin at /plugins/kaltura (see https://gollum.instructure.com/OtherServiceTestAccounts#Notorious-(NO-MORE-KALTURA-YAY))
- Enable the Equella feature for the account
- Verify that the link, image, equation, record video and equella icons are updated (http://cl.ly/image/2H3m331w0f1O)
- Hover states should match the other menu buttons
Change-Id: I91c298f3dcb2146748d6104342aa265eb43462e9
Reviewed-on: https://gerrit.instructure.com/56283
Tested-by: Jenkins
Reviewed-by: Colleen Palmer <colleen@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
QA-Review: August Thornton <august@instructure.com>
the rails asset pipeline expects fonts to be
in the 'fonts' directory of it's assets folder.
since we're using it to put md5s in our urls,
I'm moving it there
test plan:
* no changes,
* load page and ensure icons and fonts still work
Change-Id: Iec3a1b04259b1d74fbfa98f9ecc53d98e972e02a
Reviewed-on: https://gerrit.instructure.com/54805
Tested-by: Jenkins
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Davis McClellan