the global grades page will now use global grading
period IDs to support selecting grading periods
accross shards.
fixes CNVS-31407
fixes CNVS-31523
test plan:
* you will need an account in a trust relationship
with a cross-shard account
1. enroll a user in a course in the main account.
2. enroll same user in a course in the
cross-sharded account.
3. enable "Multiple Grading Periods" in the
cross-sharded course.
4. create an assignment in each course as a teacher
5. create a submission for each assignment as the student
6. grade the submission from the cross-shard course
7. return to the main account and masquerade as the
user.
8. visit the user's dashboard and click
"View Grades". select a grading period from the
dropdown on the cross-shard course.
9. verify no error message is shown and the total
grade updates.
10. go to the non-global grades page for the
cross-shard course (/courses/:course_id/grades).
11. select a grading period from the dropdown and
verify the grade updates with no error.
12. go to the cross-shard account and masquerade as the
user.
13. visit the user's dashboard and click
"View Grades". select a grading period from the
dropdown on cross-shard course.
14. verify no error message is shown and the total
grade updates.
Change-Id: I3324c09f33ad976e76cf613a8163e3b7670a5cda
Reviewed-on: https://gerrit.instructure.com/89467
Tested-by: Jenkins
Reviewed-by: Spencer Olson <solson@instructure.com>
Reviewed-by: Derek Bender <djbender@instructure.com>
QA-Review: KC Naegle <knaegle@instructure.com>
Product-Review: Christi Wruck
should be faster
Change-Id: I818aec69b5273bbaf7ef5933a00f2c32c1775823
Reviewed-on: https://gerrit.instructure.com/87886
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
avoid a chunk of student visibility logic if an
assignment is visible to all students. instead,
if an assignment is visible to all students, set
its associated visibility array to all students
in the course and sidestep the logic that was
previously run.
closes CNVS-19971
test plan:
- create a course that contains assignments with
no overrides, student overrides, section
overrides, group overrides, and combinations of
different types of overrides.
- verify the gradebook loads without issue.
- verify grade cells are correctly greyed out
in the gradebook (students that do not have an
assignment assigned to them should have their
cell greyed out in that assignment's column)
Change-Id: I14f363351ac2a3b631c74f027003fda2bd79d81a
Reviewed-on: https://gerrit.instructure.com/72281
Tested-by: Jenkins
Reviewed-by: Cameron Matheson <cameron@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Spencer Olson <solson@instructure.com>
fixes CNVS-16367
test plan:
- go to modules page and change stuff and save
- things dont break
- DA'd discussions/assignments/quizzes filter out
of the modules page for students
- the page for all student progressions works
as it should
Change-Id: I8403e4c508169e7f3750f3ddc7494f4a4ed3f371
Reviewed-on: https://gerrit.instructure.com/43113
Reviewed-by: Cameron Sutter <csutter@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Sean Lewis <slewis@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
Cody Cutrer