Commit Graph

30820 Commits

Author SHA1 Message Date
Cody Cutrer 05c6a7c046 bump saml2
Change-Id: I27feddcc6212b80691a8ba06f9baef61abfce586
Reviewed-on: https://gerrit.instructure.com/152337
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Tested-by: Rob Orton <rob@instructure.com>
2018-06-02 19:56:39 +00:00
Cody Cutrer 86355dbd0e bump saml2
Change-Id: I8a4ba3e6ea520e374bc53ed99368d233c879e911
Reviewed-on: https://gerrit.instructure.com/152335
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Tested-by: Cody Cutrer <cody@instructure.com>
2018-06-02 18:21:45 +00:00
Rob Orton 10ee663f3f spec: create fewer objects
I’m sure this could improved more, but this works
with a few seconds of work and saves seconds per
run.

test plan
 - specs should pass

Change-Id: If2d8e9c8857c58485fef3745d88ecb22ef51e5c1
Reviewed-on: https://gerrit.instructure.com/151956
Tested-by: Jenkins
Reviewed-by: James Williams  <jamesw@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
2018-06-02 14:43:09 +00:00
Jeremy Neander 4ba1e44abb conditionally prevent unmuting moderated assignments
closes GRADE-1179

test plan:
 A. Setup
    1. Setup a course with AMM and a muted moderated assignment
    2. Disable AMM
    3. Log in as various instructors and grade all students
       * Not every grader needs to grade all students
       * But give all students at least one provisional grade
    4. Log in as the moderator
    5. Visit the moderation page for the assignment
    6. Ensure grades are completely selected
       * select a grade for each student
    7. Enable AMM

 B. Verify in New Gradebook
    1. Visit New Gradebook as an admin
    2. Verify the option to Unmute is disabled
    3. Verify other assignments can be muted and unmuted

 C. Verify in Old Gradebook
    1. Visit Old Gradebook as an admin
    2. Verify the option to Unmute is disabled
    3. Verify other assignments can be muted and unmuted

 D. Post Grades
    1. Log in as the moderator
    2. Visit the moderation page for the assignment
    3. Post grades

 E. Verify in New Gradebook
    1. Visit New Gradebook as an admin
    2. Verify the option to Unmute is enabled

 F. Verify in Old Gradebook
    1. Visit Old Gradebook as an admin
    2. Verify the option to Unmute is enabled

Change-Id: I63c1b67934a34e7e5d0a57196263da9729d21555
Reviewed-on: https://gerrit.instructure.com/152136
Tested-by: Jenkins
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
Reviewed-by: Adrian Packel <apackel@instructure.com>
QA-Review: Indira Pai <ipai@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
2018-06-02 13:58:14 +00:00
Transifreq 8e77bfe834 update zh-Hans translation
Change-Id: Ie8a2db29fd3a3db07fe9f6c94a4855d78d623750
2018-06-02 05:34:15 -06:00
Cameron Sutter 080beef78d allow all observers
closes MBL-10561

test plan:
- go through all the observer_alerts & observer_alert_thresholds
  endpoints and use them with a course observer

Change-Id: I64b14746969727b69b047139fdceecb89f4c123a
Reviewed-on: https://gerrit.instructure.com/151107
Reviewed-by: Matthew Sessions <msessions@instructure.com>
Tested-by: Jenkins
QA-Review: Taylor Wilson <twilson@instructure.com>
Product-Review: Taylor Wilson <twilson@instructure.com>
2018-06-02 01:57:34 +00:00
Erin Hallmark 415301357f add files for api change log
Fixes DOC-794

Test Plan:
- compile api documentation - rake doc:api
- view new changelog and breaking api change files
- check that links to new files work in README doc
- check that CSS is okay and nothing is broken

Change-Id: I9f72f1b9fc056842b80c9ae0f45e17d51036449b
Reviewed-on: https://gerrit.instructure.com/152037
Reviewed-by: Pam Hiett <phiett@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
2018-06-01 23:45:40 +00:00
Michael Brewer-Davis a84bd0f18e show quiz info in new student lmgb
closes OUT-2235

Test plan:
- Enable non-scoring rubrics
- Create a question bank aligned to an outcome
- Create a quiz using questions from the question
  bank
- As a student, take the quiz
- Go to the student lmgb
- Verify that the outcome result for the quiz
  shows the quizzes icon, and shows the name
  of the quiz rather than the name of the quiz bank

Change-Id: I413bb936c182485dbcc3d01c34fbb5f292856548
Reviewed-on: https://gerrit.instructure.com/150948
Reviewed-by: Augusto Callejas <acallejas@instructure.com>
Tested-by: Jenkins
QA-Review: Dariusz Dzien <ddzien@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
2018-06-01 22:17:51 +00:00
Augusto Callejas 26c29259fe Backfill values without using a job
closes OUT-2178

test plan:
  - run on your test environment and confirm no migration errors:
    * docker-compose run --rm web bundle exec rake db:drop RAILS_ENV=test
    * docker-compose run --rm web bundle exec rake db:create RAILS_ENV=test
    * docker-compose run --rm web bundle exec rake db:migrate RAILS_ENV=test

Change-Id: I08ae607ae0c6ad48a7990a56dce2e0041c229c30
Reviewed-on: https://gerrit.instructure.com/151889
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
QA-Review: Frank Murphy <fmurphy@instructure.com>
Product-Review: Augusto Callejas <acallejas@instructure.com>
2018-06-01 22:07:36 +00:00
Simon Williams 10f1413dea include pandata url in pandata_token response
closes CORE-1480

test plan:
- pandata_token endpoint should include a url key in the response
- url is based on dynamic settings, pandata/env/pandata-url

Change-Id: Ic3ab95b5d19b4d07cc72a5930017b73c8d0eac77
Reviewed-on: https://gerrit.instructure.com/152267
Tested-by: Jenkins
Reviewed-by: Cameron Sutter <csutter@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
2018-06-01 22:03:19 +00:00
Simon Williams e5414f7d23 add more claims to pandata_token
closes CORE-1478

test plan: no regressions with the pandata_token endpoint

Change-Id: I4e75bdd724418d2b40131df153d7d2df80d075cb
Reviewed-on: https://gerrit.instructure.com/152119
Reviewed-by: Cameron Sutter <csutter@instructure.com>
Tested-by: Jenkins
Product-Review: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
2018-06-01 22:03:10 +00:00
Simon Williams a84ad6bd80 restrict pandata_token endpoint to only certain developer keys
closes CORE-1477

test plan:
- try to hit /api/v1/users/self/pandata_token with a session
- it should fail
- try to hit it with an access token
- it should fail
- set Setting.set("pandata_token_allowed_developer_key_ids",
                  token.global_developer_key_id)
- try again, it should work

Change-Id: I54092df1ad395b8e641bbf8b635576b5b669def4
Reviewed-on: https://gerrit.instructure.com/152118
Tested-by: Jenkins
Reviewed-by: Cameron Sutter <csutter@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
2018-06-01 22:03:04 +00:00
Simon Williams fddf85a7f2 only allow fetching a pandata_token for current user
closes CORE-1475

test plan:
- use the users pandata_token endpoint, but with
`/api/v1/users/self/pandata_token`
- it should still work

Change-Id: I6ef8723d564cab4035821761817809033461c18c
Reviewed-on: https://gerrit.instructure.com/152117
Tested-by: Jenkins
Reviewed-by: Cameron Sutter <csutter@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
2018-06-01 22:02:57 +00:00
Venk Natarajan 8b6c6777d8 Add in role filter for granular permissions.
This implements the role filter.

Closes COMMS-898

Test Plan:
* Enable new permissions UI, go to permissions table.
* Make sure the role filter works and is a11y
* Combine it with permissions search make sure it
  works
* Switching tabs should clear out the filters.
* Make sure in all cases removing all role filters
  shows all the roles in the table.

Change-Id: I634a5c58384f95f30e07897820e6f81c530cdcc3
Reviewed-on: https://gerrit.instructure.com/151488
Tested-by: Jenkins
Reviewed-by: Steven Burnett <sburnett@instructure.com>
QA-Review: Landon Gilbert-Bland <lbland@instructure.com>
Product-Review: Landon Gilbert-Bland <lbland@instructure.com>
2018-06-01 22:00:34 +00:00
Ed Schiebel 2ec6ee7262 Keep course image modal on top of course settings page
fixes ADMIN-1099

test plan:
  - go to course settings
  - click the course image button
  > expect the modal to open and cover the page
  > while ESC will dismiss it, it's a known issue that clicking
    the X close button does not.

Change-Id: I234b27c2462614e4d9fa276b0971b9bfef962788
Reviewed-on: https://gerrit.instructure.com/152219
Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Tested-by: Jenkins
Product-Review: Ed Schiebel <eschiebel@instructure.com>
2018-06-01 20:28:13 +00:00
Cody Cutrer aa8b0e3d1c use @domain_root_account as the context for a bare /api/v1/users/self
fixes CORE-1458

test plan:
 * go to /api/v1/users/self; it should work

Change-Id: I0f929ebed3fb809d554c9476946a881124e62280
Reviewed-on: https://gerrit.instructure.com/151438
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Matt Miller <mmiller@instructure.com>
Tested-by: Jenkins
2018-06-01 20:11:23 +00:00
Anju Reddy 838c654c68 spec: mute/unmute anonymous assignment by default
Change-Id: I0b8deb9257909a4e6dea5a0d70ff554b0bdf7776
FIXES: GRADE-1186
Reviewed-on: https://gerrit.instructure.com/151479
Tested-by: Jenkins
Reviewed-by: Indira Pai <ipai@instructure.com>
Product-Review: Anju Reddy <areddy@instructure.com>
QA-Review: Anju Reddy <areddy@instructure.com>
2018-06-01 20:00:36 +00:00
Jeremy Neander 1fc92e13f9 spec: update grading standard component specs
refs GRADE-544

test plan:
 * Verify Jenkins likey

Change-Id: Iff885917abb73d7fb56532e8759836ff9d1f8e28
Reviewed-on: https://gerrit.instructure.com/152232
Tested-by: Jenkins
Reviewed-by: Spencer Olson <solson@instructure.com>
Product-Review: Jeremy Neander <jneander@instructure.com>
QA-Review: Jeremy Neander <jneander@instructure.com>
2018-06-01 19:44:30 +00:00
Ryan Shaw 9e30db867c instUI5 upgrade: developer keys
refs: CORE-1437

This commit just upgrades these components to use instUI 5 instead of
getting them from ui-core in instUI 4.

It is mostly just path renaming.

Test plan:
* verify these components still work as they used to and tests pass

Change-Id: I115b77336bb70f2bebc8feb380d72530366c1ea7
Reviewed-on: https://gerrit.instructure.com/151776
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
Reviewed-by: August Thornton <august@instructure.com>
2018-06-01 19:04:46 +00:00
Cody Cutrer cb503daf6c properly delete from an AttributeSet
also, remove extra check that was unnecessary

Change-Id: I524b70c41946a4ab537422a35c1727e439bb6848
Reviewed-on: https://gerrit.instructure.com/152236
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Tested-by: Cody Cutrer <cody@instructure.com>
2018-06-01 18:56:59 +00:00
Cody Cutrer c5d392049e ignore attributes we don't know about in BroadcastPolicy
Change-Id: I59382723f54d5528c9b5517418093deef024e2a9
Reviewed-on: https://gerrit.instructure.com/152218
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
Tested-by: Jenkins
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
2018-06-01 18:10:03 +00:00
Brent Burgoyne 07fb1d39c4 ensure locale is set from localizer before js env
refs CORE-1465, refs CORE-1466

test plan:
- QA on beta:
  https://jcatibog.beta.instructure.com/courses/8392/quizzes/3613/edit
- RCE sidebar should be translated
- Date picker should work correctly

Change-Id: I7b0037d52634efb10d793a9d669f34c0bcd28660
Reviewed-on: https://gerrit.instructure.com/152023
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
QA-Review: Brent Burgoyne <bburgoyne@instructure.com>
2018-06-01 18:05:39 +00:00
Steven Burnett e8e65cb54b fix minor issues with imports
Test Plan:
- tests pass and permissions still load

Change-Id: If459e7f1c54cb64d740366e2a8af9d5bac02b88f
Reviewed-on: https://gerrit.instructure.com/152206
Reviewed-by: Landon Gilbert-Bland <lbland@instructure.com>
Reviewed-by: Venk Natarajan <vnatarajan@instructure.com>
Tested-by: Jenkins
Product-Review: Venk Natarajan <vnatarajan@instructure.com>
QA-Review: Venk Natarajan <vnatarajan@instructure.com>
2018-06-01 17:49:26 +00:00
wdransfield 3613e15e9c Change "Scopes" doc name to "API Token Scopes"
Closes PLAT-3446

Test Plan:
- doc:api rake task is successful
- "Scopes API" has been replaced with "API
   Token Scopes" in the resources api docs
- verify the api token scopes documentation
  is marked as "internal"

Change-Id: I4688d8c2ff07804626ffd37d4a8fab931ab56e73
Reviewed-on: https://gerrit.instructure.com/152198
Reviewed-by: Marc Alan Phillips <mphillips@instructure.com>
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
Product-Review: Jesse Poulos <jpoulos@instructure.com>
2018-06-01 17:25:40 +00:00
Nathan Mills 9e50d0a8db no default url sessionless launches
Also returns back json when a tool and launch url can't be found

fixes PLAT-3434

test plan:
* Create a tool with no urls only a domain and content-item configuration
* Attempt to generate a sessionless launch using a URL
* Configure an assignment using the tools content-item launch
* Attempt to generate a sessionless launch using the assignment
* The above should both work
* Also test for the use cases defined in MBL-9835

Change-Id: I4a369e1ddd1816645f6a359ba344c571ce85083d
Reviewed-on: https://gerrit.instructure.com/152153
Tested-by: Jenkins
Reviewed-by: Han Ngo <hngo@instructure.com>
QA-Review: Han Ngo <hngo@instructure.com>
Product-Review: Nathan Mills <nathanm@instructure.com>
2018-06-01 17:12:09 +00:00
James Williams ad48c840bd exclude deleted courses from planner notes api index
test plan:
* shouldn't be able to view notes for deleted courses
 in planner_notes api index

closes #ADMIN-1072

Change-Id: I715687735dd5da6c0fcbc8e9cb3834cf82c1e76b
Reviewed-on: https://gerrit.instructure.com/151487
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Luke Kingsley <lkingsley@instructure.com>
Product-Review: James Williams  <jamesw@instructure.com>
2018-06-01 17:10:09 +00:00
James Williams a4243546da overwrite filename/content_types when replacing on destroy
test plan:
* when using the file api delete endpoint with the "replace"
 param (as an account admin), it should return a renamed file
 that opens correctly when downloaded

closes #CORE-1463

Change-Id: Ibfbe5bc3e7a590bcb6efda3d7f510355b52d34d2
Reviewed-on: https://gerrit.instructure.com/151667
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rohan Cheeniyil <rcheeniyil@instructure.com>
Product-Review: James Williams  <jamesw@instructure.com>
2018-06-01 17:10:00 +00:00
Ryan Shaw e361de1655 client_apps: update deps & prepare for workspaces
This gets canvas_quizzes ready to be used as a yarn workspace

Test plan:
* the quiz log auditing pages and the quiz statistics pages
  Should look / work the exact same as before
* `cd client_apps/canvas_quizzes`
* `yarn test`
* it should work, as it did before

Change-Id: I55528fb8dfc9f49ac37989cb848be2ffd2fcf245
Reviewed-on: https://gerrit.instructure.com/152121
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
2018-06-01 16:56:38 +00:00
Ryan Shaw 03cb9f3b9a canvas-rce: update deps & prepare for workspaces
Test plan:
* tests should pass
* everything should work exactly as before

Change-Id: Iad2144ec0ab41087ea5efcc89f3492bf791dd7cf
Reviewed-on: https://gerrit.instructure.com/152122
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
2018-06-01 16:45:44 +00:00
Sara Chadwick d1fd2595ba Create enabled/disabled permission button
fixes COMMS-903
fixes COMMS-1128

Test Plan :
 - Make sure the new permissions page is toggled on
 - Navigate to http://localhost:3000/accounts/1/permissions
 - On course roles, verfiy that clicking any of the buttons will cause
 them to toggle between green check and red x
 - Verify that changing one button does not change others

Change-Id: Ie81aa2b797b26f833154824cc2c0bd835bdd7b96
Reviewed-on: https://gerrit.instructure.com/150932
Tested-by: Jenkins
Reviewed-by: Landon Gilbert-Bland <lbland@instructure.com>
QA-Review: Landon Gilbert-Bland <lbland@instructure.com>
Product-Review: Landon Gilbert-Bland <lbland@instructure.com>
2018-06-01 16:43:47 +00:00
Jeremy Neander c3e083727a add pagination to new moderation table
refs GRADE-964
closes GRADE-877

test plan:
 A. Setup
    1. Enable Anonymous Moderated Marking
    2. Select or create a course
       a. with Anonymous Marking enabled
       b. with three instructors (A, B, and C)
       c. with 51 or more students
          * this is for multiple pages of students
    3. Select or create an assignment
       a. with Moderated Grading
       b. with Anonymous Grading
       c. with instructor A as the final grader
    4. As each instructor (B and C)
       a. give at least one student a provisional grade
          on each assignment (using SpeedGrader)
       * This is optional, but is used for test plans
         in related commits

 B. Verify
    1. Log in or act as instructor A
    2. Visit the moderation page for the assignment
    3. Verify multiple pages of students load
    4. Verify the table has multiple pages
    5. Verify the table shows 20 students at a time
    6. Verify the table shows different students on each page

Change-Id: I133500446b581cfb2822eebacbfe5094c5af94ea
Reviewed-on: https://gerrit.instructure.com/151343
Tested-by: Jenkins
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
Reviewed-by: Adrian Packel <apackel@instructure.com>
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
2018-06-01 15:06:53 +00:00
Jeremy Neander 3238926671 flash error when students fail to load
refs GRADE-877

test plan:
 1. Setup a course with AMM and a moderated assignment
 2. Edit the first line of the students endpoint to fail

    app/controllers/submissions_api_controller.rb

    def gradeable_students
      fail "totes broken somehow"
      ...
    end

 3. Log in or act as the moderator
 4. Visit the moderation page for the assignment
 5. Verify a flash error appears
 6. Verify the flash error mentions loading students
 7. Remove the edit to the controller
 8. Refresh the moderation page
 9. Verify no flash error appears

Change-Id: I069f71641ed643860e27a56e615abeb643c7361c
Reviewed-on: https://gerrit.instructure.com/151601
Tested-by: Jenkins
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
Reviewed-by: Adrian Packel <apackel@instructure.com>
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
2018-06-01 15:06:49 +00:00
Clay Diffrient 0a0ae68561 Update specs to be a little less brittle/flaky
Test Plan:
  - Automated tests pass

Change-Id: I182bfb60316a79543bd4e97890f846a24d70162c
Reviewed-on: https://gerrit.instructure.com/151955
Reviewed-by: Jeremy Neander <jneander@instructure.com>
Tested-by: Jenkins
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Clay Diffrient <cdiffrient@instructure.com>
2018-06-01 13:57:10 +00:00
James Williams 39f387fd9a bump inst-jobs
fixes issues with abandoned job rescheduling

Change-Id: I2ebdaab43321e99c818f1194f90e7e8ef33acd1e
Reviewed-on: https://gerrit.instructure.com/152003
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: James Williams  <jamesw@instructure.com>
QA-Review: James Williams  <jamesw@instructure.com>
2018-06-01 12:11:01 +00:00
Neil Gupta 9b7ec59ee6 anonymize gradeable students endpoint
fixes GRADE-898 GRADE-1023

test plan:
1. create a course with 3 teachers and 1 student
2. create an anonymously graded and moderated assignment with 2 graders
3. as a teacher, give the student a provisional grade
4. as another teacher, give the student another provisional grade
5. as the final grader, visit the grade moderation page
6. inspect the API responses, there should be no identifiable ids or
  names in the responses
7. select a final grade
8. make sure the API request and response when selecting the final grade
  is also anonymous

Change-Id: I083673e29d4b49c1d97cedad46571bccc622a8a2
Reviewed-on: https://gerrit.instructure.com/151134
Tested-by: Jenkins
Reviewed-by: Jeremy Neander <jneander@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
2018-05-31 22:30:25 +00:00
Clay Diffrient 099869f0e0 Add aria-label indicating page and number
Note: In order for this to work properly without modifiying
      the arrow labels, b0a33646c55e696564f9a53987246c62fc299ae9
      from Instructure UI must be released and integrated
      into Canvas.

closes CORE-1368

Test Plan:
  - Enable new user/course search on the account
  - Use a screenreader to navigate through the pages
  - They should say "Page X" rather than just X

Change-Id: Id6c0c435e16b9ed133b9183b1dbc9f4850805af8
Reviewed-on: https://gerrit.instructure.com/149842
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Rohan Cheeniyil <rcheeniyil@instructure.com>
Tested-by: Jenkins
Product-Review: Nathan Rogowski <nathan@instructure.com>
2018-05-31 22:23:54 +00:00
Cameron Sutter e474a8120c add ObserverPairingCode model
closes MBL-10642

test plan:
- in the rails console,
  - create an ObserverPairingCode for a student
    @student.generate_observer_pairing_code
  - read pairing codes for a student
    @student.observer_pairing_codes
- generated codes should expire in 1 day
- expired and deleted codes should not be returned
  in the above call to read codes

Change-Id: I1c0bf25bca4ef34016cff94ce721e3d339e251e1
Reviewed-on: https://gerrit.instructure.com/152105
Reviewed-by: Matthew Sessions <msessions@instructure.com>
Product-Review: Matthew Sessions <msessions@instructure.com>
QA-Review: Matthew Sessions <msessions@instructure.com>
Tested-by: Jenkins
2018-05-31 22:19:37 +00:00
Michael Brewer-Davis f27490c001 filter hidden outcome results in student lmgb
closes OUT-2236

Test plan:
- create two assignments with rubrics
- for one of the rubrics, set "Don't post Outcomes results to Learning
  Mastery Gradebook" to true.  For the other, leave unchecked.
- assess a student on each assignment using the rubric
- visit the student learning mastery gradebook
- verify that the assignment with "Don't post" selected is NOT
  included in the gradebook
- verify that the assignment without "Don't post" selected
  is included

Change-Id: I2ea3a9fb170e2f8ef626d0166b6dfabaeb6bc38f
Reviewed-on: https://gerrit.instructure.com/150977
Reviewed-by: Augusto Callejas <acallejas@instructure.com>
Reviewed-by: Frank Murphy <fmurphy@instructure.com>
Tested-by: Jenkins
QA-Review: Andrew Porter <hporter-c@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
2018-05-31 22:06:12 +00:00
Michael Brewer-Davis f37f96d804 fix long description styling
Test plan:
Enable non-scoring rubrics
Assess student with rubric
On student grades page, click on the rubric icon
  to show the rubric assessment
Verify that "View longer description" is left aligned

Change-Id: I42d52fbb623eda9f296822ba5f27d22b124e0314
Reviewed-on: https://gerrit.instructure.com/151093
Tested-by: Jenkins
Reviewed-by: Frank Murphy <fmurphy@instructure.com>
Reviewed-by: Augusto Callejas <acallejas@instructure.com>
QA-Review: Augusto Callejas <acallejas@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
2018-05-31 21:41:14 +00:00
Aaron Kc Hsu d718116c88 Implament the Add Role Tray for permissions
fixes COMMS-899

Test Plan
* Turn on the permissions the new permissions
* Test the plan by clicking the cool add role button
* Make the add tray pull out and hope and pray it pulls out
* Once its out test ally compliance
* The save button doesnt do anything yet

Change-Id: Icc18d822f526b7ba90f17bb390d810b3762381d4
Reviewed-on: https://gerrit.instructure.com/151936
Tested-by: Jenkins
Reviewed-by: Landon Gilbert-Bland <lbland@instructure.com>
QA-Review: Sara Chadwick <schadwick@instructure.com>
Product-Review: Aaron Kc Hsu <ahsu@instructure.com>
2018-05-31 21:17:33 +00:00
Han Ngo 40e96db3ff Make Dev Key Name Not Tabbable
Fixes PLAT-3406

Test Plan:
- Verify the Developer Key Name is not tabbable
- Verify under the Inherited tab, when Show All Keys is
clicked, the focus should be on the toggle group
accordingly (on the last non-disabled toggle).
For example:
- If the value of the last toggle button is On, then the
focus should be on the On button
- If Off, focus on Off button
- If none of the inherited key is set to allow (all of
them are disabled), focus on the Inherited tab
- Under the Account tab, when Show All Keys button is
clicked, the focus should be on the trash can icon of the
last dev key (just got loaded)

Change-Id: I9cd19a076a608ed958859b8827f57f1ce1778e89
Reviewed-on: https://gerrit.instructure.com/151405
Tested-by: Jenkins
Reviewed-by: Marc Alan Phillips <mphillips@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
Product-Review: Han Ngo <hngo@instructure.com>
2018-05-31 19:45:21 +00:00
Steven Burnett 4f02e8ae2e fix basic permissions styling
fixes COMMS-1126 COMMS-1127

Test Plan:
- Look at the tickets see it fixes those things
- the table looks good

Change-Id: Ida4fd377dcb613abb5163efc6fe11787015cfabb
Reviewed-on: https://gerrit.instructure.com/151996
Reviewed-by: Landon Gilbert-Bland <lbland@instructure.com>
Tested-by: Jenkins
QA-Review: Landon Gilbert-Bland <lbland@instructure.com>
Product-Review: Landon Gilbert-Bland <lbland@instructure.com>
2018-05-31 19:26:48 +00:00
Jeremy Neander c8229d721e load students and graders into moderation table
closes GRADE-964
closes GRADE-1024
closes GRADE-1059
refs GRADE-877
refs GRADE-1166

test plan:
 A. Setup
    1. Enable Anonymous Moderated Marking
    2. Select or create a course
       a. with Anonymous Marking enabled
       b. with three instructors (A, B, and C)
       c. with 51 or more students
          * this is for multiple pages of students
    3. Select or create an assignment
       a. with Moderated Grading
       b. with Anonymous Grading
       c. with instructor A as the final grader
    4. As each instructor (B and C)
       a. give at least one student a provisional grade
          on each assignment (using SpeedGrader)
       * This SHOULD create a new moderation_grader for each user
         and for each assignment

 B. Verify
    1. Enable grader_names_visible_to_final_grader

       assignment.grader_names_visible_to_final_grader = true
       assignment.save!

    2. Log in or act as instructor A
    3. Visit the moderation page for the assignment
    4. Verify both instructors B an C are named in the table
    5. Verify all students are loaded into the table
    6. Verify the correct grades are displayed in the table
    7. Verify grades as associated with the correct graders
    8. Verify ungraded student/grader pairs show as "–"

 C. Verify with Other Graders Anonymous
    1. Disable grader_names_visible_to_final_grader

       assignment.grader_names_visible_to_final_grader = false
       assignment.save!

    2. Log in or act as instructor A
    3. Visit the moderation page for the assignment
    4. Verify column headers display anonymous grader names

    * Students are not yet anonymized.

Change-Id: I155567cf461380f7018c964e74d775ed182c9954
Reviewed-on: https://gerrit.instructure.com/151269
Tested-by: Jenkins
Reviewed-by: Adrian Packel <apackel@instructure.com>
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
QA-Review: Indira Pai <ipai@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
2018-05-31 18:13:48 +00:00
Jayce Higgins 31bae72fe9 Align course copy quiz duplication with quiz copy duplication
Fixes: QUIZ-4568

Test-Plan:
  1) Setup course copy set up and functional (in beta -> edge)
    1a) Can also set it up locally, though far more difficult
  2) Attempt a course copy, the assignments should copy properly

  --- Local Setup ---

  Pull down c/151706/ for quiz LTI

  1) Ensure that LTI/API are running and that the kinesis2sqs containers
    are functioning (not throwing "unable to connect to elasticmq" errors)
    1a) If you're getting these errors, stop and rm the kinesis2sqs
      containers along with sqs2lti and elasticmq
    1b) After they're removed, bring them back up manually in the
      following order:
      - elasticmq
      - sqs2lti
      - kinesis2sqs-canvas
      - kinesis2sqs-quizzes

  2) Enable the oauth2 feature flag in LTI
  3) Configure Kinesis in canvas (see quiz API live event docs for those
    steps)
  4) Create the streams using the kinesis:create_streams rake task in
    API
  5) You should be good to go after following these steps

Change-Id: I2d516c9c53cfa97ca691a80348f54ddadd6e8072
Reviewed-on: https://gerrit.instructure.com/150708
Tested-by: Jenkins
Reviewed-by: Vidya Subramaniam <vsubramaniam@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Kevin Dougherty <jdougherty@instructure.com>
2018-05-31 18:09:05 +00:00
Ryan Shaw 39129a7496 instUI5 upgrade: account_course_user_search stuff
refs: CORE-1437

This commit just upgrades these components to use instUI 5 instead of
getting them from ui-core in instUI 4.

It is mostly just path renaming.

Test plan:
* verify these components still work as they used to and tests pass

Change-Id: I80372c8e4bb733064f06ef6ee7199cac6870ae65
Reviewed-on: https://gerrit.instructure.com/151767
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
2018-05-31 17:06:10 +00:00
Han Yan f9676125bb Qti import from Canvas to Quizzes.Next
refs QUIZ-4415

test plan:
- cr
- Quiz.Next CC import is not ready for test with only this patch
- regression on `Import Content`, to make sure:
  1) `Qti .zip file` import works
  2) `Common Catridge 1.x Package` import works

Change-Id: Iba2818a2b864020b6c59ef55e02f122b996e4c40
Reviewed-on: https://gerrit.instructure.com/149978
Reviewed-by: Andrew Butterfield <abutterfield@instructure.com>
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: David Tan <dtan@instructure.com>
Product-Review: Han Yan <hyan@instructure.com>
2018-05-31 16:57:32 +00:00
Carl Kibler 7099f4c4df polish planner ui to match mockups
This became a sweeping set of visual fixes in planner as I reviewed
the UI with the design team.

fixes ADMIN-995

test plan:
- see jira for complete list of changes
- incomplete item text should be dark text color
- user-created todos use user color like in calendar
- checkboxes match course color

Change-Id: Ia624844a349f268e7a7da98744be75bfccfe12fd
Reviewed-on: https://gerrit.instructure.com/151250
Tested-by: Jenkins
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Carl Kibler <ckibler@instructure.com>
2018-05-31 16:55:12 +00:00
Michael Brewer-Davis ce913653db remove incorrect caching of grade summary
Test plan:
Visit the individual grades pages for
multiple students and verify that results are
generated for the correct student.

Change-Id: Icfa57c9f4605d89e30708e553e304c87c6d6a617
Reviewed-on: https://gerrit.instructure.com/151922
Tested-by: Jenkins
Reviewed-by: Augusto Callejas <acallejas@instructure.com>
QA-Review: Andrew Porter <hporter-c@instructure.com>
Product-Review: Michael Brewer-Davis <mbd@instructure.com>
2018-05-31 16:46:46 +00:00
James Butters c012550b6a add large_gradebook_seeds.rb
closes: GRADE-1121

The purpose of this seed is to allow us to quickly setup a
standard large course on our local database for manual
performance testing.

Test Plan:
***If you actually run this, be warned it will take a long time****
  -Run rails runner spec/manual_seeding/large_gradebook_seeds.rb
  -Output indicates it's seeding for Speedgrader
  -Creates a new course with 50 Students and 50 Assignments.
  -Run rails runner spec/manual_seeding/large_gradebook_seeds.rb -g
  -Output indicates it's seeding for Gradebook
  -Creates a new course with 400 students and 200 assignments

Change-Id: Id19832e108436823be77311df5f7f2195f8cdd7d
Reviewed-on: https://gerrit.instructure.com/150229
Tested-by: Jenkins
Reviewed-by: Adrian Packel <apackel@instructure.com>
Reviewed-by: KC Naegle <knaegle@instructure.com>
Product-Review: KC Naegle <knaegle@instructure.com>
QA-Review: KC Naegle <knaegle@instructure.com>
2018-05-31 16:10:45 +00:00
wdransfield f55a2eb426 Show 'not found' error for sub account dev keys
Refs: PLAT-3420

Test plan:
- Attempt to navigate to `/accounts/<sub account id>/developer_keys`
- Verify you see a "not found" page
- Verify you can hit that URL for root accounts and site admin

Change-Id: I1221338ea5feeadf1fffe06837e4c1ae299dac03
Reviewed-on: https://gerrit.instructure.com/151903
Reviewed-by: Stewie aka Nicholas Stewart <nstewart@instructure.com>
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
Product-Review: Jesse Poulos <jpoulos@instructure.com>
2018-05-31 16:06:03 +00:00