This is for adding new roles to permissions
fixes COMMS-1165
Test Plan
* Make sure new permissions in on
* Use the add role button to add a new role
* Notice that the role now appears in the header
* Notice the edit tray pops up allow us to edit the role
Change-Id: I2c9e30dc9e9c6a7e42e9be288d5e457b3f6c56e3
Reviewed-on: https://gerrit.instructure.com/153130
Tested-by: Jenkins
QA-Review: Venk Natarajan <vnatarajan@instructure.com>
Reviewed-by: Steven Burnett <sburnett@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
fixes OUT-2286
note: there is another issue for Safari concerning the
styling of the description box in some cases. That is being
handled in another PS. It can be treated as expected behavior
in regards to this test plan
test plan:
test the following in all browsers:
- open a rubric for assessing in speedgrader
- the styling should appear correctly (boxes right size, no weird
padding or white space, etc)
- open a rubric for assessing on the submission show page
- the styling should appear correctly
Change-Id: I6fd5b8fcbc3fceebb129f7f71e664bf05d5da347
Reviewed-on: https://gerrit.instructure.com/152938
Tested-by: Jenkins
Reviewed-by: Frank Murphy <fmurphy@instructure.com>
Reviewed-by: Augusto Callejas <acallejas@instructure.com>
QA-Review: Augusto Callejas <acallejas@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
References OUT-2249
Test Plan:
- Open a points rubric for assessing.
- Verify that an error is shown when points are set to "bad".
- Verify that when numerical points are entered, no error is shown.
- Verify that when points are blank, no error is shown.
Change-Id: I54751db996ff2ba3a2c346b185721e53288eca61
Reviewed-on: https://gerrit.instructure.com/152574
Reviewed-by: Augusto Callejas <acallejas@instructure.com>
Tested-by: Jenkins
QA-Review: Dariusz Dzien <ddzien@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
set a flag on SLO, and only logout if that flag is set (instead of
removing a flag on SLO, and logging out if the flag isn't set)
fixes CORE-1407
test plan:
* have redis configured
* configure CAS, and log in
* clear your redis
* you should stay logged in (and not get sent back to the CAS server
on your next request)
* do a CAS SLO (your CAS server must support SLO, be able to contact
your canvas server, and then log out directly at your CAS server)
* refresh Canvas - it should send you to your CAS server to log in
again
Change-Id: I3f95ba3208f8c3f29a6c610872d3fa94aa9cb67d
Reviewed-on: https://gerrit.instructure.com/151386
Reviewed-by: Rob Orton <rob@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
test plan:
* have a course with multiple sections
* create an assignment assigned to only one section
* add a student to the course in the assigned section
* deactivate the user from the course people page
* the student should not see the assignment anymore
closes #COMMS-484
Change-Id: I2a604c091ad319e8bfa08b6156b02ef211e4d938
Reviewed-on: https://gerrit.instructure.com/151171
Tested-by: Jenkins
Reviewed-by: Steven Burnett <sburnett@instructure.com>
QA-Review: KC Naegle <knaegle@instructure.com>
Product-Review: KC Naegle <knaegle@instructure.com>
refs OUT-2240
test plan:
- enable non-scoring rubrics feature flag
- load the account rubrics page
- select the "Learning Mastery" tab
- attempt to delete all the ratings
- confirm that the delete button is disabled when
down to a single rating
Change-Id: I8311ea0d68dedb839b2848a26c7a0dd657f91e2b
Reviewed-on: https://gerrit.instructure.com/152783
Tested-by: Jenkins
Reviewed-by: Frank Murphy <fmurphy@instructure.com>
Reviewed-by: Matt Berns <mberns@instructure.com>
QA-Review: Frank Murphy <fmurphy@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
Test plan:
* run yarn test or look at the console output of linters and js build
* you should not see any:
| (node:6453) UnhandledPromiseRejectionWarning: Error: only absolute
urls are supported
at node_modules/node-fetch/index.js:54:10
at new Promise (<anonymous>)
at new Fetch packages/canvas-rce/(/node-fetch/index.js:49:9)
at Fetch packages/canvas-rce/(node-fetch/index.js:37:10)
at module.exports (isomorphic-fetch/fetch-npm-node.js:8:19)
at RceApiSource.apiFetch (canvas-rce/src/sidebar/sources/api.js:236:12)
…
* the cavas-rce tests should pass
Change-Id: Id2ab92752f316dacc34290994645e47018fd0742
Reviewed-on: https://gerrit.instructure.com/153120
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
test plan:
* run `yarn && yarn test`
* the canvas-quizzes tests should pass
Change-Id: I0786e86a8f10fbbef68fca287cc178fa5129a12d
Reviewed-on: https://gerrit.instructure.com/153119
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
CLoses COMMS-1110
Test Plan:
* Have a custom role.
* Open up its tray.
* Delete it, and confirm.
* The tray should close, and the column should vanish from the table.
* A nice deletion message should appear.
* Do the above, but his cancel instead.
* The confirm message should disappear, but the tray should stay
open.
* Do a11y due diligence.
Change-Id: Ia10d35d08de3d4a4f8931d14ce25c5cf227d3f2c
Reviewed-on: https://gerrit.instructure.com/153078
Reviewed-by: Aaron Kc Hsu <ahsu@instructure.com>
Tested-by: Jenkins
QA-Review: Sara Chadwick <schadwick@instructure.com>
Product-Review: Venk Natarajan <vnatarajan@instructure.com>
closes PLAT-3436
Test Plan:
- Add a key
- Note that the search box and the Add Scopes is removed
- Click the enforce scopes checkbox
- scopes and the search box is now available
Change-Id: I63d272fa53bb8c4c2e03fb11a2e382cb1b317eaf
Reviewed-on: https://gerrit.instructure.com/152209
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
Tested-by: Jenkins
Product-Review: Jesse Poulos <jpoulos@instructure.com>
fixes COMMS-1157
Test Plan
* Turn on new permissions
* The sort order according to product is roles are placed
to the right of their base role if there is a tie then the
one that is created first is placed closest to the base
role
* Create some roles and look how it stays sorted
* Load a page and notice that it is all sorted as well
* Note there is a small bug right now where adding a role
is changing the state but not updating the header
i am currently looking into it.. but idk if it is
part of this commit
Change-Id: Ie24bcd15f1169c7a35a1065b6ee473f0da97759c
Reviewed-on: https://gerrit.instructure.com/152967
Reviewed-by: Venk Natarajan <vnatarajan@instructure.com>
Tested-by: Jenkins
QA-Review: Steven Burnett <sburnett@instructure.com>
Product-Review: Aaron Kc Hsu <ahsu@instructure.com>
refs QUIZ-4583, QUIZ-4626
Must be tested in conjunction with QUIZ-4415
Provides visual indicators in assignment list for the Importing, and
Failed to import states. Allows for the user to remove a failed
assignment import from the list.
Test Plan:
- Do a Common Cartridge or QTI import, enabling Quizzes.Next importing
- Monitor state transitions in Canvas Assignment views.
- Ensure they move from Importing to a finished stated.
Change-Id: I6f07ecae7b5a93dadd5309bb54bf15724f512c16
Reviewed-on: https://gerrit.instructure.com/151026
Reviewed-by: Omar Khan <okhan@instructure.com>
Tested-by: Jenkins
QA-Review: David Tan <dtan@instructure.com>
Product-Review: Kevin Dougherty <jdougherty@instructure.com>
Refs MBL-10482
Test Plan:
- Create a super observer connected to a student
- Student should be enrolled in a course
- Create a threshold for `assignment_missing` for that student
- POST /api/v1/users/observer_alert_thresholds
- {
student_id: :student_id,
threshold: {
alert_type: 'assignment_missing'
}
}
- Create an assignment that is due in the course for a minute
or two in the future
- Wait at least 5 minutes
- As the observer hit /api/v1/users/self/observer_alerts/:student_id
- There should be an alert for that user
Change-Id: If2dea94052ff932c866a7382a2119a3287350c28
Reviewed-on: https://gerrit.instructure.com/152073
Reviewed-by: Cameron Sutter <csutter@instructure.com>
Product-Review: Cameron Sutter <csutter@instructure.com>
Tested-by: Jenkins
QA-Review: Taylor Wilson <twilson@instructure.com>
References OUT-2249
Test Plan:
- Load up a rubric, verify the total points text is aligned to the end.
Change-Id: I0d1c77c349812622a2611b316e59b09963f2afe1
Reviewed-on: https://gerrit.instructure.com/152481
Tested-by: Jenkins
Reviewed-by: Michael Brewer-Davis <mbd@instructure.com>
QA-Review: Dariusz Dzien <ddzien@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
Test plan:
* make sure the arrows for the submission tray point the right way
And flip when you turn on RTL
Change-Id: I4b31e83a49f9336f1912f87351824fb48f1196fe
Reviewed-on: https://gerrit.instructure.com/152692
Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com>
Tested-by: Jenkins
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
refs: CORE-1437
closes: CORE-1489
the commit to upgrade gradezilla/grading stuff to instUI 5 has been
split in 2. The other, that this is based on takes care of the trivial
stuff: components whose API has not changed, who just need to have their
import paths renamed to the new location in the split-up instUI
packages.
This one takes care of the stuff that actually has meaningful changes
like <NumberInput> and <Select>. it will need more scrutiny, but
since the changes are isolated to just a couple components it won’t
be as scary.
Test plan:
* verify these components still work as they used to and tests pass
* look at the things that @solsen found in his Code Review and make sure
they work
Change-Id: I72996ead775793237fc9a527f3da366f8ad6a6e3
Reviewed-on: https://gerrit.instructure.com/151772
Tested-by: Jenkins
Reviewed-by: Spencer Olson <solson@instructure.com>
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
QA-Review: Rohan Cheeniyil <rcheeniyil@instructure.com>
Product-Review: Pert Eilers <peilers@instructure.com>
Closes: DOC-793
Test plan:
- See new table for 2018-06-23 with info and make sure links work
- In description, make sure second bullet link works
Change-Id: Ib95669e9f15e600555c95919eaad724b2e438ef1
Reviewed-on: https://gerrit.instructure.com/152796
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Reviewed-by: Pam Hiett <phiett@instructure.com>
Product-Review: Robert Lamb <rlamb@instructure.com>
QA-Review: Robert Lamb <rlamb@instructure.com>
closes GRADE-1209 CORE-1484
this new version of instui includes a fix we need
For pagination:
Test plan:
* verify the pagination on the account course/user search works
* ensure it does not steal focus with more than 5 pages
Change-Id: I5a5e67d10ff591fb0477a80598a30d89273cf35e
Reviewed-on: https://gerrit.instructure.com/152862
Tested-by: Jenkins
Reviewed-by: Jeremy Neander <jneander@instructure.com>
Reviewed-by: Mysti Sadler <mysti@instructure.com>
Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com>
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
Fixes: CORE-1490 CORE-1491
It looks like when we made an update to the saveThemeButton in g/149278,
we broke all these close buttons for other things using that shared
wrapped instUI Modal component. This fixes it
Test plan:
* make sure the close button works on the “Add Course” modal on
The account user/course search pages
* make sure the close button works on the “save theme” button in the
Theme editor
* make sure the close button works for the “Course Image picker”
Modal on the course settings page.
* also make sure the headers on each of those are styled as they were
before.
Change-Id: I3893a75c78e595b0f94f7e7c55faa3fd32c8f5ea
Reviewed-on: https://gerrit.instructure.com/152689
Tested-by: Jenkins
Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Fixes COMMS-1113
Test plan :
- Turn on thepermissions feature flag and naviagte to the
permissions page
- Verify that the labels are all the new labels, for the permissions
that have updated names
- Turn the flag off and naviage to the permissions page again
- Verify that the old labels are still present on the old page
Change-Id: If5afbbc387397946600a041dc03093a6a8481f55
Reviewed-on: https://gerrit.instructure.com/152441
Reviewed-by: Steven Burnett <sburnett@instructure.com>
Tested-by: Jenkins
QA-Review: Aaron Kc Hsu <ahsu@instructure.com>
Product-Review: Jonathan Fenton <jfenton@instructure.com>
test plan:
- enable planner
- have a course with active student enrollments
- create a new graded quiz
with a single due date (no overrides)
saving with the "Save and Publish" button
- ensure the quiz appears on a student's planner
fixes ADMIN-1070
Change-Id: I28177a4c6bdd37df165e284217719190ddc39399
Reviewed-on: https://gerrit.instructure.com/152490
Tested-by: Jenkins
Reviewed-by: Mysti Sadler <mysti@instructure.com>
Reviewed-by: Derek Bender <djbender@instructure.com>
QA-Review: Luke Kingsley <lkingsley@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
Also tidies up some a11y brokenness.
Closes COMMS-254
Test Plan:
* Have a course with 5-6 modules in it.
* Make sure you have module duplication enabled.
* Duplicate one of them.
* Try this both from the modules page, and also from
the course home page when it's set to be the modules
page.
* There will now be a spinner present that goes away once
the new module has rendered.
* Make sure screenreaders are happy.
Change-Id: I7155c674a4c31b1650598d7b12631037b0355661
Reviewed-on: https://gerrit.instructure.com/152403
Tested-by: Jenkins
Reviewed-by: Steven Burnett <sburnett@instructure.com>
Product-Review: Matt Goodwin <mattg@instructure.com>
QA-Review: Landon Gilbert-Bland <lbland@instructure.com>
closes OUT-2248
test plan:
- create an outcome with a default scale of 5/3/0
- create a rubric with several criteria, including the outcome,
and attach it to an assignment
- go to speedgrader and assess the rubric, providing a varing
level of scores
- enable the non-scoring rubrics feature flag (note that due
to caching you may need to wait for the feature to be truly
enabled)
- default colors should properly show on speedgrader, the
submission show page, and student grade summary page
- follow the instructions on g/150095 to create outcome proficiency
ratings using the API in the course's account:
* description: great, points: 5, mastery: false, color: 00ff00
* description: good, points: 3, mastery: true, color: 0000ff
* description: boo, points: 0, mastery: false, color: ff0000
- the custom created colors should now be showing on speedgrader,
the submission show page, and student grade summary page
Change-Id: I0dbe7196871950aa9786978c2f97ec6279823583
Reviewed-on: https://gerrit.instructure.com/152638
Tested-by: Jenkins
Reviewed-by: Michael Brewer-Davis <mbd@instructure.com>
QA-Review: Frank Murphy <fmurphy@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
Jeremy Neander