fixes GRADE-976
test plan:
* Make sure the AMM flag is off
* All AMM features should be visible and work
* The Anonymous Marking and Moderated feature flags should be visible
* Toggling the AMM feature flag should do nothing
Change-Id: Ie0c52c23748389c6f5df5b85e8580bdf474c0a52
Reviewed-on: https://gerrit.instructure.com/152067
Reviewed-by: Adrian Packel <apackel@instructure.com>
Tested-by: Jenkins
Reviewed-by: Derek Bender <djbender@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
Closes COMMS-1173
Test Plan:
* Have a custom role
* Open the edit mode. The current role label should be populated
in the field.
* Attempt to change it to an existing role.
* An error should show and we will not attempt to change the name
* Now make the role empty
* Blur out of the field.
* The error should be gone, and the original role name should now
be populated
* Try changing the role name, then switching out of and back into
edit view and seeing if the behavior is what you expect.
* Check nothing regressed
Change-Id: Icfaa9e17b45cb3dbdac7ed1b7bce4a4be130214b
Reviewed-on: https://gerrit.instructure.com/153420
Reviewed-by: Steven Burnett <sburnett@instructure.com>
Tested-by: Jenkins
QA-Review: Sara Chadwick <schadwick@instructure.com>
Product-Review: Venk Natarajan <vnatarajan@instructure.com>
closes OUT-2297
Test plan:
- enable non-scoring rubrics, do not create
custom learning mastery ratings
- create outcomes with mastery at 3 and max points
of 5
- create an assignment with rubric aligned to those
outcomes
- assess a student using the rubric, verify that default
colors work in rubrics
- create learning mastery ratings with max points
possible equal to 100
- assess a student using the rubric, verify that
new ratings colors are used, with the score
scaled to match the ratings (i.e., 3/5 receives
the color that would be assigned to 60/100)
Change-Id: I6a0abbdeb21457d5d44d1a2f47755fd21ffb9c78
Reviewed-on: https://gerrit.instructure.com/153366
Tested-by: Jenkins
Reviewed-by: Augusto Callejas <acallejas@instructure.com>
QA-Review: Matt Berns <mberns@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
closes PLAT-3471
Test Plan:
- verify docs:api rake task is successful
- verify documentation for scopes api controller
is visible.
- verify documentation for scopes api controller
is clearly marked as "beta."
Change-Id: I131c96de50cada9c89a25547c286cedfb0ffacc7
Reviewed-on: https://gerrit.instructure.com/153357
Tested-by: Jenkins
Reviewed-by: August Thornton <august@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Reviewed-by: Stewie aka Nicholas Stewart <nstewart@instructure.com>
Product-Review: Jesse Poulos <jpoulos@instructure.com>
Closes PLAT-3470
Test Plan:
- Verify there are no 'developer_key_management_and_scoping'
FeatureFlag records in your DB.
- As a root account admin (not site admin) navigate to
root account feature options.
- Verify you can view and toggle the 'developer_key_management_and_scoping'
feature flag.
Change-Id: I0fb3da4a0327706c1ba482f92a667f996a476efb
Reviewed-on: https://gerrit.instructure.com/153351
Tested-by: Jenkins
Reviewed-by: Stewie aka Nicholas Stewart <nstewart@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Jesse Poulos <jpoulos@instructure.com>
closes QUIZ-4713
test plan:
- cannot test production in advance but we can verify this FF still works in local
Change-Id: I6ca56941d3497ec53c0f19d5f88caab36abf8689
Reviewed-on: https://gerrit.instructure.com/153507
Tested-by: Jenkins
Reviewed-by: Jared Crystal <jcrystal@instructure.com>
QA-Review: David Tan <dtan@instructure.com>
Product-Review: Han Yan <hyan@instructure.com>
closes ADMIN-1128
test plan:
- have a student with an submitted assigment that a teacher
has added a comment to.
> expect the item to look correct in a couple browsers, esp. ie11
(the feedback and the other item details don't overlap)
Change-Id: Icea005894a5cbaa0995525ea6eecef40ad359487
Reviewed-on: https://gerrit.instructure.com/153275
Tested-by: Jenkins
Reviewed-by: Carl Kibler <ckibler@instructure.com>
QA-Review: Luke Kingsley <lkingsley@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
closes #CORE-1062
Change-Id: Idece9ba9e31b7bebadd12d8193c012048a1d62ea
Reviewed-on: https://gerrit.instructure.com/153103
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Fixes COMMS-1147
This also fixes a problem where the locked status of the new
permissions page didn't match the old permissions page. This should
bed fixed, so check for it when you QA please!
Test Plan
- Take note of the locked/enabled/readonly status of the old
permissions
- Turn on the new permissions feature flag and navigate to the new
permissions page
- Make sure all the permissions are the same as the old page
- Change some permissions, periodically refreshing to make sure
the changes are not just local
- Turn off the feature flag and make sure the old permissions page
has the same permissions locked/enabled/readonly
Change-Id: I66c70c5ecf148e8728e31aa0aae3b40bc1b45107
Reviewed-on: https://gerrit.instructure.com/152785
Reviewed-by: Steven Burnett <sburnett@instructure.com>
Tested-by: Jenkins
QA-Review: Aaron Kc Hsu <ahsu@instructure.com>
Product-Review: Landon Gilbert-Bland <lbland@instructure.com>
This spec is for old quizzes, which is being replaced by quizzes 2.0
Skipping until it's deleted.
Change-Id: I742998bdcbe5bfe7c7f99ad54ac0f27707525e68
Reviewed-on: https://gerrit.instructure.com/153476
Tested-by: Jenkins
Reviewed-by: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Robert Lamb <rlamb@instructure.com>
QA-Review: Robert Lamb <rlamb@instructure.com>
fixes GRADE-1242
test plan:
* use IE11 to enter grades
* Verify it works
Change-Id: I12f7f94a21ed1911fe9f33412d854ebaeb4d99ab
Reviewed-on: https://gerrit.instructure.com/153438
Reviewed-by: Derek Bender <djbender@instructure.com>
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
Tested-by: Jenkins
QA-Review: Spencer Olson <solson@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
fixes GRADE-1239
test plan:
* use IE11 to enter grades
* Verify it works
Change-Id: I6b10628ea848b8161a51c7367e695231c5ea61a7
Reviewed-on: https://gerrit.instructure.com/153437
Reviewed-by: Derek Bender <djbender@instructure.com>
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
Tested-by: Jenkins
QA-Review: Spencer Olson <solson@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
closes CORE-1474
test plan:
- test course and user search
- while loading a spinner should show instead of the no results found
message
Change-Id: I870afcf61fe347f0a801701e15a60bba5b0aab85
Reviewed-on: https://gerrit.instructure.com/153259
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins
QA-Review: Rohan Cheeniyil <rcheeniyil@instructure.com>
Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
closes GRADE-1192
test plan:
1. Setup a course with AMM and a moderated assignment
2. Log in as various instructors and grade some students
3. Log in as the moderator
4. Visit the moderation page for the assignment
5. Select some grades
6. Verify the grades were selected
* populated in Select element
* highlighted in row
7. Verify a flash message indicate successful selection
8. Refresh the page
9. Verify the selected grades remain selected
Change-Id: Ib07a5c7a1838ebc79bd660505f950a328d1eabfa
Reviewed-on: https://gerrit.instructure.com/151602
Tested-by: Jenkins
Reviewed-by: Adrian Packel <apackel@instructure.com>
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
QA-Review: Gary Mei <gmei@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
closes ADMIN-1130
Test plan
- Run /api/v1/courses/:course_id/files/(id that
doesn't exist, or is deleted)
- Ensure you don't get a new error report for it
Change-Id: I9df392d22ca0ecfae18a5f2576e99d907b9a77a3
Reviewed-on: https://gerrit.instructure.com/153301
Tested-by: Jenkins
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Luke Kingsley <lkingsley@instructure.com>
Product-Review: Mysti Sadler <mysti@instructure.com>
refs ADMIN-1031
Test plan
- Set up some assignments in varying
states of submission/grade/whatever
- Load /api/v1/planner/items for a user
and ensure it doesn't make all 6 of the
submission queries for every assignment
Change-Id: If22c3a3d74849c4bfdab401ce2da2caa07cda527
Reviewed-on: https://gerrit.instructure.com/152710
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins
QA-Review: Luke Kingsley <lkingsley@instructure.com>
Product-Review: Mysti Sadler <mysti@instructure.com>
fixes OUT-2287
test plan:
test the following in all browsers:
- open a rubric for assessing in speedgrader
- the styling should appear correctly (boxes right size, no weird
padding or white space, discription text should align to top of
cell, etc)
- open a rubric for assessing on the submission show page
- the styling should appear correctly
Change-Id: I543671f144ecdc8015771be2ed79184f15a61c10
Reviewed-on: https://gerrit.instructure.com/153331
Reviewed-by: Frank Murphy <fmurphy@instructure.com>
Tested-by: Jenkins
Reviewed-by: Augusto Callejas <acallejas@instructure.com>
QA-Review: Augusto Callejas <acallejas@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
Fixes OUT-2268
Test Plan:
- Open speedgrader, navigate to an assessment of a free-form rubric.
Verify:
- the new UI is present before clicking "view rubric"
- the summary rubric only has two columns
- each criteria lists points assessed out of points possible right after the
comments.
- Now go to an assignment with a points-based rubric. Verify:
- the spiky UI is present
- the summary rubric only has two columns
- each criteria lists the points assessment and comments right after
the description of the rating.
- Navigate to a student without an assessment using the top right arrow
keys
- Verify there is no summary rubric shown
- Navigate back to the student with an assessment, verify the summary is
shown again.
Change-Id: Idae819264c507e42d67a6731367d2ddef5cd176d
Reviewed-on: https://gerrit.instructure.com/152226
Tested-by: Jenkins
Reviewed-by: Augusto Callejas <acallejas@instructure.com>
Reviewed-by: Michael Brewer-Davis <mbd@instructure.com>
QA-Review: Matt Berns <mberns@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
Fixes COMMS-1159 COMMS-1129
Test Plan:
* On the edit permission tray:
- Notice that no notifications are displayed onBlur when you didn't
change the role name
- Notice that no notifications are displayed onBlur when you have a
totally empty role name
- If you change the role name to a new name that is not currently
being used it pops up with a success message on blur
- If you change the role name to a new name that is currently
being used it pops up with an error message on blur
- It no longer displayes the `changeBaseRole` dropdown menu
* On the permission tray:
- Notice that the `Changed By` field is gone, as we are not storing
that information in the database
- Notice that the `Assigned To` field is also gone.
- If you change the role name, insure it will update the last
changed date in the permission tray.
- (once Sara's commit is in), notice that when you change a
permission (role_override), the last changed date of the
permission will also be updated
- Make sure the last changed date is properly localized
* Make sure the permissions tray works for account roles and course
roles (using the tab switchet at the top of the page)
Change-Id: I9102d33b7a684c1a3b7f5a6fe4a67ecf678af8b0
Reviewed-on: https://gerrit.instructure.com/153013
Reviewed-by: Steven Burnett <sburnett@instructure.com>
Tested-by: Jenkins
QA-Review: Venk Natarajan <vnatarajan@instructure.com>
Product-Review: Landon Gilbert-Bland <lbland@instructure.com>
refs ADMIN-1031
Test plan
- Set up a couple of planner items
and make sure there are some overrides
to check for (mark as complete or dismiss
opportunities)
- Run the api/v1/planner/items call and ensure
you don't get a planner_override sql call for
every item
Change-Id: I8b4f468e3cb6177ced2aee3abec810a75d9aec9e
Reviewed-on: https://gerrit.instructure.com/152697
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins
QA-Review: Luke Kingsley <lkingsley@instructure.com>
Product-Review: Mysti Sadler <mysti@instructure.com>
closes GRADE-1001
test plan:
A. Setup
1. Setup a course with AMM
2. Add a moderated assignment with:
a. Two graders (A and B)
b. A third, final grader (C)
3. Ensure enrollment of at least 21 students
4. Assign some provisional grades using graders A and B
5. Log in as the final grader C
6. Visit the moderation page for the assignment
B. Verify VoiceOver (in Safari)
* This could be deferred to the a11y audit
1. Verify the table is accessible using VoiceOver
a. Announces table name "Grade Selection Table"
b. Announces row and column headers for cells
c. Announces cell content
2. Verify Post button accessibility
3. Verify Display to Students button accessibility
4. Verify Pagination accessibility
C. Verify KO Scrolling
1. Tab to the table
2. Verify a focus indicator surrounds the table
3. Verify left/right arrows scroll the table horizontally
Change-Id: I32a5aee6c0c61d45851fa117a21e32aa8fae9b71
Reviewed-on: https://gerrit.instructure.com/153226
Tested-by: Jenkins
Reviewed-by: Derek Bender <djbender@instructure.com>
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
QA-Review: Adrian Packel <apackel@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
Closes PLAT-3417
Test Plan:
- Verify when creating/editing, the dev key index URL get
updated with a query string 'modal_opened=true'
- Verify when closing the modal, the query string go away
- Verify the when creating a new dev key, clicking the
browser back button will take user back to the dev key index
- Verify when editting a dev key, browser back button will
also go back to the dev key index
- Verify when saving a new dev key, it also goes back to the
dev key index page
Change-Id: Ia6bcfed67ba506afa0879f4c053e518e5dc3f878
Reviewed-on: https://gerrit.instructure.com/152150
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
Reviewed-by: Marc Alan Phillips <mphillips@instructure.com>
QA-Review: Marc Alan Phillips <mphillips@instructure.com>
Tested-by: Jenkins
Product-Review: Jesse Poulos <jpoulos@instructure.com>
refs OUT-2240
test plan:
- enable the non-scoring rubric feature flag if not enabled
- load the accounts rubrics page
- click the "Learning Mastery" tab
- confirm that when attempting to save ratings with
negative points, an error message is displayed below
the points field
Change-Id: Ic41b013cbc6499e3c1783fed2283fe6ed02ba2f0
Reviewed-on: https://gerrit.instructure.com/153069
Reviewed-by: Michael Brewer-Davis <mbd@instructure.com>
Reviewed-by: Matt Berns <mberns@instructure.com>
Tested-by: Jenkins
QA-Review: Michael Brewer-Davis <mbd@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
Change-Id: I6de924dfcfda1b10824ce0464241287148129cde
Reviewed-on: https://gerrit.instructure.com/152869
Tested-by: Jenkins
Reviewed-by: Addison Higham <ahigham@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
Fixes PLAT-3450
Test Plan:
- Verify there is a column of Owner Email instead of User
- Verify this column display the owner email (if provided)
instead of the user name
Change-Id: I15c41b8d2fd5284564ef87b49651f8ffa293cf87
Reviewed-on: https://gerrit.instructure.com/152789
Tested-by: Jenkins
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Jesse Poulos <jpoulos@instructure.com>
test plan:
* verify the icons for stats & settings on each course row of
/accounts/x looks right and is centered in the space like it was.
* yarn test:jest should output less propType errors / deprecation
warnings
Change-Id: I22ade1da81f4a283b7b9876af8566b27b0105d88
Reviewed-on: https://gerrit.instructure.com/153159
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
closes OUT-2291
Test plan:
- Create a course with outcome groups but no
outcomes
- Visit a student's LMGB
- Verify that text says no outcomes in course
- Add outcomes to some but not all of the
groups
- Verify that only groups with outcomes appear
in the sLMGB
- Create an assignment with rubric that references
some but not all of the outcomes
- Assess the assignment for a student
- Verify that the sLMGB has correct results for
outcomes aligned to the assignment, and has
appropriate text for outcomes not aligned to
any assignment
Change-Id: I2cf5f350bab18c4eb45b0d62af1d950857378a9a
Reviewed-on: https://gerrit.instructure.com/152784
Reviewed-by: Augusto Callejas <acallejas@instructure.com>
Reviewed-by: Frank Murphy <fmurphy@instructure.com>
QA-Review: Dariusz Dzien <ddzien@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
Tested-by: Jenkins
Fixes COMMS-1168
Test Plan:
* Open up the new permissions page.
* Switch course/account tabs.
* Wait 5 years.
* "all roles" should be there in the role filter
* Select something in the role filter.
* Switch back to the original course/account tab.
* Again, "all roles" should be selected.
Change-Id: Ib426f89b4a003ffb4bea2b616e4c32060908ba8b
Reviewed-on: https://gerrit.instructure.com/153243
Tested-by: Jenkins
Reviewed-by: Steven Burnett <sburnett@instructure.com>
QA-Review: Landon Gilbert-Bland <lbland@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
Fixes COMMS-1116
Test Plan:
* Have notification service setup to actually send emails
* Have a user who is setup to receive all notifications immediately
* Start a new conversation with that user
* After starting a conversation with that user, send another message
(reply) to that same conversation.
* Check the emails, and make sure it doesn't say anything about do not
reply to this message
* open config/outgoing_mail.yml, and add this line under the
development section: `reply_to_disabled: true`
* Stop and start your rails server to make sure the config changes
take affect
* Do all the above steps to send a new conversation and reply to
conversation
* Make sure that it now has "Do not reply" in the subject, the bottom
link now says "Reply to this message in canvas", there there is a
message in the footer saying to not reply to this email
* Undo the config change made above
Change-Id: I7b3615d320e43c300d604c203662de97f57b565c
Reviewed-on: https://gerrit.instructure.com/150234
Tested-by: Jenkins
Reviewed-by: Landon Gilbert-Bland <lbland@instructure.com>
QA-Review: Landon Gilbert-Bland <lbland@instructure.com>
Product-Review: Matt Goodwin <mattg@instructure.com>
Reviewed-by: Steven Burnett <sburnett@instructure.com>
Closes PLAT-3466
Test Plan:
- Enable the single "Developer key management and scoping"
feature flag in a root account.
- Verify dev key management and scoping work in that account.
- Disable the "Developer key management and scoping" feature
flag.
- Verify developer key scoping and management do not apply
in that account.
Change-Id: Ic9a1a639191b754a3b0fc808739dd4f3a9cadc43
Reviewed-on: https://gerrit.instructure.com/153141
Tested-by: Jenkins
Reviewed-by: Marc Alan Phillips <mphillips@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Jesse Poulos <jpoulos@instructure.com>
now that wiki pages have context
Change-Id: I6ee0c429f4c22a67bcfe6b1ce7b3c436ccfc0ebd
Reviewed-on: https://gerrit.instructure.com/153244
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
closes GRADE-1236
Test Plan:
- specs pass
Change-Id: Ie4ed3227141451858a0f5058ff44b2a29f7f3263
Reviewed-on: https://gerrit.instructure.com/153186
Reviewed-by: Jeremy Neander <jneander@instructure.com>
Reviewed-by: Gary Mei <gmei@instructure.com>
Tested-by: Jenkins
QA-Review: Keith T. Garner <kgarner@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
fixes COMMS-1171
Test Plan:
- Go to an accounts feature page
- find the duplicate modules feature option
- notice it doesn't have a hidden tag
Change-Id: Ib24de4d27a52755f9fc444af9598cbb9ec856ecf
Reviewed-on: https://gerrit.instructure.com/153258
Reviewed-by: Gentry Beckmann <gbeckmann@instructure.com>
Tested-by: Jenkins
Product-Review: Steven Burnett <sburnett@instructure.com>
QA-Review: Steven Burnett <sburnett@instructure.com>
This will just pull these things in from the new broken-out smaller
Packages.
Test plan:
* go to the permissions page, all of these components should work as
they did before
Change-Id: I873f35c3dff46536117e07d3dc2e6827fe8c2604
Reviewed-on: https://gerrit.instructure.com/153026
Tested-by: Jenkins
Reviewed-by: Steven Burnett <sburnett@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Neil Gupta