Commit Graph

10 Commits

Author SHA1 Message Date
Cody Cutrer f552f4fc00 simplify gem test harnesses
rely on test_all_gems.sh to output header and trailer,
and use `set -e` in each test.sh to simplify passing
through errors

Change-Id: I3ba724ad2539ddfe31195394c43f646acfc73920
Reviewed-on: https://gerrit.instructure.com/70469
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
2016-01-19 17:52:58 +00:00
Cody Cutrer 02ced44cc7 some vendored gem test fixes
* explicitly depend on syck/iconv when used
 * fix cassandra spec config checking

Change-Id: Id9b706943c6b46190cf753fd302cbca0f7bf2a2b
Reviewed-on: https://gerrit.instructure.com/69779
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
2016-01-07 05:33:25 +00:00
Cody Cutrer 011f78b53a remove old autoextend API
including autoextension of methods - use prepend!

Change-Id: I073dcf4324a92e6cf14360d77fa59b1a6a4a1588
Reviewed-on: https://gerrit.instructure.com/56479
Tested-by: Jenkins
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
2015-06-17 19:48:45 +00:00
Cody Cutrer 772105314f allow autoextend target to be an actual module
sometimes there's no point in delay loading the extension

Change-Id: I0b758789f5d9985381cd6b293946312e4d3a04ac
Reviewed-on: https://gerrit.instructure.com/56347
Tested-by: Jenkins
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
2015-06-15 16:11:19 +00:00
Cody Cutrer 387a0f05c1 fix an order-of-inclusion problem with Autoextend on modules
Change-Id: I84a2a5bda44cd38236bed907200ba7b42a51bc5b
Reviewed-on: https://gerrit.instructure.com/56253
Tested-by: Jenkins
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
2015-06-12 18:27:02 +00:00
Cody Cutrer 9db90e3f32 improve Autoextend
use prepend, and do a best effort hook of modules

Change-Id: I7c636d3bfaf332cf7d2faebf62abeffed1659335
Reviewed-on: https://gerrit.instructure.com/56042
Tested-by: Jenkins
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
2015-06-11 15:52:08 +00:00
Strand McCutchen 9d5157b15d fix Style/EmptyLiteral issue
Change-Id: I8417d2abf3e2d3e01b691df553c79026801f6bce
fixes: CNVS-20009
Reviewed-on: https://gerrit.instructure.com/52920
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Strand McCutchen <smccutchen@instructure.com>
QA-Review: Strand McCutchen <smccutchen@instructure.com>
2015-04-27 19:47:30 +00:00
Cody Cutrer 84f1082b6a don't autoextend methods from modules
we can't detect when a method is added from a module, so make immediate
detection work the same way

Change-Id: I8558e1fccf14a62d21efcc3108a1fca34f0c2ac4
Reviewed-on: https://gerrit.instructure.com/51799
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
Tested-by: Jenkins
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
2015-04-14 18:41:01 +00:00
Cody Cutrer bd52b0a491 fix autoextend for ruby 1.9
const_get in 1.9 doesn't support nested constants

Change-Id: I1f511697b44846f7b8c9714f8bf84adaf42591bf
Reviewed-on: https://gerrit.instructure.com/52054
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
2015-04-13 21:11:08 +00:00
Cody Cutrer a424a91f97 add autoextend gem for plugins to easily add functionality to canvas
closes CNVS-14263

Change-Id: If2fb80e776662cae1fe56dd9e5e550c50f6accd8
Reviewed-on: https://gerrit.instructure.com/51654
Tested-by: Jenkins
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
2015-04-13 18:25:50 +00:00