closes CNVS-33618
Change-Id: Iecf79eee08a08325361f67af815399b04b235d2c
Reviewed-on: https://gerrit.instructure.com/92752
Tested-by: Jenkins
Product-Review: Benjamin Christian Nelson <bcnelson@instructure.com>
QA-Review: Benjamin Christian Nelson <bcnelson@instructure.com>
Reviewed-by: Benjamin Christian Nelson <bcnelson@instructure.com>
hide the warning "Expected string default value for '--serializer'; got
true (boolean)". it's caused by active_model_serializers not properly
passing options to hook_for, but it just means you have to use
--serializer=true instead of just --serializer, and it only affects
arguments to the `rails generate resource` generator.
test plan: start a rails console, you shouldn't see the warning
Change-Id: I10faaa0c2ca5266d520ee18062a93b828ec879b0
Reviewed-on: https://gerrit.instructure.com/97380
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Bryan Petty <bpetty@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
prevents changes to the clone from mistakenly carrying over to
the original
refs #CNVS-32664
Change-Id: Idf1ff16241cf7402d796d11c75ee886d3ed96313
Reviewed-on: https://gerrit.instructure.com/96959
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
Tested-by: Jenkins
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
closes OFFW-39
test plan:
- there should be a blank page at
courses/:course_id/offline_web_exports
- if the account setting or course setting are off,
the page should show a 404
Change-Id: Ieede91be99e4d796c9afe2074786fd08d522e4f1
Reviewed-on: https://gerrit.instructure.com/96412
Reviewed-by: Mysti Sadler <mysti@instructure.com>
Tested-by: Jenkins
QA-Review: Nathan Rogowski <nathan@instructure.com>
Product-Review: Cameron Sutter <csutter@instructure.com>
in gradebook (grid view and individual view),
overrides are no longer loaded. this should
decrease page load times for courses that
have differentiated assignments.
closes CNVS-33411
test plan:
1) create a course with
* 300 students
* 75 assignments
* one override per student per assignment
2) benchmark how long it takes to load the
gradebook
3) switch to master. benchmark how long it takes
to load the gradebook
4) gradebook should load significantly faster with
this commit than it does on master
5) verify you can sort by due date in gradebook
6) verify gradebook individual view loads
Change-Id: Id89cea8acadf7617bc8035789fb787a2bf68660a
Reviewed-on: https://gerrit.instructure.com/95897
Reviewed-by: Neil Gupta <ngupta@instructure.com>
Tested-by: Jenkins
QA-Review: KC Naegle <knaegle@instructure.com>
Product-Review: Spencer Olson <solson@instructure.com>
and use the appropriate rack-level options for passing the
session timeout from plugin settings down to the middleware
and remove "support" for other session stores
Change-Id: I8e6cab65534a150eb116b38deeced4686d9ade33
Reviewed-on: https://gerrit.instructure.com/95399
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins
QA-Review: Benjamin Christian Nelson <bcnelson@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
closes: CNVS-32953
This commit re-introduces Instructure Icons into Canvas.
Due to the range in aesthetic impact of including both line
and solid icons, the change is expansive and will be refined
in subsequent commits. The purpose of this commit is to:
- Make InstIcons available in Canvas allowing the use of the
react components
- Replace the current icon font with the new InstIcons font
- Allow for use of both 'Line' and 'Solid' icon variants
- Update the styleguide to reference the InstIcons github
documentation for examples
- Remove font custom from Canvas
Icons changed to line versions in Canvas:
- icon-compose (view on Dashboard card)
- icon-info (view on global notification)
- Updated icons to be larger for better visibility
(our old font was using a small font size)
- Updated font-size is now relative vs fixed, so better a11y
Test Plan:
- On compiling, icons in Canvas should now be changed to the
corresponding Instructure Icons as can be seen here
http://instructure.github.io/instructure-icons/
- The icon default displaying in Canvas should be solid icons.
If the variant "icon-Line" is added to an icon's css class,
it should display as line. For example, in the case of
<i class="icon-edit"></i>, adding
<i class="icon-edit icon-Line"></i> would result in a line
version of the edit icon displaying
- As a developer, you should be able to use InstUI react icons
- The rake task `bundle exec rake icons:compile` should no
longer exist
- The styleguide should no longer display example icons, but
should now include a link to the Instructure Icons github
documentation
Change-Id: I9780332de9fdf937b35caabadc2b2ee615892a43
Reviewed-on: https://gerrit.instructure.com/94175
Reviewed-by: Pam Hiett <phiett@instructure.com>
QA-Review: Dan Sasaki
Tested-by: Jenkins
Product-Review: Kyle Follett <kfollett@instructure.com>
Fixes PLAT-1908
Test Plan:
- Create an originality report and note the
id. Also note the assignmet id for the
associated attachment's assignment.
- Do a GET request to /api/v1/assignments/
<assignmnet_id>/originality_report/
<originality_report_id>
- Verify the specified originality report
is returned in the response body.
Change-Id: Icf584ed00305de8d78134ef85fca4e6003735f3e
Reviewed-on: https://gerrit.instructure.com/94739
QA-Review: August Thornton <august@instructure.com>
Reviewed-by: Nathan Mills <nathanm@instructure.com>
Tested-by: Jenkins
Product-Review: Weston Dransfield <wdransfield@instructure.com>
Transifreq