closes LS-1559
flag=none
This makes 2 changes
1. Before, we were loading both Lato and Lato Extended fonts. This is
unnecessary since Lato Extended is a superset of Lato. Now the default
behavior is to load Lato Extended and not Lato.
2. Because we host the Lato Extended font files, Cisco loads them from
their own instance of Akamai, and they want to avoid the extra bandwidth
it's using. If Setting.get('disable_lato_extended', 'false') returns
anything other than 'false', canvas will load Lato instead.
I don't know why it started failing, but I had to tweak an rce
selenium test.
test plan:
- load any canvas page
> using the devtools Network panel, Font filter, expect to see
our lato extended woff2 files downloaded from /fonts/lato/extended
and not from fonts.gstatic.com/s/lato
> expect the pages to look just like they did before
- load a page with the RCE
> expect the lato extended woff2 files loaded in the tinymce iframe
also.
- add some text including bold, italic and so forth
> expect the text to look like it did before (see also LS-317)
- in a rails console, run Setting.set('disable_lato_extended', 'true')
- send a SIGHUP to the canvas server process
(hint: `ps -a | grep puma` will find the process for `kill -1 <pid>`
- load any canvas page
> expect to see fonts from fonts.gstatic.com/s/lato, and not our
files from /fonts/lato/extended
- load a page with the RCE
> expect to see the fonts loaded in the tinymce iframe
from fonts.gstatic.com, and not ours from /fonts/lato/extended
Change-Id: Ia0c1820fa96e5ae9095c3cd1c796d381fd035a8a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/250533
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
Note: This reverts a previous revert, reintroducing the fix
without the regression.
The Lato Google Font is missing a bunch of glyphs which are
necessary for displaying certain languages. This adds the
extended character set fonts to Canvas to self-host the fonts.
It also changes the `font-family` CSS property to use the new
"Lato Extended" font, falling back to regular "Lato". It continues
to load the Google Fonts font, in the hopes that the Google
Fonts font will load faster (because it is about 10x smaller, due
to fewer character glyphs), and then the extended Lato font will
load and override the Google Font.
Test Plan:
Open the following page in the RCE and copy the raw HTML:
https://osmith.instructure.com/courses/1093/pages/reo-a-iwi-a-e-i-o-o-u-u-m-n-e-s-c-r-z-u
Paste that HTML into a page RCE raw HTML editor on your
testing Canvas instance and save the page. Also copy and
paste the page title to test bold characters.
ON WINDOWS, notice that the font renders basically the same
for extended characters as it does for latin characters.
Also, make sure the italic version works correctly
Within a Canvas course, create a page.
Enter text, highlight the text and select the italics icon to italicize the text. Notice that the text is italicized.
Save the page and notice that the text should be italicized and the correct font weight.
Fixes LS-317
flag=none
Change-Id: I2a44fd43d5433f3cecc9a1c43589643284536245
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/244837
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Alex Anderson <raanderson@instructure.com>
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
The original patchset made it so italic fonts weren't
working correctly. This reverts that change so we
don't introduce a regression.
Test Plan:
Within a Canvas course, create a page.
Enter text, highlight the text and select the italics icon to italicize the text. Notice that the text is italicized.
Save the page. The text should be italicized.
Fixes LS-1313
Change-Id: Id6a58979499a45f62abfc5f5ee911d335c32067c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/244835
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
Reviewed-by: Michael Brewer-Davis <mbd@instructure.com>
QA-Review: Michael Brewer-Davis <mbd@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Alex Anderson <raanderson@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
The Lato Google Font is missing a bunch of glyphs which are
necessary for displaying certain languages. This adds the
extended character set fonts to Canvas to self-host the fonts.
It also changes the `font-family` CSS property to use the new
"Lato Extended" font, falling back to regular "Lato". It continues
to load the Google Fonts font, in the hopes that the Google
Fonts font will load faster (because it is about 10x smaller, due
to fewer character glyphs), and then the extended Lato font will
load and override the Google Font.
Test Plan:
Open the following page in the RCE and copy the raw HTML:
https://osmith.instructure.com/courses/1093/pages/reo-a-iwi-a-e-i-o-o-u-u-m-n-e-s-c-r-z-u
Paste that HTML into a page RCE raw HTML editor on your
testing Canvas instance and save the page. Also copy and
paste the page title to test bold characters.
ON WINDOWS, notice that the font renders basically the same
for extended characters as it does for latin characters.
Fixes LS-317
flag=none
Change-Id: I5a7bb21f17f3049d9c07a9eebbd59690e01845e8
Change-Id: I603c5cee9905f315f92c0a0d39b5e2751a8f6c49
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/243281
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Alex Anderson <raanderson@instructure.com>
fixes TALLY-158
flag=none
Generating PDF files using the built-in Helvetiva font would cause
prawn to raise an error if a UTF-8 character was present that
Windows-1252 did not support.
This change is a partial revert of
25bd35cf79, but the fonts are only used
in the context of prawn at the moment.
Test Plan
- Create an assignment.
- Leave a comment on one of the assignment's submission using a
UTF-8 character that Windows-1252 does not support, such as "ă".
- Verify that downloading submission comments generates a PDF, and
that the "ă" character is present.
Change-Id: Idc7bd1400fb337d384b38a76ebf83639bdc770cf
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/222482
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
Reviewed-by: Adrian Packel <apackel@instructure.com>
QA-Review: Gary Mei <gmei@instructure.com>
Product-Review: Spencer Olson <solson@instructure.com>
closes: CORE-2746
THis is an attempt to make loading our Lato font faster for our end
users. From talking to @pam, it is our understanding that at the time
we introduced this, google did not have all the extended latin
characters, and that is why we served it ourselves.
But now google *does* include the extended latin characters so
it should be fine?
The good thing about loading it from google is that there is more of a
Likelihood that our users will already have this cached.
Also, to be honest, I still think we should just not download a webfont
and rely on system fonts that users already have. But this is my attempt
to try to see if we can make it faster before resorting that. Because I
know design really likes it :)
Test plan:
* the Lato font on pages should show up the same as it did before but
page
* load speeds should be faster as reported by lighthouse or our real
user monitoring
Change-Id: Ibcf75c74f569b6b457fe42d3be91cf6006e560fa
Reviewed-on: https://gerrit.instructure.com/188464
Tested-by: Jenkins
Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com>
QA-Review: Brent Burgoyne <bburgoyne@instructure.com>
Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
closes: CORE-1434
Test plan:
* all the icons should look the same as they did before
* make sure that icons that should flip for RTL (like the icons on
The course/user search pagination arrows, the icon to open the
Submission details tray in new gradebook, the “>” icons to expand
a submenu for the menus in new gradebook, etc)
Change-Id: I490d2dcd91b1b7ca2a116a1416718cd797f74901
Reviewed-on: https://gerrit.instructure.com/149482
Tested-by: Jenkins
Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com>
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
closes: CNVS-32953
This commit re-introduces Instructure Icons into Canvas.
Due to the range in aesthetic impact of including both line
and solid icons, the change is expansive and will be refined
in subsequent commits. The purpose of this commit is to:
- Make InstIcons available in Canvas allowing the use of the
react components
- Replace the current icon font with the new InstIcons font
- Allow for use of both 'Line' and 'Solid' icon variants
- Update the styleguide to reference the InstIcons github
documentation for examples
- Remove font custom from Canvas
Icons changed to line versions in Canvas:
- icon-compose (view on Dashboard card)
- icon-info (view on global notification)
- Updated icons to be larger for better visibility
(our old font was using a small font size)
- Updated font-size is now relative vs fixed, so better a11y
Test Plan:
- On compiling, icons in Canvas should now be changed to the
corresponding Instructure Icons as can be seen here
http://instructure.github.io/instructure-icons/
- The icon default displaying in Canvas should be solid icons.
If the variant "icon-Line" is added to an icon's css class,
it should display as line. For example, in the case of
<i class="icon-edit"></i>, adding
<i class="icon-edit icon-Line"></i> would result in a line
version of the edit icon displaying
- As a developer, you should be able to use InstUI react icons
- The rake task `bundle exec rake icons:compile` should no
longer exist
- The styleguide should no longer display example icons, but
should now include a link to the Instructure Icons github
documentation
Change-Id: I9780332de9fdf937b35caabadc2b2ee615892a43
Reviewed-on: https://gerrit.instructure.com/94175
Reviewed-by: Pam Hiett <phiett@instructure.com>
QA-Review: Dan Sasaki
Tested-by: Jenkins
Product-Review: Kyle Follett <kfollett@instructure.com>
Fixes: CNVS-30278
The product design team wants to standardize
on Lato across all Instructure products. See
JIRA for more information.
With this change, we no longer have to use
font-weight: 300 etc to make the right
weight of Helvetica show up. We can go back
to simply using bold and normal, etc.; so
those rules have been updated in this
commit.
Test plan:
to accurately test this you need to set up your
canvas to use a CDN. there is a dev CDN that ops
has set up for us. you put the settings in
config/canvas_cdn.yml. slack ryan if you need help
setting that up or need to know what the values
are to use.
you also need to edit your config/environments/development.rb
file so it look like this:
config.action_controller.perform_caching = true
ENV['USE_OPTIMIZED_JS'] = 'true'
and then when you make any changes you need to run:
bundle exec rake canvas:compile_assets
bundle exec rake canvas:cdn:upload_to_s3
touch tmp/restart.txt
for the changes to be seen
- This change applies only to new UI. Legacy
should be unchanged.
- Clear cache and cookies first.
- Go to Canvas. On the first page load only
you should see a slight shifting of the text
as Canvas loads the Lato font and falls
back on the Helvetica system font.
- From that point on, Lato should be
cached in the browser and load instantly
when you move between views:
http://screencast.com/t/hZhUZOhH
- Canvas should still work in all supported
languages and browsers.
Not yet converted:
- TinyMCE textarea fiekd
- Mobile login
Change-Id: I861e609c01824f60ac38d3fc15e5b960a06e44de
Reviewed-on: https://gerrit.instructure.com/85737
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Dan Sasaki
Product-Review: Kyle Follett <kfollett@instructure.com>
This reverts commit ce771d353b.
fixes CNVS-32874
test plan:
- make sure that old icons are working appropriately, especially with
inst-ui components
Change-Id: If749cec08302b1bd252c0938ad9fd2329e1c1040
Reviewed-on: https://gerrit.instructure.com/93540
Reviewed-by: Colleen Palmer <colleen@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
Tested-by: Jenkins
QA-Review: Pierce Arner <pierce@instructure.com>
closes: CNVS-29706
This initial commit introduces Instructure Icons into Canvas.
Due to the range in aesthetic impact of including both line
and solid icons, the change is expansive and will be refined
in subsequent commits. The purpose of this commit is to:
- Make InstIcons available in Canvas allowing the use of the
react components
- Replace the current icon font with the new InstIcons font
- Allow for use of both 'Line' and 'Solid' icon variants
- Update the styleguide to reference the InstIcons github
documentation for examples
- Remove font custom from Canvas
Test Plan:
- On compiling, icons in Canvas should now be changed to the
corresponding Instructure Icons as can be seen here
http://instructure.github.io/instructure-icons/
- The icon default displaying in Canvas should be solid icons.
If the variant "icon-Line" is added to an icon's css class,
it should display as line. For example, in the case of
<i class="icon-edit"></i>, adding
<i class="icon-edit icon-Line"></i> would result in a line
version of the edit icon displaying
- As a developer, you should be able to use InstUI react icons
- The rake task `bundle exec rake icons:compile` should no
longer exist
- The styleguide should no longer display example icons, but
should now include a link to the Instructure Icons github
documentation
Change-Id: Id5a2f7be33b8e5bed76867da067309d044b5be06
Reviewed-on: https://gerrit.instructure.com/91014
Tested-by: Jenkins
QA-Review: Pierce Arner <pierce@instructure.com>
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
Product-Review: Kyle Follett <kfollett@instructure.com>
Fixes: CNVS-31497
test plan:
- as a user navigate to /styleguide click style then icons and
scroll down to the bottom of the icons to see the new one has
been added http://screencast.com/t/WuhgdCUTKaBr
Note: locally if having trouble getting the assets to compile
the icon font correctly (as in it keeps showing as an ascii
box... delete /dist folder inside public and run all of the
necessary icon-font compiling commands and it should
generate just fine)
Change-Id: I355a9408d216d01bb0ff6b2fbed029d22a361445
Reviewed-on: https://gerrit.instructure.com/89582
Tested-by: Jenkins
Reviewed-by: Stephen Jensen <sejensen@instructure.com>
Product-Review: Kyle Follett <kfollett@instructure.com>
QA-Review: Pierce Arner <pierce@instructure.com>
Fixes: CNVS-30755
Test plan:
When you use the publish button to publish and
unpublish things in Canvas, the icon should
no longer be dark gray:
http://screencast.com/t/cHCeNc6KEA5e
Note: the number of files changed is due to the
icon font stylesheet being dynamically generated
through font custom. If you edit the stylesheet, it
also recreates all the SVG files, etc., when you
compile the icon font.
Change-Id: I00b2ce52027ca64516d4bdd35dff7c315c78d25e
Reviewed-on: https://gerrit.instructure.com/87277
Tested-by: Jenkins
Reviewed-by: Pam Hiett <phiett@instructure.com>
Product-Review: Pam Hiett <phiett@instructure.com>
QA-Review: Pierce Arner <pierce@instructure.com>
Fixes: CNVS-30674
test plan:
- make sure the icon font updates locally
- as a teacher/admin
- navigate to speedgrader to ensure the "ALT" has been replaced
with a "keyboard"
- next navigate to a quiz or an assignment and in the edit view
the keyboard shortcut icon should be back to the "icon-info"
(it will be updated in a future commit as far as placement
and aligning with the updated keyboard look)
Change-Id: I85541a8f0858a1a22d798003e38e7145016ef9db
Reviewed-on: https://gerrit.instructure.com/86524
Tested-by: Jenkins
Reviewed-by: Colleen Palmer <colleen@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
QA-Review: Pierce Arner <pierce@instructure.com>
fresh coat of paint for speedgrader toolbar.
in addition, improvements have been made for
a11y.
closes CNVS-29917
test plan:
- full regression test on speedgrader, including:
a) verify when no students have been graded,
the average grade is hidden
b) verify the icons on the left-hand side of the
page are <a> tags if they take you somewhere,
or <button> tags if they take action (previously,
they were all links)
c) verify the dropdown behaves properly and is also
usable with a screenreader
d) verify all links in the toolbar take you to the
correct page
e) verify the 'Graded', 'Average', and 'Student'
metrics are accurate and update as expected (when
grading a student or switching to a different
student)
Change-Id: Iee7e4ef9c0501d6207d1746011d7f02f7fc0ecb5
Reviewed-on: https://gerrit.instructure.com/82618
Tested-by: Jenkins
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
QA-Review: KC Naegle <knaegle@instructure.com>
Product-Review: Christi Wruck
refs: CNVS-29785
This was fixed before in https://gerrit.instructure.com/39153
but it broke again and never got caught because
node-sass let the @extend fail silently even though
it couldn't find the css it was trying to @extend.
(since the sheet that has the icons is loaded in
common and conversations is loaded in its own sheet,
you can't @extend something that is not already in the
bundle your rendering)
I filed a new ticket that is a clone of the original:
fixes: CNVS-29766
here's the commit message of the original bug:
fixes CNVS-14436
This fixes the icon not showing up correctly in the conversations
dropdown
Test Plan:
- Go to Inbox
- Click on "All Courses"
- Make sure a checkmark icon shows on the selected course
- Also click on "Compose a Message"
- Make sure the checkmark also appears in the Courses dropdown here
Change-Id: I3c0c753fdc1020366d9fbe2cb823f8eb268c4eb9
Reviewed-on: https://gerrit.instructure.com/81511
Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com>
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
closes: CNVS-28669
refs: CNVS-28781
Back in 2013 we came up with an awesome idea to have these
"Tours" to introduce new features and stuff. It was a
great idea but we don't use it anymore. it has been commented
out so it doesn't show up in the styleguide and all but one
(see below) were commented out of config/tours.rb.
so in the interest of not letting code hang around
that we don't use, I'm removing it (unless anyone is opposed
or has a good reason to leave it). If we want to do it in the
future, we can just add it back, because yay Git!
There was one place in quizzes that was still trying to
use a tour. if you go to create a quiz and edit a question
and then pick another option as the correct answer for a
multiple choice question it would try to show a tour telling
you that you could regrade all the existing submissions. but
in reality it just threw a javascript error and the tour never
popped up. So even though it was still in the code, it didn't
work. Since no one noticed that it stopped working, I'm assuming
we don't need it any more. Quizzes team and quizzes
product/QA, will you confirm this is ok?
test plan:
* no tours should show up anywhere in canvas
* read that paragraph above about the "regrade existing"
thing in quizzes.
* try that feature, it should work but no tour should show up
and no error should occur in the console
Change-Id: Ib2d6bbb80f93fd7ca0a33d20c1f57ee16e7027ea
Reviewed-on: https://gerrit.instructure.com/76875
Tested-by: Jenkins
Reviewed-by: Jennifer Stern <jstern@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
Fixes: CNVS-28725
test plan:
- as a user with the new UI using a windows machine (any browser)
- navigate to "Courses" in the left-hand nav
- select "All Courses" from the sub-nav
- there should be an obvious difference between items that have
been favorited vs those that have not (ensure the deliniation
remains when turning on "high contrast")
Change-Id: I6bc9b2eca4a7524e0e5e0f82727875e7dc9442ae
Reviewed-on: https://gerrit.instructure.com/77090
Tested-by: Jenkins
Reviewed-by: Colleen Palmer <colleen@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
QA-Review: Pierce Arner <pierce@instructure.com>
Fixes: CNVS-27871
test plan:
- as a user with the old and/or new ui
- navigate to the course listing page /courses ("all courses")
- there should now be an outlined version of the star and once
clicked it will fill to a solid golden
- example: http://screencast.com/t/g1vpLc78NSbZ
note:
- product design asked that the dashcard cog icon be swapped
out for the paper/pencil icon so that was addressed on
this ticket as well (http://screencast.com/t/hKw3AHLi)
Change-Id: Iab9048db7bfd8a8ec3672cc00a5c50dafd729992
Reviewed-on: https://gerrit.instructure.com/74220
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
QA-Review: Pierce Arner <pierce@instructure.com>
Tested-by: Jenkins
Fixes: CNVS-27125
test plan
- once compiling assets
- navigate to local canvas/styleguide#icons
- scroll to the bottom of the list and ensure you see icon-table
Change-Id: I741e55997092d13a21faa8141f02b00de88c84c2
Reviewed-on: https://gerrit.instructure.com/71728
Tested-by: Jenkins
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Fixes: CNVS-26579
note:
- the font-size: 4px was specific to screen-reader-text class
which has been replaced with screenreader-only
sample test plan:
- ensure the css compiles without errors
- as an admin using the old or new UI in safari
- navigate to a course and click on settings
- click into the "sections" tab ensure everything displays correctly
- turn on VO navigate down to the edit/delete icons and through VO
you should hear the alert that shows as a popover for sighted
users (example: http://www.screencast.com/t/bpNg0n1hFFX)
Change-Id: I0003b6fbd0a360cfe0c7e1faf4e038fc9b94bb8b
Reviewed-on: https://gerrit.instructure.com/70886
Tested-by: Jenkins
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
Fixes: CNVS-26196
test plan:
- as a user
- navigate to a course and choose "Course Setup Checklist"
- the Canvas icon should have all its heads on the logo
Screenshot of it working: http://cl.ly/0X2K150F2337
Change-Id: If2f5451a93b1c2396625c8585d9cb219b26e85fe
Reviewed-on: https://gerrit.instructure.com/70032
Reviewed-by: Pam Hiett <phiett@instructure.com>
Product-Review: Pam Hiett <phiett@instructure.com>
Tested-by: Jenkins
QA-Review: Myller de Araujo <myller@instructure.com>
Reviewed-by: Colleen Palmer <colleen@instructure.com>
Fixes: CNVS-25973
notes:
- old icons: http://screencast.com/t/F1iM8Nplm
- new icons: http://screencast.com/t/AhkxbTDwBs
*** running locally may require be rake icons:compile
along with compiling css AND restarting the server
test plan:
- in order to see these updated icons frd
- login in to local canvas and navigate to
/styleguide
- click on the "Style" link and then select "Icons" from
the sub-nav
- note: titles have been added to all of the icon for a11y
Change-Id: I54cc59dd116fae5fc792b9260a6b4a9e9e77a285
Reviewed-on: https://gerrit.instructure.com/69190
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
Tested-by: Jenkins
QA-Review: Myller de Araujo <myller@instructure.com>
fixes CNVS-25467
fixes CNVS-25468
test plan:
- Go to assignment and quiz page
- Ensure that "Post grade to SIS enabled" icon is attached to
all assignments that have the option enabled and that
"Post grade to SIS disabled" icon is on the rest.
- Click "Post grade to SIS enabled" icon and ensure that
it toggles on the screen and that the option toggles for the
assignment
- Ensure that the icon is accesible
- Check that tooltip on icon is correct on both toggle positions
- Disable post grades to SIS at the account level
- Check both quizzes and assignments to ensure that the icon is
no longer there
Change-Id: Ib6682a7ca4d77dcc9a5e05095e33920eac981e9b
Reviewed-on: https://gerrit.instructure.com/68635
Tested-by: Jenkins
Reviewed-by: Ryan Taylor <rtaylor@instructure.com>
QA-Review: Rajkumar Kethavath <rkethavath@instructure.com>
Product-Review: Jason Sparks <jsparks@instructure.com>
Support passing a class for an icon for styling goodness.
added support for `canvas_icon_class` allowing use od css classes from canvas
style guide which can make it look better and maintain our styling
standards.
Fixes PLAT-1222
Test Plan:
prereq's
- "LOR External Tools" feature flag enabled
- (notice the lack of lti example tool, you dont need it)
A new commons icon has been added so you should probably run the
following
`bundle exec rake brand_configs:clean canvas:compile_assets`
Add a new LTI tool to the account using [this xml](https://gist.github.com/defektive/dbd182cb04500e236bde)
check placements to make sure they show a fancy new icon instead of a
crappy star. course_home_sub_navigation should show up as the commons icon
placements to look at
:assignment_menu - cog on an assignment
:course_home_sub_navigation - right side of page
:course_settings_sub_navigation
:discussion_topic_menu
:file_menu (no icon)
:global_navigation (no icon)
:module_menu
:quiz_menu
:wiki_page_menu
Change-Id: Ib462e928a5a3811df490f9bf2441b755db2882a9
Reviewed-on: https://gerrit.instructure.com/62492
Tested-by: Jenkins
Reviewed-by: Nathan Mills <nathanm@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Brad Horrocks <bhorrocks@instructure.com>
refs CNVS-19605
Note: added two new icons to the canvas iconset (equation, equella)
Test plan:
- Enable the kaltura plugin at /plugins/kaltura (see https://gollum.instructure.com/OtherServiceTestAccounts#Notorious-(NO-MORE-KALTURA-YAY))
- Enable the Equella feature for the account
- Verify that the link, image, equation, record video and equella icons are updated (http://cl.ly/image/2H3m331w0f1O)
- Hover states should match the other menu buttons
Change-Id: I91c298f3dcb2146748d6104342aa265eb43462e9
Reviewed-on: https://gerrit.instructure.com/56283
Tested-by: Jenkins
Reviewed-by: Colleen Palmer <colleen@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
QA-Review: August Thornton <august@instructure.com>
the rails asset pipeline expects fonts to be
in the 'fonts' directory of it's assets folder.
since we're using it to put md5s in our urls,
I'm moving it there
test plan:
* no changes,
* load page and ensure icons and fonts still work
Change-Id: Iec3a1b04259b1d74fbfa98f9ecc53d98e972e02a
Reviewed-on: https://gerrit.instructure.com/54805
Tested-by: Jenkins
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Jacob Burroughs