closes ARC-9763
flag=speedgrader_studio_media_capture
test plan:
- start recording a screen share media comment in speedgrader
- click the 'shop sharing' button
- verify that the recording stops and the media modal appears
Change-Id: Ib3de0b680acb9edc30b652e00b0c131354cfaac4
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/350455
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Ojaswee Chaudhary <ojaswee.chaudhary@instructure.com>
Product-Review: Ravi Koll <ravi.koll@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
Reviewed-by: Rohan Chugh <rohan.chugh@instructure.com>
The modal that is used to record screen share media
on speed grader submission comments was blocking the
page, so you could not interact with the page while
the modal was open. This change removes the modal
and instead shows an indicator bar.
flag=speedgrader_studio_media_capture
closes EVAL-4130
test plan:
- go to speed grader
- click on the media recorder icon
- click the start button (this should default to
the webcam recoring)
- the modal should stay on the page
- close the modal and click the media recorder
icon again
- select screen share this time
- click the start button and the modal should
disappear and the indicator bar should show
at the top of the page
- click the 'cancel' button and the indicator bar
should disappear
- click the media recorder icon again and select
screen share
- click the start button and the indicator bar
should show at the top of the page again
- click the 'finish' button and the indicator bar
should disappear and the modal should show
Change-Id: I20911ae96c0bd9c2ce1519e3958f9b659adc0ec0
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/345967
Reviewed-by: Cameron Ray <cameron.ray@instructure.com>
QA-Review: Cameron Ray <cameron.ray@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Melissa Kruger <melissa.kruger@instructure.com>
flag=speedgrader_studio_media_capture
test plan:
- enable speedgrader_studio_media_capture feature flag
- go to the speed grader
- click on the media recorder button
- verify that the screen capture option is available
Change-Id: I37349bbe5fa29f431ecb028c2c96f05290974488
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/341093
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Christopher Soto <christopher.soto@instructure.com>
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
QA-Review: Rohan Chugh <rohan.chugh@instructure.com>
Product-Review: Ravi Koll <ravi.koll@instructure.com>
fixes LF-906
flag=none
Test Plan:
- In an RCE, record a video and save it
- Go to course file
- Verify new file has appropriate extension
- Repeat with uploading media
- Go to submission comments
- Submit an assignment
- Go to speedgrader for submission
- Record media
- Go to user files
- Verify new file has appropriate extension
- Repeat with uploading media
Change-Id: Ie79209fd6bd43eb5eeaae1dbd85c89bc34f7d2a3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/331893
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Jacob DeWar <jacob.dewar@instructure.com>
Reviewed-by: Juan Chavez <juan.chavez@instructure.com>
QA-Review: Juan Chavez <juan.chavez@instructure.com>
test plan:
- all tests pass
flag=none
Change-Id: I50e858039081b8bd0c5a497cdf9e697710a54dc5
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287364
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ahmad Amireh <ahmad@instructure.com>
QA-Review: Ahmad Amireh <ahmad@instructure.com>
Product-Review: Ahmad Amireh <ahmad@instructure.com>
refs FOO-2696
flag = none
applied by the codemod found here: https://github.com/instructure/canvas-i18n-loader-rewrite
this won't pass in isolation, see the mega patch that cherry-picks them
all for the status
~ test plan ~
do a cursory glance over the changes and verify we didn't miss anything
Change-Id: I9bc7dad55c7aba9053ab69c9bb477cb4ee3e78bb
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/286661
Tested-by: James Butters <jbutters@instructure.com>
Reviewed-by: Charley Kline <ckline@instructure.com>
QA-Review: Charley Kline <ckline@instructure.com>
Product-Review: Charley Kline <ckline@instructure.com>
This bump fixes an issue in Chrome 92
that prevented media recording
Ignore some failing tests for now as it seems to be
a Jenkins environment issue
Closes MAT-375
flag=none
Change-Id: I9cae6048dfe23fbdc990f0dc03c1610616af06bf
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/271683
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Gary Mei <gmei@instructure.com>
QA-Review: Gary Mei <gmei@instructure.com>
Product-Review: Gary Mei <gmei@instructure.com>
Derek Williams