closes LX-2002
flag=selective_release_ui_api
flag=selective_release_edit_page
pre-requisites:
- Have a course with students and without group sets.
test plan:
- Navigate to an assignment creation page.
- Click on "This is a Group Assignment".
> Notice that the group set dropdown IS NOT visible.
- Click on New Group Category.
- On the modal, add a name, select "Split students in
groups" and set the number to 1.
- Save the modal.
- Wait until creation process ends.
> Verify that the group set dropdown IS visible.
> Verify that the new group set is automatically selected.
> Save.
> Verify on the edit page that the group set selection
is persisted.
NOTE: The original issue is reproducible without the
selective_release_edit_page FF so you can test this
with the FF disabled.
Change-Id: Ib1141736efb3f7ad48aac1646b23233573ed2d23
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/355734
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Juan Chavez <juan.chavez@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
closes LX-1961
flag=selective_release_ui_api
flag=selective_release_edit_page
test plan:
- create a new assignment
- mark as group and select a group set
- add one group to the asignees in the cards
- save it
- go back to edit and try to change the set group
- an error should appear
Change-Id: I29779795b301e9a9d56188abf0843ef2f3459238
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/355465
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jonathan Guardado <jonathan.guardado@instructure.com>
QA-Review: Jonathan Guardado <jonathan.guardado@instructure.com>
Product-Review: Alvaro Talavera <alvaro.talavera@instructure.com>
fixes VICE-4308
flag=none
Test plan:
- Go to a course's people page
- Create a group set
- Create another group set with the same name
- A proper error message should show the name is already in use
Change-Id: Idb0875ad9ed0716b7918ea24965703e5a93061f9
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/349591
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jason Gillett <jason.gillett@instructure.com>
Product-Review: Mario Hegyi <mario.hegyi@instructure.com>
QA-Review: Roland Beres <roland.beres@instructure.com>
Fixes FOO-4376
flag=none
Test Plan:
- Best a student who manages a group
- Go to the group page, see the manage link is
translated now.
Change-Id: I340e447ade7c17fe34ac7b53458e1d896e133632
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/347305
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ryan Norton <rnorton@instructure.com>
Product-Review: Ryan Norton <rnorton@instructure.com>
QA-Review: Jason Perry <jason.perry@instructure.com>
Change-Id: I253d4a8fdcd99268ef436598feed05ea6de14b52
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/343012
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Michael Hulse <michael.hulse@instructure.com>
Reviewed-by: Gustavo Bernardes <gustavo.bernardes@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Ryan Norton <rnorton@instructure.com>
Product-Review: Ryan Norton <rnorton@instructure.com>
Each instance of the jQuery UI dialog will now incorporate
specific options that were previously implemented through
custom modifications to the source code. This update aims
to streamline our codebase by directly applying critical
customizations, such as z-index and modal type, to the
instantiation calls themselves. By doing so, we eliminate
the need to maintain separate versions of the library
source code with one-off modifications.
refs FOO-4258
flag=none
test plan: tests pass
[skip-crystalball]
Change-Id: I213cfd8d7b754c3d9ca202bc70a2fe563ccaff57
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/340323
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Michael Hulse <michael.hulse@instructure.com>
Product-Review: Michael Hulse <michael.hulse@instructure.com>
Reviewed-by: Jen Smith <jen.smith@instructure.com>
this resolves some test failures with jquery 1.8
it also reduces jquery usage
refs FOO-3741
Change-Id: Ic9d77395d15f28db5252a6d5221f30c69b2f5796
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/338463
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Michael Hulse <michael.hulse@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
This is part of a larger effort to remove
cyclical dependencies.
Refs CFA-27
flag=none
Change-Id: I69471400e98e67a3b0d19877a3833e6ef1ba8286
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/335934
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Reviewed-by: Michael Hulse <michael.hulse@instructure.com>
flag = none
fixes VICE-3741
Test Plan:
0) Make a course,
make sure on more options you allow for students
and teachers.
1) Go to /courses/1/groups as a student.
2) Test tabbing doesn't go into sub menu.
Change-Id: Ieb467c482bf8f568a91914bde64bebecc62fcb75
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/332597
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Reviewed-by: Jason Gillett <jason.gillett@instructure.com>
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
fixes VICE-3742
flag=none
Test Plan:
- as a student
- go to the people page
- select the group tab
- the search bar should function as expected
- search icon should render before input
Change-Id: I27f3e1b2adfd3725c2f95b60cfb5eb4019a6f0cb
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/331639
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Sam Garza <sam.garza@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Reviewed-by: Chawn Neal <chawn.neal@instructure.com>
closes VICE-3738
flag=none
Test Plan:
- go to groups page
- click create set button
- submit without filling in any fields
- name field should show bright red
- lable should show with '*'
Change-Id: I113d98a9c007c64b912c83871c429486fe010651
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/330125
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Sam Garza <sam.garza@instructure.com>
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Reviewed-by: Caleb Guanzon <cguanzon@instructure.com>
modifies the REST API endpoint that the student view groups page uses
to fetch groups to add a filter query param. this param filters
groups by group name or the names of the users of the group.
closes EVAL-3254
refs EVAL-3253
flag=none
test plan:
- go to a canvas course that has a large number of groups (e.g. 100+)
- go to the people tab of the course
- click on student view at the top right
- go to the groups section on the people page of the student view
- search for a group name or a user's name that is in the group
- ensure that only one request is made to find those filtered groups
- ensure that the groups that are returned are filtered by the search
term
- enter another search term
- ensure that only one request is made to find those filtered groups
- ensure that the groups that are returned are filtered by the search
term and NOT the previous search term
Change-Id: Iaa62024aaef7f1db50d5cf7029bc590cf31c396b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/324188
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
we want the fix some inconsistencies in the assignment
edit page
fixes EVAL-2613
flag=
test plan:
- create an assignment
- click on the edit button
- make sure assignment boxes are aligned
Change-Id: I6d9d3e1c002832bc6b5ce810bae921eb3d36d35c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/314202
Reviewed-by: Cameron Ray <cameron.ray@instructure.com>
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Kai Bjorkman <kbjorkman@instructure.com>
Product-Review: Cameron Ray <cameron.ray@instructure.com>
this removes annoyances when decaffeinating files
test plan:
- all tests pass
flag=none
Change-Id: Ie3af0faf13d64a4701bb917fbcae29cb10474df1
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/315484
Reviewed-by: Derek Williams <derek.williams@instructure.com>
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
QA-Review: Kai Bjorkman <kbjorkman@instructure.com>
Product-Review: Cameron Ray <cameron.ray@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
In this one instance, the checkbox was using an attribute called
`aria-checked`. This is currenlty having bugs within chrome and is no
longer needed as screen readers can now user the normal `checked`
attribute.
closes EVAL-2945
flag=none
Test Plan:
- test using Chrome and FF, create an assignment in a course
- Using a supported screen reader, tab to the Group Assignment option
and enable it
- Tab to the Assign Grades Individually option
- Tab back to the Group Assignment option and ensure it annouces
correctly whether the box is checked.
Change-Id: I04cc6ec14867892794104ef2889b3fc3168fd5b0
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/314475
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
Reviewed-by: Derek Williams <derek.williams@instructure.com>
QA-Review: Derek Williams <derek.williams@instructure.com>
Product-Review: Cameron Ray <cameron.ray@instructure.com>
closes VICE-3380
flag=none
test plan:
- Specs pass.
- Go to the People's Page.
- Create a group set.
- Enable “Allow Self Sign-up”.
- Enter a name and set the “Limit Group Members” to 1.
- Click Save and it should show an error message.
qa risk: low
Change-Id: Ie667f5828ff0aa10b4e56849289c669ca606791b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/313620
QA-Review: Jason Gillett <jason.gillett@instructure.com>
Reviewed-by: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
fixes VICE-3292
flag=none
turning it into a plain string should lessen the
risk of issues when compiling for translations.
the next round of 3rd party spanish translations
should be able to translate it when they get to it
test plan:
- start canvas server
LOLCALIZE=true bundle exec rails s
- visit the people page of a course
- create a new group set
- in the create group set modal, hover over
the info icon
- verify all the text inside the popup
is LOLCALIZED
Change-Id: Iedb72e20dd0d157be9ba22b2e310953a07600130
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/308785
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jason Gillett <jason.gillett@instructure.com>
Product-Review: Jason Gillett <jason.gillett@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
closes VICE-3036
flag=none
Currently this patchset only removes groups inside of group_categories that:
1. Are self-signup
2. Require students to be in the same section
OR
1. Are not self-signup
Test Plan
1. Create a self-signup group set that requires students to be in the same section
2. Create a student that is limited to interact with students in their own section
3. Make sure the created student is in their own section
4. Make 3 groups
4a. Have a group with the ceated student
4b. Have a group with any other student
4c. Create an empty group
5. As the created student view your groups
6. Only the empty group and the group you are in should be visible
Change-Id: I084aedfb3e10b129618eff0fa4d1c1bb0561fecc
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/302420
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
fixes VICE-2960
flag=none
Test Plan:
Setup:
- create a course
- create multiple sections in the course
- enroll students in the course in the various
sections
- go to the people page of the course
- open create new group modal
- change "create groups later" to "split by # of groups"
- check the require students to be in the same section box
- save the group
> students should only share a group with students from
same section
Change-Id: I304eb49baf7d62aef71e01ae4e8497c66321e8ba
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/294959
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Caleb Guanzon <cguanzon@instructure.com>
Reviewed-by: Chawn Neal <chawn.neal@instructure.com>
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Chawn Neal <chawn.neal@instructure.com>
QA-Review: Chawn Neal <chawn.neal@instructure.com>
closes VICE-2671
flag=none
Test Plan:
- able to create groups using self sign up flow
Change-Id: Ide308d2835ede3599bed161175cd16cae18645a4
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/294680
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Reviewed-by: Jeffrey Johnson <jeffrey.johnson@instructure.com>
Product-Review: Jeffrey Johnson <jeffrey.johnson@instructure.com>
refs VICE-2671
flag=none
Test Plan:
- can create groups by member count
- can create groups by group count
Change-Id: If697cf6789c360f8456aaf56b5caf7bfebf6e965
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/294171
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Jeffrey Johnson <jeffrey.johnson@instructure.com>
Reviewed-by: Jeffrey Johnson <jeffrey.johnson@instructure.com>
juan.chavez