refs VICE-4193
flag=instui_nav
Test plan:
- Check, than the instui_nav feature flag has been enabled
- Visit the discussions list page under the Courses menu
- Check the new tablet and mobile design changes based on the figma
- Check the filter (arrow next to the title) functionalities
- Check the search field functionality
- Check the buttons (add, setting) functionality on the right corner
Change-Id: Ib67da73304f8083cdf21956f2704303fdca9d500
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/350559
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Daniel Matyas Vincze <daniel.vincze@instructure.com>
QA-Review: Dora Csolakov <dora.csolakov@instructure.com>
Product-Review: Roland Beres <roland.beres@instructure.com>
refs LF-1439
flag=none
Test Plan:
- 'renders "Delayed" date label' test passes
Change-Id: I927d120fe83cfbe26d40942a7adbf3f290bc01fa
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/348042
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Balint Kartyas <balint.kartyas@instructure.com>
Reviewed-by: Árpád Kozma <arpad.kozma@instructure.com>
QA-Review: Árpád Kozma <arpad.kozma@instructure.com>
QA-Review: Balázs Buri <balazs.buri@instructure.com>
Product-Review: Árpád Kozma <arpad.kozma@instructure.com>
Product-Review: Balázs Buri <balazs.buri@instructure.com>
fixes LF-1425
flag=none
test plan:
- tests are still testing what they were before
- tests pass
Change-Id: If1c69d04d7f3a797ad6cc79665dbb36966630862
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/344442
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob DeWar <jacob.dewar@instructure.com>
QA-Review: Jacob DeWar <jacob.dewar@instructure.com>
Product-Review: Eric Saupe <eric.saupe@instructure.com>
refs VICE-4084
flag=none
Test Plan
1. create some announcements
2. have one be locked for comments
3. Have one be open for comments
4. open announcement index as student
5. verify that locked announcement does not display reply
6. turn off permission for student to reply to discussion/announcement
7. verify that both announcements do not display reply button
Notifications will to observers will be updated in a following
patchset
Change-Id: I81d311326616c1ffb51c644e1a2628da716342d6
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/340513
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Reviewed-by: Samuel Lee <samuel.lee@instructure.com>
Product-Review: Jason Gillett <jason.gillett@instructure.com>
closes LF-581
closes LF-583
flag=explicit_latex_typesetting
test plan:
- with the flag on
- test out different pages with multiple user content divs
- add some math ex. \(Latex\) throughout the page
- save the page
- math should render
- places to test:
- announcements landing page (math should render in the content
snippet of each announcement)
- classic quizzes when taking the quiz (math should render in
the questions and the answers)
- discussions (posts and replies, etc)
- with the flags outcomes_friendly_description and
improved_outcomes_management on
- test adding math to outcomes descriptions and friendly descriptions
- expand and un-expand the descriptions, math should still render
- try creating new outcomes, removing outcomes, and editing outcomes
- ensure that math still renders on pages with one user content div
- ex. math on a page
Change-Id: I11d7a186ce7acdbd8a8705409d25b117e7842f0d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/325861
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jonathan Guardado <jonathan.guardado@instructure.com>
Reviewed-by: Jake Oeding <jake.oeding@instructure.com>
QA-Review: Jonathan Guardado <jonathan.guardado@instructure.com>
Product-Review: Jonathan Guardado <jonathan.guardado@instructure.com>
this removes annoyances when decaffeinating files
test plan:
- all tests pass
flag=none
Change-Id: Ie3af0faf13d64a4701bb917fbcae29cb10474df1
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/315484
Reviewed-by: Derek Williams <derek.williams@instructure.com>
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
QA-Review: Kai Bjorkman <kbjorkman@instructure.com>
Product-Review: Cameron Ray <cameron.ray@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
flag=granular_permissions_manage_course_content
fixes VICE-3285
Since the permission explainer test specifically specifies
that announcement locking and deleting should really
affect announcements locking and deleting,
we should make it so
this fix will also work with the manage course content
combined permission
test plan:
- turn on the
granular_permissions_manage_course_content feature flag
verify the following in the course announcements index:
- the delete row item menu option only shows for roles with
the manage_course_content_delete permission
- the lock/allow row item menu option only shows for roles with
the manage_course_content_edit permission
- if user has neither of these 2 permissions, the
announcement rows do not show a checkbox, and does
not show a manage menu
Change-Id: Ia4b2eee6461b6a85ae71a8b8e5af15586b7aad23
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/310593
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
QA-Review: Jason Gillett <jason.gillett@instructure.com>
fixes VICE-2952
flag=none
Test Plan:
- import an announcement
> should load without error
Change-Id: I5fc2b4612eabd352b4785359ce9563fe0b6bf608
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/294464
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jason Gillett <jason.gillett@instructure.com>
Product-Review: Jason Gillett <jason.gillett@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Refs FOO-2744
flag=none
This addresses all deprecated use of the `variant` prop
in Button objects in the ui/shared directory.
Test plan:
* possibly spot-check parts of the UI that use these
components that have been touched?
Change-Id: Iefd507398c09029be03734378316bc818e8c48cf
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/293561
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: August Thornton <august@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Charley Kline <ckline@instructure.com>
Also marks a handful of dirs to proove the tooling
Change-Id: I2e19b3861dbf626efd9361829454b6eb16224755
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/292044
Reviewed-by: Ahmad Amireh <ahmad@instructure.com>
Product-Review: Ahmad Amireh <ahmad@instructure.com>
Tested-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Jacob Burroughs <jburroughs@instructure.com>
Closes FOO-2921
flag=none
Our locale data overrides for Canadian French have some
minor errors in formatting and spelling of abbreviations.
This commit corrects them to the values generated by
Intl.DateTimeFormat, which should be correct since those
come directly from the Unicode CLDR.
This also fixes up a couple of the React components that
were using old-style date time formatters, so that they
will now use Intl (this also frees them from having to
import jQuery)
Test plan:
* These translations should be correct. One place to look
for them is in the posting dates for course announcements
Change-Id: Ie81c1e327807259ea43fb128355c1e9ca728558c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/291396
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Charley Kline <ckline@instructure.com>
Product-Review: Charley Kline <ckline@instructure.com>
test plan:
- all tests pass
flag=none
Change-Id: I50e858039081b8bd0c5a497cdf9e697710a54dc5
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287364
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ahmad Amireh <ahmad@instructure.com>
QA-Review: Ahmad Amireh <ahmad@instructure.com>
Product-Review: Ahmad Amireh <ahmad@instructure.com>
refs FOO-2696
flag = none
applied by the codemod found here: https://github.com/instructure/canvas-i18n-loader-rewrite
this won't pass in isolation, see the mega patch that cherry-picks them
all for the status
~ test plan ~
do a cursory glance over the changes and verify we didn't miss anything
Change-Id: I9bc7dad55c7aba9053ab69c9bb477cb4ee3e78bb
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/286661
Tested-by: James Butters <jbutters@instructure.com>
Reviewed-by: Charley Kline <ckline@instructure.com>
QA-Review: Charley Kline <ckline@instructure.com>
Product-Review: Charley Kline <ckline@instructure.com>
flag=none
closes VICE-2214
Test Plan:
- see ticket for designs
- create and publish a discussion
> should see "All Sections" under topic title on landing page
> on mouse over tool tip should render
Change-Id: I1477c016eaf1815edb8e8b663f3929524e069179
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276741
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Caleb Guanzon <cguanzon@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
fixes VICE-2081
flag=none
test plan:
- Go to Discussions/Announcement index page
- Notice that All Sections isn't clickable and
has no tooltip.
qa risk: low
Change-Id: I8726de9a5dc39c2a9bc1955bc9a77705227fb1e5
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274974
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
Janos Csizmas