It is no longer a default gem in Ruby 3.4
flag=none
closes AE-1117
test plan:
- tests pass
Change-Id: I713705e8e20bf08833023e87209a5a403ef10969
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/355338
Reviewed-by: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Isaac Moore <isaac.moore@instructure.com>
Product-Review: Isaac Moore <isaac.moore@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Change-Id: Ifc2eec42a5bec624361aa5aaf163a1a7061b1b1a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/354137
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Build-Review: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Change-Id: Ief031dcf3280d5ea59912a7d050a3816a65e38ea
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/354136
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Build-Review: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Change-Id: I21f74bca49f068b1fc9c4c0fbc340aa51cef2956
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/354057
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Build-Review: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Change-Id: I2c403cf8dccaa63cc2450db7e37ebde5e0249c57
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/354053
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Build-Review: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
they are no longer experimental, since the full test suite has passed
with them
Change-Id: Id49ab672b688a1608eba76ceaa0d883104115456
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/354043
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
and apply new cops. well, mostly. I skipped the update of the rubocop
gem itself until
f005b0506d
is released, since otherwise it spits out a _ton_ of un-actionable
deprecation warnings
Change-Id: I300d0180ed2028060c46491f2baa3efd5336830c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/353237
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
fixes RCX-2117
flag=none
Test Plan:
- In rich content, have an iframe with a src
- src should point to a non-media document
* ex <iframe src="/courses/1/files/3/download">
- Export the course
- Import package into new course
* Url migrates properly
* iframe with a media src still migrates properly
Change-Id: I2404e5a68817236bbaf2f0db75623e6d9465f68b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/353387
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Mysti Lilla <mysti@instructure.com>
QA-Review: Mysti Lilla <mysti@instructure.com>
Build-Review: James Butters <jbutters@instructure.com>
Product-Review: Jacob DeWar <jacob.dewar@instructure.com>
closes AE-985
flag=none
test plan:
- when traces and profiles are both enabled,
profiles are collected and sent to Sentry
Change-Id: I4f401056128a47556f5b56bfb731dfc6c06fbd46
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/348756
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Isaac Moore <isaac.moore@instructure.com>
Product-Review: Isaac Moore <isaac.moore@instructure.com>
Build-Review: Isaac Moore <isaac.moore@instructure.com>
the only functionality we were using in this gem is
the ability to assign an array to a vector column.
pgvector natively accepts a string array.
somehow neighbor broke on job servers in the latest release,
so we will work without it.
test plan:
- search works
- newly created pages are searchable
- courses are searchable after copying
flag=smart_search
closes ADV-172
Change-Id: I7bea0c6764de7aced48cf7ce3fe47f277e60560e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/353133
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jonathan Featherstone <jfeatherstone@instructure.com>
Build-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
Change-Id: I91835f332f081dc70c4c15edcf1f142bc237f17c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/351589
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Build-Review: Isaac Moore <isaac.moore@instructure.com>
Migration-Review: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Change-Id: I901a1f33dcc28ecd607c75c3176babba3bc88c22
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/351964
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Build-Review: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
it was an implicit dependency in Rails 7.0, but no longer in Rails
7.1. it's a useful utility to have around
Change-Id: I744c179a12aba7273c670be54fe49c42ca98c21b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/351593
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Build-Review: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Change-Id: Ic9563d9d3e88d1ee8177688fe0366a629094a9ce
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/351588
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Build-Review: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
with bundler-multilock, you might get a _lot_ of warnings, since this
gemfile fragment is used multiple times
Change-Id: I8683044d3c08d70bad9e2d72e9f36d39d8b27122
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/351019
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
closes RCX-1839
flag=none
Test plan
- Test with https://github.com/instructure/canvas_link_migrator/pull/34
- Have a link in rich content that looks like
<iframe title="media file" src="media_objects_iframe/media_id?type=video" data-media-type="video"
data-media-id="undefined"></iframe>
- Ensure it points to a valid media object that doesn't have an
attachment in the course
- Copy the course and ensure the link comes over
as a media attachment correctly
Change-Id: I1712ce7e31e74b22028256c8d098577074102cad
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/346989
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob DeWar <jacob.dewar@instructure.com>
QA-Review: Jacob DeWar <jacob.dewar@instructure.com>
Product-Review: Eric Saupe <eric.saupe@instructure.com>
Build-Review: James Butters <jbutters@instructure.com>
Cody Cutrer