refs LS-3571
flag=none
In theory, this check is not needed as we are attempting to set state
and call a callback. If this were to happen, we would only have reference
errors.
test plan:
- tests pass
qa risk: low
Change-Id: Ic19c015819c85b7a72a7a0162ccac3181ba1f4fe
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/304607
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
refs LS-3571
flag=none
These warnings were encountered after removing the Button error
suppression. No idea why, but we are without warning/errors after this
change again.
test plan:
- tests pass
qa risk: low
Change-Id: I2f2a63d3763faed564a0cc192c9df1756c7fe4be
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/304581
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
refs LS-3571
flag=none
The test(s) previously causing this error have either been fixed or
removed. This supression is no longer necessary.
test plan:
- tests pass
qa risk: low
Change-Id: Ic4c4e4c80b041a08ee33291f539f2465bf20e146
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/304580
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
refs LS-3571
flag=none
The only instance of the prop being used in the component already has
null safety baked in. We have one instance of this component that
doesn't provide said prop so we are opting to match the expectation
of the component and usage of it by removing the requirement.
test plan:
- tests pass
qa risk: low
Change-Id: I8c3b0e02ed93b48f75595057b37db2df3d5fae09
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/304578
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
refs LS-3571
flag=none
The test(s) previously causing this error have either been fixed or
removed. This supression is no longer necessary.
test plan:
- tests pass
qa risk: low
Change-Id: I49a9ef573073923fb3b86c022835ff4d25c3ff9e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/304603
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
refs LS-3571
flag=none
The test(s) previously causing this error have either been fixed or
removed. This supression is no longer necessary.
test plan:
- tests pass
qa risk: low
Change-Id: Iaaae158fe315fbc23dfab1d1e19f099d345fd60d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/304493
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
refs LS-3571
flag=none
The test(s) previously causing this error have either been fixed or
removed. This supression is no longer necessary.
test plan:
- tests pass
qa risk: low
Change-Id: I7d41a4c0647c1f83cf8674b0a9afce3e212ffd27
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/304577
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
refs LS-3571
flag=none
The test(s) previously causing this error have either been fixed or
removed. This supression is no longer necessary.
test plan:
- tests pass
qa risk: low
Change-Id: Ic8a3a99c1fa3c6bfe8c7dd73814ef647aec47abc
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/304573
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
refs LS-3571
flag=none
The test(s) previously causing this error have either been fixed or
removed. This supression is no longer necessary.
test plan:
- tests pass
qa risk: low
Change-Id: Id9bf57378ae79d4db95ec0aac4bdf6b0b1fa461d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/304508
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
refs LS-3571
flag=none
The test(s) previously causing this error have either been fixed or
removed. This supression is no longer necessary.
test plan:
- tests pass
qa risk: low
Change-Id: I45e08aec1a07873a499209dee79acdd8db907edd
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/304494
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
refs LS-3571
flag=none
The test(s) previously causing this error have either been fixed or
removed. This supression is no longer necessary.
test plan:
- tests pass
qa risk: low
Change-Id: I3aef822aa32c7228cf1a5e8cdb07979282dd64c2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/304492
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
refs LS-3571
flag=none
InstUI prefers the underlying html element to be set via elementRef,
otherwise we are referencing the react component which is a
DeprecatedComponent as we upgrade buttons.
test plan:
- tests pass
qa risk: low
Change-Id: Ib355451231d93418301b3a15156b78cb3acd2b99
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/304377
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
refs LS-3571
flag=none
The test(s) previously causing this error have either been fixed or
removed. This supression is no longer necessary.
test plan:
- tests pass
qa risk: low
Change-Id: Ic7a2dcce6a2d33cc7430e283d9e4c00797207375
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/304379
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
refs LS-3571
flag=none
The test(s) previously causing this error have either been fixed or
removed. This supression is no longer necessary.
test plan:
- tests pass
qa risk: low
Change-Id: I727aebe23edcd6365329422b5dee68326ccef46c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/304376
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
refs LS-3571
flag=none
The test(s) previously causing this error have either been fixed or
removed. This supression is no longer necessary.
test plan:
- tests pass
qa risk: low
Change-Id: I59cb872639159bf780b536d8cff039e81701a6b5
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/304375
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
refs LS-3571
flag=none
The test(s) previously causing this error have either been fixed or
removed. This supression is no longer necessary.
test plan:
- tests pass
qa risk: low
Change-Id: I005a15a8388d617aa2d963844ded79f8d3c8af61
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/304372
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
refs LS-3571
flag=none
The test(s) previously causing this error have either been fixed or
removed. This supression is no longer necessary.
test plan:
- tests pass
qa risk: low
Change-Id: I226d9ae620a53063e61ef6c27cd7522d4327b79f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/304373
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
refs LS-3571
flag=none
The test(s) previously causing this error have either been fixed or
removed. This supression is no longer necessary.
test plan:
- tests pass
qa risk: low
Change-Id: Ie986c569c980b2c17a8800b5d7e863337af817ce
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/304371
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
refs LS-3571
flag=none
The test(s) previously causing this error have either been fixed or
removed. This supression is no longer necessary.
test plan:
- tests pass
qa risk: low
Change-Id: I6c1dfa0cfc78e022381085e6f4119879ee678db4
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/304359
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
refs LS-3571
flag=none
The test(s) previously causing this error have either been fixed or
removed. This supression is no longer necessary.
test plan:
- tests pass
qa risk: low
Change-Id: Id2ecda2572460e8d0720e378a05986e347846f06
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/304360
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
refs LS-3571
flag=none
The test(s) previously causing this error have either been fixed or
removed. This supression is no longer necessary.
test plan:
- tests pass
qa risk: low
Change-Id: I01a06715c51e2dc405f1dbd52dbaa440a8aaeee6
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/304363
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
closes MAT-782
flag=new_equation_editor
flag=new_math_equation_handling
flag=buttons_and_icons_root_account
flag=buttons_and_icons_cropper
test plan:
-enable the feature flags
-test the following on various pages with an RCE:
1. Use the new equation editor
- make sure that you can insert equations as normal
- test that Canvas KB shortcuts don't work while the modal
is open (old discussions is a good place to test this part)
- make sure the advanced preview renders
- test this locale related change:
* change your locale
* open the new eq editor
* enter some latex
* toggle to advanced view
* check that the mathjax request made to the following URL
has the appropriate locale query parameter at the end:
https://cdnjs.cloudflare.com/ajax/libs/mathjax/2.7.7/MathJax.js?config=TeX-MML-AM_SVG&locale=en
2. Make sure you can still insert a course document link
without errors related to ENV values
3. Make sure you can still insert a course link to
something like an assignment with a due date or a
dated announcement without ENV related errors
4. Test that no console errors related to ENV values
occur when using a screenreader in the IM cropper
while zooming in or out (I think this is the only
place currently using flash alerts inside the RCE)
-double check that I didn't miss any lingering ENV deps
Change-Id: I49f0a80a200cbe0418e735b5e638dd1ed519f750
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/298916
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Joe Hernandez <joe.hernandez@instructure.com>
QA-Review: Joe Hernandez <joe.hernandez@instructure.com>
Product-Review: Jake Oeding <jake.oeding@instructure.com>
Fetches and renders the first layer of account tree on initial load,
then subsequent layers when expanded. If a single layer has multiple
pages of accounts, then all pages are fetched. Saves the changes to
the database when the apply button is clicked.
Note: the search, filter, and text describing the number of selected
accounts are not functional yet, and will be addressed in a future
commit.
closes LS-3271
flag = account_calendar_events
Test plan:
- Go to /accounts/self/calenda_settings
- Expect to see an account tree listing the account hierarchy
(accounts with subaccounts can be expanded)
- Expand some accounts and check/uncheck a few things
- Click apply
- Expect the changes to be persisted on reload
Change-Id: I6b0023f9cf6df80d732c7c6301124909eaff17ea
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/296871
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Eric Saupe <eric.saupe@instructure.com>
QA-Review: Eric Saupe <eric.saupe@instructure.com>
Product-Review: Allison Howell <allison.howell@instructure.com>
refs FOO-2801
flag = none
[change-merged][build-registry-path=jenkins/canvas-lms/foo-2801]
[pin-commit-analytics=4fd9e2fbb7fc2790ba7985bb4025e901bf33a9e3]
this part reaches the goal of this series where we turn the locale
files that are used by our JS engine into plain JSON files that don't
need any special processing and are also of a simpler structure
before, translations were stored in a tree structure that we needed to
traverse in order to look up a translation, which we did by
deconstructing keys through the "." operator:
I18n.lookup("foo.bar.baz")
{
en: {
foo: {
bar: {
baz: "Hello!" // <-- this
}
}
}
}
now, translations are stored in a flat dictionary structure where the
keys are not processed in any special way but are instead "fully
qualified":
I18n.lookup("foo.bar.baz")
{
en: {
"foo.bar.baz": "Hello!"
}
}
this is nice when you consider that the previous structure contained a
mixture of nested keys and flat ones, based on different conditions:
{
en: {
"asdf_1234": "ASDF", // inferred, so it was never "nested"
"foo": {
"bar": {
"baz": {
"one": "One banana",
"other": "Many many bananas"
}
}
}
}
}
because, for example, keys that are inferred by i18nliner end up at
the root level and not nested. You also never knew whether a key was a
container or a phrase that was pluralized, because they both had the
shape of an object.
Now these distinctions are gone; a key is always fully-qualified
regardless of how it was specified:
1) inferred: I18n.t("Inferred key")
// => inferred_key_c49e3743
2) absolute: I18n.t('#buttons.cancel')
// => buttons.cancel
3) relative: I18n = useScope('outer')
I18n.t('something', 'Something')
// => outer.something
4) nested: I18n = useScope('outer');
I18n.t('something.inside', 'Something inside')
// => outer.something.inside
5) pluralized: I18n.t({
one: 'One banana',
other: 'Many bananas'
})
// => many_many_bananas_ce8e7fb7.one
// => many_many_bananas_ce8e7fb7.other
Change-Id: I7c33fbd2321d7d56994223d65f2572db0ac12ed5
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/293675
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Charley Kline <ckline@instructure.com>
Reviewed-by: Charley Kline <ckline@instructure.com>
Product-Review: Charley Kline <ckline@instructure.com>
fixes FOO-2930
flag = none
this hasn't been used for quite some time and there's no good reason for
the code to stay, also I noticed it was used in test at some point but
again, no more
~ test plan ~
CI is ok
Change-Id: If4c5dab06d1b5a579d4475c5f3f33ab4f34c5c91
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/291699
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Charley Kline <ckline@instructure.com>
QA-Review: Charley Kline <ckline@instructure.com>
Product-Review: Charley Kline <ckline@instructure.com>
refs DE-1070
flag=none
TEST PLAN:
Confirm local jest tests work
Confirm Jenkins builds still work
Change-Id: I7bec13fd8292fb14ea1ea932bf8befd6e6139292
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287958
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Bobby Buten <bobby.buten@instructure.com>
Product-Review: Bobby Buten <bobby.buten@instructure.com>
refs DE-1070
flag=none
TEST PLAN:
Confirm build still runs
Compare build times of pre/post changes
Change-Id: I9364314b8e5f99ea8f29cc69c0f711bf959c8fa3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/286171
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Bobby Buten <bobby.buten@instructure.com>
Product-Review: Bobby Buten <bobby.buten@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
refs FOO-2697
flag = none
those two packages were relying on canvas's babel.config.js but no more
test plan: the build phase of the CI is enough as there were no logical
changes
Change-Id: I7814796f36f1e30b4dd494a12f768f9dbafb4f1f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/286759
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: August Thornton <august@instructure.com>
Product-Review: August Thornton <august@instructure.com>
QA-Review: Ahmad Amireh <ahmad@instructure.com>
refs LS-3017
flag=none
In regards to the BulkEditDateSelect change:
The previously used timezone library was formatting the date to null on
blur which was throwing the error. Switching to the new standard as it
both handles the formatting correctly and is the new preference
test plan:
- tests pass
qa risk: low
Change-Id: I8103cfdf2ccd9bc8ad4f4b58c192c05ae0e34596
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/286329
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
refs FOO-2696
flag = none
jest needs to explicitly load the _core_en translation file since its
i18nTransformer is no longer a thing (and it's what was doing that
before)
otherwise, this just cleans up the remaining references to i18n! in the
code, aside of eslintrc which we'll address in FOO-2738
Change-Id: Ie0a74b46c4d0a48188ba86765b46b2793eed94d7
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/286763
Tested-by: James Butters <jbutters@instructure.com>
Reviewed-by: Charley Kline <ckline@instructure.com>
QA-Review: Charley Kline <ckline@instructure.com>
Product-Review: Charley Kline <ckline@instructure.com>
refs LS-3017
flag=none
Shape is not a valid prop type, but rather a function that returns a
valid prop type. Since no shape was being defined, requiring a simple
object seemed more appropriate.
test plan:
- tests pass
qa risk: low
Change-Id: I10d6743669c3138d6426a455868f5af1c33722fe
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/286330
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
refs LS-3017
flag=none
These warnings were not causing tests to fail for some reason. I wasn't
able to pin the reason down, my suspicion is that fetch-mock uses an
internal logging mechanism.
test plan:
- run `yarn test:jest ui/features/k5_`
- there should be no console output regarding unmatched requests
qa risk: low
Change-Id: I4e8eb876571ca74eb0b2edef6a62640387f15a15
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/286391
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Davis Hyer