Change-Id: I3c1fd74154a52aad96ef7ab85144dcc8dceb414a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/310751
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Jacob Burroughs <jburroughs@instructure.com>
Product-Review: Jacob Burroughs <jburroughs@instructure.com>
Build-Review: Jacob Burroughs <jburroughs@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Test plan:
- See that TypeScript errors are reported in Gergich for prior
failing build
- Tests pass for latest build for this commit
flag=none
Refs DE-1519
Change-Id: I3cd7e8fc43d24932fdd60b296e9015d76d3671ac
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/310278
Reviewed-by: Christopher Soto <christopher.soto@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Build-Review: Jacob Burroughs <jburroughs@instructure.com>
Test plan:
- Run `yarn run check:ts` and see that it fails on new TypeScript errors
Future improvement needed:
- Improve Gergich to parse TypeScript errors
Closes DE-1519
flag=none
Change-Id: I16a498794839753c0f6494f413480df954c55ad8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/310200
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
closes AE-30
flag=none
test plan:
- verify Canvas boots in CD
- verify no influx of new errors in CD
[fsc-timeout=30]
Change-Id: Ifa04bebe1b09f01c6d3b8b2d8f3bb424759730f5
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/308067
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Isaac Moore <isaac.moore@instructure.com>
Product-Review: Isaac Moore <isaac.moore@instructure.com>
Build-Review: James Butters <jbutters@instructure.com>
Clean up some of the messy output caused by not mounting all the source
flag=none
test plan - none
Change-Id: Id41b12ea7ec860af66151ead333d621280bf595f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/306986
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jake Oeding <jake.oeding@instructure.com>
QA-Review: Jake Oeding <jake.oeding@instructure.com>
Product-Review: Jon Scheiding <jon.scheiding@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
closes: DE-1483
Test Plan:
- new image starlord.inscloudgate.net/jenkins/selenium-node-chrome:107.0
- Jenkins build uses chrome 107
- No failures in Jenkins
Change-Id: I31f453d34dcfcbc71c88b3bc379380bbd17ef133
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/306441
QA-Review: James Butters <jbutters@instructure.com>
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
Build-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Ryan Norton <rnorton@instructure.com>
-----------------------------------------------------------------------
This PS reimplements "wait_for_ajax_requests" and "wait_for_animations"
The changes mitigate some corner case failure scenarios and removes
the dependency of these methods on the in-browser events. The new
implementation relies on iterative polling of the browser for state
changes.
Method "wait_for_animations" is now waiting for all JQuery animations
to complete and rises exception if not all are done.
The poll-waiting iteration controll and timeout choice is delegated
to a new module CustomWaitMethods::Poller. The logic recognizes
when a test is being re-run and increases the timeout. This allows
failures due to overloaded environment to pass during the rerun.
This also enables tests, which caught degraded performance to still
complete their functionality validation role on the rerun.
Framework method "move_mouse_to_known_position" was disabled as it
was found to cause long running JQuery animations, resulting in
test stability issues.
Test results summary page was updated to highlight the tests falied
due to timeouts waiting for AJAX requests or IQuery animation.
(see build/new-jenkins/library/vars/rspecStage.groovy)
fixes DE-1442
flag=none
test plan:
- Trigger multiple Jenkins test runs and check for method failures
Change-Id: I456dfcb5e290e6f53b1cafb217726aa4ff47d83d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/304610
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
QA-Review: Danail Kozhuharov <danail.kozhuharov@instructure.com>
Product-Review: Danail Kozhuharov <danail.kozhuharov@instructure.com>
Change-Id: Ie45881293f278e57b8c54e6c780408e863020df3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/305048
QA-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
Product-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Reviewed-by: Bobby Buten <bobby.buten@instructure.com>
Build-Review: Bobby Buten <bobby.buten@instructure.com>
[build-registry-path=jenkins/canvas-lms/de-1217]
[change-merged]
refs DE-1217
flag=none
TEST PLAN:
- run post-merge build test
- confirm webpack size is properly run and recorded
Change-Id: I2e84dbd5509276a3ec817d916c56c15e6fb9ef50
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/304585
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
Build-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
QA-Review: Bobby Buten <bobby.buten@instructure.com>
Product-Review: Bobby Buten <bobby.buten@instructure.com>
Address "detected dubious ownership" error message
test plan
- `export SSH_KEY_FILE=./nonexistent`
- Run the script
`build/new-jenkins/package-translations/sync-translations.sh`
- Verify that the value of `$?` is zero
Change-Id: Icd9c3e25b39549103d92127721b7983f32fa7fb2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/303138
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Joe Hernandez <joe.hernandez@instructure.com>
Product-Review: Jon Scheiding <jon.scheiding@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
Includes:
- Take `git status` command out of condition so failure is detected
- Guards in the `sync-strings.sh` script so it can run locally
- Dockerfile change for better cache usage when iterating locally
test plan
- `export SSH_KEY_FILE=./nonexistent`
- Run the script
`build/new-jenkins/package-translations/sync-translations.sh`
- Verify that the value of `$?` is non-zero
Alternatively, observe the differences between these two builds
- https://jenkins.inst-ci.net/job/Canvas/job/package-translations/1166/
run against the master branch
- https://jenkins.inst-ci.net/job/Canvas/job/package-translations/1167/
run against this PS
Change-Id: Ifa74770f2ff1ac7526577587abfc1e5a128fbde0
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/303133
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
QA-Review: Joe Hernandez <joe.hernandez@instructure.com>
Product-Review: Jon Scheiding <jon.scheiding@instructure.com>
refs DE-1379
Test Plan
1. JS Impact Analysis works
2. Tarball hashes are reproducible crossbuild
[build-registry-path=jenkins/canvas-lms/de-1379-3]
[change-merged]
Change-Id: I69631a80dd2cbdc03467b1ae690c0eeeaeda555c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/301748
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Bobby Buten <bobby.buten@instructure.com>
Build-Review: Bobby Buten <bobby.buten@instructure.com>
QA-Review: Aaron Ogata <aogata@instructure.com>
Product-Review: Aaron Ogata <aogata@instructure.com>
Rover was originally added as a devDependency so that Apollo Studio
schema checks could be performed. However, Rover does not build under
linux/arm64, so developers with newer M1 Macs were unable to get Canvas
running. Instead, the schema checks will be run inside of a separate
rover specific container, removing the dependency.
[canvas-builds-refspec=1b94202e657e6899de6629afd85b628a1e27b66c]
[force-graphql-schema-check]
closes INTEROP-7174
flag=none
test-plan:
- the simulated post-merge build succeeds
- M1 users can run yarn install without issue
- devx is happy :P
Change-Id: I92f8862b580b4300b14ee98bc9e9826c8d649e96
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/298396
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
QA-Review: Xander Moffatt <xmoffatt@instructure.com>
Product-Review: Ryan Hawkins <ryan.hawkins@instructure.com>
why:
- Schema checks ensure that any change to the Canvas GraphQL Schema
don't impact existing queries as well as ensuring we don't break
supergraph composition.
- We're starting with a post-merge build to see how common of an issue
this is for now. We'll move it into the deploy and pre-merge steps
once we're sure we like it.
flag=none
[canvas-builds-refspec=0e2b75ca09d79fe85fdb749b9288dabbbfc86012]
[change-merged]
[build-registry-path=jenkins/canvas-lms/interop-7174]
closes INTEROP-7174
test-plan:
- the simulated post-merge build reports to the appropriate Slack
channel and we *don't* get a message about a schema check failure.
- we'll get eyes from devx and our SET to make sure everything looks
A-OK.
Change-Id: Ibdb55c1f50d0ab71d809bb06a5f0d01a5b7fbc02
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/296771
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
QA-Review: Ryan Hawkins <ryan.hawkins@instructure.com>
Product-Review: Ryan Hawkins <ryan.hawkins@instructure.com>
Creates a generic Slack failure for Jenkins. This is useful for newer
processes that need to customize where an error message might be sent
and whether or not the author of the failing patchset should be alerted.
refs INTEROP-7174
flag=none
test-plan:
- The current alerting methodology still works
Change-Id: I952548c2c3954028f63c2bfc9a23a8c4a3efd40b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/296974
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
QA-Review: Ryan Hawkins <ryan.hawkins@instructure.com>
Product-Review: Ryan Hawkins <ryan.hawkins@instructure.com>
Jacob Burroughs