send_keys has an issue that sometimes it won't send
the full string before the next line of code is executed
resulting in a new folder with wrong name. It's recommended
to add a click to the input before send_keys.
flag = none
Change-Id: Ib2659a418d29ef85fd0fcadd91037e5f309e94a0
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/230876
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Powell <spowell@instructure.com>
Reviewed-by: Derek Bender <djbender@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
use the accept_alert method rather than custom accept alert. Add
wait for delete option to be visible before trying to click.
flag = none
Test Plan:
jenkins passes specifically FSC build
Change-Id: Id697279b467a9e416d2f8c93bd269e469948c870
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/230925
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Powell <spowell@instructure.com>
Reviewed-by: Derek Bender <djbender@instructure.com>
QA-Review: Jacob Powell <spowell@instructure.com>
Product-Review: Jacob Powell <spowell@instructure.com>
added wait_for_ajaximations after entering section name for
the search to complete before attempting click, bettered the
selector for the override option to click.
flag = none
Test Plan:
jenskins passes specifically the FSC build
Change-Id: I13216fa8c01e39ec5b55d5e81ed3be3fa9759591
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/230924
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Powell <spowell@instructure.com>
Reviewed-by: Derek Bender <djbender@instructure.com>
QA-Review: Jacob Powell <spowell@instructure.com>
Product-Review: Jacob Powell <spowell@instructure.com>
wait for elements to be displayed before attempting interaction.
use accept_alert method.
flag = none
Test Plan:
jenkins passes
Change-Id: I21eba7fb7b3b2f18faef8808c3cf2b3ae29e54a3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/230927
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Powell <spowell@instructure.com>
Reviewed-by: Derek Bender <djbender@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
expecting user to be the first in enrollments leads
to flakey results. Instead check for the user to be
included in the enrollments, no requirement for this
user to be the first.
flag = none
Test Plan:
passes jenkins specifically FSC build
Change-Id: Ia067daf8bb8d8ad2dec751743b1e87505887ef6e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/230918
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
flag=none
closes UXS-8
Adds new content (copy and links to Canvas Guides), as well as
updated images for each of the existing new user tutorial trays.
Test Plan:
Verify that the trays work as follows:
- All links should correctly resolve to the Canvas Guides page
they name
- All trays should feature a Panda image
- All tray should open and close, and should be able to be
dismissed permanently (no regressions from existing functionality)
Check the following index pages for trays: Announcements, Assignments,
Collaborations, Conferences, Discussions, Grades, Course Home Page,
Course Import page (under Settings), Modules, Pages, People, Quizzes,
Settings, Syllabus. There is a tray for Files, but it seems to be removed
from the Files index page on page load (not a result of this commit).
Change-Id: I873fdf9ceb6097d987f3e7da38e5fd615c1d98ea
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/230372
QA-Review: David Tan <dtan@instructure.com>
Reviewed-by: Pam Hiett <phiett@instructure.com>
Product-Review: Pam Hiett <phiett@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Fixes DIG-1726
Test plan:
- Launch a DocViewer session
- assignment_name should be sent
Change-Id: I1995ba90e6b3973cf8cb43d94abb36fadb7df747
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/230729
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Daniel Nehring <dnehring@instructure.com>
Reviewed-by: Robert Hanna <rhanna@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Matt Meservey
test plan:
* the "Assignment Allowed Attempts" flag should
be able to be configured on a course level
flag=assignment_attempts
closes #UXS-48
Change-Id: Icf467667b5a4205edf4a3f4addd3de53632f00c4
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/230693
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Clint Furse <cfurse@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
refs #UXS-4
Change-Id: If0a1010d7351bd5d6b3134342597bbafd318551a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/230663
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
This chunks out roughly 32 KB of JavaScript.
closes TALLY-746
flag = none
test plan:
* Visit Gradebook
* Click the "Grade Posting Policy" action for an assignment
* Verify the "Grade Posting Policy" tray appears
* Verify settings can be changed
* Verify assignment options menu button receives focus
when tray closes
Change-Id: Id061cdbf5ffde365fe5735d89836a9f7e245169b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/230584
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Keith Garner <kgarner@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Spencer Olson <solson@instructure.com>
This chunks out roughly 140 KB of JavaScript.
closes TALLY-744
flag = none
test plan:
* Visit Gradebook
* Click the "Post Grades" action for an assignment
* Verify the "Post Grades" tray appears
* Verify posting grades works
* Verify assignment options menu button receives focus
when tray closes
Change-Id: Id0bb96ab81270c3697b591dcdb3b942b6c1db8fd
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/230576
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Adrian Packel <apackel@instructure.com>
Reviewed-by: Keith Garner <kgarner@instructure.com>
QA-Review: Spencer Olson <solson@instructure.com>
Product-Review: Spencer Olson <solson@instructure.com>
This chunks out roughly 50 KB of JavaScript.
closes TALLY-740
flag = none
test plan:
* Visit Gradebook
* Click the "Set Default Grade" action for an assignment
* Verify the "Set Default Grade" dialog appears
* Verify setting default grades works
* Verify the assignment options menu button receives focus
when the dialog closes
Change-Id: I9236498ef1c2450dcab6d74a4525a00238cf1928
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/230553
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Adrian Packel <apackel@instructure.com>
Reviewed-by: Keith Garner <kgarner@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Spencer Olson <solson@instructure.com>
This chunks out roughly 50 KB of JavaScript.
closes TALLY-747
flag = none
test plan:
* Visit Gradebook
* Click the "Message Students Who" action for an assignment
* Verify the "Message Students Who" dialog appears
* Verify messaging students "succeeds"
* just as a Gradebook step. No need to check messages.
* Verify assignment options menu button receives focus
when dialog closes
Change-Id: I487d18ad9edf4569b77b2510eca2efb0fb0950b1
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/230548
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Adrian Packel <apackel@instructure.com>
Reviewed-by: Keith Garner <kgarner@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Spencer Olson <solson@instructure.com>
This chunks out about 50 KB of JavaScript.
closes TALLY-743
flag = none
test plan:
* Visit Gradebook
* Click the "Curve Grades" option for an assignment
* Verify the Curve Grades dialog is displayed
Change-Id: I7a21e6452ba0d64853356cb3bf0cda682ec81a35
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/230514
Reviewed-by: Adrian Packel <apackel@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Spencer Olson <solson@instructure.com>
closes TALLY-756
flag = none
QA Notes:
* Learning Mastery is Outcomes stuff
* Gradebook is the Assignments stuff
test plan:
A. Setup
1. Create a course
2. Enable the outcome_gradebook feature flag
3. Create content for Outcomes
4. Create content for Gradebook (i.e. assignments)
B. UI Verification
1. Visit Gradebook
2. Verify the "Assignments view" is displayed
3. Select Learning Mastery from the Gradebook Selector
4. Verify Learning Mastery loads
5. Refresh the page
6. Verify Learning Mastery loads
7. Select Gradebook from the Gradebook Selector
8. Verify Gradebook loads
9. Refresh the page
10. Verify Gradebook loads
C. Verification
1. Visit Gradebook
2. Ensure Gradebook is the current view
3. Visit `/gradebook?view=learning_mastery`
4. Verify Learning Mastery loads
5. Verify `?view=learning_mastery` is not in the url
6. Refresh the page
7. Verify Learning Mastery loads
8. Visit `/gradebook?view=gradebook`
9. Verify Gradebook loads
10. Verify `?view=gradebook` is not in the url
11. Refresh the page
12. Verify Gradebook loads
D. Smoke test Learning Mastery
Change-Id: I1fa79a7e4e53f3ffb54f325658a6f5c0962782f0
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/230296
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Frank Murphy <fmurphy@instructure.com>
Reviewed-by: Keith Garner <kgarner@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Jonathan Fenton <jfenton@instructure.com>
Closes USERS-433
Refs USERS-438
Refs UXS-30
flag=mobile_qr_login
Adds an entry to the left nav "Profile" tray that allows a user to pull
up a modal that displays QR code to scan on their phone to log into the
mobile app.
Test Plan:
- Ensure your version of canvas has an up to date
instructure_misc_plugin
- create a developer key
- add https://sso.canvaslms.com/canvas/login as its only redirect URI
- In a rails console
- a = Account.default
- a.settings[:ios_mobile_sso_developer_key_id] = <dev key global id>
- a.save!
- a.account_domains.create!(name: 'sso.canvaslms.com')
- In canvas, ensure the QR for Mobile Login release flag is on
- Open the profile tray and click "QR for Mobile Login"
- Ensure the modal dialog shows the QR code
- Ensure the modal dialog can then be dismissed
Change-Id: I92b3c4869530207b9274e9e207828be8de111672
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/230318
Reviewed-by: Spencer Olson <solson@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: Pat Renner <prenner@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Kevin Dougherty <jdougherty@instructure.com>
closes TALLY-741
flag = none
test plan:
* Verify Gradebook Settings Modal works
Change-Id: Idf6b70a6272d2dc3ab32df627fc9c95615afbba9
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/230172
Product-Review: Keith Garner <kgarner@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Adrian Packel <apackel@instructure.com>
Reviewed-by: Gary Mei <gmei@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
test plan:
* the blueprint associations modal should have a
"Publish upon association" checkbox when adding a course
that will publish the course after the sync completes
closes #UXS-4
Change-Id: Icfaab5723edee843aaafde7af8332645f54d037f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/230438
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Jody Sailor
closes APM-11
flag = none
TEST PLAN:
* deploy to some environment with APM enabled
* observe telemetry and confirm root_account
and shard tags
Change-Id: I7246801c51617f10b8b7f3ca69b5d245375e81be
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/230415
Reviewed-by: Simon Williams <simon@instructure.com>
Reviewed-by: David Warkentin <dwarkentin@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
closes TALLY-739
flag = none
test plan:
* Verify Grade Detail Tray loads in Gradebook
(specs would fail if it did not)
Change-Id: I51954c004ad05b50b59faa645be6390069b2fac2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/230167
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
Reviewed-by: Adrian Packel <apackel@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Spencer Olson <solson@instructure.com>
- also updates help text to reference "local admin"
closes C19CONF-59
flag=none
Test plan:
- enable conferences by adding plugin settings at
/plugins/big_blue_button
- verify that course/group conference pages
appear normal
- in the console, set course setting:
> course.settings[:show_conference_alternatives] = true
> course.save!
- verify that course/group conference pages
show the alternatives view
Change-Id: Ic2db21277d46a18ee391b565f8be16ababdd8a25
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/230349
Reviewed-by: Augusto Callejas <acallejas@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Pat Renner <prenner@instructure.com>
Product-Review: Michael Brewer-Davis <mbd@instructure.com>
closes C19CONF-36
flag=none
Test plan:
- adjust the "is free trial" and "disable BBB" settings
at /plugins/big_blue_button
- replace with alternatives off
- free trial off
- can create: should not see warning
- can't create: should not see warning
- free trial on
- can create: should see warning
- can't create: should not see warning
- replace with alternatives on
- free trial on/off
- can create: should see alternatives and concluded
conferences
- can't create: should just see concluded conferences
- verify that alternatives content is accessible and links
connect to proper locations
Change-Id: I12993fa4d68b97cf73946a76aeabaee22a2c6dc4
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/230191
Reviewed-by: Mysti Lilla <mysti@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Pat Renner <prenner@instructure.com>
Product-Review: Michael Brewer-Davis <mbd@instructure.com>
refs C19CONF-36
flag=none
- specifies "Replace with alternatives" and "Is free trial" for
BBB, so we can show different content based on those settings
in the ensuing PS
Test plan:
- verify plugin settings are saved and returned
correctly
- verify plugin settings inherit correctly
Change-Id: I577804d53737e163272f023003169b25ad8d65bf
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/230076
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Pat Renner <prenner@instructure.com>
Reviewed-by: Augusto Callejas <acallejas@instructure.com>
Product-Review: Michael Brewer-Davis <mbd@instructure.com>
Test Plan: Run correctly through performance Jenkins and doesn't break
canvas.
Change-Id: Ia5714843b7f5101e6cea36b6de1bd8b7e0d17615
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/230233
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Gary Mei <gmei@instructure.com>
Reviewed-by: Adrian Packel <apackel@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Robin Kuss <rkuss@instructure.com>
Refs DIG-1726
After merging https://gerrit.instructure.com/c/canvas-lms/+/230155
we discovered that there are plans to allow students to view old
submissions (in Canvas). To prepare for this, we're going to need
submission_id as well.
Test plan:
- Launch a DocViewer session from Canvas
- submission_id should be sent to DocViewer
Change-Id: I9442b51a13f92aafa613fe83bffc59000b967c50
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/230247
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Robert Hanna <rhanna@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
closes APM-7, APM-8
flag = none
hardcode set to a very low % of client sampling by default
to keep performance impact low.
test plan:
* make sure telemetry is arriving in datadog APM
* ensure trace traffic level is low, only from one cluster
(proves settings are working)
* canvas should not show degradation in response times post deployment
Change-Id: Ifca8d3f6239d6c4e70098dd2b68b9c2a1950e121
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/230064
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
closes LA-823
flag=assignment_bulk_edit
test plan:
- Only with the feature flag on, as a teacher, the root level kabob menu
on the assignment index page should contain a new "Bulk Edit" option.
- Clicking on the bulk edit option should replace the index page with
a blank bulk edit mode page
- When the assignments index page is set to the course home page, the
Bulk Edit option is not shown on the course home page.
- Students still don't see the kabob menu and no bulk edit option
Change-Id: If478de2847d31ddc2cdfea0851b904422d5d4832
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/229980
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Jon Willesen <jonw+gerrit@instructure.com>
Refs DIG-1726
Also remove the stuff from the DocViewer data migration since that's
over and done with.
This doesn't add anything to the DocViewer doc creation call. Nothing
additional is needed there.
Test plan:
- Launch a DocViewer session from Canvas
- The following params should be sent to DocViewer
- canvas_base_url
- user_id
- submission_user_id
- course_id
- assignment_id
- post_manually
- posted_at
Change-Id: I5df3291f52df108c9b2b30823d7bbf0033c24b5d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/230155
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Alex Anderson <raanderson@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
closes TALLY-721
flag=none
test plan:
* Ensure the Big Blue Button plugin is configured
* Visit the conferences page
* Verify there is an alert about Big Blue Button
* Verify the link goes to the expected page
Change-Id: I6a1efbc8fd643902085c2be438cd39f8ca362f06
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/229995
Reviewed-by: Spencer Olson <solson@instructure.com>
QA-Review: Spencer Olson <solson@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Keith Garner <kgarner@instructure.com>
Closes QUIZ-7286
Flag=newquizzes_on_quiz_page
Test plan:
In Canvas with newquizzes_on_quiz_page flag enabled:
Initial selection tests:
1. As a teacher/admin, navigate to the Quizzes view
2. Click [+Quiz]. The quiz engine selection modal should appear.
3. Sielect either engine without checking the
'Remember my choice' checkbox.You should be redirected to
the corresponding quiz build page.
4. Return to Quizzes view, click [+Quiz] again and select either engine.
Check the 'Remember my choice' checkbox. Click 'Submit'. You
should be redirected to the selected engine.
5. Return to Quizzes view, click [+Quiz] again. This time, no modal
should open. Instead, you should automatically be redirected to your
previously selected quiz engine.
Reset selection tests:
1. As a teacher/admin, navigate to the Quizzes view
2. Click the kabob menu [...] next to the [+Quiz] button
3. Click 'Reset quiz engine choice'. A success/failure message
should appear at the top of the Quizzes view.
4. Click the [+Quiz] button. The selection modal should appear.
In Canvas with newquizzes_on_quiz_page flag disabled:
1. There should be no option to select/reset a quiz engine anywhere
Change-Id: I4370d1463745839b949d0d153ab3bed84884d2de
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/224587
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Stephen Kacsmark <skacsmark@instructure.com>
QA-Review: Alex Slaughter <aslaughter@instructure.com>
Product-Review: Kevin Dougherty <jdougherty@instructure.com>
Follow up to: 3a1fa0e567
Refs: QUIZ-7495
Current Behavior:
If the assignment was launched from homepage, the quizzes return button
would lead back to the modules page.
Expected Behavior:
If the assignment was launched from homepage, the quizzes return button
should return to the course homepage.
Test plan:
- create a course
- create quizzes.next assignment
- navigate to homepage
- create a module and add the quizzes.next assignment
- click on the assignment from the homepage
- Check network utils that "http://quiz-lti.docker/lti/launch" has a POST
request with the following launch param in the body
"launch_presentation_return_url: http://canvas.docker/courses/1"
flag = none
Change-Id: Ic651ecd2bcbac77375da6c61d39239e20862abee
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/229650
Reviewed-by: Bryan Petty <bpetty@instructure.com>
Reviewed-by: Laura Gonzalez-Horwitz <lgonzalez-horwitz@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Kevin Dougherty <jdougherty@instructure.com>
QA-Review: David Tan <dtan@instructure.com>
refs ARC-6467, ARC-4600
These cases appear to have been missed when working on the
original ARC-4600 fix.
Change-Id: Ibb2e5724d08e9becc0cdecaf868f9681e7ecd3a0
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/229631
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
Reviewed-by: Jeremy Neander <jneander@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Jeffrey Johnson <jeffrey.johnson@instructure.com>
We are restricting the types of notifcations that will be delivered via
SMS to the types listed in the the change.
Test Plan:
- Have a student with an SMS communication channel confirmed and set to
ASAP on all notification types
- Trigger an Announcement notification
- Verify that the message was queued to be sent (/users/<id>/messages)
- Trigger a non-allowed notifcation type (such as Conversation Message)
- Verify that the message was not set to be delivered
closes KNO-274
flag=deprecate_sms
Change-Id: Ic82ac60294807d0659dd207c1b24f4ffa0b00a58
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/228755
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
flag=none
test plan
- spec should pass
Change-Id: I4f7839410ed6f3878c6dc71ff74eb510d20b8142
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/229513
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ben Nelson <bnelson@instructure.com>
QA-Review: Ben Nelson <bnelson@instructure.com>
Product-Review: Ben Nelson <bnelson@instructure.com>
James Butters