we may eventually want to support querying by subaccount, but for now we
want to fix an error where the user got a template error instead of
a 404.
fixes CNVS-26628
test plan:
- create a course in a subaccount
- create an enrollment and note the id
- query /api/v1/accounts/:sub_account_id/enrollments/:id
- you should get a 404
Change-Id: I3c453d32152df6339df020d38025338cd4981039
Reviewed-on: https://gerrit.instructure.com/70635
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
Fixes: CNVS-26218
test plan:
- as a teacher/admin using the old or new ui
- navigate to a course
- click on the grades link from the left-hand sub-nav
(note: enable grid view for this ticket)
- now switch to tabbing... first tab should trigger the
"skip to content" link - hit enter the warning should
appear (was red as seen here...
http://screencast.com/t/QKX94TqKGt
should now be blue as seen here...
http://screencast.com/t/TfF4dFPYum6o
Change-Id: I5384a06d17b5e3966f4baffbce5900862f73d00d
Reviewed-on: https://gerrit.instructure.com/70696
Tested-by: Jenkins
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
Fixes: CNVS-26600
Most jqueryUI plugins we still use (datepicker,
modal, tooltip, tabs) use ems for font-sizing.
However, there were a few cases where we've
overwritten those original font sizes with pixel
values. This commit turns those pixels into rems
for accessibility reasons.
Test plan:
- Make sure the CSS compiles as usual.
- Go to Chrome's preferences, and (under
Advanced) change Chrome's default font
size to Very Large
- Open any page with a datepicker on it (the add
assignment page has plenty)
- Note that the datepicker now scales up its font-sizing
to respect the browser preferences:
http://screencast.com/t/WXeA18kjkel
- Return your Chrome font-size preferences to
Medium.
- Click around a variety of Canvas pages. You should
see no difference from production.
Change-Id: I5091fc16902f31860c33c810187aeb2fe1e7234d
Reviewed-on: https://gerrit.instructure.com/70650
Tested-by: Jenkins
Reviewed-by: Pam Hiett <phiett@instructure.com>
Product-Review: Pam Hiett <phiett@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
Fixes: CNVS-26576
Test plan:
Bootstrap isn't used for much in Canvas anymore,
BUT one really important remaining use is as
the foundation for our forms:
- Go to /styleguide#forms in Chrome. Note the
appearance of text inputs, selects, and
textareas, etc.
- Go to Chrome's preferences, and (under
Advanced) change Chrome's default font
size to Very Large
- Go back to /styleguide#forms, and note
that the form components' font sizes should
now be scaling up, respecting the browser
settings. Here is a comparison of this commit
vs. production:
http://screencast.com/t/mz7AnOP1RA
- Return your Chrome font-size preferences to
Medium.
- Click around a variety of Canvas pages. You should
see no difference from production.
Change-Id: I0218e59bf5d8d4ba4ba5c5e8f4cec5d53e6c61c6
Reviewed-on: https://gerrit.instructure.com/70600
Tested-by: Jenkins
Reviewed-by: Pam Hiett <phiett@instructure.com>
Product-Review: Pam Hiett <phiett@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
test plan:
* using the API, try to create a Facebook auth provider multiple times
* it should only succeed once
Change-Id: Ib3bfff9a5cd933bca00304d3cecf19abeb653677
Reviewed-on: https://gerrit.instructure.com/63265
Reviewed-by: Rob Orton <rob@instructure.com>
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
closes CNVS-26089
Test plan:
* in a rails console, call
DataFixup::CreateCanvadocsSubmissionsRecords.run
a few times
* run migrations
* there should be no duplicate entries in canvadocs_submissions
* you should not be able to create duplicate entries in
canvadocs_submissions
Change-Id: I38cd3c990c13434d5daa016f3b4d192bdc877e16
Reviewed-on: https://gerrit.instructure.com/69327
Tested-by: Jenkins
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Cameron Matheson <cameron@instructure.com>
fixes PLAT-1300
test plan
install a tool that uses and underscore in the domain or subdomain
try and launch the tool
it shouldn't throw a canvas error
Change-Id: I91164574be94e7e10d5e9820d0ecef48a5503005
Reviewed-on: https://gerrit.instructure.com/70044
Reviewed-by: Brad Horrocks <bhorrocks@instructure.com>
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
Product-Review: Nathan Mills <nathanm@instructure.com>
fixes CNVS-22672
test plan:
* have both canvas and non canvas auth configured on an account
* add a pseudonym not linked to an auth config
* you should still be able to change the password both as an admin
and on the /profile/settings page
* add an SIS id to the login
* you should be able to change the password as an admin, but not on
the /profile/settings page
* create a login explicitly linked to the non canvas auth
* you should not be able to change that password on either page
* create a login explicitly linked to canvas auth, with an SIS ID
* you should be able to change the password on either page
Change-Id: I68ee27d36dc5eb20ca81a145dd097f3f8f37b155
Reviewed-on: https://gerrit.instructure.com/63817
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Tested-by: Jenkins
Product-Review: Cody Cutrer <cody@instructure.com>
refs CNVS-26515
Some tweaks from UX to bring the docs more in line with the rest of
Canvas, and better call out important information.
test plan: generate and view the api docs
Change-Id: Ibf1d56f1dcdd663d993efca8f48513136baa009b
Reviewed-on: https://gerrit.instructure.com/70648
Reviewed-by: Rob Orton <rob@instructure.com>
Tested-by: Jenkins
Product-Review: Brian Palmer <brianp@instructure.com>
QA-Review: Brian Palmer <brianp@instructure.com>
refs CNVS-26515
Request params are now formatted in an HTML table, with separate fields
for name, type, required/optional, valid enum values, and description.
This is at the same time more compact and more readable.
To parse this information out of what is actually free-form text
comments, I'm re-using the OpenAPI (swagger) parsing code, which I
tweaked and simplified slightly. Eventually I'd like to see the whole
API documentation generated from the OpenAPI spec, and then we can
slowly move away from using free-form code comments to more declarative
code constructs, but still generate an OpenAPI spec and get the same API
docs.
test plan: Generate the api documentation, and view request parameter
information. you should see the new formatting.
Change-Id: Ida00869d96a9b2d9fa84c29079ddf2511a2d5917
Reviewed-on: https://gerrit.instructure.com/70485
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins
Product-Review: Brian Palmer <brianp@instructure.com>
QA-Review: Brian Palmer <brianp@instructure.com>
In new UI, load custom CSS / JS even for users
that have High Contrast turned on.
closes: CNVS-22656
Originally, we tried to just say that to ensure schools
could not mess up their own high contrast compliance,
we would not load custom css or js for high contrast
users in NewUI.
This was problematic for things like the school using
js to add a custom help menu or something that the rest
of their classmates would see but the high contrast
user would not see. or using some "display: none"s in
css to hide things that they didn't want people to see,
but the high contrast users would still see.
This change makes it so custom css and js overrides
are loaded for high contrast users too. that means that
there is a possibility that the school could mess up
high contrast ratios with their css but I think given
the problems above this is the best we can do.
Product reviewers: (colleen, dana, aaron) please
review this description and + or - 1 if you agree.
test plan:
* turn on high contrast in New UI
* any custom css/js file you have set for your account
(or any of your account's parents) should be loaded
Change-Id: I72ed06688f0b7b131ec00c2ea6031597277e7445
Reviewed-on: https://gerrit.instructure.com/69941
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Dana Danger <dana@instructure.com>
fixes CNVS-26484
test plan:
- set up a saml idp
- sign logout requests with an invalid issuer (idp_entity_id)
- you should get a 400 response.
Change-Id: I45b912f41c15777d82fa09aed3e067fd2f47155c
Reviewed-on: https://gerrit.instructure.com/70295
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
This will allow us to use React (with JSX) inside of gems/plugins
such as analytics. It also allows us to use ES2015 features because
it's compiled using Babel.
closes CNVS-26632
Test Plan:
- Make sure JSX compiles as normal
- Add a plugin (such as analytics)
- Inside that create a jsx file in the 'jsx' directory within
i.e. gems/plugins/analytics/app/jsx
- Run rake js:jsx or rake js:generate
- Check that public/javascripts/plugins/<plugin_name>/compiled/jsx
contains the contained file.
Change-Id: Ic847e24ff9d7b88747adfb7add3b47b66a27c614
Reviewed-on: https://gerrit.instructure.com/70642
Tested-by: Jenkins
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>
QA-Review: Dan Minkevitch <dan@instructure.com>
refs CNVS-25916
the click_option calls use "fj" which doesn't wait for load time,
and so they often fire before the right stuff has loaded. Add
checks to make sure the page is loaded before proceeding to interact
with it.
TEST PLAN:
1) discussions/discussions_edit_page_spec pass rate should increase
Change-Id: I4cd6cfc9cae650394fc5c93f098a63ef67ee03a5
Reviewed-on: https://gerrit.instructure.com/70657
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
QA-Review: Ethan Vizitei <evizitei@instructure.com>
refs CNVS-25916
this line fails a lot because the calendar hasn't quite loaded yet.
Make sure the calendar is present and visible before continuing
the spec.
TEST PLAN:
1) calendar2_event_create_spec pass rate should increase
Change-Id: Iab573163a296357f3dfa0e8e70f789b11010402b
Reviewed-on: https://gerrit.instructure.com/70662
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins
Product-Review: Ethan Vizitei <evizitei@instructure.com>
QA-Review: Ethan Vizitei <evizitei@instructure.com>
Previously, speedgrader would omit comments from the submitting student
for group assignments when the submitter unchecked "Send Comment to the
Whole Group"
This will look across all submissions within group and collect all unique
comments for display.
fixes: CNVS-20346
Test Plan:
- create and publish a course with at least 2 students
- add the students to a group
- create a group assignment and publish it
- as the first student, submit and leave a comment, do not check
the box that says "Send Comment to the Whole Group"
- go to the submission and leave another comment without checking the box
- masquerade as the non-submitting student and repeat the above step
- stop masquerading and go to speedgrader
- both comments should be present
- this should be the same as the submission details page and in gradebook
Change-Id: I9955804202f4381d8afc0fbe3e5dc23b3ca94747
Reviewed-on: https://gerrit.instructure.com/69547
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
Tested-by: Jenkins
QA-Review: KC Naegle <knaegle@instructure.com>
Product-Review: Christi Wruck
This got merged in at the same time as my change that adds an error if
you specify an invalid type.
Change-Id: Iec37f2dc967d38752eb643dbdbbf5584e0ba08fb
Reviewed-on: https://gerrit.instructure.com/70688
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Brian Palmer <brianp@instructure.com>
QA-Review: Brian Palmer <brianp@instructure.com>
Tested-by: Brian Palmer <brianp@instructure.com>
refs CNVS-26515
Pretty much anything that wasn't a number was being rendered as a
string, including sub-arrays and sub-objects. Worse, a lot of our api
docs were defining them using ruby syntax rather than json syntax.
This change fixes types so that booleans, arrays, and objects all render
correctly in the @model docs (the "A ModuleItem object looks like:"
sections of the docs). It also adds some basic error checking to help
avoid future mistakes.
This doesn't fully support the "$ref" OpenAPI (swagger) syntax yet, but
still renders examples for "$ref" fields when an example is provided.
Eventually it'd be nice to auto-generate an example for "$ref" fields,
since we can look at the linked documentation and just embed it.
test plan: generate the api documentation and look through the @model
definitions at the top of each Resources page. the new rendering should
show more accurate type information.
Change-Id: Id5af514cd235e66af2ce868bce95eb49d71062ab
Reviewed-on: https://gerrit.instructure.com/70484
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Brian Palmer <brianp@instructure.com>
QA-Review: Brian Palmer <brianp@instructure.com>
refs CNVS-26515
Renders the @model definitions as json, and improves the json
formatting. Also renders all json as the prettify "js" type internally,
because we put a lot of code comments in our json which isn't strictly json
anymore, and so doesn't render correctly as json.
test plan: compile the api docs and look at some @model blocks ("A File
object looks like", e.g. in the Files API) to verify the new formatting.
Change-Id: Icac9ad04bb42af80da66bc5ad0b5adead70ec168
Reviewed-on: https://gerrit.instructure.com/70483
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Brian Palmer <brianp@instructure.com>
QA-Review: Brian Palmer <brianp@instructure.com>
crocodoc/canvadoc annotations have some issues in firefox
so we display a warning for those using firefox. Previously
we were only checking for Canvadoc annotations settings,
but adding further check for crocodocable document so
that the warning shows up anytime a document is
annotatable via crocodoc since Canvadocs are not
available to everyon yet.
fixes CNVS-23286
Test Plan:
1. In /plugins/crocodoc, enable crocodoc
2. In /plugins/canvadocs, enable both canvadocs and annotations
3. Create an assignment that accepts file uploads
4. Create a submission with a pdf
5. Open speedgrader for this assignment in FF
Verify: You see a green flash message at the top that says,
"Warning: Crocodoc has limitations when used in Firefox.
Comments will not always be saved."
6. Do the same thing in Chrome
Verify: You don't see a flash warning about FF
7. Also repeat steps above except with an assignment that accepts
url submissions only.
Verify: In FF, that you don't see a flash warning about FF and
annotations since url submissions are not previewable with
crocodoc.
8. Disable Canvadoc annotations (remove checkbox and apply in plugins)
9. Repeat step 5 and verify warning still shows up in FF
10. Create an assignment that has turnitin enabled
11. Submit to the assignment with text entry (make sure text is long)
12. Repeat step 6 and verify warning still shows up in FF
Change-Id: I7fef65bf78117bbd983f89f5774b792e8c68aa9c
Reviewed-on: https://gerrit.instructure.com/68846
Tested-by: Jenkins
Reviewed-by: Derek Bender <djbender@instructure.com>
Reviewed-by: Cameron Matheson <cameron@instructure.com>
QA-Review: Jason Carter <jcarter@instructure.com>
Product-Review: Christi Wruck
refs CNVS-26515
The rails4 upgrade changed the formatting so that this sub didn't match
anymore, and we ended up with "(.:format)" on the end of each url.
test plan: generate the api docs, the path for each endpoint shouldn't
include "(.:format)" at the end.
Change-Id: I8073c30d780b23abacc97f417e608db598415b28
Reviewed-on: https://gerrit.instructure.com/70537
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
Reviewed-by: August Thornton <august@instructure.com>
Product-Review: Brian Palmer <brianp@instructure.com>
fixes: CNVS-26348
this is a straight 1-to-1 conversion for replacing existing
px font-sizes to allow a user to easily increase/decrease
their font-sizes within the browser
ui dev test plan:
- all css should compile successfully
test plan:
- easiest way to make sure it's working is to create or have an outcome
ready
- go to Grades > Learning Mastery (you might have to enable this in
settings)
- on the tab that matched your outcome you should hover and see a
popup, this should look/feel the same as the screenshot below:
http://cl.ly/3w2Y0f421H16
Change-Id: I282059fbcecc2b0278c893a8ce548b919b5ce7d5
Reviewed-on: https://gerrit.instructure.com/70118
Product-Review: Colleen Palmer <colleen@instructure.com>
Tested-by: Jenkins
Reviewed-by: Colleen Palmer <colleen@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
Refs: CNVS-26348
test plan:
- as a user navigate to the calendar app from the left-hand nav
- your view should look like this: http://screencast.com/t/ZTfeKcIr1vg
- now increase the font size of your browser (zoom in chrome)
the fonts should increase as well and look like this:
http://screencast.com/t/i7nztNBnvP
Change-Id: If35bd5192bab77e7dc76bba97be6e336f7e33782
Reviewed-on: https://gerrit.instructure.com/70101
Tested-by: Jenkins
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
refs #CNVS-26056
Change-Id: I6bd8f15c375afc1bbb49d156949c1a92bd1c01d3
Reviewed-on: https://gerrit.instructure.com/70497
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
breaks specs when initializing a test db by running
predeploys before postdeploys because the index gets removed
in a later (predeploy) migration
Change-Id: I8b18ec05693bfbcf34e3f514800d34dd7d90c61b
Reviewed-on: https://gerrit.instructure.com/70565
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
refs CNVS-25916
this declaration works, but is more correct as a define statement
because it's building a module for the bundle to require and use
Change-Id: I466fe500c5791bf076d5b80b0bb7b85890239923
Reviewed-on: https://gerrit.instructure.com/70569
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins
refs CNVS-25916
Replicate old require-js plugin behavior
for making sure contextual timezone and locale
information is loaded before any other modules
depend upon it.
TEST PLAN:
1) grading_periods_account_spec should pass in
webpack selenium build
Change-Id: I46871b15e803e551149d344922f1679906873c54
Reviewed-on: https://gerrit.instructure.com/70553
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins
Product-Review: Ethan Vizitei <evizitei@instructure.com>
QA-Review: Ethan Vizitei <evizitei@instructure.com>
Fixes PLAT-1307
Test Plan:
Enable a plugin at the root account (I recommend github with garbage data)
Try to disable the plugin for an account
- once when there is no existing settings saved
- once with existing settings
Change-Id: Ib59981fb8b3f222cf7fe9ff7d356d6e37aec8229
Reviewed-on: https://gerrit.instructure.com/70499
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Brad Horrocks <bhorrocks@instructure.com>
fixes CNVS-13389
test plan:
* enable CAS on an account
* go to create a user from the account settings page
* fill in a username, but not an e-mail address
* it should succeed; double verify that the user was created
(as opposed to silently failing)
Change-Id: Ibe1e4e53ef94cfb2c369436428a5668f79a706d0
Reviewed-on: https://gerrit.instructure.com/70542
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
refs CNVS-25916
Both of these specs periodically fail with
bad authenticity tokens. Although it happens
frequently, I've not been able to reproduce
these failures either locally or manually on
jenkins nodes. Some possibilities are
polluted sessions or cached html (that has an
old authenticity token in it).
As a stopgap to prevent false failures, I'm adding
page refreshes at key points in these workflows
if logins fail the first time to try to get a
proper authenticity token for the given server
loaded into the session. Also doing session
destroys where it seems like it might have
been missed in case there are bad bits of session
being left around.
TEST PLAN:
1) oauth_spec should pass selenium build
2) terms_of_use_spec should pass selenium build
Change-Id: I772a5ec137ca94ed4b2a29f826a9dfe9b7fcea09
Reviewed-on: https://gerrit.instructure.com/70568
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins
Product-Review: Ethan Vizitei <evizitei@instructure.com>
QA-Review: Ethan Vizitei <evizitei@instructure.com>
refs #CNVS-26056
Change-Id: Iccb8c2943927817c27a3e82106ab1844e683de98
Reviewed-on: https://gerrit.instructure.com/70558
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
test plan:
* add a teacher to a course
* in the account enrollment term, set access dates for teacher
to start in the future
* the course should show up in the list of "Future Enrollments"
but should not be accessible
closes #CNVS-25707
Change-Id: I869baaad67c88854cbc0585c7043ae80d0b40d32
Reviewed-on: https://gerrit.instructure.com/70261
Tested-by: Jenkins
Reviewed-by: Dan Minkevitch <dan@instructure.com>
QA-Review: Jason Carter <jcarter@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Fixes CNVS-25360
Test plan:
- Test in all browsers Canvas supports - I'm not confident at all
that the styles I've used will work across all browsers
- Also test with both the old UI and the new UI
- View the calendar
- Make sure the mini calendar on the right sidebar shows a black
highlight with white text for the current day and black outlines
around days with events
Change-Id: Ibadc69ef3b04f7c6cc38bf38c6da5960190ca082
Reviewed-on: https://gerrit.instructure.com/70449
Reviewed-by: Steven Burnett <sburnett@instructure.com>
Tested-by: Jenkins
QA-Review: Adrian Russell <arussell@instructure.com>
Product-Review: Allison Weiss <allison@instructure.com>
Fixes CNVS-26270
Test plan:
- Enable Faculty Journal on an account
- Open the faculty journal for a user in that account
- Click the button to create an entry
- Ensure that the cancel button comes before the create button in
the tab order
Change-Id: I46aae8b389c03f8cb0b55fb8bdad8482d1adc335
Reviewed-on: https://gerrit.instructure.com/70208
Tested-by: Jenkins
Reviewed-by: Matthew Wheeler <mwheeler@instructure.com>
QA-Review: Adrian Russell <arussell@instructure.com>
Product-Review: Allison Weiss <allison@instructure.com>
Fixes CNVS-26447
Test plan:
- Enable Faculty Journal on an account's settings page
- Go to /users/<id>/user_notes, where <id> is the id of any user
in that account
- Make sure it loads without saying that there was a problem
loading the page
Change-Id: Ia964c18e3c79fda98006013f28a48d4827fd2e9d
Reviewed-on: https://gerrit.instructure.com/70192
Reviewed-by: Andrew Butterfield <abutterfield@instructure.com>
Tested-by: Jenkins
QA-Review: Adrian Russell <arussell@instructure.com>
Product-Review: Alex Boyd <aboyd@instructure.com>
Fixes CNVS-25877
Test plan:
- Create a user with:
- an assignment that needs to be submitted
- an assignment that needs to be graded
- an assignment whose grades the user needs to moderate
- an assignment that they need to peer review
- a calendar event that they can see
- Go to the user's home page
- Ensure all of the assignments show up in the to-do list
- Ensure they show up in Coming Up as well
- Ensure that the calendar event shows up under Coming Up
- Go to the courses where you created the assignments
- Ensure that each assignment shows up on its respective course to-do
list
- Submit an assignment
- As a teacher, ensure that the assignment shows up as needing
grading, and that the number in the badge to the left is 1
- Ensure that screenreaders read the badge as "1 submission
needs grading"
- Make another submission as a different user
- Clear the cache by running `Rails.cache.clear` at a Rails console
- As the teacher, ensure that the badge is now 2
- Ensure that screenreaders read the badge as "2 submissions
need grading"
- Repeat 8 more times as different users, so that there are now
10 submissions
- Clear the cache again
- Ensure that the badge now says "9+"
- Ensure that screenreaders read the badge as "More than 9
submissions need grading"
- As the user who submitted the assignment, ensure that the grade
shows up on the To-Do list, Coming Up, and Recent Feedback
- As a teacher, leave a submission comment
- As the user who submitted the assignment, ensure that the comment
shows up under Recent Feedback
- Create a public course
- You can make a course public by going to its settings page
and checking "Make this course publicly visible"
- Log out
- Visit /courses/<id>, where <id> is the id of the course
- Ensure that the course shows as expected, and that nothing
shows up on the to-do list
- Automated tests should cover everything else
Change-Id: I18673995db94d896bf2c39515258e61065b48319
Reviewed-on: https://gerrit.instructure.com/69474
Reviewed-by: Andrew Butterfield <abutterfield@instructure.com>
QA-Review: Heath Hales <hhales@instructure.com>
Tested-by: Jenkins
Product-Review: Allison Weiss <allison@instructure.com>
refs CNVS-25916
the migration_tool plugin uses the secondary
bundle override technique of having an extension
bundle loaded in parallel. I don't think we
want to support both that and the glue-module
extension approach since only one plugin makes
use of the former. In order to migrate that
work to extend a core module, the work
needs to be moved to a non-entry-point
module (because overriding require names doesn't
work if you're talking about the bundles
rails knows how to load). All this patchset does
is move the core work done in the content_migration
bundle into it's own module to make a valid
override target for the plugin refactor.
Also adds this new module as a non-entry-point
exception in the bundles.js, just like it's sibling
file.
TEST PLAN:
1) nothing should change on /courses/x/content_migrations
Change-Id: I2dfa0d1b1d11657bb5931e8caae6ef9d4b3c9aec
Reviewed-on: https://gerrit.instructure.com/70510
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
fixes CNVS-25795
test plan
create a quiz with a multiple fill in the blank question
set jaws focus to the pts possible header
push the down arrow key
you shouldn't get a hidden link for "skip to question test"
Change-Id: Ie11597ac36dd23ec727e187a74028129184b6093
Reviewed-on: https://gerrit.instructure.com/70278
Tested-by: Jenkins
Reviewed-by: Ryan Taylor <rtaylor@instructure.com>
Reviewed-by: Matt Berns <mberns@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Product-Review: Nathan Mills <nathanm@instructure.com>
When the GradebookImporter receives data which would create
a new assignment, but there exists a future grading period,
the new assignment is not creatable due to MGP logic. This
change makes assignment creation and editing of assignments
without due dates possible through the GradebookImporter.
fixes CNVS-25380
Test plan:
0. In a course with a student…
1. Create a grading period in the present and another in
the future.
2. Export the gradebook.
3. Open the exported file and add a new assignment column
to the gradebook.csv, putting the name in row 1 and
possible points in row 2.
4. Import the gradebook.
5. Verify that the gradebook is imported and a new
assignment is created.
Change-Id: I8f88547582c1a632c7129eac72a4ba4e7f12a624
Reviewed-on: https://gerrit.instructure.com/68498
Reviewed-by: Cameron Matheson <cameron@instructure.com>
Tested-by: Jenkins
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
QA-Review: Jason Carter <jcarter@instructure.com>
Product-Review: Christi Wruck
rely on test_all_gems.sh to output header and trailer,
and use `set -e` in each test.sh to simplify passing
through errors
Change-Id: I3ba724ad2539ddfe31195394c43f646acfc73920
Reviewed-on: https://gerrit.instructure.com/70469
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
test plan:
* relocking should work as before
closes #CNVS-26389
Change-Id: I5bc9d532860445131e43a04b8296e01d107bff79
Reviewed-on: https://gerrit.instructure.com/70272
Tested-by: Jenkins
Reviewed-by: Dan Minkevitch <dan@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Simon Williams