Refs MBL-10998
Test plan:
* Create a sub account
* Add an admin to the sub account
* Create a course for the sub account
* Enroll a student in the course
* Verify that you can generate pairing codes as the admin in the sub
account
Change-Id: I7a67fc6c5c9335bbd7cd8716720b66bf9fe31f42
Reviewed-on: https://gerrit.instructure.com/160286
Tested-by: Jenkins
Reviewed-by: Matthew Sessions <msessions@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Matthew Sessions <msessions@instructure.com>
QA-Review: Matthew Sessions <msessions@instructure.com>
Show the comment sidebar on the submission details page when a student
is viewing their own submission (even if the assignment is muted or
anonymous). Also, when a teacher (or admin) is viewing a student's
submission, always show all relevant comments, as opposed to
mistakenly hiding all non-student comments when the page first loads.
fixes GRADE-1304
Test plan:
- Create an assignment (do not enable anonymous or moderated) and mute it
- As a student, leave some comments on the assignment via the submission
details page
- As a teacher, leave some comments on the student's assignment (via
either SpeedGrader or the submission details page)
- Check comment visibility for both users:
- The student should be able to see their own comments but not the
teacher's comments
- The teacher should be able to see all comments
- Unmute the assignment
- The student should now be able to see the teacher's comments
- Create an anonymous assignment (it will be muted automatically)
- Ensure that the student has regained the ability to leave comments
on the submission details page
- Check that comment visibility generally works as specified above
(aside from the comments now being anonymous)
Change-Id: I541345d335bccd2cfb6587db44850ae51371d326
Reviewed-on: https://gerrit.instructure.com/159255
Tested-by: Jenkins
Reviewed-by: Jeremy Neander <jneander@instructure.com>
Reviewed-by: Gary Mei <gmei@instructure.com>
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
test plan:
* visit /accounts/self/terms
* should not be able to edit the default term name
closes #CORE-1470
Change-Id: I4b69ee97389957b9c00259cf39caf62998909ae7
Reviewed-on: https://gerrit.instructure.com/157792
Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com>
Tested-by: Jenkins
QA-Review: Rohan Cheeniyil <rcheeniyil@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
closes OUT-2365
test plan:
- create a course-level outcome with default rubric criterion
- create an assignment that is aligned to that outcome
- create two sections in a course (in Settings)
- create 6 student users, split evenly between the two sections
- masquerade as each student and submit to the assignment
- in speedgrader, assess the rubrics with the following scores:
1st section students: 5, 3, 0
2nd section students: 4, 2, 1
- load the LMGB page
- for each section options ("All Sections", 1st section, 2nd section):
* for each course statistic ("Course average", "Course Median"):
* confirm the following values:
* All Sections: mean = 2.5 median = 2.5
* 1st section: mean = 2.67 median = 3
* 2nd section: mean = 2.33 median = 2
* for "Course average", refresh the page, which should preserve
the section option and load that value on reload
- repeat steps above starting at "load the LMGB page" using
the new gradebook, except that the section option isn't preserved
after refreshing a page
Change-Id: I31cd8b38bd24f8d5d01aa7c83b8488da555a5315
Reviewed-on: https://gerrit.instructure.com/157781
Reviewed-by: Frank Murphy <fmurphy@instructure.com>
Reviewed-by: Michael Brewer-Davis <mbd@instructure.com>
Tested-by: Jenkins
QA-Review: Dariusz Dzien <ddzien@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
also don't explode if current_user is missing
just in case
also don't leave users as pre-registered if
a password is provided on creation (so the email
confirmation link works now)
test plan:
* use test plan for g/145033
closes #CORE-1647
Change-Id: I9f9a457be555f19afc2b0b997dd87a0024f02d63
Reviewed-on: https://gerrit.instructure.com/157978
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: Rohan Cheeniyil <rcheeniyil@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
fixes ADMIN-1281
test plan:
- Navigate to the Admin Tools page
- Move through each tab with a screen reader
- No horizontal lines are focused as you move through each pane
Change-Id: I1a48303526702fad529ebb37ccfb1301c87a4cbd
Reviewed-on: https://gerrit.instructure.com/158874
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Luke Kingsley <lkingsley@instructure.com>
Product-Review: Nathan Rogowski <nathan@instructure.com>
fixes ADMIN-1286
test plan:
- Navigate to a course's Settings page
- Click on Export Course Content
- Move through the page with a screen reader
- Note that each horizontal rule is read to the SR
Change-Id: Ic04b9beba89f4cc9847528cb16189100123d79c8
Reviewed-on: https://gerrit.instructure.com/158913
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Luke Kingsley <lkingsley@instructure.com>
Product-Review: Nathan Rogowski <nathan@instructure.com>
fixes COMMS-1339
Test Plan:
- Create a discussion that has the "users must post
before seeing replies" option checked
- save and publish
- as a student go visit the discussion
- notice you see no admin menu in the top right of
the discussion topic page
- as a teacher go to the same discussion
- notice you do see the admin menu in the top right of
the discussion topic page
- as a student post to the discussion topic
- notice the admin menu shows up
- as a teacher refresh the page
- notice the menu is still there
Change-Id: I9a27c75e63f740906d7803a9dfee607cd223d437
Reviewed-on: https://gerrit.instructure.com/158272
Tested-by: Jenkins
Reviewed-by: Landon Gilbert-Bland <lbland@instructure.com>
QA-Review: Sara Chadwick <schadwick@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
The issue was the checkboxe label were much longer than their text. The
trick I used to fix it was to wrap the labels in a div so they could still
act like blocks, but make the label itself an inline-block so the
label would only be as long as its text.
fixes ADMIN-1213
test plan:
- Open the discussions add/edit page
- You shouldn't be able to click on the checkboxes to the right of their
label text.
- Click on the "Add student to-do" checkbox, and then open the date
picker. Click to the whitespace to the right of the checkboxes to close
the date picker. It shouldn't interact with any of the checkboxes.
Change-Id: I9057da3f5eb07b70d8952e4a280964b8834305c2
Reviewed-on: https://gerrit.instructure.com/158235
Tested-by: Jenkins
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Ed Schiebel <eschiebel@instructure.com>
Product-Review: Jon Willesen <jonw+gerrit@instructure.com>
Fixes PLAT-3524
Test Plan:
- Verify that the "remember authorization for this service" checkbox
is only shown for 'auth/userinfo' scope (with no other scope specified)
- Verify that the checkbox just show once when it's first initiated
(with only the 'auth/userinfo' scope)
- Verify that the checkbox is not displayed for any other scopes or
with no scope specified
Change-Id: Ie486d4ca626a1a144b38dae5068f6b7a539665e9
Reviewed-on: https://gerrit.instructure.com/157339
Reviewed-by: Marc Alan Phillips <mphillips@instructure.com>
QA-Review: Marc Alan Phillips <mphillips@instructure.com>
Product-Review: Jesse Poulos <jpoulos@instructure.com>
Tested-by: Jenkins
Hide view/submission dates on submission details page and SpeedGrader if
the assignment should be anonymizing student information.
closes GRADE-1070
Test plan:
* Create an anonymous assignment allowing file-upload submissions
* Logged in as a student (S1):
* Submit something
* As another student (S2), submit multiple files for the same assignment
(i.e., submit something, then re-submit and upload something else)
* Logged in as a teacher:
* Open the assignment in SpeedGrader
* For S1, the "submitted" and "student viewed at" lines on the right
side should not appear
* For S2, the dropdown letting you choose between submissions, which
previously denoted them using the dates submitted, should now name
them "Submission 1", "Submission 2" and so forth
* In both cases, it's okay if the assignment is marked as late or
missing for a given student (we're not trying to hide that info)
* Logged in as an admin:
* Open the assignment in SpeedGrader
* None of the above should apply; i.e., the admin should be able to
view submission dates as though the assignment weren't anonymous
* Log back in as the teacher:
* Unmute the assignment
* For both students, the submitted at/viewed at information should now
be shown again
Change-Id: I35bb3e6d189fd6f5aca333b6eb4419c209d95090
Reviewed-on: https://gerrit.instructure.com/157540
Tested-by: Jenkins
Reviewed-by: Gary Mei <gmei@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
Reviewed-by: Derek Bender <djbender@instructure.com>
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
Show pairing code generation button only when self registration
is turned on
Refs: MBL-10903, MBL-10904
Test Plan:
- The feature flag for generating a pairing code should
now be gone
- Turn on self registration in your account
- Go through the pairing code generation and observer
sign up process
- Everything should still work
- Turn off self registration
- The generate pairing code button should no longer be visible
Change-Id: I1431d358bbe24078c24fce98d727f150aa5ab847
Reviewed-on: https://gerrit.instructure.com/157514
Reviewed-by: Nate Armstrong <narmstrong@instructure.com>
Tested-by: Jenkins
Product-Review: Nate Armstrong <narmstrong@instructure.com>
QA-Review: Nate Armstrong <narmstrong@instructure.com>
for both the teacher and the student
fixes ADMIN-1219
test plan:
- add an assignment, a graded discussion, a calendar event, an ungraded
discussion with a to-do date, and a page with a to-do date to a course.
- view the course's syllabus as a student. All of those items should
show up with the appropriate icon.
- view the course's syllabus as the teacher. same items should show.
- set the course's home page to the syllabus. the syllabus should be
viewable as the course's home page with the ungraded items.
- make the course public and view the syllabus without logging in.
should be able to see the syllabus, but the ungraded items will not
be shown. this will be fixed in a separate ticket.
- turn off the planner feature flag and view the syllabus page and the
course's home page as a teacher and a student. the syllabus should be
shown without the ungraded items.
Change-Id: Ia2309ef31bf1e508dff06e3ecd5796a117ef7e44
Reviewed-on: https://gerrit.instructure.com/157936
Tested-by: Jenkins
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Luke Kingsley <lkingsley@instructure.com>
Product-Review: Jon Willesen <jonw+gerrit@instructure.com>
Fixes COMMS-1325
Test Plan:
- Go to the announcements page and click the +Announcement
button while you have a screenreader on
- Move around the area where the "Topic Title" bar is; the h1 is
screenreader-only and should be around there
- Verify that it says "New Announcement"
- Do the same for a new discussion, and verify that it says "New
Discussion"
Change-Id: Ice030b22f95e9aa3c324d2333f36e03d27105872
Reviewed-on: https://gerrit.instructure.com/157871
Tested-by: Jenkins
Reviewed-by: Landon Gilbert-Bland <lbland@instructure.com>
QA-Review: Aaron Kc Hsu <ahsu@instructure.com>
Product-Review: Sara Chadwick <schadwick@instructure.com>
closes ADMIN-1077
test plan:
- go to a course's syllabus page
- read down to the "Schedule of Delivery/Course Summary" table
- read the table using the keyboard
> in NVDA, use down-arrow to read the table, and you should be able
to press Enter to click the link in the details column.
> should continue to work with other browser/screen readers too
Change-Id: Ia6eb1ee802d037252a26cd40434ae3d245221d81
Reviewed-on: https://gerrit.instructure.com/157446
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Luke Kingsley <lkingsley@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
closes OUT-1861
test plan:
- in a course, create 5 outcomes and 5 student users
- create an assignment aligned to a single outcome
- using 2 student users, submit to the assignment
- assess the submissions' rubric assessments
- using current and new gradebook, perform the following steps:
* load up LMGB
* all students and all outcomes should be displayed, with 2 results
* enable "Hide outcomes with no results"
* confirm that only the assessed outcome appears as a column
* enable "Hide students with no results"
* confirm that a spinner appears and then displays the 2 assessed
student users
* disable "Hide outcomes with no results"
* confirm that all outcomes appear, but still just 2 students
* disable "Hide students with no results"
* confirm that a spinner appears and then displays all
outcomes and students
Change-Id: Idcf8371410b5b4871e03e175523399e9a4941651
Reviewed-on: https://gerrit.instructure.com/156908
Reviewed-by: Michael Brewer-Davis <mbd@instructure.com>
Reviewed-by: Frank Murphy <fmurphy@instructure.com>
Tested-by: Jenkins
QA-Review: Dariusz Dzien <ddzien@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
The teacher can add a student to do date to ungraded discussions,
and the date now appears on the discussions index page and the discussion's
view page
fixes ADMIN-1160
test plan:
- have a course with graded discussions including a due date, ungraded
discussions with no student to do date, and ungraded discussions with a
student to do date.
> expect the discussions index page to show properly show the due date
and to do date.
Change-Id: Ief0537f326e0e7ba77cf7830a23a2dd8fb90591f
Reviewed-on: https://gerrit.instructure.com/154583
Tested-by: Jenkins
Reviewed-by: Carl Kibler <ckibler@instructure.com>
Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
test plan:
- enable planner
- as a teacher, set todo dates on wiki pages and
ungraded discussions in both course and group context
- ensure these appear on the calendar when the appropriate
contexts are selected
fixes ADMIN-1228
Change-Id: If93ccdda70ac30a2d1769600bce8a482cf382329
Reviewed-on: https://gerrit.instructure.com/157140
Tested-by: Jenkins
Reviewed-by: Carl Kibler <ckibler@instructure.com>
Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com>
QA-Review: Luke Kingsley <lkingsley@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
fixes OUT-2369
test plan:
- enable voiceover
- go to rubric index page (either course or account)
- navigate to the edit and delete buttons for a rubric
- the buttons should read out as "Edit Rubric (rubric title)" and
"Delete Rubric (rubric title)" for a given rubric
Change-Id: I739c2115a27a625b22bf890c48722b6cdc986f03
Reviewed-on: https://gerrit.instructure.com/157143
Tested-by: Jenkins
Reviewed-by: Michael Brewer-Davis <mbd@instructure.com>
QA-Review: Dariusz Dzien <ddzien@instructure.com>
Product-Review: Nathan Rogowski <nathan@instructure.com>
fixes OUT-2230
test plan:
- create an eportfolio
- go to edit a page in the portfolio
- enable "Allow comments on this page"
- save a reload the page
- leave some comments
- return to the main eportfolio dashboard
- click "Download the contents of this ePortfolio as a zip file"
- the download should complete as expected
- the downloaded pages should not include comments
Change-Id: I8d24f062c7dc67f6e7debac4b5d0a1d1ba7c58b4
Reviewed-on: https://gerrit.instructure.com/156968
Tested-by: Jenkins
Reviewed-by: Michael Brewer-Davis <mbd@instructure.com>
QA-Review: Augusto Callejas <acallejas@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
fixes OUT-2185
test plan:
- create an account level rubric in a course with at
least two students
- create an assignment with peer reviews
- attach the account level rubric
- assign peer reviewers
- submit to the assignment with at least one pair of
peer reviewers
- as one of the students, go to assess their assessee
- after saving the assessment, reload the submission
show page
- the Show Rubric button should still appear for the
student assessor. The contents should not be editable,
but they should be able to see the scores they provided
on their assessment. Repeat this step of the test plan
with NSR both enabled and disabled, to ensure that the
contents are not editable with the feature and without
it
Change-Id: I717868bd023828f8df94fdd31f4ae9b0134ca131
Reviewed-on: https://gerrit.instructure.com/155581
Tested-by: Jenkins
Reviewed-by: Augusto Callejas <acallejas@instructure.com>
Reviewed-by: Michael Brewer-Davis <mbd@instructure.com>
QA-Review: Dariusz Dzien <ddzien@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
fixes QUIZ-4877
Test Plan
1. Navigate to the assignment index page for a course
2. Ensure the Quizzes Next easy button no longer has the beta
tag shown
Change-Id: I2841c3cdf264707d56496140715136b75a8e99bd
Reviewed-on: https://gerrit.instructure.com/156101
Reviewed-by: Aaron Griffin <agriffin@instructure.com>
Tested-by: Jenkins
QA-Review: David Tan <dtan@instructure.com>
Product-Review: Kevin Dougherty <jdougherty@instructure.com>
…like how the login page has: https://cl.ly/0g3R1g0S2u3v
Fixes: CORE-1535
Test plan:
Go to the forgot password page using a screenreader,
It should have an h1 that says “Forgot password?”
Change-Id: I5c7bc409a91d8dd462d71fd75d9550825e08de98
Reviewed-on: https://gerrit.instructure.com/156472
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Rohan Cheeniyil <rcheeniyil@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
Unmuting an anonymous assignment will now cause that assignment to show
in the UI as though it is not anonymous. In addition, posting grades for
a moderated anonymous assignment will now cause that assignment to show
in the UI as though it is not anonymous.
closes GRADE-1310
closes GRADE-1313
Test Plan:
1. Verify unmuting an anonymous assignment causes that assignment to no
longer be anonymized in the UI. You can do this by spot checking
gradebook (old/new/individual) and SpeedGrader. In addition,
re-muting an unmuted anonymous assignment should cause the assignment
to become anonymized in the UI.
2. Verify posting grades for a moderated, anonymous assignment causes
that assignment to no longer be anonymized in the UI (even if the
assignment is muted).
Change-Id: I113c61b4e7fa0eb8909448d8ba7cffb22600e17c
Reviewed-on: https://gerrit.instructure.com/156151
Reviewed-by: Gary Mei <gmei@instructure.com>
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Tested-by: Jenkins
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
fixes COMMS-1272
Test Plan:
- create a course with a couple users
- create a graded discussion that is a peer review
- have a student1 (the one you are going to mark in active)
submit to that discussion (simply just comment on the discussion)
- assign that student1 to another student2 as a peer review
- go to that discussion page as student2
- notice there is a peer review banner
- inactivate student1 from the course
- go back to the discussion as student2
- notice banner is gone
Change-Id: Ic048b840b160b63887425deb49236273cac466f8
Reviewed-on: https://gerrit.instructure.com/156504
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: Sara Chadwick <schadwick@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
fixes COMMS-995 COMMS-996
Test Plan
* Make sure discussion and announcement pages don't white page
* Make sure the edit pages and other pages in flow works
* Test well.... reallly welll
Change-Id: I1f4e6ececddba8e81aca595287e59ee75fce3fa0
Reviewed-on: https://gerrit.instructure.com/155878
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: KC Naegle <knaegle@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
test plan: ensure the "+ Group" and "+ Group Set" buttons
are read by a screenreader as "Add Group" and "Add Group Set"
in the following places:
- Course People Page (/courses/X/users)
- Course Groups List Page (/courses/X/groups)
- test with and without existing groups in the course
- Account Groups (/accounts/X/groups)
- test with and without existing groups in the account
fixes ADMIN-1176
fixes ADMIN-1177
Change-Id: Iabbd0209ad8b56f3be06902890a85693e40cd860
Reviewed-on: https://gerrit.instructure.com/155328
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
Reviewed-by: Carl Kibler <ckibler@instructure.com>
Tested-by: Jenkins
QA-Review: Ed Schiebel <eschiebel@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
fixes COMMS-1274
Test Plan
- Create a user in Canvas with a name at least 26 characters long
- Enroll the user in a course as a student
- Create a group set and add the student to a group
- Deactivate the student from the people page in the course
- Navigate back to the group set in Firefox, Chrome, Safari or Edge.
- Notice that the inactive label does appear and hovering over the
ellipsis does not display the title indicating they are inactive.
Change-Id: Ib72213fd673a910e2210566ec56f8f3f60bcae5b
Reviewed-on: https://gerrit.instructure.com/156403
Tested-by: Jenkins
Reviewed-by: Steven Burnett <sburnett@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
QA-Review: Steven Burnett <sburnett@instructure.com>
closes CORE-1577
Test Plan:
- With no custom login page logo set, the login page alt
text should be "Canvas by Instructure"
- Set a custom logo for the login page in the theme editor
- Alt text for the custom logo should be the account name
Change-Id: I8061a7fce3bfbe175e0e2e4b0cc9366fbf1ff391
Reviewed-on: https://gerrit.instructure.com/156340
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Rohan Cheeniyil <rcheeniyil@instructure.com>
Product-Review: Nathan Rogowski <nathan@instructure.com>
Uploading a media comment from the Submission Details page wasn't
grabbing the media_comment_type. That endpoint now saves the
media_comment_type, and old media comments will now also show after
removing a redundant if check.
fixes GRADE-441
Test Plan
- Set up the Kaltura plugin so that you have access to media
comments.
- Have a course with at least 1 teacher and 1 student.
- Create an assignment for that student.
- Go to the Submission Details page and upload a media comment.
- Refresh the page.
- Verify that the media comment is still visible and playable.
- Repeat the previous 3 steps, but with SpeedGrader instead.
Change-Id: Ib7380ffaec5f5b7c92935a1c6d095abe1b9342ad
Reviewed-on: https://gerrit.instructure.com/156276
Tested-by: Jenkins
Reviewed-by: Adrian Packel <apackel@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
Closes ADMIN-1161
Test Plan:
Part 1:
* With student planner enabled
* Without any wiki pages that have
a todo date assigned
* View the wiki pages list view
* It should list the pages without showing an
empty "To-Do Date" column
* View a wiki page
* No "To-Do Date" should be shown on the details view
Part 2:
* With student planner enabled
* With a wiki page with a todo date assigned
* View the wiki pages list view
* A To-Do Date column should show with the todo date
listed for the wiki page specified above
* View the details for the wiki page
* A To-Do date should be listed under the header
of the wiki page
Change-Id: I30b202f2db9cac584370f13b0d3c16b3d2fb5ecf
Reviewed-on: https://gerrit.instructure.com/156044
Tested-by: Jenkins
Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com>
QA-Review: Jon Willesen <jonw+gerrit@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>
fixes COMMS-1270
Test Plan:
- on the login page navigate to the acceptable use policy
link on the footer (make sure you have instructure misc plugins
checked out)
- notice it meets a11y standards
- login and notice at the fotter of canvas the same links appear
- navigate to them with keyboard only and notice they are accessible
Change-Id: I387f5a69a3de277b7ddc957a46478a9003b786d7
Reviewed-on: https://gerrit.instructure.com/156188
Tested-by: Jenkins
Reviewed-by: Aaron Kc Hsu <ahsu@instructure.com>
QA-Review: Aaron Kc Hsu <ahsu@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
fixes COMMS-1237
Test Plan:
- Go to /accounts/1/admin_tools
- click on the view notifications tab
- search for a user
- navigate the table headers with a SR
Change-Id: I23b8fd5cc154eea3cc5e4d2ff9b3fa6fa6afb5a1
Reviewed-on: https://gerrit.instructure.com/156053
Tested-by: Jenkins
Reviewed-by: Sara Chadwick <schadwick@instructure.com>
QA-Review: Venk Natarajan <vnatarajan@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
fixes ADMIN-1151
test plan:
- load the card dashboard
- inspect the Coming Up in devtools
> expect "Coming Up" to be in the <h2>, and not the
"view calendar" <a>
> expect it to look the same as before
Change-Id: I4caba030416e0886c089efe75d25b4bbbe0c2f8e
Reviewed-on: https://gerrit.instructure.com/155578
Tested-by: Jenkins
Reviewed-by: Mysti Sadler <mysti@instructure.com>
Reviewed-by: Carl Kibler <ckibler@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
refs COMMS-1163
fixes COMMS-1273
Test Plan:
- Tests Pass
- we will be verifying this on beta
Change-Id: I924e8ec4aec17873e1ce7855c55122dbbceeca01
Reviewed-on: https://gerrit.instructure.com/155940
Reviewed-by: Sara Chadwick <schadwick@instructure.com>
Tested-by: Jenkins
Product-Review: Steven Burnett <sburnett@instructure.com>
QA-Review: Steven Burnett <sburnett@instructure.com>
fixes COMMS-1163
Test Plan:
- Ask steven for creds to configure adobe connect
- go to accounts/1/plugins/adobe_connect
- enter in creds and enable plugin
- go to the conferences tab
- ensure you can create a conference
- you won't be able to join given the creds are limited
- stop the recording
- ensure its still accessible
Change-Id: I216d88f47ef6f4eca20a98a51b8bddb0fd0d9252
Reviewed-on: https://gerrit.instructure.com/155764
Tested-by: Jenkins
Reviewed-by: Sara Chadwick <schadwick@instructure.com>
Reviewed-by: Venk Natarajan <vnatarajan@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
QA-Review: Steven Burnett <sburnett@instructure.com>
Fixes OUT-2310
Test Plan:
- (recommend testing in at least two supported browsers)
- Create an assignment / new rubric. Add / remove ratings, including
some with long descriptions.
- Verify the add ratings buttons remain present and centered on the fold
between table cells.
- With the non-scoring rubric feature flag OFF:
- Open a rubric and assessed rubric in speed grader. Verify there are no
visual anomolies.
Change-Id: Id20f8a08b58a96d599476cee65517e57cf89f438
Reviewed-on: https://gerrit.instructure.com/155446
Tested-by: Jenkins
Reviewed-by: Augusto Callejas <acallejas@instructure.com>
Reviewed-by: Michael Brewer-Davis <mbd@instructure.com>
QA-Review: Augusto Callejas <acallejas@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
"Duplicate" and "Delete" are not synonyms. Thus it is probably
a good idea to not have the title for duplicating a module say
"delete". That's just my opinion though.
Fixes COMMS-1265
Test Plan:
* Open up the modules page.
* Have a module without an old quiz.
* Make sure module duplication is enabled in feature options.
* Hover over the "duplicate" option for duplicating a module.
Change-Id: Id1ac99ab8f9cf8687c10f36efd069dd5512bb30d
Reviewed-on: https://gerrit.instructure.com/155500
Reviewed-by: Steven Burnett <sburnett@instructure.com>
Tested-by: Jenkins
Product-Review: Venk Natarajan <vnatarajan@instructure.com>
QA-Review: Venk Natarajan <vnatarajan@instructure.com>
Refs MBL-10718
Test Plan:
- Using the parent app linked to your local canvas
- Need to have compiled assets
- Open the login page
- Tap the button to create an account
- The link for what is a pairing code should be there
- For now, tapping it will just open the webpage in the webview
Change-Id: Ia67bb7e449d71ba102fabfda83db89b3ad49b155
Reviewed-on: https://gerrit.instructure.com/155463
Tested-by: Jenkins
Reviewed-by: Nate Armstrong <narmstrong@instructure.com>
Reviewed-by: Layne Moseley <lmoseley@instructure.com>
Product-Review: Nate Armstrong <narmstrong@instructure.com>
QA-Review: Nate Armstrong <narmstrong@instructure.com>
Tested-by: Nate Armstrong <narmstrong@instructure.com>
There are cases when a TA might have only :view_all_grades
permission. This allows the link to be visible to those
users.
fixes GRADE-835
Test Plan
- Create a custom role with only View All Grades and View
Discussions permissions. View Discussions is necessary
because you can't navigate to the discussions page
otherwise.
- Create a graded discussion as a teacher.
- Create an assignment of type external tool as a teacher.
- Navigate to that discussion as the custom role and verify that
the speedgrader link is available in the three-dot menu of the
discussion.
- Navigate to the external tools assignment and verify that the
speedgrader link is available.
Change-Id: I259fc4a4d2f8322f5c41dff044320f5deab5ba57
Reviewed-on: https://gerrit.instructure.com/154230
Tested-by: Jenkins
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
Reviewed-by: Adrian Packel <apackel@instructure.com>
QA-Review: Adrian Packel <apackel@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
Refs MBL-10693
test plan:
- Toggle the new permission to generate student pairing codes
- If toggled on, pairing code button appears on student pages
- If toggled off, the pairing code button will not appear
- The pairing button always appears for students when viewings their profile page
- Affects the following user pages:
- /courses/:courseID/users/:userID
- /accounts/:accountID/users/:userID
- Note: permissions are cached, so in testing you'll need
to modify permission, update the course, then
test to see if it worked. Otherwise the old permissions
stick around.
Change-Id: Ibea1140abf14df5b5e7150c876f31720468d600a
Reviewed-on: https://gerrit.instructure.com/154823
Reviewed-by: Matthew Sessions <msessions@instructure.com>
Product-Review: Matthew Sessions <msessions@instructure.com>
QA-Review: Matthew Sessions <msessions@instructure.com>
Tested-by: Jenkins
Refs MBL-10698
Test Plan:
- Turn on the observer pairing code feature flag
- Create a pairing code for a student
- Create a developer key at /accounts/self/developer_keys
The redirect uri should be https://canvas/login
- Open XCode and modify the preload-account-info.plist
with the developer key info
- Open the parent app from xcode
- Once you get to the select your domain screen
tap the link for your local canvas instance
- Tap on the Create Account link
- Create a parent using the pairing code
- After you hit Start participating it should redirect
you to the app and successfully log you in
Change-Id: I37a5db197c885a21f8916294f93bd77ab0747838
Reviewed-on: https://gerrit.instructure.com/155120
Tested-by: Jenkins
Reviewed-by: Layne Moseley <lmoseley@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com>
Product-Review: Nate Armstrong <narmstrong@instructure.com>
QA-Review: Nate Armstrong <narmstrong@instructure.com>
Fixes COMMS-1184
Test Plan:
* With a screenreader, navigate to the calendar page
* Click on the agenda view button to change to the agenda view
* Create an event for sometime in the future
* Notice that as you navigate the page and get to the button that
opens that event, it reads "Open event menu for <title>"
Change-Id: If155fa8cbc0192cc80c5fb0c2251249a84e56dab
Reviewed-on: https://gerrit.instructure.com/155238
Tested-by: Jenkins
Reviewed-by: Venk Natarajan <vnatarajan@instructure.com>
QA-Review: Steven Burnett <sburnett@instructure.com>
Product-Review: Landon Gilbert-Bland <lbland@instructure.com>
Refs MBL-10412, MBL-10414
Test Plan:
- As an admin turn on the ability for
observers to create accounts in
/accounts/self/authentication_providers
- Turn on the pairing code feature flag
- Generate a pairing code for a student
- In a private window go to /login/canvas?mobile=1
- click the Create Account button
- Sign up using the form and the pairing code
- It should work and redirect you to the dashboard
Change-Id: Ic96a0d167a1d73bf2b386dea01966ef036c41414
Reviewed-on: https://gerrit.instructure.com/154630
Tested-by: Jenkins
Reviewed-by: Layne Moseley <lmoseley@instructure.com>
QA-Review: Layne Moseley <lmoseley@instructure.com>
Product-Review: Matthew Sessions <msessions@instructure.com>
Refs MBL-10422
Test Plan:
- Turn on the Observer pairing code feature flag
- Have an observer that is super observing a student
- As an admin go to a second student and generate a
pairing code
- As an observer go to /profile/observees
- Add the second student using the pairing code
Change-Id: I8028b4ab6bc6845a8167cc440ac370ecf8ef088a
Reviewed-on: https://gerrit.instructure.com/154674
Tested-by: Jenkins
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
Reviewed-by: Layne Moseley <lmoseley@instructure.com>
QA-Review: Layne Moseley <lmoseley@instructure.com>
Product-Review: Matthew Sessions <msessions@instructure.com>
Closes: GRADE-1306
test plan:
- create an anonymous assignment
- as a student, submit an uploaded file
- create an eportfolio page for this submission
- the submission correctly displays
Change-Id: Ieab08716f135cfbd70695fe62c9fb26188c3f286
Reviewed-on: https://gerrit.instructure.com/154981
Reviewed-by: Jeremy Neander <jneander@instructure.com>
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
Tested-by: Jenkins
QA-Review: Indira Pai <ipai@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
fixes GRADE-1268 GRADE-1267
test plan:
1. Create a course with a student
2. Create a normal assignment
3. Create a moderated assignment
4. Create an anonymous assignment
5. Create an anonymous assignment and then unmute it (hereinafter
referred to as "unmuted")
A. In New Gradebook:
1. View the Grade Detail tray for each assignment
2. Only the normal and unmuted assignments should show the comments UI
B. In Screenreader Gradebook:
1. Select a student
2. The normal assignment should show Submission Details below
the grade input field, where you can enter a comment in the popup
3. The moderated assignment should not show any Submission Details
button
4. The anonymous assignment should not even show up in the list of
assignments available
5. The unmuted anonymous assignment should show Submission Details
below the grade input field, where you can enter a comment in the
popup
C. From Gradebook:
1. Click the student name to go their Grade dashboard
2. Click on the normal assignment
3. You should see comments UI in the right sidebar
4. Go back and click on the other moderated and anonymous assignments
5. Neither should show any comments UI
6. Go back and click on the unmuted assignment
7. You should see the comments UI
Change-Id: I7239e8b19d5bb2921c517ced93fbdc4dfbbb96ce
Reviewed-on: https://gerrit.instructure.com/154598
Tested-by: Jenkins
Reviewed-by: Gary Mei <gmei@instructure.com>
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
QA-Review: Indira Pai <ipai@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
When editing a discussion topic and adding a student todo, it should
default to fancy midnight.
fixes ADMIN-1096
test plan:
- see g/153015
Change-Id: Ibb113b5a3c420626a74a6b826aaf14f4a593377a
Reviewed-on: https://gerrit.instructure.com/154618
Tested-by: Jenkins
Reviewed-by: Dan Minkevitch <dan@instructure.com>
QA-Review: Luke Kingsley <lkingsley@instructure.com>
Product-Review: Jon Willesen <jonw+gerrit@instructure.com>
Refs MBL-10414
Test Plan:
- Ensure that you have observer sign up enabled
in the account authentication settings
- Go to the login page
- Click on the `Parent of a canvas user` link
- It should show the password and confirm password fields
- As an admin generate a pairing code for a student
- Use that pairing code to sign up as a new observer
- Click on the start participating button
- After the dashboard loads, it shouldn't show you a modal
to confirm your email and finish registration
- You should have access to the course your student is reigstered in
- If you go to /profile/settings, in the left nav links there should be
a link for Observees
- Click on it
- you should be able to get to that page
Change-Id: I27f75b78556d203a798d872052e3dbc4ecee3199
Reviewed-on: https://gerrit.instructure.com/154226
Reviewed-by: Layne Moseley <lmoseley@instructure.com>
QA-Review: Layne Moseley <lmoseley@instructure.com>
Tested-by: Jenkins
Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com>
Product-Review: Matthew Sessions <msessions@instructure.com>
fixes COMMS-1209
Test Plan:
- Enable duplicating calendar events FF on an account level
- click the + to create a calendar event
- click the more options button
- on the new page click the duplicate check box
- at the bottom hover over the count checkbox and label
- notice it no longer says for ="append_iterator
Change-Id: Ic1e9185fadbc59752703d16034c076cc0ed9e1ce
Reviewed-on: https://gerrit.instructure.com/154593
Tested-by: Jenkins
Reviewed-by: Landon Gilbert-Bland <lbland@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
QA-Review: Steven Burnett <sburnett@instructure.com>
Nate Armstrong